Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-07-14 Thread Francisco Jerez
Vedran Miletić writes: > On 07/13/2016 12:49 AM, Francisco Jerez wrote: >> You can just replace the current implementation of tokenize(), it's not >> used for anything else other than splitting compiler arguments AFAIK. >> > > Done, patch incoming. > >>> Also, I would really like to progress on g

[Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-07-13 Thread Vedran Miletić
OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the Clang OpenCL compiler was called via a shell, the shell would split the arguments with respect to to quotes and then remove quotes before passing the arguments to the compiler. S

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-07-13 Thread Vedran Miletić
On 07/13/2016 12:49 AM, Francisco Jerez wrote: You can just replace the current implementation of tokenize(), it's not used for anything else other than splitting compiler arguments AFAIK. Done, patch incoming. Also, I would really like to progress on getting this merged in some way, so any

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-07-12 Thread Francisco Jerez
Vedran Miletić writes: > 06.06.2016 u 12:24, Vedran Miletić je napisao/la: >> On 06/06/2016 02:04 AM, Francisco Jerez wrote: >>> Vedran Miletić writes: Aside from working just like NVIDIA and AMD proprietary stacks, no. However, what we do right now is most certainly broken.

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-07-12 Thread Vedran Miletić
06.06.2016 u 12:24, Vedran Miletić je napisao/la: On 06/06/2016 02:04 AM, Francisco Jerez wrote: Vedran Miletić writes: Aside from working just like NVIDIA and AMD proprietary stacks, no. However, what we do right now is most certainly broken. Consider the following argument -I"/foo bar/baz

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-06-06 Thread Vedran Miletić
On 06/06/2016 02:04 AM, Francisco Jerez wrote: Vedran Miletić writes: Aside from working just like NVIDIA and AMD proprietary stacks, no. However, what we do right now is most certainly broken. Consider the following argument -I"/foo bar/baz" which is going to be sent to Clang as two argume

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-06-05 Thread Francisco Jerez
Vedran Miletić writes: > On 06/04/2016 10:13 AM, Francisco Jerez wrote: >> Vedran Miletić writes: >> >>> OpenCL apps can quote arguments they pass to the OpenCL compiler, most >>> commonly include paths containing spaces. If the OpenCL compiler was >>> called via a shell, the shell would remove

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-06-05 Thread Vedran Miletić
On 06/04/2016 10:13 AM, Francisco Jerez wrote: Vedran Miletić writes: OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the OpenCL compiler was called via a shell, the shell would remove (single or double) quotes before passing

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-06-04 Thread Francisco Jerez
Vedran Miletić writes: > OpenCL apps can quote arguments they pass to the OpenCL compiler, most > commonly include paths containing spaces. If the OpenCL compiler was > called via a shell, the shell would remove (single or double) quotes > before passing the argument to the compiler. Since we cal

[Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-05-27 Thread Vedran Miletić
OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the OpenCL compiler was called via a shell, the shell would remove (single or double) quotes before passing the argument to the compiler. Since we call Clang as a library, we have to