Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Emil Velikov
On 23 August 2016 at 22:56, Nicholas Miell wrote: > On 08/23/2016 02:45 PM, Emil Velikov wrote: >> >> On 23 August 2016 at 19:05, Nicholas Miell wrote: >>> >>> On 08/23/2016 02:07 AM, Emil Velikov wrote: Skimmed through the discussion and I'm not sure the above will be enough.

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Nicholas Miell
On 08/23/2016 02:45 PM, Emil Velikov wrote: On 23 August 2016 at 19:05, Nicholas Miell wrote: On 08/23/2016 02:07 AM, Emil Velikov wrote: Skimmed through the discussion and I'm not sure the above will be enough. Since the user is free to place json files in $HOME/.local ... this implies that

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Emil Velikov
On 23 August 2016 at 19:05, Nicholas Miell wrote: > On 08/23/2016 02:07 AM, Emil Velikov wrote: >> >> Skimmed through the discussion and I'm not sure the above will be enough. >> >> Since the user is free to place json files in $HOME/.local ... this >> implies that they may _not_ have access to /u

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Nicholas Miell
On 08/23/2016 02:07 AM, Emil Velikov wrote: Skimmed through the discussion and I'm not sure the above will be enough. Since the user is free to place json files in $HOME/.local ... this implies that they may _not_ have access to /usr or /etc. Thus as they install the file (to say $HOME/foo/lib)

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Julien Cristau
On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: > diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am > index ad0148d..9fef960 100644 > --- a/src/intel/vulkan/Makefile.am > +++ b/src/intel/vulkan/Makefile.am > @@ -141,7 +141,7 @@ anv_timestamp.h: > $(AM_V_G

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Julien Cristau
On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: > Not providing a path allows the ICD to work on multi-arch systems but > breaks it if you install anywhere other than /usr/lib. Given that users > may be installing locally in .local or similar, we probably do want to > provide a file

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Emil Velikov
On 23 August 2016 at 04:33, Nicholas Miell wrote: > On 08/22/2016 04:10 PM, Julien Cristau wrote: >> >> On Mon, Aug 22, 2016 at 14:18:51 -0700, Jason Ekstrand wrote: >> >>> On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau >>> wrote: >>> On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand w

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Nicholas Miell
On 08/22/2016 04:10 PM, Julien Cristau wrote: On Mon, Aug 22, 2016 at 14:18:51 -0700, Jason Ekstrand wrote: On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau wrote: On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: Not providing a path allows the ICD to work on multi-arch systems

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Jason Ekstrand
On Mon, Aug 22, 2016 at 2:56 PM, Dave Airlie wrote: > On 23 August 2016 at 07:18, Jason Ekstrand wrote: > > On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau > wrote: > >> > >> On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: > >> > >> > Not providing a path allows the ICD to work on

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Julien Cristau
On Mon, Aug 22, 2016 at 14:18:51 -0700, Jason Ekstrand wrote: > On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau wrote: > > > On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: > > > > > Not providing a path allows the ICD to work on multi-arch systems but > > > breaks it if you instal

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Dave Airlie
On 23 August 2016 at 07:18, Jason Ekstrand wrote: > On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau wrote: >> >> On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: >> >> > Not providing a path allows the ICD to work on multi-arch systems but >> > breaks it if you install anywhere other

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Jason Ekstrand
On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau wrote: > On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: > > > Not providing a path allows the ICD to work on multi-arch systems but > > breaks it if you install anywhere other than /usr/lib. Given that users > > may be installing loc

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-20 Thread Jason Ekstrand
On Aug 20, 2016 5:00 AM, "Emil Velikov" wrote: > > On 20 August 2016 at 07:25, Jason Ekstrand wrote: > > On Aug 19, 2016 18:05, "Eric Engestrom" wrote: > >> > >> On Fri, Aug 19, 2016 at 09:04:14AM -0700, Jason Ekstrand wrote: > >> > Not providing a path allows the ICD to work on multi-arch syste

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-20 Thread Emil Velikov
On 20 August 2016 at 07:25, Jason Ekstrand wrote: > On Aug 19, 2016 18:05, "Eric Engestrom" wrote: >> >> On Fri, Aug 19, 2016 at 09:04:14AM -0700, Jason Ekstrand wrote: >> > Not providing a path allows the ICD to work on multi-arch systems but >> > breaks it if you install anywhere other than /us

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-20 Thread Jason Ekstrand
On Fri, Aug 19, 2016 at 11:25 PM, Jason Ekstrand wrote: > On Aug 19, 2016 20:08, "Chad Versace" wrote: > > > > On Fri 19 Aug 2016, Jason Ekstrand wrote: > > > Not providing a path allows the ICD to work on multi-arch systems but > > > breaks it if you install anywhere other than /usr/lib. Given

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-19 Thread Jason Ekstrand
On Aug 19, 2016 20:08, "Chad Versace" wrote: > > On Fri 19 Aug 2016, Jason Ekstrand wrote: > > Not providing a path allows the ICD to work on multi-arch systems but > > breaks it if you install anywhere other than /usr/lib. Given that users > > may be installing locally in .local or similar, we p

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-19 Thread Jason Ekstrand
On Aug 19, 2016 18:05, "Eric Engestrom" wrote: > > On Fri, Aug 19, 2016 at 09:04:14AM -0700, Jason Ekstrand wrote: > > Not providing a path allows the ICD to work on multi-arch systems but > > breaks it if you install anywhere other than /usr/lib. Given that users > > may be installing locally in

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-19 Thread Chad Versace
On Fri 19 Aug 2016, Jason Ekstrand wrote: > Not providing a path allows the ICD to work on multi-arch systems but > breaks it if you install anywhere other than /usr/lib. Given that users > may be installing locally in .local or similar, we probably do want to > provide a filename. Distros can ca

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-19 Thread Eric Engestrom
On Fri, Aug 19, 2016 at 09:04:14AM -0700, Jason Ekstrand wrote: > Not providing a path allows the ICD to work on multi-arch systems but > breaks it if you install anywhere other than /usr/lib. Given that users > may be installing locally in .local or similar, we probably do want to > provide a fil

[Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-19 Thread Jason Ekstrand
Not providing a path allows the ICD to work on multi-arch systems but breaks it if you install anywhere other than /usr/lib. Given that users may be installing locally in .local or similar, we probably do want to provide a filename. Distros can carry a revert of this commit if they want an intel_