Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-11-03 Thread Marek Olšák
Pushed with a fixed typo and whitespace, thanks. Marek On Thu, Nov 2, 2017 at 3:50 PM, Andrey Grodzovsky wrote: > Fixes reverted patch f03b7c9 by doing VMID reservation per > process and not per context. > Also updates required amdgpu libdrm version since the change > involved interface updates

[Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-11-02 Thread Andrey Grodzovsky
Fixes reverted patch f03b7c9 by doing VMID reservation per process and not per context. Also updates required amdgpu libdrm version since the change involved interface updates in amdgpu libdrm. Signed-off-by: Andrey Grodzovsky --- configure.ac | 2 +- meson.buil

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-11-01 Thread Marek Olšák
Yeah, it should be called when the winsys is created. Marek On Wed, Nov 1, 2017 at 9:49 AM, Christian König wrote: > I'm not 100% sure that patch was correct. > > When is amdgpu_ctx_create() called? The VMID is reserved for the whole > process, not just a context. > > Regards, > Christian. > > >

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-11-01 Thread Christian König
I'm not 100% sure that patch was correct. When is amdgpu_ctx_create() called? The VMID is reserved for the whole process, not just a context. Regards, Christian. Am 31.10.2017 um 16:57 schrieb Marek Olšák: I addressed the feedback and pushed the patch. Marek On Tue, Oct 31, 2017 at 4:50 PM

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-11-01 Thread Christian König
Am 31.10.2017 um 16:50 schrieb Michel Dänzer: On 31/10/17 04:40 PM, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky [...] diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index 8f43e93..1155492 100644 --- a/src/gallium/winsys/amdgp

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Andrey Grodzovsky
On 2017-10-31 11:50 AM, Samuel Pitoiset wrote: On 10/31/2017 04:40 PM, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky --- configure.ac | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h |

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Marek Olšák
I addressed the feedback and pushed the patch. Marek On Tue, Oct 31, 2017 at 4:50 PM, Michel Dänzer wrote: > On 31/10/17 04:40 PM, Andrey Grodzovsky wrote: >> Signed-off-by: Andrey Grodzovsky > > [...] > >> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c >> b/src/gallium/winsys/amdgpu/d

[Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Andrey Grodzovsky
Signed-off-by: Andrey Grodzovsky --- configure.ac | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 8 src/gallium/winsys/amdgpu/drm/amdgpu_cs.

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Michel Dänzer
On 31/10/17 04:40 PM, Andrey Grodzovsky wrote: > Signed-off-by: Andrey Grodzovsky [...] > diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > index 8f43e93..1155492 100644 > --- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > +++ b/src/gallium/wi

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-10-31 Thread Samuel Pitoiset
On 10/31/2017 04:40 PM, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky --- configure.ac | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c