Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-04-01 Thread Mike Lothian
Thanks for pointing that out I've sent a 4th patch, I've never compiled swr before, would you mind testing to see if it fixes things for you, it's using the llvm include rather than the llvm-c include On Sun, 1 Apr 2018 at 06:15 Vinson Lee wrote: > On Sat, Mar 31, 2018 at 5:08 PM, Mike Lothian

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Vinson Lee
On Sat, Mar 31, 2018 at 5:08 PM, Mike Lothian wrote: > On 1 April 2018 at 00:03, Vinson Lee wrote: >> >> A similar change is needed in >> src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp. >> >> Vinson > > Hi > > I'm not convinced that it does > > Utils.h defines two functions LLVMAddLowerSwi

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
On 1 April 2018 at 00:03, Vinson Lee wrote: > > A similar change is needed in > src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp. > > Vinson Hi I'm not convinced that it does Utils.h defines two functions LLVMAddLowerSwitchPass & LLVMAddPromoteMemoryToRegisterPass. Whilst jit_pch.hpp does

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Vinson Lee
On Thu, Mar 29, 2018 at 4:56 PM, Mike Lothian wrote: > Include llvm-c/Transforms/Utils.h with the newest LLVM 7 > > Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h > Signed-of-by: Mike Lothian > > --- > > I don't have git commit rights > > If you're happy with this patch please can you com

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
On Sat, 31 Mar 2018 at 00:54 Dylan Baker wrote: > > Quoting Mike Lothian (2018-03-29 17:49:30) > > > > > > On Fri, 30 Mar 2018, 01:42 Dylan Baker, wrote: > > > > Quoting Mike Lothian (2018-03-29 16:56:28) > > > Include llvm-c/Transforms/Utils.h with the newest LLVM 7 > > > > > > F

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-30 Thread Dylan Baker
Quoting Mike Lothian (2018-03-29 17:49:30) > > > On Fri, 30 Mar 2018, 01:42 Dylan Baker, wrote: > > Quoting Mike Lothian (2018-03-29 16:56:28) > > Include llvm-c/Transforms/Utils.h with the newest LLVM 7 > > > > Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h > > I h

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-30 Thread Dieter Nützel
Samuel, go for it. Tested-by: Dieter Nützel Thanks Mike! Dieter Am 30.03.2018 11:32, schrieb Samuel Pitoiset: With the Fixes tag removed, this is: Reviewed-by: Samuel Pitoiset On 03/30/2018 01:56 AM, Mike Lothian wrote: Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Fixes: 2d

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-30 Thread Samuel Pitoiset
With the Fixes tag removed, this is: Reviewed-by: Samuel Pitoiset On 03/30/2018 01:56 AM, Mike Lothian wrote: Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h Signed-of-by: Mike Lothian --- I don't have git commit rights If yo

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-29 Thread Mike Lothian
On Fri, 30 Mar 2018, 01:42 Dylan Baker, wrote: > Quoting Mike Lothian (2018-03-29 16:56:28) > > Include llvm-c/Transforms/Utils.h with the newest LLVM 7 > > > > Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h > > I have no comment on the patch itself. > > JFYI, this tag ("Fixes") has speci

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-29 Thread Dylan Baker
Quoting Mike Lothian (2018-03-29 16:56:28) > Include llvm-c/Transforms/Utils.h with the newest LLVM 7 > > Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h I have no comment on the patch itself. JFYI, this tag ("Fixes") has specific meaning in mesa and should only refer to mesa commits (we

[Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-29 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h Signed-of-by: Mike Lothian --- I don't have git commit rights If you're happy with this patch please can you commit it Cheers Mike --- src/amd/vulkan/radv_nir_to_llvm.c