On Fri, Nov 11, 2016 at 10:35 PM, Daniel Scharrer wrote:
> On 2016-11-11 22:24, Bas Nieuwenhuizen wrote:
>> Maybe also add an assert in ac_add_function_attr that the attr is a
>> single flag? Something like
>>
>> assert(attr && util_is_power_of_two(attr));
>
> There is already a warning printed fo
On 2016-11-11 22:24, Bas Nieuwenhuizen wrote:
> Maybe also add an assert in ac_add_function_attr that the attr is a
> single flag? Something like
>
> assert(attr && util_is_power_of_two(attr));
There is already a warning printed for unknown attributes in
ac_attr_to_llvm_attr / attr_to_str that ca
Maybe also add an assert in ac_add_function_attr that the attr is a
single flag? Something like
assert(attr && util_is_power_of_two(attr));
Either way, this patch is
Reviewed-by: Bas Nieuwenhuizen
On Fri, Nov 11, 2016 at 9:36 PM, Daniel Scharrer wrote:
> This fixes a NULL pointer dereference f
This fixes a NULL pointer dereference for intrinsics with more than
one function attribute introduced in commit 2fdaf38.
The fix is ported from the lp_build_intrinsic changes in commit 8bdd52c.
---
I'm a bit unsure about the index change from 0 to -1, but the gallium code does
this as well and wit
