Re: [Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

2012-09-18 Thread Matt Turner
On Mon, Sep 17, 2012 at 7:15 PM, Roland Scheidegger wrote: > Am 18.09.2012 01:34, schrieb Matt Turner: >> Here is the assembly output of the other two (IEEE being the fi_type >> union hack, and SIGNBIT using signbit(). >> >> : >> movd %xmm0,%eax >> shr$0x1f,%eax >> >> : >> pmovms

Re: [Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

2012-09-18 Thread Chris Wilson
On Mon, 17 Sep 2012 16:34:21 -0700, Matt Turner wrote: > I understand Ian's concern given the subtle nature of this code. > Brian's commit (c8a86f717 - converting from macros to inline > functions) caused bug 54365, and then his fix (23cd6c43da) caused bug > 54805. Neither commit looked like it sh

Re: [Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

2012-09-17 Thread Roland Scheidegger
Am 18.09.2012 01:34, schrieb Matt Turner: > On Mon, Sep 17, 2012 at 1:20 PM, Jose Fonseca wrote: >> >> >> - Original Message - >>> signbit() appears to be available everywhere (even MSVC according to >>> MSDN), so let's use it instead of open-coding some messy and >>> confusing >>> bit twi

Re: [Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

2012-09-17 Thread Matt Turner
On Mon, Sep 17, 2012 at 1:20 PM, Jose Fonseca wrote: > > > - Original Message - >> signbit() appears to be available everywhere (even MSVC according to >> MSDN), so let's use it instead of open-coding some messy and >> confusing >> bit twiddling macros. >> >> Bugzilla: https://bugs.freedes

Re: [Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

2012-09-17 Thread Jose Fonseca
- Original Message - > > > - Original Message - > > signbit() appears to be available everywhere (even MSVC according > > to > > MSDN), so let's use it instead of open-coding some messy and > > confusing > > bit twiddling macros. > > > > Bugzilla: https://bugs.freedesktop.org/s

Re: [Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

2012-09-17 Thread Jose Fonseca
- Original Message - > signbit() appears to be available everywhere (even MSVC according to > MSDN), so let's use it instead of open-coding some messy and > confusing > bit twiddling macros. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54805 > Cc: Alan Coopersmith > Sugges

Re: [Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

2012-09-17 Thread Paul Berry
On 14 September 2012 16:20, Matt Turner wrote: > signbit() appears to be available everywhere (even MSVC according to > MSDN), so let's use it instead of open-coding some messy and confusing > bit twiddling macros. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54805 > Cc: Alan Cooper

[Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

2012-09-14 Thread Matt Turner
signbit() appears to be available everywhere (even MSVC according to MSDN), so let's use it instead of open-coding some messy and confusing bit twiddling macros. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54805 Cc: Alan Coopersmith Suggested-by: Ian Romanick --- I'd prefer to see if