Re: [Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-12 Thread Ilia Mirkin
On Thu, Jun 12, 2014 at 11:08 AM, Neil Roberts wrote: >>> + if (ctx->Version >= 30 || ctx->Extensions.EXT_texture_integer) { >>> + /* both source and dest must be integer-valued, or neither */ >>> + if (_mesa_is_format_integer_color(texImage->TexFormat) != >>> + _mesa_is_enum_

Re: [Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-12 Thread Neil Roberts
Thanks for the review. I'm working on incorporating the changes into a v2 patch series. However I'm a bit stuck with what to do about enabling the extension assuming there is no Gallium implementation for now. I couldn't find a convenient place to enable the extension for all DRI-based drivers wit

Re: [Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-05 Thread Marek Olšák
Hi Neil, I'd like to have full hardware acceleration for Gallium drivers before advertising the extension for them. I wouldn't like to have extensions which are only implemented in software where hardware support is preferable. Therefore, not advertising the extension is the way to go if you are n

Re: [Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-04 Thread Ilia Mirkin
On Wed, Jun 4, 2014 at 9:26 PM, Ian Romanick wrote: > On 06/04/2014 04:15 PM, Ilia Mirkin wrote: >> On Wed, Jun 4, 2014 at 6:42 PM, Ian Romanick wrote: >>> On 06/04/2014 11:12 AM, Neil Roberts wrote: + + ctx->Driver.ClearTexSubImage(ctx, +texImage,

Re: [Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-04 Thread Ian Romanick
On 06/04/2014 04:15 PM, Ilia Mirkin wrote: > On Wed, Jun 4, 2014 at 6:42 PM, Ian Romanick wrote: >> On 06/04/2014 11:12 AM, Neil Roberts wrote: >>> + >>> + ctx->Driver.ClearTexSubImage(ctx, >>> +texImage, >>> +xoffset, yoffset, zoff

Re: [Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-04 Thread Ilia Mirkin
On Wed, Jun 4, 2014 at 6:42 PM, Ian Romanick wrote: > On 06/04/2014 11:12 AM, Neil Roberts wrote: >> The clear texture extension is used to clear a texture to a given value >> without having to provide a buffer for the whole texture and without having >> to >> create an FBO. This patch provides a

Re: [Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-04 Thread Ian Romanick
On 06/04/2014 11:12 AM, Neil Roberts wrote: > The clear texture extension is used to clear a texture to a given value > without having to provide a buffer for the whole texture and without having to > create an FBO. This patch provides a generic implementation that works with > any driver. There ar

Re: [Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-04 Thread Ilia Mirkin
On Wed, Jun 4, 2014 at 2:12 PM, Neil Roberts wrote: > The clear texture extension is used to clear a texture to a given value > without having to provide a buffer for the whole texture and without having to > create an FBO. This patch provides a generic implementation that works with > any driver.

[Mesa-dev] [PATCH] Implement the ARB_clear_texture extension

2014-06-04 Thread Neil Roberts
The clear texture extension is used to clear a texture to a given value without having to provide a buffer for the whole texture and without having to create an FBO. This patch provides a generic implementation that works with any driver. There are two approaches, the first being in meta.c which tr