On 02/02/2015 12:49 PM, Laura Ekstrand wrote:
After a very thorough search, I did find two lines in i965/intel_fbo.c
that had ctx->DrawBuffer when they were supposed to have drawFb. Here's
the new commit:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=d9d7e65cd6a0fe2c8648
After a very thorough search, I did find two lines in i965/intel_fbo.c that
had ctx->DrawBuffer when they were supposed to have drawFb. Here's the new
commit:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=d9d7e65cd6a0fe2c864803a77e34d0f52e8609b6
.
_
I broke out some of the whitespace:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=ebe159fa9a6b1d98d63862bf89044028e67a4377
.
Here is the (hopefully cleaner) BlitFramebuffers refactor:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=fc85665eaa9aff8240
I'd have put the swrast whitespace changes in a separate commit, but
it's not a big deal.
Reviewed-by: Brian Paul
On 01/30/2015 05:25 PM, Laura Ekstrand wrote:
In preparation for glBlitNamedFramebuffer, the DD table function
BlitFramebuffer needs to accept two arbitrary framebuffer objects r
Quick question: Did you search for ReadBuffer and DrawBuffer as you went to
make sure you didn't miss any?
If the answer to the above is yes and the comment below is addressed,
Reviewed-by: Jason Ekstrand
This is going to help the PBO upload path a lot!
--Jason
On Fri, Jan 30, 2015 at 4:25 PM,
In preparation for glBlitNamedFramebuffer, the DD table function
BlitFramebuffer needs to accept two arbitrary framebuffer objects rather
than assuming ctx->ReadBuffer and ctx->DrawBuffer.
---
src/mesa/drivers/common/meta.c| 3 +-
src/mesa/drivers/common/meta.h
