Re: [Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Ian Romanick
On 06/03/2014 03:47 PM, Chad Versace wrote: > On Tue, Jun 03, 2014 at 03:42:32PM -0700, Chad Versace wrote: >> On Tue, Jun 03, 2014 at 02:00:13PM -0700, Sinclair Yeh wrote: >>> v2: >>> Incorporated feedback from idr - moved the check to a higher level >>> function. >>> >>> v1: >>> We have customers

Re: [Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Chad Versace
On Tue, Jun 03, 2014 at 03:42:32PM -0700, Chad Versace wrote: > On Tue, Jun 03, 2014 at 02:00:13PM -0700, Sinclair Yeh wrote: > > v2: > > Incorporated feedback from idr - moved the check to a higher level > > function. > > > > v1: > > We have customers using NULL as a way to test the robustness of

Re: [Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Chad Versace
On Tue, Jun 03, 2014 at 02:00:13PM -0700, Sinclair Yeh wrote: > v2: > Incorporated feedback from idr - moved the check to a higher level > function. > > v1: > We have customers using NULL as a way to test the robustness of > the API. Without this check, EGL will segfault trying to > dereference d

[Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Sinclair Yeh
v2: Incorporated feedback from idr - moved the check to a higher level function. v1: We have customers using NULL as a way to test the robustness of the API. Without this check, EGL will segfault trying to dereference dri2_surf->wl_win->private because wl_win is NULL. This fix adds a check and s