Re: [Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload

2015-07-13 Thread Dylan Baker
On Fri, Jul 10, 2015 at 02:24:42PM -0700, Ben Widawsky wrote: > On Fri, Jul 10, 2015 at 12:03:54PM -0700, Matt Turner wrote: > > I don't think putting Intel-internal links in the commit message is a good > > idea. > > > > Ken's made similar comments to me. > > > > Also, so much off the wall comm

Re: [Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload

2015-07-11 Thread Kenneth Graunke
On Thursday, July 09, 2015 11:00:40 AM Ben Widawsky wrote: > While implementing the workaround in the previous patch I noticed things were > starting to get a bit messy. Since gen8 works differently enough from gen7, I > thought splitting it out with be good. IMHO this is still a bit messy. What

Re: [Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload

2015-07-10 Thread Ben Widawsky
On Fri, Jul 10, 2015 at 12:03:54PM -0700, Matt Turner wrote: > On Thu, Jul 9, 2015 at 11:00 AM, Ben Widawsky > wrote: > > While implementing the workaround in the previous patch I noticed things > > were > > starting to get a bit messy. Since gen8 works differently enough from gen7, > > I > > th

Re: [Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload

2015-07-10 Thread Matt Turner
On Thu, Jul 9, 2015 at 11:00 AM, Ben Widawsky wrote: > While implementing the workaround in the previous patch I noticed things were > starting to get a bit messy. Since gen8 works differently enough from gen7, I > thought splitting it out with be good. > > While here, get rid of gen8 MOCS which d

[Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload

2015-07-09 Thread Ben Widawsky
While implementing the workaround in the previous patch I noticed things were starting to get a bit messy. Since gen8 works differently enough from gen7, I thought splitting it out with be good. While here, get rid of gen8 MOCS which does nothing and was in the wrong place anyway. This patch is t