Re: [Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

2017-06-20 Thread Constantine Kharlamov
Omg, nvm, it was a copy-paste error (the "input[i]"), I should've written a follow up mail. The real problem remains to be seen. Alright, later then. 20.06.2017, 10:04, "Constantine Kharlamov" : > 20.06.2017, 08:34, "Constantine Kharlamov" : >>  This was discussed on IRC, there was much confusio

Re: [Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

2017-06-20 Thread Constantine Kharlamov
20.06.2017, 08:34, "Constantine Kharlamov" : > This was discussed on IRC, there was much confusion, and overall there was a > belief like the bug in some place other. A few minutes ago I was writing a > follow-up in mail because I'll have trouble replying today. > > And… for writing a reply I fou

Re: [Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

2017-06-19 Thread Constantine Kharlamov
This was discussed on IRC, there was much confusion, and overall there was a belief like the bug in some place other. A few minutes ago I was writing a follow-up in mail because I'll have trouble replying today. And… for writing a reply I found the actual bug, and lol, it is funny! Here's the e

[Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

2017-06-19 Thread Constantine Kharlamov
tgsi_declaration() configures inputs. Then tgsi_interp_egcm() uses one of them for interpolation. Unfortunately it was choosing registers by using Src[0].Register.Index of the interpolation instruction as an index into shader inputs. Of course it was working by pure coincidence. E.g. for pidglit te