Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

2016-07-06 Thread Emil Velikov
On 6 July 2016 at 16:09, Jiang, Sonny wrote: > Hi Emil, > > > Are you Okay with these? > It'll do for now. General suggestion - do not try to justifying the patch on the grounds that it fixes a bug. Mention what was wrong and/or why it was resolved in a particular way. A style example/suggestion

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

2016-07-06 Thread Alex Deucher
uly 4, 2016 5:33:29 PM > To: Christian König; Emil Velikov > Cc: 12.0; mesa-dev@lists.freedesktop.org > > Subject: Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version > for amdgpu > > > Hi Emil, > > > I have added comments for each patch, and appli

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

2016-07-06 Thread Jiang, Sonny
; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu Am 01.07.2016 um 13:14 schrieb Emil Velikov: > Hi all, > > On 29 June 2016 at 20:20, Christian König wrote: >> Am 29.06.2016 um 18:35 schrieb Alex Deucher: >>&

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

2016-07-04 Thread Jiang, Sonny
@lists.freedesktop.org Subject: Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu Am 01.07.2016 um 13:14 schrieb Emil Velikov: > Hi all, > > On 29 June 2016 at 20:20, Christian König wrote: >> Am 29.06.2016 um 18:35 schrieb Alex Deucher: >>> On We

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

2016-07-01 Thread Christian König
Am 01.07.2016 um 13:14 schrieb Emil Velikov: Hi all, On 29 June 2016 at 20:20, Christian König wrote: Am 29.06.2016 um 18:35 schrieb Alex Deucher: On Wed, Jun 29, 2016 at 11:38 AM, Leo Liu wrote: From: sonjiang Signed-off-by: sonjiang Cc: "12.0" For the series: Reviewed-by: Alex Deuche

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

2016-07-01 Thread Emil Velikov
Hi all, On 29 June 2016 at 20:20, Christian König wrote: > Am 29.06.2016 um 18:35 schrieb Alex Deucher: >> >> On Wed, Jun 29, 2016 at 11:38 AM, Leo Liu wrote: >>> >>> From: sonjiang >>> >>> Signed-off-by: sonjiang >>> Cc: "12.0" >> >> For the series: >> Reviewed-by: Alex Deucher > > > Review