Re: [Mesa-dev] [PATCH] mesa/util: add missing va_end() after va_copy()

2018-09-06 Thread asimiklit.w...@gmail.com
correct for me. 'orig va' is used for a first call 'copy' is used for another call Could you please correct me if I am incorrect. src/util/u_string.h: util_vasprintf -> using the orig va I agree. 'copy' is created but 'orig va' is used for both c

Re: [Mesa-dev] [PATCH] mesa/util: add missing va_end() after va_copy()

2018-09-05 Thread asimiklit.w...@gmail.com
Hello, Thanks for your reply. I think that we just misunderstand each other) static inline int util_vsnprintf(char *str, size_t size, const char *format, va_list ap) { /* We need to use _vscprintf to calculate the length as vsnprintf returns -1 * if the number of characters to write i