> >>> case LP_FLOAT_MODE_UNSAFE_FP_MATH:
> >>> +#if HAVE_LLVM >= 0x0600
> >>> + flags.setFast();
> >>> +#else
> >>> flags.setUnsafeAlgebra();
> >>> +#endif
> >>> llvm::unwrap(builder)->s
LLVM 6 changed the API on the fast-math-flags:
https://reviews.llvm.org/rL317488
NOTE: This also enables the new flag 'ApproxFunc' to allow for
approximations for library functions (sin, cos, ...). I'm not completly
convinced, that this is something mesa should do.
Signed-off-by
ibs without --link-static assumes shared
> link.
> +dnl Everybody now, say - Thank you LLVM developers
> +LLVM_LIBS="`echo $LLVM_LIBS | $SED 's/\n//g'`"
Split this into two calls?
LLVM_LIBS="`$LLVM_CONFIG --link-static --libs ${LLVM_COMPONE
Reviewed-by: Tobias Droste
Am Donnerstag, 5. Oktober 2017, 12:19:03 CEST schrieb Emil Velikov:
> From: Emil Velikov
>
> Prior to the refactor/cleanup by Tobias one could add an invalid
> component to LLVM_COMPONENTS.
>
> Since that's no longer the case we can drop the
Reviewed-by: Tobias Droste
Am Donnerstag, 5. Oktober 2017, 12:19:04 CEST schrieb Emil Velikov:
> From: Emil Velikov
>
> As of LLVM 3.9 one could use consistent ways to handle the component.
> Factor out the current handling, as it will be used for older versions.
>
Reviewed-by: Tobias Droste
Am Donnerstag, 5. Oktober 2017, 12:19:08 CEST schrieb Emil Velikov:
> From: Emil Velikov
>
> Coverage and LTO seems to be hard requirements for Clang, while
> coroutines is needed as of LLVM/Clang 4.0.
>
> Mark the last one as "optional&q
> shortly.
>
> Cc: mesa-sta...@lists.freedesktop.org
> Cc: Tobias Droste
> Signed-off-by: Emil Velikov
> ---
> Tobias, any preference if we keep this separate helperor fold it with
> llvm_add_component?
>
> Should we fold the llvm_add_default_components usecase here, or keep it
>
Oops... :-)
Reviewed-by: Tobias Droste
Am Montag, 6. März 2017, 20:06:07 CET schrieb Matt Turner:
> It printed the version of LLVM ($1):
>
>configure: error: 3.6.0 requires libelf when using llvm
>
> instead of the driver name ($2):
>
>configure: error: r600
Hi Timothy,
if you plan to support multiple compression algorithms, shouldn't "struct
cache_entry_file_data" contain some info about what compression algorithm was
used to compress the data? Or is this already there and I missed it?
Am Donnerstag, 2. März 2017, 03:20:05 CET schrieb Matt Turner:
Mit freundlichen Grüßen
Am Freitag, 24. Februar 2017, 11:25:24 CET schrieb Marc Dietrich:
> Am Donnerstag, 23. Februar 2017, 11:50:07 CET schrieb Emil Velikov:
> > On 23 February 2017 at 10:20, Marc Dietrich wrote:
> > > Am Donnerstag, 23. Februar 2017, 10:54:39 CET schrieb Michel Dänzer:
> > >>
Reviewed-by: Tobias Droste
Am Donnerstag, 9. Februar 2017, 20:54:26 CET schrieb Emil Velikov:
> From: Tobias Droste
>
> Set FOUND_LLVM only when LLVM is present (checking for exact version/etc
> is deferred) and use enable-gallium-llvm to indicate the global LLVM
> status.
&g
Reviewed-by: Tobias Droste for v2, too
Am Donnerstag, 9. Februar 2017, 20:57:45 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Earlier refactoring commits changed from one, dare I say it, broken
> behaviour to another. Namely:
>
> Before, as you explicitly --enable
ts
> added for the LLVM draw.
>
> Otherwise we'll error (as below) when building RADV w/o gallium drivers.
>
> configure: error: --enable-gallium-llvm is required when building radv
>
> v2: Don't remove but move the dependency (Tobias).
>
> Cc: Dave Airlie
>
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:58 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Currently we have extra (somewhat questionable) modularity, such that
> one could build some parts with LLVM while others w/o.
>
> That is extremely fragil
Am Mittwoch, 8. Februar 2017, 10:39:56 CET schrieb Emil Velikov:
> On 8 February 2017 at 01:03, Tobias Droste wrote:
> > Small comment below. Either way:
> >
> > Reviewed-by: Tobias Droste
> >
> > Am Dienstag, 7. Februar 2017, 22:44:47 CET schrieb Emil
Am Mittwoch, 8. Februar 2017, 10:49:47 CET schrieb Emil Velikov:
> On 8 February 2017 at 01:08, Tobias Droste wrote:
> > Does this cause problems if someone builds just intel classic drivers
> > without LLVM installed?
>
> The classic (with_dri_drivers) drivers are co
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:57 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> The extra function brings no added benefit as of earlier commit which
> made llvm_require_version (as called by radeon_llvm_check) require LLVM
> (--enab
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:55 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Already implicitly handled throughout, but keep it clear and disable
> gallium-llvm. This change should be a no-op.
>
> Cc: Tobias Droste
> Signed
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:49 CET schrieb Emil Velikov:
> From: Tobias Droste
>
> Set FOUND_LLVM only when LLVM is present (checking for exact version/etc
> is deferred) and use enable-gallium-llvm to indicate the global LLVM
> status.
&g
e effectively made --enable-gallium-llvm mean --enable-llvm with
> earlier commits, we need to remove the, now artificial, requirement.
>
> Otherwise we'll error (as below) when building RADV.
>
> configure: error: --enable-gallium-llvm is required when building radv
>
>
Small comment below. Either way:
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:47 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> With this change we effectively require --enable-gallium-llvm when
> building RADV. This should be perfectly safe since the gall
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:46 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Drop the gallium prefix since we're about it use it throughout the
> configure.
>
> Note we do want to check for enable_gallium_llvm check since (as
>
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:44 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> With next commits we'll require --enable-gallium-llvm (en route to a
> greater good later on) for RADV. The latter is required to ensure that
> as otherwise
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:43 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Signed-off-by: Emil Velikov
> ---
> configure.ac | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index a6
Am Sonntag, 29. Januar 2017, 22:31:55 CET schrieb Marek Olšák:
> On Sat, Jan 28, 2017 at 9:29 PM, Tobias Droste wrote:
> > Am Samstag, 28. Januar 2017, 16:09:29 CET schrieb Marek Olšák:
> >> On Sat, Jan 28, 2017 at 3:31 PM, Ilia Mirkin
wrote:
> >> > Can you explai
> >
> > On Jan 28, 2017 8:57 AM, "Tobias Droste" wrote:
> >
> > This is a reworked series of the previous LLVM related changes to
> > configure.ac that were reverted due to breaking scons.
> >
> > This takes a different approach to the pre
. Januar 2017, 09:31:28 CET schrieb Ilia Mirkin:
> Can you explain why it's a desirable goal to be able to build radv without
> --enable-gallium-llvm? Perhaps it's obvious, but I'm not seeing it.
>
> On Jan 28, 2017 8:57 AM, "Tobias Droste" wrote:
>
> Thi
Only define HAVE_LLVM if --enable-gallium-llvm is provided.
If radv is built add HAVE_LLVM_RADV define with the same value
as HAVE_LLVM.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99010
Signed-off-by: Tobias Droste
---
configure.ac | 3 ++-
src/amd/common
Ignore that, wrong version...
Am Samstag, 28. Januar 2017, 14:56:59 CET schrieb Tobias Droste:
> Only define HAVE_LLVM if --enable-gallium-llvm is provided.
> If radv is built add HAVE_LLVM_RADV define with the same value
> as HAVE_LLVM.
>
> Bugzilla: https://bugs.freedesktop.org/
Only define HAVE_LLVM if --enable-gallium-llvm is provided.
If radv is built add HAVE_LLVM_RADV define with the same value
as HAVE_LLVM.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99010
Signed-off-by: Tobias Droste
---
configure.ac | 3 ++-
src/amd/common
DEFINES="${DEFINES} -DHAVE_LLVM=0x0$LLVM_VERSION_INT
-DMESA_LLVM_VERSION_PATCH=$LLVM_VERSION_PATCH"
else
USE_LLVM_GALLIUM=no
fi
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/config
Signed-off-by: Tobias Droste
---
configure.ac | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8366672f19..f956df5120 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1003,13 +1003,17
llium-llvm".
Patch 1, 2 and 3 are the same as in the previous series, just rebased.
The new stuff is in patch 3.
Tobias Droste (4):
configure.ac: Rename MESA_LLVM to FOUND_LLVM
configure.ac: Only set LLVM_LIBS if LLVM is used
configure.ac: Separate HAVE_LLVM defines for galliu
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/configure.ac b/configure.ac
index 92339b4a3f..8366672f19 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1002,15
Hey Matt,
yeah sorry about this, it is a known problem:
https://bugs.freedesktop.org/show_bug.cgi?id=99010
A fix was commited but broke scons and Jose reverted it and doesn't accept the
way it was fixed in general.
See discussion here:
https://lists.freedesktop.org/archives/mesa-dev/2017-Janua
Am Montag, 23. Januar 2017, 11:53:18 CET schrieb Jose Fonseca:
> On 20/01/17 02:48, Emil Velikov wrote:
> > On 19 January 2017 at 19:26, Tobias Droste wrote:
> >> Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov:
> >>> On 18 January 2017 at 18:12, Jo
Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov:
> On 18 January 2017 at 18:12, Jose Fonseca wrote:
> >>> In order to untangle things we want to have a distinction between the
> >>> gallium (gallivm afaict) and other users - RADV presently.
> >>> So how about we update the RADV ins
Mit freundlichen Grüßen
Tobias Droste
Am Mittwoch, 18. Januar 2017, 18:12:37 CET schrieb Jose Fonseca:
> On 18/01/17 17:51, Tobias Droste wrote:
> > Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov:
> >> On 18 January 2017 at 15:11, Jose Fonseca wrote:
> &
Reviewed-by: Tobias Droste
Am Mittwoch, 18. Januar 2017, 13:54:04 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Earlier refactoring commits changed from one, dare I say it, broken
> behaviour to another. Namely:
>
> Before, as you explicitly enable gallium-llvm your sel
uire the preprocessor flags (includes in particular) for the
> header version parsing keep those as-is. They are not used outside of
> configure.ac thus should not cause any side-effects.
>
> As-is adding the C/CXXFLAGS can lead to build issues on when
> cross-compiling.
>
>
Reviewed-by: Tobias Droste
Old habits... sorry :-)
Am Mittwoch, 18. Januar 2017, 13:54:00 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Although it works, it's not the correct thing to do.
>
> Cc: Tobias Droste
> Signed-off-by: Emil Velikov
> ---
> co
Reviewed-by: Tobias Droste
Am Mittwoch, 18. Januar 2017, 13:54:01 CET schrieb Emil Velikov:
> As stated in [1] by the LLVM devs, the new versioning scheme will not
> deploy any minor version (i.e. it will always be zero). As such the
> patch should not be needed.
>
> This
Reviewed-by: Tobias Droste
Am Mittwoch, 18. Januar 2017, 13:53:59 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> LLVM_BINDIR is completely unused while others such as LLVM_LIBDIR are
> used only internally. In the latter case there's no need to AC_SUBST it.
>
> Cc:
Reviewed-by: Tobias Droste
Am Mittwoch, 18. Januar 2017, 13:53:58 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> There's no point in the extra conditional.
>
> Cc: Tobias Droste
> Signed-off-by: Emil Velikov
> ---
> configure.ac | 6 +-
> 1 file chan
You may want to hold this one until we have a solution for Joses problem.
In case the .c file changes stay:
Reviewed-by: Tobias Droste
Am Mittwoch, 18. Januar 2017, 13:53:57 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Just ensure that the variable is set and print it&#
Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov:
> On 18 January 2017 at 15:11, Jose Fonseca wrote:
> > I've reverted this and took a closer look.
> >
> > I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM
> > and what not.
> >
> > But I'm afraid I can't a
Hi Tomasz,
does this actually fix anything?
Because right now llvm-config.h does not include anything and I doubt it will
in the future, as it's just a collection of defines.
The path to the header file itself is given by llvm-config ($LLVM_INCLUDEDIR).
Did you just happen to see this or do you
llium with its optional dependency
is a special case in mesa and that's why it is handled in special way (patch
4). All other users have a hard requirement.
Tobias
Am Donnerstag, 8. Dezember 2016, 23:02:36 CET schrieb Tobias Droste:
> Am Donnerstag, 8. Dezember 2016, 17:14:12 CET schrieb
Am Donnerstag, 8. Dezember 2016, 16:59:27 CET schrieb Emil Velikov:
> On 8 December 2016 at 02:03, Tobias Droste wrote:
> > this renames MESA_LLVM to FOUND_LLVM and updates the config.log report
> > to say if LLVM is found or not, to make clear that this does not mean
>
Am Donnerstag, 8. Dezember 2016, 17:24:14 CET schrieb Emil Velikov:
> On 8 December 2016 at 02:03, Tobias Droste wrote:
> > This is actually not needed because the version is checked later.
> >
> > Line 2609:
> > if test "x$enable_gallium_llvm" == "xye
Am Donnerstag, 8. Dezember 2016, 17:14:12 CET schrieb Emil Velikov:
> On 8 December 2016 at 02:03, Tobias Droste wrote:
> > Gallium code used HAVE_LLVM to check if it needs to compile code for
> > LLVM in header and source files.
> >
> > With the new logic HAVE_LL
Am Donnerstag, 8. Dezember 2016, 17:06:16 CET schrieb Emil Velikov:
> On 8 December 2016 at 02:03, Tobias Droste wrote:
> > This renames llvm_check_version_for to llvm_require_version and let it
> > set a variable to mark that LLVM will be used.
> >
> > Use this
Signed-off-by: Tobias Droste
---
configure.ac | 33 -
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/configure.ac b/configure.ac
index 1499380c45..a209d87e62 100644
--- a/configure.ac
+++ b/configure.ac
@@ -998,13 +998,17
Make sure that HAVE_LLVM compiler define is only set if LLVM is
actually used.
Signed-off-by: Tobias Droste
---
configure.ac | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index a209d87e62..7362ecdfaf 100644
--- a/configure.ac
+++ b
Make setting LLVM_LIBS a function, put it to the other LLVM related
functions and call it if LLVM is used.
Signed-off-by: Tobias Droste
---
configure.ac | 109 +--
1 file changed, 54 insertions(+), 55 deletions(-)
diff --git a
Gallium code used HAVE_LLVM to check if it needs to compile code for
LLVM in header and source files.
With the new logic HAVE_LLVM is always set. Use extra define to figure
out if LLVM is used.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99010
Signed-off-by: Tobias Droste
DEFINES="${DEFINES} -DHAVE_GALLIUM_LLVM"
fi
Signed-off-by: Tobias Droste
---
configure.ac | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6e12ac8912..8457b388a8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2435,9
this renames MESA_LLVM to FOUND_LLVM and updates the config.log report
to say if LLVM is found or not, to make clear that this does not mean
that it is used.
Signed-off-by: Tobias Droste
---
configure.ac | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a
Patches 1 to 4 (hopefully) fix
https://bugs.freedesktop.org/show_bug.cgi?id=99010.
Patch 5 and 6 are cosmetic changes.
I build and run tested this with radeonsi, radv and llvmpipe and build tested
with softpipe.
@Emil:
Please test and push if everything is ok.
Tobias Droste (6
Hi Vinson,
ah sorry, CMAKE_INSTALL_PREFIX=~/code/llvm/build/result.
and you have to run make install.
Tobias
Am Samstag, 3. Dezember 2016, 23:54:37 CET schrieb Tobias Droste:
> Hi Vinson,
>
> are you sure you are using the correct one?
>
> I'm building
/include. I am
> not setting the "--with-llvm-prefix" configure option.
>
> Cheers,
> Vinson
>
> On Sat, Dec 3, 2016 at 1:46 PM, Tobias Droste wrote:
> > Hi Vinson,
> >
> >
> >
> > why is LLVM_INCLUDEDIR not /include? How does t
header
> files are not found. LLVM_INCLUDEDIR is /include and the
> header files are in /include.
>
> Cheers,
> Vinson
>
> On Sat, Dec 3, 2016 at 4:55 AM, Tobias Droste wrote:
> > Hi Vinson,
> >
> > this should not be needed and is obsolete as soon as this
Hi Vinson,
this should not be needed and is obsolete as soon as this gets merged (Emil?):
https://lists.freedesktop.org/archives/mesa-dev/2016-November/135840.html
Did you actually need this or were you just seeing that the code is wrong?
Because LLVM >=3.1 has the header files and this code shou
Add functions to add and check targets/components.
Not used in this patch.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 36
1 file changed, 36 insertions(+)
diff --git a/configure.ac b/configure.ac
index 5a11798..0c955bf 100644
There's no harm in always searching llvm-config.
This way it's available as soon as possible for all functions.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/conf
LLVM components are only added when LLVM is needed.
This means gallium adds this as soon as "--enable-gallium-llvm"
is "yes" and radv + opencl add it explicitly.
v5:
Removed hunk that disabled LLVM for gallium if it was not found.
Signed-off-by: Tobias Droste
--
Use the same order as llvm_check_version_for.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index 5b299d0..5042bf9 100644
--- a/configure.ac
+++ b
The LLVM checks can be anywhere below line 1161 now.
Move the openCL LLVM checks to the section with the other openCL checks.
No functional change.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 41 +++--
1 file changed, 19
or gallium. Rename it to HAVE_GALLIUM_LLVM.
In order to only link LLVM when it is needed, HAVE_GALLIUM_LLVM is only
set if "$enable-gallium-llvm" is yes.
Signed-off-by: Tobias Droste
---
configure.ac| 11 ---
src/gallium/auxiliary/Makefile.am
; is checked by gallium_require_llvm().
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/configure.ac b/configure.ac
index da107b7..d07ac96 100644
--- a/configure.ac
+++ b/configure.ac
@@ -
This moves llvm_set_environment_variables to its final destination
and moves all the LLVM AC_SUBST() below the function call.
No functional change.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 29 ++---
1 file changed, 14 insertions(+), 15
required but missing target/component
--> fail to configure
e) "enable-gallium-llvm" needed but "disable-gallium-llvm" used
--> fail to configure
I also made sure that i965 ("classic" dri driver) and softpipe build
regardless of the LLVM version
This is handled by "llvm_check_version_for" for openCL.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 4
1 file changed, 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6f9ebed..a511c68 100644
--- a/configure.ac
+++ b/configure.ac
@
This moves the LLVM check for radv to the corresponding driver section.
No functional change.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 00a1791..5b299d0
drivers need the patch version and they depend on
LLVM >= 3.6.0, so this is safe too.
Signed-off-by: Tobias Droste
---
configure.ac | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index c92aa82..5fc2c87 100644
--- a/configure.ac
++
A function with the LLVM version checked is moved to the top.
The function is called where the old code was.
No functional change.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 144 ++-
1 file changed, 74
This way LLVM_CONFIG can bet set from an env variable if it's outside
the $llvm_prefix.
This is not a must, but it helps testing.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/configu
led. Now it only gets called by llvmpipe if gallium
LLVM is actually enabled (i.e. only on x86).
Both reasons mentioned above remove the need to check host cpu
in the gallium_require_llvm function.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 17 +-
This makes sure that we handle LLVM minor version >= 10 correctly.
Signed-off-by: Tobias Droste
---
configure.ac | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 5fc2c87..4cdd0cc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -99
This just moves code around so that all LLVM related stuff is at the
top of the file in the correct order.
No functional change.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 151 +--
1 file changed, 74
Consolidate the required LLVM versions at the top where the other
versions for dependencies are listed.
v5:
Splitted out separate changes (see patch 19 and 20)
Signed-off-by: Tobias Droste
---
configure.ac | 68 +++-
1 file changed, 54
There are no non gallium r300 and r600 drivers anymore.
No need to explicilty mention gallium here.
Just cosmetics, no functional change.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index 0c955bf..4f98c19 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2242,11 +2242,7 @@ if test "x$enable_gallium
Use the new helper function to add LLVM targets and components.
The components are added one by one to later find out which component
is missing in case there is one.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 25 ++---
1 file changed, 18
Am Mittwoch, 16. November 2016, 22:56:10 CET schrieb Eric Engestrom:
> On Wednesday, 2016-11-16 18:46:23 +, Emil Velikov wrote:
> > From: Emil Velikov
> >
> > Still far from perfect, but a few small steps in the right direction.
> >
> > - Split build systems, compilers, third party tools
>
Am Donnerstag, 20. Oktober 2016, 18:30:42 CEST schrieb Emil Velikov:
> On 19 October 2016 at 18:55, Tobias Droste wrote:
> > Am Mittwoch, 19. Oktober 2016, 14:17:53 CEST schrieb Emil Velikov:
> >> On 16 October 2016 at 01:20, Tobias Droste wrote:
> >> > LLVM compo
Am Mittwoch, 19. Oktober 2016, 14:33:19 CEST schrieb Emil Velikov:
> Hi Tobias,
>
> Thanks for sticking around and re-spinning the lot. I hope you'll
> agree that things look a lot better now.
True :-)
>
> On 16 October 2016 at 01:20, Tobias Droste wrote:
> > This
Am Mittwoch, 19. Oktober 2016, 14:17:53 CEST schrieb Emil Velikov:
> On 16 October 2016 at 01:20, Tobias Droste wrote:
> > LLVM components are only added when LLVM is needed.
> > This means gallium adds this as soon as "--enable-gallium-llvm"
> > is "yes&
Am Mittwoch, 19. Oktober 2016, 13:55:16 CEST schrieb Emil Velikov:
> On 16 October 2016 at 01:20, Tobias Droste wrote:
> > No need for an additional function here.
> > Use the same style for LLVM checks as the other drivers
> > (e.g. r300, llvmpipe) that don't n
it is set to "no". If later drivers need
this they get the error message that "--enable-gallium-llvm" is
needed.
This way if someone is only building softpipe he doesn't need to
specify "--disable-gallium-llvm" and doesn't have to have LLVM
installed.
Signed-off
This moves llvm_set_environment_variables to its final destination
and moves all the LLVM AC_SUBST() below the function call.
No functional change.
Signed-off-by: Tobias Droste
---
configure.ac | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a
h.
Signed-off-by: Tobias Droste
---
configure.ac | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index 35034d3..62825b7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1180,6 +1180,8 @@ AC_ARG_ENABLE([gallium-tests],
[enable_gal
A function with the LLVM version checked is moved to the top.
The function is called where the old code was.
No functional change.
Signed-off-by: Tobias Droste
---
configure.ac | 144 ++-
1 file changed, 74 insertions(+), 70 deletions
This is handled by "llvm_check_version_for" for openCL.
Signed-off-by: Tobias Droste
Reviewed-by: Emil Velikov
---
configure.ac | 4
1 file changed, 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index c29604e..e1fa7c2 100644
--- a/configure.ac
+++ b/configure.ac
@
There's no harm in always searching llvm-config.
This way it's available as soon as possible for all functions.
Signed-off-by: Tobias Droste
---
configure.ac | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index 4133a7
led. Now it only gets called by llvmpipe if gallium
LLVM is actually enabled (i.e. only on x86).
Both reasons mentioned above remove the need to check host cpu
in the gallium_require_llvm function.
Signed-off-by: Tobias Droste
---
configure.ac | 17 +
1 file changed, 5 inse
Use the same order as llvm_check_version_for.
Signed-off-by: Tobias Droste
---
configure.ac | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index 3aa8214..bbc1cb5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1003,12 +1003,12
This just moves code around so that all LLVM related stuff is at the
top of the file in the correct order.
No functional change.
Signed-off-by: Tobias Droste
---
configure.ac | 151 +--
1 file changed, 74 insertions(+), 77 deletions
This moves the LLVM check for radv to the corresponding driver section.
No functional change.
Signed-off-by: Tobias Droste
---
configure.ac | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 2f5ed50..3aa8214 100644
--- a/configure.ac
+++ b
Use the new helper function to add LLVM targets and components.
The components are added one by one to later find out which component
is missing in case there is one.
Signed-off-by: Tobias Droste
---
configure.ac | 25 ++---
1 file changed, 18 insertions(+), 7 deletions
1 - 100 of 189 matches
Mail list logo
