Re: Lavapipe performance

In addition to what Jose listed, one simple experiment is to try rendering to a smaller window. How does the frame rate change? If it's basically inversely proportional to the window size, that tells us that the rendering is limited by fragment generation/processing. Otherwise, perhaps you're ge

Re: Helping Wine use 64 bit Mesa OGL drivers for 32-bit Windows applications

On 10/22/24 18:03, Derek Lesho wrote: Am 10/21/24 um 11:35 schrieb Michel Dänzer: And Wine's solution for this can't be implemented in Mesa? I think this might actually be possible: In order to accomplish this Wine essentially keeps calling mmaps with addresses in its range until it finds

Re: Question about BITSET_WORD

Maybe there should be a comment regarding the performance and risk of change? -Brian On 8/21/24 07:54, Faith Ekstrand wrote: I've actually benchmarked this and 32bit is still faster on many modern CPUs. Also, I would be very surprised if we could change it without breaking the universe. I'm

Don't forget, freedesktop.org offers free CoC training for inquiring projects

hat's needed is to send an email to the board, and we can handle setting up scheduling :). And of course as always, the Code of Conduct team is always looking for new volunteers. -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat

Re: Intel clc dependency

On 4/10/24 13:53, Timo Aaltonen wrote: Brian Paul kirjoitti 6.4.2024 klo 1.05: I'm trying to build the Intel Vulkan driver.  First time in a few months.  I'm having build problems related to clc.  I'm on Ubuntu 22.04 [...] [1347/3181] Generating src/intel/vulkan/...om comm

Re: Intel clc dependency

d to avoid the whole thing. On Fri, Apr 5, 2024, 6:05 PM Brian Paul <mailto:brian.p...@broadcom.com>> wrote: I'm trying to build the Intel Vulkan driver.  First time in a few months.  I'm having build problems related to clc.  I'm on Ubuntu 22.04 [...]

Intel clc dependency

I'm trying to build the Intel Vulkan driver. First time in a few months. I'm having build problems related to clc. I'm on Ubuntu 22.04 [...] [1347/3181] Generating src/intel/vulkan/...om command (wrapped by meson to set env) FAILED: src/intel/vulkan/grl/gfx125_bvh_build_BFS_BFS_pass1_index

Re: Porting / AMIGA / PiStorm32 / developer needed - Back to the roots

On 4/12/23 02:30, Ignacio Soriano Hernandez wrote: !! External Email Dear Mesa dev community, Please let me apologize if you consider this off topic but I think that this is probably the audience that could help in reviving and getting back to the roots where Mesa3D originated from. To use B

Requests For Proposals for hosting XDC 2023 are now open

ier is better since there generally will be a bit of Q&A with organizers. And if you just have some questions about what organizing XDC entails, please feel free to chat with previous organizers, or someone from the board. Best regards, Lyude Paul On behalf of X.org -- Cheers, L

XDC 2022: Registration & Call for Presentations still open!

d me an email to x...@codeweavers.com, adding on CC the X.org board (board at foundation.x.org).   And don't forget, you can follow us on Twitter for all the latest updates and to stay connected:   https://twitter.com/XOrgDevConf Best regards, Lyude Paul, on behalf of X.org -- Cheers, L

XDC 2022: Registration & Call for Presentations still open!

d me an email to x...@codeweavers.com, adding on CC the X.org board (board at foundation.x.org).   And don't forget, you can follow us on Twitter for all the latest updates and to stay connected:   https://twitter.com/XOrgDevConf Best regards, Lyude Paul, on behalf of X.org -- Cheers, L

XDC 2022: Registration & Call for Presentations still open!

d me an email to x...@codeweavers.com, adding on CC the X.org board (board at foundation.x.org).   And don't forget, you can follow us on Twitter for all the latest updates and to stay connected:   https://twitter.com/XOrgDevConf Best regards, Lyude Paul, on behalf of X.org

Requests For Proposals for hosting XDC 2023 are now open

ier is better since there generally will be a bit of Q&A with organizers. And if you just have some questions about what organizing XDC entails, please feel free to chat with previous organizers, or someone from the board. Best regards, Lyude Paul On behalf of X.org

XDC 2022: Registration & Call for Proposals now open!

oard (board at foundation.x.org). And don't forget, you can follow us on Twitter for all the latest updates and to stay connected: https://twitter.com/XOrgDevConf Best regards, Lyude Paul, on behalf of X.org

2022 X.Org Foundation Election vote results

that Emma Anholt, Alyssa Rosenzweig, Mark Filion and Ricardo Garcia were elected for two year terms. The old full board is: Emma Anholt, Samuel Iglesias Gonsálvez, Mark Filion, Manasi D Navare, Keith Packard, Lyude Paul, Daniel Vetter, Harry Wentland The new full board is: Emma Anholt, Samuel

2022 X.org Foundation Election Candidates

eriod begins. Lyude Paul, on behalf of the X.Org elections committee

2022 X.Org Foundation Membership deadline for voting in the election

upcoming election is 31 March 2022 at 23:59 UTC. If you are interested in joining the X.Org Foundation or in renewing your membership, please visit the membership system site at: https://members.x.org/ Lyude Paul, on behalf of the X.Org elections committee

2022 X.Org Board of Directors Elections Nomination period is NOW

were Lyude Paul, Samuel Iglesias Gonsálvez, Manasi D Navare and Daniel Vetter. They will continue to serve until their term ends in 2023. Current directors whose term expires in 2022 are Emma Anholt, Keith Packard, Harry Wentland and Mark Filion. A director is expected to participate in the

2022 X.Org Board of Directors Elections timeline extended, Request for nominations

will serve as directors for two year terms. The directors who received two year terms starting in 2021 were Lyude Paul, Samuel Iglesias Gonsálvez, Manasi D Navare and Daniel Vetter. They will continue to serve until their term ends in 2023. Current directors whose term expires in 2022 are Emma Anholt

2022 X.Org Board of Directors Elections Nomination period is NOW

directors elected from the membership. Each year, an election is held to bring the total number of directors to eight. The four members receiving the highest vote totals will serve as directors for two year terms. The directors who received two year terms starting in 2021 were Lyude Paul, Samuel

[Important!] 2022 X.Org Foundation Membership deadline for voting in the election

/Elections/2022/ Lyude Paul, On behalf of the X.Org elections committee

[Important!] 2022 X.Org Foundation Membership deadline for voting in the election

/Elections/2022/     Lyude Paul,     On behalf of the X.Org elections committee

Re: [Mesa-dev] Help needed for EVoC/GSoC/Outreachy

ts in areas that wouldn't be eligible for GSoC would still have a chance at participating in a project. Outreachy also helps fill this gap, as I don't believe they have the same kind of international restrictions that GSoC does. * What is the expected result, a grading? Yes. On Wed, 2

[Mesa-dev] Help needed for EVoC/GSoC/Outreachy

e myself wouldn't be in this community without projects like GSoC :). -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Freenode fallout

munity. As well, the board believes OFTC's current Governance model is a lot more clear then Libera's. -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are

Re: [Mesa-dev] Mesa (master): lavapipe: bump maxMemoryAllocationCount

On 3/17/21 6:12 PM, GitLab Mirror wrote: Module: Mesa Branch: master Commit: 23100f3b6531d7055ae4d42e07bda09d991ea438 URL: https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcgit.freedesktop.org%2Fmesa%2Fmesa%2Fcommit%2F%3Fid%3D23100f3b6531d7055ae4d42e07bda09d991ea438&data=04%7C

[Mesa-dev] Fwd: [Mesa-users] Surfaceless mesa 20.3.X?

Forwarding to mesa-dev where you may get more help. There was talk of changing software rendering but I'm not sure what's changed. What version of Mesa are you using? -Brian Forwarded Message Subject:[Mesa-users] Surfaceless mesa 20.3.X? Date: Wed, 27 Jan 2021 09

[Mesa-dev] Fwd: [Mesa-users] Issues with removal of classic OSMesa

Hi Andreas, I'm forwarding your message to the mesa-dev list for better visibility. BTW, when you say "antialiasing" below, what exactly do you mean? -Brian Forwarded Message Subject:[Mesa-users] Issues with removal of classic OSMesa Date: Thu, 31 Dec 2020 12:56:04

Re: [Mesa-dev] GLSLstd450NMin/NMax/NClamp

On 11/17/2020 01:59 PM, Brian Paul wrote: On 11/17/2020 11:45 AM, Ian Romanick wrote: On 11/17/20 9:25 AM, Brian Paul wrote: It appears these SPIR-V extension functions don't behave as they should on Intel (don't know about other Vulkan drivers). They're supposed to be NaN-awa

Re: [Mesa-dev] SpvOpSelect w/ float operands

On 11/18/2020 02:49 AM, Connor Abbott wrote: On Tue, Nov 17, 2020 at 9:56 PM Brian Paul wrote: On 11/17/2020 11:49 AM, Ian Romanick wrote: On 11/17/20 9:25 AM, Brian Paul wrote: Using the Intel Vulkan driver, we've found some cases where SpvOpSelect is returning -0.0 (negative

[Mesa-dev] fp/int64 on gen11/12?

Another Intel question: It looks like gen11/gen12 don't have fp/int64 enabled in the Vulkan driver. From gen_device_info.c: #define GEN11_FEATURES(_gt, _slices, _subslices, _l3) \ GEN8_FEATURES, \ GEN11_HW_INFO, \

Re: [Mesa-dev] GLSLstd450NMin/NMax/NClamp

On 11/17/2020 11:45 AM, Ian Romanick wrote: On 11/17/20 9:25 AM, Brian Paul wrote: It appears these SPIR-V extension functions don't behave as they should on Intel (don't know about other Vulkan drivers). They're supposed to be NaN-aware such that if one argument is NaN, the ot

Re: [Mesa-dev] SpvOpSelect w/ float operands

On 11/17/2020 11:49 AM, Ian Romanick wrote: On 11/17/20 9:25 AM, Brian Paul wrote: Using the Intel Vulkan driver, we've found some cases where SpvOpSelect is returning -0.0 (negative zeros) instead of normal 0.0 depending on the arguments. Do you have a specific test case that fails?

[Mesa-dev] SpvOpSelect w/ float operands

Using the Intel Vulkan driver, we've found some cases where SpvOpSelect is returning -0.0 (negative zeros) instead of normal 0.0 depending on the arguments. I'm wondering if "SpvOpSelect x, a, b" for floats is being implemented with something like "a*x + b*(1-x)" ? That might explain where

[Mesa-dev] GLSLstd450NMin/NMax/NClamp

It appears these SPIR-V extension functions don't behave as they should on Intel (don't know about other Vulkan drivers). They're supposed to be NaN-aware such that if one argument is NaN, the other argument is returned. From our testing, it looks like NMax works as expected, but not NMin

Re: [Mesa-dev] llvmpipe is OpenGL 4.5 conformant.

Nice work!  It's good to see llvmpipe being maintained and improved like that. -Brian On 10/30/2020 02:24 PM, Dave Airlie wrote: Just to let everyone know, a month ago I submitted the 20.2 llvmpipe driver for OpenGL 4.5 conformance under the SPI/X.org umbrella, and it is now official[1]. Than

Re: [Mesa-dev] Gallium interface rename proposals

This all sounds find to me, FWIW. -Brian On 09/19/2020 04:24 AM, Marek Olšák wrote: Hi, I don't know if you have been following gitlab, but there are a few cleanups that I have been considering doing. Rename PIPE_TRANSFER flags to PIPE_MAP, and pipe_transfer_usage to pipe_map_flags: https

[Mesa-dev] [RESEND] Requests For Proposals for hosting XDC2021 are now open

amp;A with organizers. And if you just have some questions about what organizing XDC entails, please feel free to chat with previous organizers, or someone from the board. -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat __

Re: [Mesa-dev] New Mesa3D.org website proposal

On Sun, Jun 14, 2020 at 9:28 AM Daniel Stone wrote: > Hi, > > On Fri, 29 May 2020 at 10:08, Erik Faye-Lund > wrote: > > In the light of the explanation above, do you still have objections to > > this split? > > > > Obviously, we haven't moved forward yet ;-) > > Well, we have now after getting s

Re: [Mesa-dev] New Mesa3D.org website proposal

On 05/13/2020 03:13 AM, Erik Faye-Lund wrote: On Tue, 2020-05-12 at 12:17 +0200, Erik Faye-Lund wrote: On Thu, 2020-05-07 at 11:03 -0600, Brian Paul wrote: On 05/07/2020 04:33 AM, Erik Faye-Lund wrote: Hey Brian TLDR; are you OK with me moving forward with the rework of mesa3d.org? Yes

Re: [Mesa-dev] New Mesa3D.org website proposal

On Tue, May 12, 2020 at 4:04 AM Daniel Stone wrote: > Hi Brian, > > On Fri, 8 May 2020 at 15:30, Brian Paul wrote: > > Done. easydns says it may take up to 3 hours to go into effect. > > Thanks for doing this! Could you please add the following TXT records > as well (no

Re: [Mesa-dev] RFC: Memory allocation on Mesa

On 05/11/2020 10:13 AM, Jose Fonseca wrote: Hi, To give everybody a bit of background context, this email comes from https://gitlab.freedesktop.org/mesa/mesa/-/issues/2911 . The short story is that Gallium components (but not Mesa) used to have their malloc/free calls intercepted, to satisfy

Re: [Mesa-dev] New Mesa3D.org website proposal

On Thu, May 7, 2020 at 12:16 PM Brian Paul wrote: > On 05/07/2020 11:35 AM, Daniel Stone wrote: > > Hi, > > > > On Thu, 7 May 2020 at 18:08, Erik Faye-Lund > > wrote: > >> On Thu, 2020-05-07 at 11:03 -0600, Brian Paul wrote: > >>> It seems like

Re: [Mesa-dev] New Mesa3D.org website proposal

On 05/07/2020 11:35 AM, Daniel Stone wrote: Hi, On Thu, 7 May 2020 at 18:08, Erik Faye-Lund wrote: On Thu, 2020-05-07 at 11:03 -0600, Brian Paul wrote: It seems like only the front page is served at the moment. Is it possible to get a look at the rest? The front page looks nice. Yeah, we

Re: [Mesa-dev] New Mesa3D.org website proposal

On 05/07/2020 04:33 AM, Erik Faye-Lund wrote: Hey Brian TLDR; are you OK with me moving forward with the rework of mesa3d.org? Yes... (BTW, sorry about the URL mangling below) As you hopefully are aware of, I've been working on a new website for mesa3d.org, split into a "marketing"-frontpa

[Mesa-dev] Windows build broken

by: commit f8f1413070ae079443ab31a75679cfd10cb756ed Author: Pierre-Eric Pelloux-Prayer Date: Mon Mar 16 10:49:17 2020 +0100 util/u_process: add util_get_process_exec_path Reviewed-by: Marek Olšák Part-of: scons

Re: [Mesa-dev] Drop scons for 20.1?

ristian > > > > > Jose > > > > > > From: Kristian Høgsberg > > Sent: Wednesday, February 26, 2020 18:37 > > To: Jason Ekstrand > > Cc: Rob Clark ; mesa-dev < > mesa-dev@lists.freedesktop.org>; Dylan Baker ; &

Re: [Mesa-dev] [Review Request (master branch)] svga: Use pipe_shader_state_from_tgsi to set shader state

I'm going to update the docs regarding patches and gitlab. It's kind of a mess now. -Brian On 02/11/2020 03:03 AM, Michel Dänzer wrote: Hi Charmaine, it looks like you pushed this patch and another one directly to the main Mesa repository master branch. Pushing directly to the main Mes

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

On 12/11/2019 10:42 AM, Jason Ekstrand wrote: On Wed, Dec 11, 2019 at 11:33 AM Michel Dänzer <mailto:mic...@daenzer.net>> wrote: On 2019-12-11 5:47 p.m., Brian Paul wrote: > > I've had little time for Mesa work the past 18 months. That makes me sad, I h

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

On 12/09/2019 04:07 PM, Dylan Baker wrote: Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through gitlab. I think we should stop using the mailing list, here are some reasons: 1) Most development is ha

Re: [Mesa-dev] [PATCH] util/atomic: Fix p_atomic_add for unlocked and msvc paths

Reviewed-by: Brian Paul On 12/09/2019 10:49 AM, srol...@vmware.com wrote: From: Roland Scheidegger Braces mismatch (flagged by CI, untested). Fixes: 385d13f26d2 "util/atomic: Add a _return variant of p_atomic_add" --- src/util/u_atomic.h | 4 ++-- 1 file changed, 2 insert

Re: [Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

On 11/22/2019 09:16 PM, Ian Romanick wrote: On 11/22/19 6:49 PM, Brian Paul wrote: This fixes a build failure on MSVC. BTW, it looks like clang supports _Pragma() but I don't know if it understands the "gcc unroll N" directive. It probably doesn't, but that should be oka

[Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

This fixes a build failure on MSVC. BTW, it looks like clang supports _Pragma() but I don't know if it understands the "gcc unroll N" directive. Signed-off-by: Brian Paul --- src/compiler/nir/nir_range_analysis.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/s

Re: [Mesa-dev] [PATCH] Call shmget() with permission 0600 instead of 0777

Ping again. On 10/24/2019 03:25 PM, Brian Paul wrote: Ping.  Anyone? -Brian On Tue, Oct 22, 2019 at 3:52 PM Brian Paul <mailto:bri...@vmware.com>> wrote: A security advisory (TALOS-2019-0857/CVE-2019-5068) found that creating shared memory regions with permission mode 0

[Mesa-dev] [PATCH] spirv: s/{}/{0}/ initializer to fix MSVC build

Trivial. --- src/compiler/spirv/vtn_variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 944d1f0..37ad4f2 100644 --- a/src/compiler/spirv/vtn_variables.c +++ b/src/compiler/spirv/vtn_variables

[Mesa-dev] [PATCH] nir: fix a couple signed/unsigned comparison warnings in nir_builder.h

--- src/compiler/nir/nir_builder.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index de00fe7..aed4759 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -782,7 +782,7 @@ nir

[Mesa-dev] [PATCH] s/APIENTRY/GLAPIENTRY/ in teximage.c

The later is the right symbol for entrypoint functions. --- src/mesa/main/texgetimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index e43f336..d6ec4c5 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/

[Mesa-dev] [v2, 2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

Signed-off-by: Paul Gofman --- Corresponding piglit test patch: https://patchwork.freedesktop.org/patch/338798/ src/mesa/state_tracker/st_gen_mipmap.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_gen_mipmap.c b/src/mesa/state_tracker

[Mesa-dev] [v2, 1/2] i965: Handle texture view min level in brw_generate_mipmap()

Currently minlevel set with glTextureView() is ignored for mipmap generation and original texture's first layer is used as the source layer in glGenerateMipmap(). Signed-off-by: Paul Gofman --- Corresponding piglit test patch: https://patchwork.freedesktop.org/patch/338798/ src

Re: [Mesa-dev] [2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

On 11/2/19 00:09, Ian Romanick wrote: > > It's not strictly a requirement, but having some kind of a test is very > highly desirable. I will try to do that next week. I can guess piglit/tests/spec/arb_texture_view/mipgen.c is the right place for that. ___

Re: [Mesa-dev] [2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

d all use some piglit tests that iterate through all > or at least many different formats, including both renderable and > non-renderable ones. So do you think it is required to add such tests prior to these fixes? Regards,     Paul. ___ mesa-dev m

[Mesa-dev] [1/2] i965: Handle texture view min level in brw_generate_mipmap()

Currently minlevel set with glTextureView() is ignored for mipmap generation and original texture's first layer is used as the source layer in glGenerateMipmap(). Signed-off-by: Paul Gofman --- Spotted while debugging Wine d3d11 unit test failures with Nouveau and Intel drivers. src

[Mesa-dev] [2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

Signed-off-by: Paul Gofman --- src/mesa/state_tracker/st_gen_mipmap.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_gen_mipmap.c b/src/mesa/state_tracker/st_gen_mipmap.c index b71a8ee57bb..c5cf7063836 100644 --- a/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH] Call shmget() with permission 0600 instead of 0777

Ping. Anyone? -Brian On Tue, Oct 22, 2019 at 3:52 PM Brian Paul wrote: > A security advisory (TALOS-2019-0857/CVE-2019-5068) found that > creating shared memory regions with permission mode 0777 could allow > any user to access that memory. Several Mesa drivers use shared- > me

[Mesa-dev] [PATCH] Call shmget() with permission 0600 instead of 0777

A security advisory (TALOS-2019-0857/CVE-2019-5068) found that creating shared memory regions with permission mode 0777 could allow any user to access that memory. Several Mesa drivers use shared- memory XImages to implement back buffers for improved performance. This path changes the shmget() ca

[Mesa-dev] Anyone interested in CoC training courtesy of X.Org?

a few different projects to figure out who all would be interested in such training. If there's any takers, or anyone has any questions, feel free to respond and let us know! -- Cheers, Lyude Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp

On 09/11/2019 03:06 PM, Ian Romanick wrote: On 9/10/19 10:53 PM, Brian Paul wrote: IIRC, designated initializers are not legal C++. Fixes the MSVC build. Fixes: 83fd1e58 ("glsl/nir: Add and use a gl_nir_link() function") --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- 1 fi

[Mesa-dev] [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp

IIRC, designated initializers are not legal C++. Fixes the MSVC build. Fixes: 83fd1e58 ("glsl/nir: Add and use a gl_nir_link() function") --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/

Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.

For the series, Reviewed-by: Brian Paul On 08/27/2019 04:57 AM, Jose Fonseca wrote: Uses some of the same -Werror options used by Meson, as suggested by Michel Daezer. --- scons/gallium.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scons/gallium.py b/scons

Re: [Mesa-dev] [PATCH] st/mesa: don't allocate mipmapped texture for NEAREST_MIPMAP_LINEAR

Reviewed-by: Brian Paul On 08/10/2019 10:14 AM, Marek Olšák wrote: Ping On Fri., Aug. 2, 2019, 19:13 Marek Olšák, <mailto:mar...@gmail.com>> wrote: From: Marek Olšák mailto:marek.ol...@amd.com>> ---  src/mesa/state_tracker/st_cb_texture.c | 12 ++

Re: [Mesa-dev] [PATCH] gallivm: fix issue with AtomicCmpXchg wrapper on llvm 3.5-3.8

logic be moved into the body of LLVMBuildAtomicCmpXchg() so the whole function isn't duplicated? Other than that, Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Mesa (update-reviewers-for-vmware): i965/clear: clear_value better precision

On 08/02/2019 09:56 AM, Eric Engestrom wrote: On Friday, 2019-08-02 17:50:17 +0200, Michel Dänzer wrote: On 2019-08-02 5:37 p.m., Brian Paul wrote: Ugh, I didn't mean to do this.  I'm trying to figure out how to make a merge request with gitlab. Just push to a branch in you

Re: [Mesa-dev] Mesa (update-reviewers-for-vmware): i965/clear: clear_value better precision

Ugh, I didn't mean to do this. I'm trying to figure out how to make a merge request with gitlab. -Brian On 08/02/2019 09:35 AM, GitLab Mirror wrote: Module: Mesa Branch: update-reviewers-for-vmware Commit: a86eccfb78092493b3999849db62613838951756 URL: https://nam04.safelinks.protection.o

Re: [Mesa-dev] Mesa 19.2.0 release plan

Hi all I would suggest to add this issue to the release - https://bugs.freedesktop.org/show_bug.cgi?id=110814 Since, the isn't actual with 19.0 version of the Mesa - it's a regression issue and we proposed the fix to it and would ask to merge it to 19.2 release it in this release. Reg

Re: [Mesa-dev] [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

Ordering), + mapFromLLVMOrdering(FailureOrdering), SingleThread ? llvm::SynchronizationScope::SingleThread : llvm::SynchronizationScope::CrossThread)); } #endif Reviewed-by: Br

Re: [Mesa-dev] [PATCH] intel/ir: Fix CFG corruption in opt_predicated_break().

I've run the test from the https://bugs.freedesktop.org/show_bug.cgi?id=111009 with applied patch and it doesn't crash and successfully passes. Thanks! Tested-by: Paul Chelombitko ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH 1/2] nir/loop_analyze: used nir_alu_src to track loop limit

On 06/19/2019 02:08 AM, Timothy Arceri wrote: This helps reduce the amount of abstraction in this pass and allows us to retain more information about the src such as any swizzles. Retaining the swizzle information is required for a bugfix in the following patch. Fixes: 6772a17acc8e ("nir: Add a

Re: [Mesa-dev] [PATCH] nir: silence three compiler warnings seen with MinGW

Ping. -Brian On 05/20/2019 07:36 AM, Brian Paul wrote: Silence two unused var warnings. And init elem_size, elem_align to zero to silence "maybe uninitialized" warnings. --- src/compiler/nir/nir_lower_int_to_float.c | 2 +- src/compiler/nir/nir_opt_copy_prop_vars.c | 4 +--- sr

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

On 05/23/2019 02:48 AM, Erik Faye-Lund wrote: On Wed, 2019-05-22 at 18:06 +0200, Akim Demaille wrote: Hi Erik, Le 22 mai 2019 à 08:54, Erik Faye-Lund < erik.faye-l...@collabora.com> a écrit : I ended up reverting the change [from-%error-verbose to %define parse.error verbose] , and I can't fi

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

I think this change broke the MSVC build for us. I may not have time to investigate until later today. -Brian On 05/21/2019 05:41 AM, GitLab Mirror wrote: Module: Mesa Branch: master Commit: eb85124a9f6e9cb94d0d4a99f91bbae374777e3a URL: https://nam04.safelinks.protection.outlook.com/?url=

Re: [Mesa-dev] [PATCH 2/2] mesa: unreference current winsys buffers when unbinding winsys buffers

Both look OK to me. Do they need to be tagged with "Cc: mesa-sta...@lists.freedesktop.org" for the stable branches? Reviewed-by: Brian Paul On 05/18/2019 07:46 PM, Charmaine Lee wrote: This fixes surface leak when no winsys buffers are bound. --- src/mesa/main/context.c | 4 +++

[Mesa-dev] [PATCH] nir: silence three compiler warnings seen with MinGW

Silence two unused var warnings. And init elem_size, elem_align to zero to silence "maybe uninitialized" warnings. --- src/compiler/nir/nir_lower_int_to_float.c | 2 +- src/compiler/nir/nir_opt_copy_prop_vars.c | 4 +--- src/compiler/nir_types.cpp| 2 +- 3 files changed, 3 inserti

[Mesa-dev] [PATCH] svga: clamp max_const_buffers to SVGA_MAX_CONST_BUFS

In case the device reports 15 (or more) buffers. --- src/gallium/drivers/svga/svga_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 02c1a99..b70fd85 100644 --- a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 0/6] Update mesa state handling past VAO changes.

The series LGTM. Reviewed-by: Brian Paul On 05/12/2019 07:05 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Brian, The series is a collection of comment updates and state handling cleanup past the VAO changes that went into mesa. There are two fixes for potential bugs in

[Mesa-dev] [PATCH] st/mesa: fix uninitialized lower_flrp_progress variable

The 'progress' variable is initialized to false in other locations. This fixes a new Coverity warning. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_ni

Re: [Mesa-dev] [PATCH] gallivm: fix broken 8-wide s3tc decoding

LGTM. Just two little nits below. Reviewed-by: Brian Paul Perhaps you could review the 5-patch series of clean-ups I posted on Saturday? On 05/06/2019 06:12 PM, srol...@vmware.com wrote: From: Roland Scheidegger Brian noticed there was an uninitialized var for the 8-wide case and 128

[Mesa-dev] [PATCH 2/5] ddebug: fix a few MSVC compiler warnings

Don't return an expression in void functions. Replace an unsigned int with proper enum. --- src/gallium/auxiliary/driver_ddebug/dd_context.c | 15 --- src/gallium/auxiliary/driver_ddebug/dd_screen.c | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/gallium/au

[Mesa-dev] [PATCH 1/5] glsl: s/GLboolean/bool/ to silence MSVC compiler warning

It complains about mixing GLboolean and bool in the |= expression. --- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp b/src/compiler/glsl/glsl_parser_extras.cpp index d99ab3d..41f2a97 100644 ---

[Mesa-dev] [PATCH 4/5] gallium/pp: s/uint/enum tgsi_semantic/ to fix MSVC warning

--- src/gallium/auxiliary/postprocess/pp_program.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/postprocess/pp_program.c b/src/gallium/auxiliary/postprocess/pp_program.c index 52786de..4cd3990 100644 --- a/src/gallium/auxiliary/postprocess/pp_program.c

[Mesa-dev] [PATCH 3/5] noop: s/enum pipe_transfer_usage/unsigned/ to fix MSVC warning

The function pointer declaration in pipe_context uses unsigned for the bitmask. --- src/gallium/auxiliary/driver_noop/noop_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/driver_noop/noop_pipe.c b/src/gallium/auxiliary/driver_noop/noop_pipe.c index

[Mesa-dev] [PATCH 5/5] gallium/util: fix two MSVC compiler warnings

Remove stray const qualifier. s/unsigned/enum tgsi_semantic/ --- src/gallium/auxiliary/util/u_format_zs.h | 2 +- src/gallium/auxiliary/util/u_simple_shaders.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_zs.h b/src/gallium/auxi

[Mesa-dev] [PATCH] nir/algebraic: Don't emit empty arrays for MSVC

Just don't emit the transform array at all if there are no transforms for a state, and avoid trying to walk over it. Original patch by Connor Abbott. Updated with suggestions by Dylan Baker. --- src/compiler/nir/nir_algebraic.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --

Re: [Mesa-dev] [PATCH 03/10] mesa: Implement _mesa_array_element by walking enabled arrays.

On 05/02/2019 11:18 PM, Mathias Fröhlich wrote: Hi Brian, On Friday, 3 May 2019 00:17:51 CEST Brian Paul wrote: On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich In glArrayElement, use the bitmask trick to just walk the enabled vao arrays. This should be about

Re: [Mesa-dev] [PATCH 03/10] mesa: Implement _mesa_array_element by walking enabled arrays.

;Mappings[MAP_INTERNAL].Pointer, + _mesa_vertex_attrib_address(array, binding)) + + elt * binding->Stride; + return src; +} Could you add some brief comments on those functions to explain what they do? Otherwise, for the rest of the series, Reviewed-by: Brian Paul Nice work!! -Brian

Re: [Mesa-dev] [PATCH 01/10] mesa: Factor out index function that will have multiple use.

On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich For access to glArrayElement methods factor out a function to get the table lookup index for normalized/integer/double access. The function will be used in the next patch at least twice. Signed-off-by: Mathias Fröh

Re: [Mesa-dev] [PATCH 02/10] mesa: Use glVertexAttrib*NV functions for fixed function attribs.

that use a loop to walk the attributes. I'm not sure I understand that last sentence. The code looks fine. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/api_arrayelt.c | 185 ++- 1 file changed, 28 insertions(+), 157 dele

Re: [Mesa-dev] [PATCH] nir/algebraic: Don't emit empty initializers for MSVC

On 05/02/2019 02:34 PM, Connor Abbott wrote: Just don't emit the transform array at all if there are no transforms for a state, and avoid trying to walk over it. --- Brian, does this build on Windows? I tested it on my shader-db on radeonsi. Yes, it compiles. Thanks! Tested-by: Brian

Re: [Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

ash trying to access it. Hmm, any ideas for how to fix this? -Brian Running piglit with i965, or radeonsi will reproduce the crash. On Thu, May 2, 2019 at 7:52 PM Brian Paul <mailto:bri...@vmware.com>> wrote: This fixes a build failure with MSVC. --- I've compile

[Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

This fixes a build failure with MSVC. --- I've compiled tested this, but not sure how to runtime test it. --- src/compiler/nir/nir_algebraic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index 6db749e..dc25421 100

[Mesa-dev] [PATCH 1/2] svga: move host logging to winsys

From: Charmaine Lee This patch adds a host_log interface to svga_winsys and moves the host logging code to the winsys layer. Reviewed-by: Brian Paul --- src/gallium/drivers/svga/Makefile.sources | 2 - src/gallium/drivers/svga/meson.build | 1 - src/gallium/drivers/svga

  1   2   3   4   5   6   7   8   9   10   >