Re: [Mesa-dev] [PATCH] egl/android: config id increase one by one

> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, June 15, 2017 9:59 PM > To: Liu, Zhiquan > Cc: ML mesa-dev ; Long, Zhifang > ; Rob Herring ; Tomasz Figa > > Subject: Re: [PATCH] egl/android: config id increase one b

[Mesa-dev] [PATCH] egl/android: config id increase one by one

when dri2_add_config, driver_configs may add to exist dri2_conf, the config id should not increase in this case. In the code, when ConfigID equal to count+1, it's mean a new config, config_count will increase. otherwise it's a exist config. Signed-off-by: Liu Zhiquan Signed-off-by: Lon

[Mesa-dev] [PATCH 1/2] Revert "egl: stop claiming support for pbuffer + msaa"

This reverts commit 4d6d55deef291b489af4d7870c6f5eb223c8da5d. SurfaceType added EGL_PBUFFER_BIT when dri_single_config is null. This will fix in "egl: correct surface_type when add config" patch. --- src/egl/drivers/dri2/egl_dri2.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/e

[Mesa-dev] [PATCH 2/2] egl: correct surface_type when add config

dri_single_config is null. Signed-off-by: Liu Zhiquan Signed-off-by: Long, Zhifang --- src/egl/drivers/dri2/egl_dri2.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index ac231d0..60b24ad 100644 --- a/src/egl

[Mesa-dev] [PATCH v3] EGL/android: Enhance pbuffer implementation

for supported buffer failed. v2: coding style and log changes v3: coding style changes and update patch format Signed-off-by: Liu Zhiquan Signed-off-by: Long, Zhifang Reviewed-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 177 +--- 1 file changed, 96

Re: [Mesa-dev] [PATCH] EGL/android: Enhance pbuffer implementation

I upload v2 version, please review. https://patchwork.freedesktop.org/patch/125787/ Best Regards, Zhiquan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] EGL/android: Enhance pbuffer implementation

for supported buffer failed. Signed-off-by: Liu Zhiquan Signed-off-by: Long, Zhifang --- src/egl/drivers/dri2/platform_android.c | 180 ++-- 1 file changed, 101 insertions(+), 79 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers

Re: [Mesa-dev] [PATCH] EGL/android: Enhance pbuffer implementation

Hi Tomasz, Thanks for the review. I will change these logs and code styles errors in v2 version. > > + } else if (dri2_surf->base.Type == EGL_PBUFFER_BIT) { > > We won't be called with anything else than window or pbuffer bit here, > because we don't advertise pixmap support and createPixm

Re: [Mesa-dev] [PATCH] EGL/android: Enhance pbuffer implementation

> >>> if (dri2_surf->dri_image_front) { > >>> - _eglLog(_EGL_DEBUG, "%s : %d : destroy dri_image_front", __func__, > __LINE__); > >>> + _eglLog(_EGL_DEBUG, "destroy dri_image_front"); > >>>dri2_dpy->image->destroyImage(dri2_surf->dri_image_front); > >>>dri2_surf->dri_i

Re: [Mesa-dev] EGL/android: pbuffer implementation.

Hi Tomasz, I submitted a new patch to enhance the pbuffer implementation. Please check if it satisfy your requirement. https://patchwork.freedesktop.org/patch/123848/ Thanks, Zhiquan, ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lis

[Mesa-dev] [PATCH] EGL/android: Enhance pbuffer implementation

for supported buffer failed. Signed-off-by: Liu Zhiquan Signed-off-by: Long, Zhifang --- src/egl/drivers/dri2/platform_android.c | 209 +++- 1 file changed, 126 insertions(+), 83 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers

Re: [Mesa-dev] EGL/android: pbuffer implementation.

Hi Tomasz, Thanks for you commends. > > > > Looks like this patch has already landed, but please let me try to > confirm some things here anyway. Would you mind keeping me on CC for > any future patches for the EGL/Android module? (I believe > scripts/get_reviewer.pl should already include me

[Mesa-dev] EGL/android: pbuffer implementation.

e and code review changes. Signed-off-by: Liu Zhiquan Signed-off-by: Kalyan Kondapally --- src/egl/drivers/dri2/egl_dri2.h | 3 +- src/egl/drivers/dri2/platform_android.c | 98 + 2 files changed, 78 insertions(+), 23 deletions(-) diff --git a/src/egl/dr

[Mesa-dev] EGL/android: pbuffer implementation.

emove duplicate codes. Signed-off-by: Liu Zhiquan Signed-off-by: Kalyan Kondapally --- src/egl/drivers/dri2/egl_dri2.h | 3 +- src/egl/drivers/dri2/platform_android.c | 109 2 files changed, 86 insertions(+), 26 deletions(-) diff --git a/src/egl/dr

[Mesa-dev] EGL/android: pbuffer implementation.

d-off-by: Liu Zhiquan --- src/egl/drivers/dri2/egl_dri2.h | 3 +- src/egl/drivers/dri2/platform_android.c | 169 +++- 2 files changed, 124 insertions(+), 48 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.h b/src/egl/drivers/dri2/egl_dri2.h index 3a