Passes all corresponding piglit tests.
Signed-off-by: Lars Hamre
---
CC: Roland Scheidegger
NOTE: someone with access will need to commit this post
review process
src/gallium/drivers/llvmpipe/lp_screen.c | 3 ++-
src/gallium/drivers/llvmpipe/lp_surface.c | 3 ++-
2 files changed, 4
.
Signed-off-by: Lars Hamre
---
CC: Roland Scheidegger
NOTE: someone with access will need to commit this post
review process
src/gallium/auxiliary/util/u_surface.c | 386 -
src/gallium/auxiliary/util/u_surface.h | 7 +
2 files changed, 248 insertions
Passes all corresponding piglit tests.
Signed-off-by: Lars Hamre
---
CC: Roland Scheidegger
NOTE: someone with access will need to commit this post
review process
src/gallium/drivers/softpipe/sp_screen.c | 3 ++-
src/gallium/drivers/softpipe/sp_texture.c | 2 ++
2 files changed, 4
Signed-off-by: Lars Hamre
---
CC: Roland Scheidegger
NOTE: someone with access will need to commit this post
review process
docs/features.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/features.txt b/docs/features.txt
index 01315a0..d7828b1 100644
--- a
That does seem nicer, then pipe->clear_texture could just be set to
util_clear_texture.
Tangentially, do you see anything preventing this solution being
utilized by llvmpipe?
On Mon, Feb 20, 2017 at 2:31 PM, Roland Scheidegger wrote:
> Am 20.02.2017 um 18:01 schrieb Lars Hamre:
>>
v2: rework util clear functions such that they operate on a resource
instead of a surface (Roland Scheidegger)
Implements the ARB_clear_texture extension for softpipe.
Passes all corresponding piglit tests.
Signed-off-by: Lars Hamre
---
CC: Roland Scheidegger
NOTE: someone with access
thing similar would also be done for clear_depth_stencil.
Lars
On Mon, Feb 13, 2017 at 7:41 PM, Roland Scheidegger wrote:
> Am 13.02.2017 um 16:20 schrieb Lars Hamre:
>> Implements the ARB_clear_texture extension for softpipe.
>> Passes all corresponding piglit tests.
>>
&g
Implements the ARB_clear_texture extension for softpipe.
Passes all corresponding piglit tests.
Signed-off-by: Lars Hamre
---
NOTE: someone with access will need to commit this post
review process
src/gallium/drivers/softpipe/sp_screen.c | 3 +-
src/gallium/drivers/softpipe
Yes please, thanks!
On Tue, Sep 13, 2016 at 4:22 PM, Brian Paul wrote:
> On 09/13/2016 01:08 PM, Lars Hamre wrote:
>>
>> Fixes the following piglit test (for softpipe):
>> /spec/glsl-1.10/execution/fs-loop-return
>>
>> Signed-off-by: Lars Hamre
>>
Fixes the following piglit test (for softpipe):
/spec/glsl-1.10/execution/fs-loop-return
Signed-off-by: Lars Hamre
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 4
1 file changed, 4 insertions(+)
NOTE: Someone with access will need to commit this
after the review process
diff --git
The extension is already exposed, this simply marks it as done.
Signed-off-by: Lars Hamre
---
Note: someone with access will need to commit this after the review process
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index ce34869
Gentle ping. I would appreciate feedbaçk on what (if anything) I
should do to get this patch into shape.
Regards,
Lars Hamre
On Mon, Jun 6, 2016 at 9:00 AM, Lars Hamre wrote:
> v2:
> - ES version check (Tapani Pälli)
> v3/v4:
> - compare varying slot locations rather than names
Hmmm looks like you're right. I thought I was also seeing this crash
in dri swrast, but that's not the case after a second look.
Will investigate more, thanks!
Regards,
Lars Hamre
On Tue, Jun 7, 2016 at 10:10 AM, Nicolai Hähnle wrote:
> On 07.06.2016 03:21, Lars Hamre wrote:
>
d-off-by: Lars Hamre
---
NOTE: Someone with access will need to commit this after the
review process
src/compiler/glsl/loop_unroll.cpp | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/compiler/glsl/loop_unroll.cpp
b/src/compiler/glsl/loop_unroll.cpp
index bc377df..b1674e
fixes the following piglit tests in spec/glsl-es-1.00/linker:
glsl-fcoord-invariant
glsl-fface-invariant
glsl-pcoord-invariant
Signed-off-by: Lars Hamre
---
NOTE: Someone with access will need to commit this after the
review process
src/compiler/glsl/link_varying
Gentle ping, I would appreciate a Gallium developer's eyes on this.
Regards,
Lars Hamre
On Thu, May 26, 2016 at 6:30 PM, Lars Hamre wrote:
> Switches to using truncf in micro_trunc.
>
> Fixes the following piglit tests (for softpipe):
>
> /spec/glsl-1.30/execution/built-i
-functions/...
gs-trunc-float
gs-trunc-vec2
gs-trunc-vec3
gs-trunc-vec4
Signed-off-by: Lars Hamre
---
NOTE: someone with access will need to commit this post
review process
src/gallium/auxiliary/tgsi/tgsi_exec.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src
Gentle ping for a gallium developer.
If nobody has any issues I would appreciate a push.
Regards,
Lars Hamre
On Thu, May 19, 2016 at 6:16 PM, Matt Turner wrote:
> On Thu, May 19, 2016 at 2:34 PM, Lars Hamre wrote:
>> Fixes the following piglit tests (for softpipe):
>>
>
Ping.
On Tue, May 17, 2016 at 10:49 AM, Lars Hamre wrote:
> Gentle ping, if nobody has an issues I would appreciate a push.
>
> Regards,
> Lars Hamre
>
> On Mon, May 9, 2016 at 7:00 PM, Lars Hamre wrote:
>> v3/v4:
>> - compare varying slot locations rather
-roundeven-float
gs-roundeven-vec2
gs-roundeven-vec3
gs-roundeven-vec4
Signed-off-by: Lars Hamre
---
Note: someone with access will need to commit this
after the review process.
src/gallium/auxiliary/tgsi/tgsi_exec.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff
Gentle ping, if nobody has an issues I would appreciate a push.
Regards,
Lars Hamre
On Mon, May 9, 2016 at 7:00 PM, Lars Hamre wrote:
> v3/v4:
> - compare varying slot locations rather than names (Ilia Mirkin)
> v2:
> - ES version check (Tapani Pälli)
>
> The conditions
fixes the following piglit tests in spec/glsl-es-1.00/linker:
glsl-fcoord-invariant
glsl-fface-invariant
glsl-pcoord-invariant
Signed-off-by: Lars Hamre
---
CC: Ilia Mirkin
NOTE: Someone with access will need to commit this after the
review process
src/compiler/glsl/link_varying
Looks like it, I didn't realized VARYING_SLOT_POS covered both cases.
On Mon, May 9, 2016 at 5:17 PM, Ilia Mirkin wrote:
> On Mon, May 9, 2016 at 5:10 PM, Lars Hamre wrote:
>> v3:
>> - compare varying slot locations rather than names (Ilia Mirkin)
>> v2:
>>
fixes the following piglit tests in spec/glsl-es-1.00/linker:
glsl-fcoord-invariant
glsl-fface-invariant
glsl-pcoord-invariant
Signed-off-by: Lars Hamre
---
CC: Ilia Mirkin
NOTE: Someone with access will need to commit this after the
review process
src/compiler/glsl/link_varying
lsl-fcoord-invariant
glsl-fface-invariant
glsl-pcoord-invariant
Signed-off-by: Lars Hamre
---
CC: Tapani Pälli
NOTE: Someone with access will need to commit this after the
review process
src/compiler/glsl/link_varyings.cpp | 46 +++--
1 file changed, 44 insert
Reviewed-by: Lars Hamre
On Fri, May 6, 2016 at 11:54 AM, Juan A. Suarez Romero
wrote:
> Copy propagate is not applied in function parameters when they are out
> or inout.
>
> But if the parameter is an array, we can copy propagate the index array.
>
> This also fixes sha
The conditions for which certain built-in special variables
can be declared invariant were not being checked.
OpenGL ES 1.00 specification "Invariance and linkage":
For the built-in special variables, gl_FragCoord can
only be declared invariant if and only if gl_Position is
declared invariant. Si
Sounds good to me, go ahead and push the new version!
On Fri, May 6, 2016 at 10:44 AM, Juan A. Suarez Romero
wrote:
> On Fri, 2016-05-06 at 10:39 -0400, Lars Hamre wrote:
>> Hi Juan,
>>
>> Sorry I missed that.
>>
>> It looks like your patch doesn't fix the o
ropagate it's index
- if the ir->ir_type == ir_type_swizzle, if it's val was a dereferenced_array,
copying propagate it's index
I would rather move ahead with your patch as mine seems quite
"hacky" in comparison :)
Regards,
Lars Hamre
On Fri, May 6, 2016 at 9:53 AM
-index-inout-vec4-array
vs-inout-index-inout-vec4-array-element
Signed-off-by: Lars Hamre
---
NOTES:
- Someone with access will need to commit this post
review process.
- Not sure if this is the "mesa" approach to this
problem, feedback is appreciated.
src/com
Thanks again, I will make/modify those piglit tests.
Regards,
Lars Hamre
On Tue, Apr 26, 2016 at 9:20 PM, Timothy Arceri
wrote:
> On Tue, 2016-04-26 at 19:50 -0400, Lars Hamre wrote:
>> v2: limit lowerings to return statments in main()
>>
>> Return statements in condit
-1.10/execution/vs-vec3-main-return
Signed-off-by: Lars Hamre
---
CC: Timothy Arceri
Hi Timothy,
As it turns out, functions are inlined prior to
lower_packed_varyings() being called. I put in the check
to not visit other functions anyways in case that changes
at some point in the future.
I
Hi Timothy,
Thanks for your comments, you're absolutely right about not wanting to
visit other functions.
I will modify the visitor appropriately and submit a couple of piglit tests.
Regards,
Lars Hamre
On Mon, Apr 25, 2016 at 8:20 PM, Timothy Arceri
wrote:
> Hi Lars,
>
> Than
Gentle ping, I would appreciate feedback.
Regards,
Lars Hamre
On Sun, Apr 17, 2016 at 1:18 PM, Lars Hamre wrote:
> Return statements in conditional blocks were not having their
> output varyings lowered correctly.
>
> This patch fixes the following piglit tests:
> /spec/glsl-1.
/compiler/literals/invalid-float-suffix-f.vert
Either way,
Reviewed-by: Lars Hamre
On Wed, Apr 20, 2016 at 3:29 PM, Matt Turner wrote:
>
> Float suffixes are allowed in all subsequent GLSL specifications, and
> it's obvious what the user meant if they specify one. Accept it with
: Lars Hamre
---
NOTE: Someone with access will need to commit this after the review
process
src/compiler/glsl/lower_packed_varyings.cpp | 58 +++--
1 file changed, 54 insertions(+), 4 deletions(-)
diff --git a/src/compiler/glsl/lower_packed_varyings.cpp
b/src
176
regressions: 2
The two regressions are for the following tests:
glean@glsl1-matrix column check (1)
glean@glsl1-matrix column check (2)
which regress from FAIL to CRASH.
I am okay with these regressions because the tests are currently
failing due to the aforementioned linker error.
Signed-off-by
Agreed, I didn't see that check_explicit_uniform_locations() was
only used in link_shaders(). I will submit a v2 with those changes.
On Thu, Apr 7, 2016 at 11:24 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> On Thu, 2016-04-07 at 11:22 -0400, Lars Hamre wr
linker error.
Signed-off-by: Lars Hamre
---
src/compiler/glsl/linker.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp
index cd35464..a0a9104 100644
--- a/src/compiler/glsl/linker.cpp
+++ b/src/compiler/glsl/link
d if other apps did the same thing. Forbidding
> float suffixes sounds sort of unusual (and unexpected) to me. Albeit
> there weren't really any other data types then, so possibly noone else
> did it...
>
> Roland
>
> >
> > On 03/28/2016 05:42 PM, Lars Hamre wrote:
glean@glsl1-matrix column check (2)
which regress from FAIL to CRASH.
I am okay with these regressions because the tests are currently
failing due to the aforementioned linker error.
Signed-off-by: Lars Hamre
---
src/compiler/glsl/linker.cpp | 6 --
1 file changed, 4 insertions(+), 2 del
-suffix-capital-f.vert
tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-f.vert`
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81585
Signed-off-by: Lars Hamre
Reviewed-by: Timothy Arceri
Reviewed-by: Kenneth Graunke
---
src/compiler/glsl/glsl_lexer.ll | 7 +++
1 file
That sounds good to me, I will submit a v3 with those edits.
On Mon, Mar 28, 2016 at 9:19 PM, Kenneth Graunke
wrote:
> On Monday, March 28, 2016 8:16:17 PM PDT Lars Hamre wrote:
> > NOTE: someone with access will need to commit this patch after the
> > review process
>
-suffix-f.vert`
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81585
Signed-off-by: Lars Hamre
Reviewed-by: Timothy Arceri
---
src/compiler/glsl/glsl_lexer.ll | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler
Invalidates float suffixes for glsl 1.10
Fixes the following piglit tests:
tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-capital-f.vert
tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-f.vert`
Signed-off-by: Lars Hamre
---
src/compiler/glsl/glsl_lexer.ll | 13
ecessary to send a new version only to add the tag. You can instead
> ask directly someone with committing rights to merge it for you.
>
> cheers,
> Eduardo
>
>
> On 03/23/2016 03:14 PM, Lars Hamre wrote:
>
>> v3: Added reviewed-by tag
>> v2: Fixed regression poin
This is similar to the logic from process_initializer() which performs the
same check for constant variable initialization with sequence operators.
Signed-off-by: Lars Hamre
Reviewed-by: Eduardo Lima Mitev
---
src/compiler/glsl/ast_to_hir.cpp | 4 +++-
1 file changed, 3 insertions(+), 1
from process_initializer() which performs the
same check for constant variable initialization with sequence operators.
Signed-off-by: Lars Hamre
---
src/compiler/glsl/ast_to_hir.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src
You are correct, it should be state->is_version(120, 300).
I will submit an updated patch.
On Tue, Mar 22, 2016 at 3:32 PM, Eduardo Lima Mitev
wrote:
> On 03/22/2016 02:48 PM, Lars Hamre wrote:
>
>> Resending this patch because it received no response last week.
>>
should not mandate that for lower GLSL
versions.
Signed-off-by: Lars Hamre
---
src/compiler/glsl/ast_to_hir.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 5262bd8..4037468 100644
--- a/src
Allow the sequence operator to be a constant expression in GLSL ES versions
prior
to GLSL ES 3.0
Fixes the following piglit test:
/all/spec/glsl-es-1.0/compiler/array-sized-by-sequence-in-parenthesis.vert
This mirrors the logic from process_initializer() which performs the
same check for cons
Sounds good, is there a protocol to signify a patch isn't active anymore?
On 03/09/2016 04:37 PM, Lars Hamre wrote:
> I have not been able to force a NULL dereference, this is based off
> analyzing the code.
> Yes that is implicitly true, but if at some point the implicit
> relat
, 2016 at 6:23 PM, Ian Romanick wrote:
> On 03/09/2016 10:21 AM, Lars Hamre wrote:
> > Fixes a possible null dereference.
> >
> > NOTE: this is my first time contributing, please let me know if I
> > should be doing anything differently, thanks!
> &
Fixes a possible null dereference.
NOTE: this is my first time contributing, please let me know if I
should be doing anything differently, thanks!
Signed-off-by: Lars Hamre
---
src/mesa/swrast/s_triangle.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src
54 matches
Mail list logo
