Hi Boris,
Thank you for resurrecting this series and taking it further. Just one
nitpick.
The commit summary should read:
"egl/dri: Use __DRI_BUFFER_DAMAGE extension for KHR_partial_update"
While you are at it, could you please update my authorship and signoff
to:
"Harish Krupo
ts.xml and
remove.xml. Projects.xml contains all the lines and the
remove.xml contains the lines to remove those
repos for that particular project.
Reference: https://github.com/projectceladon/manifest
Thank you
Regards
Harish Krupo
___
mesa-dev mai
Hi Eric,
Eric Engestrom writes:
> On Sunday, 2018-07-08 12:53:00 +0530, Harish Krupo wrote:
>> Clamp the x and y co-ordinates of the rectangles.
>>
>> v2: Clamp width/height after converting to co-ordinates
>> (Ilia Merkin)
>>
>> Signed-off-by
Eric Anholt writes:
> Harish Krupo writes:
>
>> Eric Anholt writes:
>>
>>> Harish Krupo writes:
>>>
>>>> Hi Eric,
>>>>
>>>> Eric Anholt writes:
>>>>
>>>>> Harish Krupo writes:
>>>>
Eric Anholt writes:
> Harish Krupo writes:
>
>> Hi Eric,
>>
>> Eric Anholt writes:
>>
>>> Harish Krupo writes:
>>>
>>>> The intension of the KHR_partial_update was not to send the damage back
>>>> to the platfor
Hi Eric,
Eric Anholt writes:
> Harish Krupo writes:
>
>> The intension of the KHR_partial_update was not to send the damage back
>> to the platform but to send the damage to the driver to ensure that the
>> following rendering could be restricted to those regions.
&
Harish Krupo writes:
> Clamp the x and y co-ordinates of the rectangles.
>
> v2: Clamp width/height after converting to co-ordinates
> (Ilia Merkin)
>
> Signed-off-by: Harish Krupo
> ---
> src/egl/main/eglapi.c | 25 +++--
> 1 file ch
Clamp the x and y co-ordinates of the rectangles.
v2: Clamp width/height after converting to co-ordinates
(Ilia Merkin)
Signed-off-by: Harish Krupo
---
src/egl/main/eglapi.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/src/egl/main
Ilia,
Ilia Mirkin writes:
> On Sat, Jul 7, 2018 at 11:15 PM, Harish Krupo
> wrote:
>> Ilia,
>>
>> Ilia Mirkin writes:
>>
>>> On Sat, Jul 7, 2018 at 5:05 PM, Harish Krupo
>>> wrote:
>>>> Clamp the x and y co-ordina
Ilia,
Ilia Mirkin writes:
> On Sat, Jul 7, 2018 at 5:05 PM, Harish Krupo
> wrote:
>> Clamp the x and y co-ordinates of the rectangles.
>>
>> Signed-off-by: Harish Krupo
>> ---
>> src/egl/main/eglapi.c | 23 +--
>> 1 f
Clamp the x and y co-ordinates of the rectangles.
Signed-off-by: Harish Krupo
---
src/egl/main/eglapi.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index c110349119..c7d07c4fde 100644
--- a/src/egl
Use the DRI2 interface callback to pass the damage rects to
the driver.
v2: check for dri2_dpy->damage_extension after checking for
optional_core_extensions in dr2_setup_extensions.
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/egl_dri2.c | 46 ++---
Use the DRI2 interface callback to pass the damage rects to
the driver.
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/egl_dri2.c | 46 ++---
src/egl/drivers/dri2/egl_dri2.h | 1 +
2 files changed, 43 insertions(+), 4 deletions(-)
diff --git a/src/egl/drivers
.
Then upcomming patches add a new dri2 interface for the drivers to
implement
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/egl_dri2.c | 2 +-
src/egl/drivers/dri2/egl_dri2.h | 4 --
src/egl/drivers/dri2/egl_dri2_fallbacks.h | 9 -
src/egl/drivers/dri2
Implementors of this interface provide ability to render only
to damaged regions on the framebuffer.
Signed-off-by: Harish Krupo
---
include/GL/internal/dri_interface.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/include/GL/internal/dri_interface.h
b/include
removes that implementation
and adds an interface for drivers to implement so that the damage can
be reported to the drivers and the rendering can be restricted to those
damage rectangles.
Harish Krupo (3):
egl/android: Delete set_damage_region from egl dri vtbl
dri_interface: add an interface
this is the intention of this extension (which
> is also proposed by ARM guys)
> to benifit tile GPU rendering.
>
> Useful blog:
> https://community.arm.com/graphics/b/blog/posts/mali-performance-3-is-egl_5f00_buffer_5f00_preserved-a-good-thing
>
Thanks, will read it.
Regards
Harish Krupo
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
vided
> by EGL_KHR_partial_update to skip rendering of un-damaged region when
> eglSwapBuffersXXX. And tell damage region (surface damage) to compositor
> should
> be left to eglSwapBuffersWithDamageKHR provided by
> EGL_KHR_swap_buffers_with_damage.
>
How do you plan to i
Signed-off-by: Harish Krupo
---
src/intel/Android.vulkan.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk
index 07e69d890a..419d560b0c 100644
--- a/src/intel/Android.vulkan.mk
+++ b/src/intel/Android.vulkan.mk
Hi Tapani,
Tapani Pälli writes:
> On 02/20/2018 10:10 AM, Harish Krupo wrote:
>> Signed-off-by: Harish Krupo
>> ---
>> src/intel/Android.vulkan.mk | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/intel/Android.vulkan.mk
Signed-off-by: Harish Krupo
---
src/intel/Android.vulkan.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk
index 6fe736d397..444278613d 100644
--- a/src/intel/Android.vulkan.mk
+++ b/src/intel/Android.vulkan.mk
current check and also provides the backend
with an option to expose the KHR_image extension.
Test: run cts -m CtsOpenGLTestCases -t \
android.opengl.cts.OpenGlEsVersionTest#testRequiredEglExtensions
Signed-off-by: Harish Krupo
Reviewed-by: Tapani Pälli
Reviewed-by: Eric Engestrom
Reviewed-by
Hi Emil,
Emil Velikov writes:
> Hi Harish,
>
> On 7 December 2017 at 13:34, Harish Krupo wrote:
>> From android cts 8.0_r4, a new test case checks if all the required egl
>> extensions are exposed. In the current implementation we expose KHR_image
>> if KHR_image_ba
Harish Krupo writes:
> This passes 33/37 deqp tests related to partial_update, 4 are not
> supported. Tests not supported:
> dEQP-EGL.functional.negative_partial_update.not_postable_surface
> dEQP-EGL.functional.negative_partial_update.not_current_su
current check and also provides the backend
with an option to expose the KHR_image extension.
Test: run cts -m CtsOpenGLTestCases -t \
android.opengl.cts.OpenGlEsVersionTest#testRequiredEglExtensions
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/platform_android.c | 1 +
src/egl/main
the rework done in v3. Fix code indentation (Emil Velikov)
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/platform_wayland.c | 36 -
1 file changed, 31 insertions(+), 5 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/src/egl/drivers/dri2
Hi Emil,
Emil Velikov writes:
> On 27 October 2017 at 05:54, Harish Krupo wrote:
>> Hi Eric,
>>
>> Eric Engestrom writes:
>>
>>> On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote:
>>>> This passes 33/37 deqp tests related to partial_updat
for EXT_sRGB for Opengl ES/mesa: add support for GL_EXT_sRGB/
>
This was my first patch in mesa, so the rookie mistakes. :)
> On 7 April 2017 at 05:20, Harish Krupo wrote:
>> This addes support for the GL_EXT_sRGB extension for OpengGL ES 1.0 and
>> above.
>> With
Harish Krupo writes:
> Hi Eric,
>
> Eric Engestrom writes:
>
>> On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote:
>>> This passes 33/37 deqp tests related to partial_update, 4 are not
>>> supp
Hi Eric,
Eric Engestrom writes:
> On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote:
>> This passes 33/37 deqp tests related to partial_update, 4 are not
>> supported. Tests not supported:
>> dEQP-EGL.functional.negative_partial_update.not_pos
Hi Emil,
Emil Velikov writes:
> On 23 October 2017 at 11:50, Harish Krupo wrote:
>> This passes 33/37 deqp tests related to partial_update, 4 are not
>> supported. Tests not supported:
>> dEQP-EGL.functional.negative_partial_update.not_pos
Engestrom)
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/platform_wayland.c | 54 ++---
1 file changed, 36 insertions(+), 18 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/src/egl/drivers/dri2/platform_wayland.c
index b38eb1c335..8846099d57
Hi Emil,
Emil Velikov writes:
> On 20 October 2017 at 12:35, Harish Krupo wrote:
>
>> + else if (!n_rects || !try_damage_buffer(dri2_surf, rects, n_rects))
>>wl_surface_damage(dri2_surf->wl_surface_wrapper,
>> 0, 0, INT32_MAX, IN
-EGL.functional.negative_partial_update.not_current_surface2
Reason: No matching egl config found.
v2: Remove unnecessary return statement. Keep function names
consistent. (Emil Velikov)
Add not supported list to commit message. (Eric Engestrom)
Signed-off-by: Harish Krupo
---
src/egl/drivers
Hi Eric,
Eric Engestrom writes:
> On Wednesday, 2017-10-18 06:06:45 +0000, Harish Krupo wrote:
>> Hi Eric,
>>
>> Eric Engestrom writes:
>> > I might need to double check the spec, but I thought "no damage hint"
>> > meant "no way to red
Hi Eric,
Eric Engestrom writes:
> On 17 October 2017 17:36:06 BST, Harish Krupo
> wrote:
>> Hi Emil,
>>
>> Thank you for the comments, will fix the code accordingly and send a
>> v2 patch.
>> I have answered the question inline.
>>
&
Hi Emil,
Thank you for the comments, will fix the code accordingly and send a
v2 patch.
I have answered the question inline.
Emil Velikov writes:
> Hi Harish,
>
> Overall looks great, a few comments/questions inline.
>
> On 13 October 2017 at 19:49, Harish Krupo wrote:
>&
Eric Engestrom writes:
> On Monday, 2017-10-16 13:54:25 +, Emil Velikov wrote:
>> Hi Harish,
>>
>> Overall looks great, a few comments/questions inline.
>>
>
> I agree with everything Emil said :)
>
>> On 13 October 2017 at 19:49, Harish Krupo
This passes 33/37 deqp tests related to partial_update, 4 are not
supported.
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/platform_wayland.c | 68 -
1 file changed, 59 insertions(+), 9 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b
Hi Ilia,
On 08/21/2017 10:42 AM, Ilia Mirkin wrote:
On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo
wrote:
Hi Ilia,
On 08/18/2017 07:20 PM, Ilia Mirkin wrote:
Why the static data changes? Also, I haven't double checked the code, but
I'm almost certain this is incomplete. You h
the patch. Could you please explain why it is not needed?
Thank you
Regards
Harish Krupo
On Aug 18, 2017 6:42 AM, "Harish Krupo" <mailto:harish.krupo@intel.com>> wrote:
It passes
dEQP-GLES2.capability.extensions.other.GL_EXT_occlusion_query_boolean
test. I
It passes dEQP-GLES2.capability.extensions.other.GL_EXT_occlusion_query_boolean
test. I think the test is just a check for the existence of the extension. On
gles3 and above, occlusion queries are part of the spec.
Signed-off-by: Harish Krupo
---
There is a piglit test for this extension in the
Hi Eric,
On 06/09/2017 08:59 PM, Eric Engestrom wrote:
On Friday, 2017-06-09 20:13:34 +0530, Harish Krupo wrote:
This patch adds support for the EGL_KHR_partial_update extension for
android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update.
1 test not supported.
v2: add
alloc (Eric)
Check for BAD_ALLOC error (Emil)
Check for error in native_window_set_damage_region. (Emil, Tapani,
Eric).
Signed-off-by: Harish Krupo
Reviewed-by: Emil Velikov
Reviewed-by: Eric Engestrom
Reviewed-by: Tapani Pälli
---
src/egl/drivers/dri2/egl_dri2.c |
On 06/09/2017 12:58 PM, Tapani Pälli wrote:
On 06/08/2017 04:53 PM, Emil Velikov wrote:
Hi all,
On 8 June 2017 at 13:06, Harish Krupo wrote:
Hi Tapani,
On 06/08/2017 04:32 PM, Tapani Pälli wrote:
Harish, please find small addition below.
I noticed we still have one crasher in tests
On 06/08/2017 07:23 PM, Emil Velikov wrote:
Hi all,
On 8 June 2017 at 13:06, Harish Krupo wrote:
Hi Tapani,
On 06/08/2017 04:32 PM, Tapani Pälli wrote:
Harish, please find small addition below.
I noticed we still have one crasher in tests when this extension is
enabled, it's relat
On 06/08/2017 07:23 PM, Eric Engestrom wrote:
On Thursday, 2017-06-08 17:36:47 +0530, Harish Krupo wrote:
Hi Tapani,
On 06/08/2017 04:32 PM, Tapani Pälli wrote:
Harish, please find small addition below.
I noticed we still have one crasher in tests when this extension is
enabled, it's re
a-dev/2017-June/158391.html
On 06/07/2017 07:11 PM, Harish Krupo wrote:
This patch adds support for the EGL_KHR_partial_update extension for
android platform. It passes 36/37 tests in dEQP for
EGL_KHR_partial_update.
1 test not supported.
v2: add fallback for eglSetDamageRegionKHR (Tapani
VEL >= 23 (Android 6.0 or
greater). Add fallback function for platforms other than Android.
Fix possible math overflow. (Emil Velikov)
Return immediately when n_rects is 0. Place function's entrypoint
in alphabetical order. (Eric Engestrom)
Signed-off-by: Harish Krupo
-
On 06/01/2017 08:12 PM, Emil Velikov wrote:
Hi Harish
On 1 June 2017 at 11:27, Harish Krupo wrote:
This patch adds support for the EGL_KHR_partial_update extension for
android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update.
1 test not supported.
v2: add fallback for
Android version 6.0. Reintroduce the ANDROID_VERSION guard and
advertise extension only if version is >= 6.0. (Emil Velikov)
Signed-off-by: Harish Krupo
---
Android.common.mk | 3 +-
Android.mk | 2 +
src/egl/drivers/dri2/egl_dri
This patch adds support for the EGL_KHR_partial_update extension for
android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update.
1 test not supported.
v2: add fallback for eglSetDamageRegionKHR (Tapani)
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/egl_dri2.c
This patch adds support for the EGL_KHR_partial_update extension for
android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update.
1 test not supported.
Signed-off-by: Harish Krupo
---
src/egl/drivers/dri2/egl_dri2.c | 12 +
src/egl/drivers/dri2/egl_dri2.h | 4
This addes support for the GL_EXT_sRGB extension for OpengGL ES 1.0 and above.
With this patch this test passes in dEQP:
dEQP-GLES2.capability.extensions.uncompressed_texture_formats.GL_EXT_sRGB
Signed-off-by: Harish Krupo
---
src/mapi/glapi/gen/es_EXT.xml| 8
src/mesa
We have functions which depend on sse4.1 support but we didnt pass
the right compile flag for it. This patch fixes it.
Signed-off-by: Kalyan Kondapally
Signed-off-by: Harish Krupo
---
src/mesa/Android.libmesa_sse41.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa
55 matches
Mail list logo
