Re: [Mesa-dev] [PATCH] egl/main: remove undefined X11_LIBS automake variable

2013-10-09 Thread Gaetan Nadon
On 13-10-07 05:28 PM, Kenneth Graunke wrote: > On 10/01/2013 02:07 PM, Kenneth Graunke wrote: >> On 10/01/2013 06:31 AM, Gaetan Nadon wrote: >>> On 13-09-28 04:23 PM, Emil Velikov wrote: >>>> On 28/09/13 20:00, Gaetan Nadon wrote: >>>>> The EGL libra

Re: [Mesa-dev] [PATCH] egl/main: remove undefined X11_LIBS automake variable

2013-10-01 Thread Gaetan Nadon
On 13-09-28 04:23 PM, Emil Velikov wrote: > On 28/09/13 20:00, Gaetan Nadon wrote: >> The EGL library has some references to x11 but it gets the link flags >> from the XCB_DRI2_LIBS iff HAVE_EGL_PLATFORM_X11 is true. > s/iff/if/ >> The X11_LIBS variable was probably coming

[Mesa-dev] [PATCH] egl/main: remove undefined X11_LIBS automake variable

2013-09-28 Thread Gaetan Nadon
then the link flags for libX11 should be passed. However, it won't come from X11_LIBS which is undefined. Reported-by: Emil Velicov Signed-off-by: Gaetan Nadon --- src/egl/main/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/Makefile.am b/sr

Re: [Mesa-dev] [PATCH RESEND 0/3] gallium: replacing X11_CFLAGS with X11_INCLUDES

2013-09-27 Thread Gaetan Nadon
On 13-09-27 07:59 PM, Brian Paul wrote: > On 09/27/2013 03:42 PM, Gaetan Nadon wrote: >> The X11_CFLAGS variable is undefined (not defined in config.status). >> It appears the intent was to use X11_INCLUDES defined in configure.ac. >> >> Gaetan Nadon (3): >>

[Mesa-dev] [PATCH RESEND 3/3] gallium/state_trackers/glx: X11/Xlib.h: No such file or directory

2013-09-27 Thread Gaetan Nadon
installed on my workstation. It is supplied in the libx11-dev package. This allows an X developer control over which version of this file is used for X development. Use to test: --enable-gallium-egl --enable-xlib-glx --disable-dri Signed-off-by: Gaetan Nadon --- src/gallium/state_trackers/glx

[Mesa-dev] [PATCH RESEND 2/3] gallium/state_trackers/egl: use X11_INCLUDES rather than X11_CFLAGS

2013-09-27 Thread Gaetan Nadon
X11. It will not always be the case. The option --enable-gallium-egl is required durimg configuration. Signed-off-by: Gaetan Nadon --- src/gallium/state_trackers/egl/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/egl/Makefile.am b/src

[Mesa-dev] [PATCH RESEND 1/3] gallium/targets/libgl-xlib: X11/Xlib.h: No such file or directory

2013-09-27 Thread Gaetan Nadon
installed on my workstation. It is supplied in the libx11-dev package. This allows an X developer control over which version of this file is used for X development. Signed-off-by: Gaetan Nadon --- src/gallium/targets/libgl-xlib/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion

[Mesa-dev] [PATCH RESEND 0/3] gallium: replacing X11_CFLAGS with X11_INCLUDES

2013-09-27 Thread Gaetan Nadon
The X11_CFLAGS variable is undefined (not defined in config.status). It appears the intent was to use X11_INCLUDES defined in configure.ac. Gaetan Nadon (3): gallium/targets/libgl-xlib: X11/Xlib.h: No such file or directory gallium/state_trackers/egl: use X11_INCLUDES rather than X11_CFLAGS

[Mesa-dev] [PATCH 1/3] gallium/targets/libgl-xlib: X11/Xlib.h: No such file or directory

2013-09-19 Thread Gaetan Nadon
installed on my workstation. It is supplied in the libx11-dev package. This allows an X developer control over which version of this file is used for X development. Signed-off-by: Gaetan Nadon --- src/gallium/targets/libgl-xlib/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion

[Mesa-dev] [PATCH 2/3] gallium/state_trackers/egl: use X11_INCLUDES rather than X11_CFLAGS

2013-09-19 Thread Gaetan Nadon
X11. It will not always be the case. The option --enable-gallium-egl is required durimg configuration. Signed-off-by: Gaetan Nadon --- src/gallium/state_trackers/egl/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/egl/Makefile.am b/src

[Mesa-dev] [PATCH 3/3] gallium/state_trackers/glx: X11/Xlib.h: No such file or directory

2013-09-19 Thread Gaetan Nadon
installed on my workstation. It is supplied in the libx11-dev package. This allows an X developer control over which version of this file is used for X development. Use to test: --enable-gallium-egl --enable-xlib-glx --disable-dri Signed-off-by: Gaetan Nadon --- src/gallium/state_trackers/glx

[Mesa-dev] [PATCH 0/3] gallium: replacing X11_CFLAGS with X11_INCLUDES

2013-09-19 Thread Gaetan Nadon
The X11_CFLAGS variable is undefined (not defined in config.status). It appears the intent was to use X11_INCLUDES defined in configure.ac. Gaetan Nadon (3): gallium/targets/libgl-xlib: X11/Xlib.h: No such file or directory gallium/state_trackers/egl: use X11_INCLUDES rather than X11_CFLAGS

Re: [Mesa-dev] [PATCH] glx: fix compile error in egl_glx.c.

2013-09-19 Thread Gaetan Nadon
On 13-09-18 09:41 PM, Kenneth Graunke wrote: > On 09/17/2013 12:46 PM, Gaetan Nadon wrote: >> egl_glx.c:40:22: fatal error: X11/Xlib.h: No such file or directory >> >> The compiler cannot find the Xlib.h in the installed system headers. >> All supplied include directiv

[Mesa-dev] [PATCH] glx: fix compile error in egl_glx.c.

2013-09-17 Thread Gaetan Nadon
to use X11_INCLUDES defined in configure.ac. The Xlib.h file is not installed on my workstation. It is supplied in the libx11-dev package. This allows an X developer control over which version of this file is used for X development. Signed-off-by: Gaetan Nadon --- src/egl/drivers/glx

[Mesa-dev] [PATCH] winsys/sw/xlib: fix compile error in xlib_sw_winsys.c.

2013-09-17 Thread Gaetan Nadon
intent was to use X11_INCLUDES defined in configure.ac. The Xlib.h file is not installed on my workstation. It is supplied in the libx11-dev package. This allows an X developer control over which version of this file is used for X development. Signed-off-by: Gaetan Nadon --- src/gallium/winsys/sw

Re: [Mesa-dev] [PATCH] autoconf: bail out if flex isn't found

2012-03-15 Thread Gaetan Nadon
On 12-03-14 10:20 AM, Brian Paul wrote: > On Tue, Mar 13, 2012 at 9:14 PM, Matt Turner wrote: >> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=47248 >> Signed-off-by: Matt Turner >> --- >> configure.ac |3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/confi

Re: [Mesa-dev] [PATCH 5/5] src/glsl/glcpp: wire up glcpp-test to make check

2012-01-31 Thread Gaetan Nadon
On 12-01-30 12:33 PM, Matt Turner wrote: > On Mon, Jan 30, 2012 at 12:03 PM, Gaetan Nadon wrote: >> Sorry, I meant $(top_builddir)/src/glsl/glcpp or whatever the correct >> location is. > I don't understand -- I'm not seeing top_builddir or builddir defined > in th

Re: [Mesa-dev] [PATCH 5/5] src/glsl/glcpp: wire up glcpp-test to make check

2012-01-30 Thread Gaetan Nadon
On 12-01-30 11:53 AM, Gaetan Nadon wrote: > On 12-01-30 01:09 AM, Matt Turner wrote: >> --- >> src/glsl/glcpp/Makefile.am |2 ++ >> src/glsl/glcpp/tests/glcpp-test |6 +- >> 2 files changed, 7 insertions(+), 1 deletions(-) >> >> diff --git

Re: [Mesa-dev] [PATCH 5/5] src/glsl/glcpp: wire up glcpp-test to make check

2012-01-30 Thread Gaetan Nadon
On 12-01-30 01:09 AM, Matt Turner wrote: > --- > src/glsl/glcpp/Makefile.am |2 ++ > src/glsl/glcpp/tests/glcpp-test |6 +- > 2 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/src/glsl/glcpp/Makefile.am b/src/glsl/glcpp/Makefile.am > index 198908c..68f55dc 100644 >

Re: [Mesa-dev] [PATCH 1/7] i965: use AM_CPPFLAGS instead of AM_CFLAGS/CXXFLAGS

2012-01-18 Thread Gaetan Nadon
On 12-01-18 01:11 PM, Eric Anholt wrote: > On Tue, 17 Jan 2012 15:58:11 -0500, Matt Turner wrote: > > As far as I can tell, the point of AM_CPPFLAGS existing is if you want > to make a target that separately calls the preprocessor, so you a list > of includes and a list of non-preprocessor compile

Re: [Mesa-dev] [PATCH 5/7] automake: src/mesa/drivers/dri/nouveau

2012-01-18 Thread Gaetan Nadon
On 12-01-17 08:30 PM, Matt Turner wrote: > On Tue, Jan 17, 2012 at 7:32 PM, Gaetan Nadon wrote: >> On 12-01-17 03:58 PM, Matt Turner wrote: >> >> +AM_CPPFLAGS = \ >> +-I$(top_srcdir)/include \ >> +-I$(top_srcdir)/src/ \ >> +-I$(top_srcdir)/src/

Re: [Mesa-dev] [PATCH 1/7] i965: use AM_CPPFLAGS instead of AM_CFLAGS/CXXFLAGS

2012-01-18 Thread Gaetan Nadon
On 12-01-17 08:28 PM, Matt Turner wrote: > On Tue, Jan 17, 2012 at 7:21 PM, Gaetan Nadon wrote: >> On 12-01-17 03:58 PM, Matt Turner wrote: >>> --- >>> src/mesa/drivers/dri/i965/Makefile.am |4 +--- >>> 1 files changed, 1 insertions(+), 3 deletions(-) &

Re: [Mesa-dev] [PATCH 5/7] automake: src/mesa/drivers/dri/nouveau

2012-01-17 Thread Gaetan Nadon
On 12-01-17 03:58 PM, Matt Turner wrote: > +AM_CPPFLAGS = \ > + -I$(top_srcdir)/include \ > + -I$(top_srcdir)/src/ \ > + -I$(top_srcdir)/src/mapi \ > + -I$(top_srcdir)/src/mesa/ \ > + -I../common \ Why does this one cannot be written properly based on top_srcdir? > + $(DEFIN

Re: [Mesa-dev] [PATCH 3/7] automake: src/mesa/drivers/dri/radeon

2012-01-17 Thread Gaetan Nadon
On 12-01-17 03:58 PM, Matt Turner wrote: > +AM_CPPFLAGS = \ > + -DRADEON_R100 \ > + -I$(top_srcdir)/include \ > + -I$(top_srcdir)/src/ \ > + -I$(top_srcdir)/src/mapi \ > + -I$(top_srcdir)/src/mesa/ \ > + -I../common \ > + -Iserver \ > + $(DEFINES) \ > + $(ASM_FLA

Re: [Mesa-dev] [PATCH 1/7] i965: use AM_CPPFLAGS instead of AM_CFLAGS/CXXFLAGS

2012-01-17 Thread Gaetan Nadon
On 12-01-17 03:58 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/Makefile.am |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/Makefile.am > b/src/mesa/drivers/dri/i965/Makefile.am > index 5512381..93937b1 100644 > --- a/src/mesa/

Re: [Mesa-dev] [PATCH 2/4] Use AC_PROG_YACC/LEX

2012-01-15 Thread Gaetan Nadon
On 12-01-14 11:16 AM, Matt Turner wrote: > Needed for automake. Using AC_PROG_PATH(bison/flex) causes automake to > fail to build .y and .l files. > > It is up to the builder to use bison/flex instead of yacc/lex. > > Signed-off-by: Matt Turner > --- > configs/autoconf.in |4 ++-- > configure

Re: [Mesa-dev] [PATCH] configure.ac: add and use AC_PROG_BISON/FLEX macros

2012-01-11 Thread Gaetan Nadon
On 12-01-11 01:29 AM, Matt Turner wrote: > On Wed, Jan 11, 2012 at 1:16 AM, Matt Turner wrote: >> Defining these macros lets us use AC_PROG_YACC/LEX which makes automake >> easier while still specifically requiring bison and flex. >> >> Based on bison.m4 and flex.m4 found in LLVM's tree. >> >> Sig

Re: [Mesa-dev] [PATCH] configure.ac: use AC_PROG_SED

2012-01-11 Thread Gaetan Nadon
On 12-01-11 01:16 AM, Matt Turner wrote: > AC_PROG_PATH was used in the original configure.ac (dca1b796b) and I > can't see any reason AC_PROG_SED wasn't used. > > Signed-off-by: Matt Turner > --- > configure.ac |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/config

Re: [Mesa-dev] [PATCH] configure.ac: add and use AC_PROG_BISON/FLEX macros

2012-01-11 Thread Gaetan Nadon
On 12-01-11 01:16 AM, Matt Turner wrote: > Defining these macros lets us use AC_PROG_YACC/LEX which makes automake > easier while still specifically requiring bison and flex. > > Based on bison.m4 and flex.m4 found in LLVM's tree. > > Signed-off-by: Matt Turner > --- > configure.ac |9 ---

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Gaetan Nadon
On 12-01-03 03:27 PM, Ian Romanick wrote: > On 01/03/2012 11:13 AM, Mike Lothian wrote: >> Hi >> >> Ever since these tests went in I get failures during configure: >> >> >> configure: creating ./config.status >> config.status: creating configs/autoconf >> config.status: error: cannot find input fil

Re: [Mesa-dev] [PATCH 5/5] automake: add src/glsl and src/glsl/glcpp

2011-12-27 Thread Gaetan Nadon
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11-12-23 08:51 PM, Matt Turner wrote: > On Fri, Dec 23, 2011 at 8:37 PM, Kenneth Graunke wrote: >> On 12/23/2011 04:21 PM, Matt Turner wrote: >>> # Flex and Bison for GLSL compiler >>> -FLEX = @FLEX@ >>> -BISON = @BISON@ >>> +FLEX = @LEX@ >>> +BIS

Re: [Mesa-dev] [PATCH 2/5] configure.ac: bump AC_PREREQ to 2.60

2011-12-27 Thread Gaetan Nadon
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11-12-23 08:09 PM, Matt Turner wrote: > On Fri, Dec 23, 2011 at 8:06 PM, Kenneth Graunke wrote: >> On 12/23/2011 04:21 PM, Matt Turner wrote: >>> --- >>> configure.ac | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a

Re: [Mesa-dev] [RFC PATCH] automake: add support to src/glsl/

2011-09-28 Thread Gaetan Nadon
On Sun, 2011-09-25 at 16:55 -0400, Matt Turner wrote: > On Sun, Sep 25, 2011 at 4:22 PM, Gaetan Nadon wrote: > > If you are moving towards a non-hacked automake world, the INSTALL variable > > should not be used for mesa makefiles. It all depends on the end goals and > >

Re: [Mesa-dev] [RFC PATCH] automake: add support to src/glsl/

2011-09-28 Thread Gaetan Nadon
On Sun, 2011-09-25 at 15:41 -0400, Matt Turner wrote: > On Sun, Sep 25, 2011 at 3:06 PM, Gaetan Nadon wrote: > > I had a quick look, configure.ac is huge and has a big impact on Makefiles. > > I think it should be reviewed and cleaned-up to understand how it affects > > make

Re: [Mesa-dev] [RFC PATCH] automake: add support to src/glsl/

2011-09-28 Thread Gaetan Nadon
On Sat, 2011-09-24 at 21:06 -0400, Matt Turner wrote: > The patch has a few problems currently, and a few things that can > possibly be > done better: > - Mainly, that building libmesa.a currently fails. > - Not sure how to handle shared/static dricore options. > - libtool

Re: [Mesa-dev] [RFC PATCH] automake: add support to src/glsl/

2011-09-28 Thread Gaetan Nadon
On Sat, 2011-09-24 at 21:06 -0400, Matt Turner wrote: > The last discussion about using automake ("[RFC] Convert mesa to > automake/libtool") > ended without anything happening, probably because the branch wasn't > ready. > > This patch is an attempt to get the ball rolling again. Without > rippi