[Mesa-dev] R: [PATCH 1/2] meson: require libdrm for gallium svga or virgl

Dear Alyssa, Sorry the bothering.. Your patch also added the check for freedreno, but it is not mentioned in the commit message. Is it actually what you wanted? Cheers, Francesco ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fr

Re: [Mesa-dev] [PATCH v2 00/29] do not allow invalid texture-format enums

Il giorno ven 30 nov 2018, 12:26 Erik Faye-Lund < erik.faye-l...@collabora.com> ha scritto: > On Fri, 2018-11-23 at 11:53 +0100, Erik Faye-Lund wrote: > > OK, so here's a v2 of this series. These are the changes since v1: > > - Removed double-semicolons in patch #25 > > - Removed default-case and

Re: [Mesa-dev] [PATCH 3/9] freedreno/ir3: resync instr-a3xx.h/disasm-a3xx.c

2017-04-19 0:15 GMT+02:00 Rob Clark : > Sync to the same files from freedreno.git to correct decoding of ldgb/ > stgb instructions. > > Signed-off-by: Rob Clark > --- > src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c | 2 +- > src/gallium/drivers/freedreno/disasm.h | 3 + > src/gall

Re: [Mesa-dev] [PATCH 3/3] mesa: implement GL_OES_texture_view (V2)

:44, "Ilia Mirkin" ha scritto: > On Mon, Aug 29, 2016 at 1:25 AM, Francesco Ansanelli > wrote: > > XXX still need to figure how to treat the removed VIEW_CLASS* > > and formats. > > Can you elaborate what this comment means? > > You definitely need to ad

Re: [Mesa-dev] [PATCH 2/3] mesa: Add and use _mesa_has_texture_view helper(v2)

Hi, to switch to the macro would mean to check also the version. I'd prefer to keep the original behaviour but, if it's necessary I'll change it.. Francesco Il 31 ago 2016 01:39, "Ilia Mirkin" ha scritto: On Mon, Aug 29, 2016 at 1:25 AM, Francesco Ansanelli wrote: &g

Re: [Mesa-dev] [PATCH 2/3] mesa: Handle OES_texture_view tokens

:24 AM, Francesco Ansanelli > wrote: > >> Signed-off-by: Francesco Ansanelli >> --- >> src/mesa/main/texparam.c | 48 ++ >> >> 1 file changed, 48 insertions(+) >> >> diff --git a/src/mesa/main/texparam.c b/s

Re: [Mesa-dev] GL_OES_texture_view RFC

portant to have the oes suffix in messages. > > On Aug 28, 2016 10:31 AM, "Francesco Ansanelli" > wrote: > >> Hi list, >> >> I tried to figure how this extension could be hooked-up. >> >> I fear last patch is a bit an hack because we may want t

[Mesa-dev] [PATCH 1/3] glapi: add GL_OES_texture_view

Signed-off-by: Francesco Ansanelli --- src/mapi/glapi/gen/es_EXT.xml | 15 +++ src/mesa/main/extensions_table.h|1 + src/mesa/main/mtypes.h |1 + src/mesa/main/tests/dispatch_sanity.cpp |3 +++ 4 files changed, 20 insertions(+) diff

[Mesa-dev] [PATCH 3/3] mesa: implement GL_OES_texture_view (V2)

XXX still need to figure how to treat the removed VIEW_CLASS* and formats. V2: drop the oes suffix in messages (Ilia Mirkin) Signed-off-by: Francesco Ansanelli --- src/mesa/main/textureview.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mesa/main

[Mesa-dev] [PATCH 2/3] mesa: Add and use _mesa_has_texture_view helper(v2)

V2:use the same tokens of the desktop version (Ilia Mirkin, Chris Forbes) Signed-off-by: Francesco Ansanelli --- src/mesa/main/context.h |7 +++ src/mesa/main/texparam.c | 22 ++ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/src/mesa/main

[Mesa-dev] GL_OES_texture_view RFC

Hi list, I tried to figure how this extension could be hooked-up. I fear last patch is a bit an hack because we may want to add also the EXT one... But this could be figured later. In any case, please review. Cheers, Francesco ___ mesa-dev mailing lis

[Mesa-dev] [PATCH 3/3] mesa: implement GL_OES_texture_view

XXX still need to figure how to treat the removed VIEW_CLASS* and formats. Signed-off-by: Francesco Ansanelli --- src/mesa/main/textureview.c | 69 +-- 1 file changed, 41 insertions(+), 28 deletions(-) diff --git a/src/mesa/main/textureview.c b/src

[Mesa-dev] [PATCH 1/3] glapi: add GL_OES_texture_view

Signed-off-by: Francesco Ansanelli --- src/mapi/glapi/gen/es_EXT.xml | 15 +++ src/mesa/main/extensions_table.h|1 + src/mesa/main/mtypes.h |1 + src/mesa/main/tests/dispatch_sanity.cpp |3 +++ 4 files changed, 20 insertions(+) diff

[Mesa-dev] [PATCH 2/3] mesa: Handle OES_texture_view tokens

Signed-off-by: Francesco Ansanelli --- src/mesa/main/texparam.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index bdd3fcb..4dd97b1 100644 --- a/src/mesa/main/texparam.c +++ b/src/mesa

[Mesa-dev] [PATCH] mesa/main: missing return in a non-void function

Signed-off-by: Francesco Ansanelli --- src/mesa/main/program_resource.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c index 6ddbdad..51dbe95 100644 --- a/src/mesa/main/program_resource.c +++ b/src/mesa/main

[Mesa-dev] [PATCH] mesa/st: use llabs instead of abs for long args (v2)

v2: long has 32bit on Windows (Marek) Signed-off-by: Francesco Ansanelli --- src/mesa/state_tracker/st_atom_array.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index dcead27..1c2cfa7

[Mesa-dev] [PATCH] mesa/st: use labs instead of abs for long args Signed-off-by: Francesco Ansanelli

--- src/mesa/state_tracker/st_atom_array.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index dcead27..70247b9 100644 --- a/src/mesa/state_tracker/st_atom_array.c +++ b/src/mesa/state_tracker

[Mesa-dev] [PATCH] freedreno/a2xx: add missing casts to silence notices

Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c b/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c index 2b62b3a..163c282 100644 --- a/src

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

Hello, I did more tests... and I didn't experience any error. I attach last version of the script. Cheers, Francesco 2016-08-04 19:50 GMT+02:00 Francesco Ansanelli : > Hi Eric, > > after your question: > > [snip] > I expect, with enums having varying size, that this cast

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

c and clang (and others?) to find the case you're taking about. I'm also thinking about a negative test... What do you think? Cheers, Francesco 2016-08-01 14:10 GMT+02:00 Eric Engestrom : > On Sat, Jul 30, 2016 at 09:49:57AM +0200, Francesco Ansanelli wrote: > > Signed-off

[Mesa-dev] [PATCH 3/3] freedreno/a4xx: fix comparison out of range warnings

Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a4xx/fd4_screen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_screen.c b/src/gallium/drivers/freedreno/a4xx/fd4_screen.c index 57fecf1..aa60658

[Mesa-dev] [PATCH 2/3] freedreno/a3xx: fix comparison out of range warnings

Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a3xx/fd3_screen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/freedreno/a3xx/fd3_screen.c b/src/gallium/drivers/freedreno/a3xx/fd3_screen.c index 013b0ca..52a284e

[Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c b/src/gallium/drivers/freedreno/a2xx/fd2_screen.c index fe4849b..007b9e6 100644

[Mesa-dev] [PATCH] freedreno/ir3: init ir3_shader_key with memset()

To silence missing initializers warning Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/ir3/ir3_shader.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_shader.c b/src/gallium/drivers/freedreno/ir3/ir3_shader.c

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

happy. Cheers, Francesco 2016-07-29 2:20 GMT+02:00 Rob Herring : > On Thu, Jul 28, 2016 at 6:55 PM, Rob Clark wrote: > > On Thu, Jul 28, 2016 at 6:36 PM, Rob Herring wrote: > >> On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli > >> wrote: > >>> --- &g

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

I did a test with: static struct ir3_shader_key key; memset(&key, 0, sizeof(key)); both gcc and clang seems happy with it. Let me know if you want me to send a patch. 2016-07-29 1:53 GMT+02:00 Rob Clark : > On Thu, Jul 28, 2016 at 6:44 PM, Rob Herring wrote: > > On Thu, Jul 28, 2016 at 1:07 P

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

gt; >> On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: > >>> Hello, > >>> > >>> unluckily this didn't fix the warning... > >>> I've done some more compile testing and found this solution: > >>> > >

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

h? Cheers, Francesco 2016-07-20 9:49 GMT+02:00 Francesco Ansanelli : > --- > src/gallium/drivers/freedreno/ir3/ir3_shader.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/freedreno/ir3/ir3_shader.c > b/src/gallium/drivers/freedr

[Mesa-dev] [PATCH] freedreno/a2xx: silence missing case 'SHADER_COMPUTE' warning (v2)

v2: no need for break after an unreachable (Matt Turner) Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c b/src/gallium/drivers/freedreno/a2xx/disasm

[Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

--- src/gallium/drivers/freedreno/ir3/ir3_shader.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_shader.c b/src/gallium/drivers/freedreno/ir3/ir3_shader.c index 9f39f9f..5d57c0b 100644 --- a/src/gallium/drivers/freedreno/ir3/ir3_shade

[Mesa-dev] [PATCH 4/4] mesa/st: Add missing braces in initializer

--- src/mesa/state_tracker/st_glsl_to_nir.cpp |2 +- src/mesa/state_tracker/st_program.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 73a692a..6470fae 100644 --- a/sr

[Mesa-dev] [PATCH 2/4] i965: Add missing braces in initializer

--- .../drivers/dri/i965/brw_fs_vector_splitting.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp b/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp index 5c05586..0e16415 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 1/4] glsl: Add missing braces in initializer

--- src/compiler/glsl/ast_to_hir.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 8ddc084..b82e693 100644 --- a/src/compiler/glsl/ast_to_hir.cpp +++ b/src/compiler/glsl/ast_to_hir.cpp @@ -4700,7 +47

[Mesa-dev] [PATCH] freedreno/a2xx: silence missing case 'SHADER_COMPUTE' warning

--- src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c b/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c index f00d5d4..54b3514 100644 --- a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c +

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

Yes, please. Cheers, Francesco ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i915: fix implicit truncation from 'int' to bitfield

--- src/gallium/drivers/i915/i915_context.c |6 +++--- src/gallium/drivers/i915/i915_flush.c |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/i915/i915_context.c b/src/gallium/drivers/i915/i915_context.c index 82798bb..d7cdfd9 100644 --- a/sr

[Mesa-dev] [PATCH] i965: fix ignored qualifiers warning

--- src/mesa/drivers/dri/i965/gen6_queryobj.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen6_queryobj.c b/src/mesa/drivers/dri/i965/gen6_queryobj.c index 96db5e9..95a5c56 100644 --- a/src/mesa/drivers/dri/i965/gen6_queryobj.c +++ b/src/mesa/d

Re: [Mesa-dev] [PATCH] mesa/main: handle gl_buffer_index correctly

ping? This patch put away the compiler warning: "comparison of constant -1 with expression of type 'gl_buffer_index' is always false" 2016-06-28 19:31 GMT+02:00 Francesco Ansanelli : > --- > src/mesa/main/buffers.c | 10 +- > 1 file changed,

[Mesa-dev] [PATCH 2/3] freedreno/a3xx: Fix sign compare warnings

--- src/gallium/drivers/freedreno/a3xx/fd3_screen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/freedreno/a3xx/fd3_screen.c b/src/gallium/drivers/freedreno/a3xx/fd3_screen.c index 4aea2fe..013b0ca 100644 --- a/src/gallium/drivers/freedr

[Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

--- src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c b/src/gallium/drivers/freedreno/a2xx/fd2_screen.c index c2baa6f..fe4849b 100644 --- a/src/gallium/drivers/freedreno/a2

[Mesa-dev] [PATCH 3/3] freedreno/a4xx: Fix sign compare warnings

--- src/gallium/drivers/freedreno/a4xx/fd4_screen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_screen.c b/src/gallium/drivers/freedreno/a4xx/fd4_screen.c index c193f36..57fecf1 100644 --- a/src/gallium/drivers/freedr

[Mesa-dev] [PATCH] mesa/main: handle gl_buffer_index correctly

--- src/mesa/main/buffers.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index e8aedde..3ff6061 100644 --- a/src/mesa/main/buffers.c +++ b/src/mesa/main/buffers.c @@ -170,7 +170,7 @@ draw_buffer_enum_to_bitmask(c

[Mesa-dev] [PATCH] st/mesa: handle negative _ColorDrawBufferIndexes values correctly

--- src/mesa/state_tracker/st_cb_fbo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index a53b95a..950ec3e 100644 --- a/src/mesa/state_tracker/st_cb_fbo.c +++ b/src/mesa/state_tracker/st_cb_fbo.c @@

Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

un 16, 2016 at 7:02 AM, wrote: > > From: Francesco Ansanelli > > > > --- > > src/mesa/state_tracker/st_cb_fbo.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/mesa/state_tracker/st_cb_fbo.c > b/src/mesa/state_tra