Since commit 96d63eb59e34 (" kmscube: Add gears mode") , kmscube fails
to build on platforms without .
Fix it by changing the header file to .
Reported-by: Martin Jansa
Suggested-by: Martin Jansa
Signed-off-by: Fabio Estevam
---
cube-gears.c | 2 +-
1 file changed, 1 insertion(+),
Hi Lucas,
On Mon, Sep 21, 2020 at 9:59 AM Lucas Stach wrote:
> Try starting glmark with --visual-config red=8 as a workaround to get a
> scanout capable visual.
You are right: passing --visual-config red=8 works with the old
version of glmark2.
The latest glmark2 version works without passing
starting glmark with --visual-config red=8 as a workaround to get a
> scanout capable visual.
Thanks for the suggestion.
I bumped the glmark2 version to the latest one in master and now it
runs fine without any extra parameters.
Thanks,
Fabio Estevam
__
anyone have any ideas?
Thanks,
Fabio Estevam
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi Jason and Ian,
On Tue, Mar 31, 2020 at 5:39 PM Jason Ekstrand wrote:
> My feelings aren't usually all that strong on this point though I
> generally prefer !=. That said, this is a float. I very strongly
> prefer != 0.0f.
Thanks for the feedback. I did as suggested:
https://gitlab.freedesk
On Tue, Mar 31, 2020 at 10:25 PM Fabio Estevam wrote:
>
> Hi Rob,
>
> On Tue, Mar 31, 2020 at 7:40 PM Rob Clark wrote:
>
> > thx.. I don't suppose I could talk you in to sending a gitlab merge request?
>
> Please find it at
> https://gitlab.freedesktop.org/mesa
Hi Rob,
On Tue, Mar 31, 2020 at 7:40 PM Rob Clark wrote:
> thx.. I don't suppose I could talk you in to sending a gitlab merge request?
Please find it at
https://gitlab.freedesktop.org/mesa/kmscube/-/merge_requests/22
Let me know if this is the correct process.
Thanks
Hi Rob,
On Tue, Mar 31, 2020 at 7:40 PM Rob Clark wrote:
> thx.. I don't suppose I could talk you in to sending a gitlab merge request?
I never did it, but let me try to learn it how to do it.
Thanks
___
mesa-dev mailing list
mesa-dev@lists.freedeskt
The 'complemented' variable is a pointer to boolean. Use the !! operator
to fix the following build warning:
../texturator.c:603:45: warning: '*' in boolean context, suggest '&&' instead
[-Wint-in-bool-context]
*complemented = (((float)rgba[2]) / 255.0)
When libpng is not present the following build warning is seen:
../texturator.c:98:13: warning: 'png' defined but not used [-Wunused-variable]
static bool png;
Fix it by only defining the png variable when HAVE_LIBPNG is defined.
Signed-off-by: Fabio Estevam
---
texturator.c | 2
and-c99-standard
c99 has been used since commit 6cbd03ab9406 ("Makefile.am: Add -std=c99 to
CFLAGS") to fix the following mips64el build failure:
"cube-tex.c:230:2: note: use option -std=c99 or -std=gnu99 to compile your code"
Use c_std=gnu99 to make both mips64el and ARM32 happy.
Hi Rob,
On Mon, Mar 30, 2020 at 6:29 PM Fabio Estevam wrote:
>
> When building kmscube in Buildroot for ARM the following
> errors are seen:
>
> ../common.c: In function 'get_time_ns':
> ../common.c:376:18: error: storage size of 'tv&#x
IC, &tv);
Fix it by using the default for each compiler on every platform instead.
Inspired by this gst-plugins-good commit:
https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=19f6559582c73123a3ec1fcf5a6b8651fbc2e83f
Signed-off-by: Fabio Estevam
---
meson.build | 6 +
Hi Christian,
On Fri, May 24, 2019 at 7:52 AM Christian Gmeiner
wrote:
>
> Signed-off-by: Christian Gmeiner
Maybe you could remove the '&& s/FALSE/false' from the Subject since
you are only replacing the TRUE occurrences in this patch.
___
mesa-dev ma
Hi Lucas,
On Fri, Aug 25, 2017 at 4:57 AM, Lucas Stach wrote:
> There is no fix for this. The terrain shaders are simply too big to be
> executed on GC2000. (You remember that 512 instruction limit mentioned
> in the reference manual? That's it.)
>
> This demo runs fine on GC3000.
Thanks for th
Hi,
Getting the following errors when running glmark2 terrain test on imx6q:
# glmark2-es2-drm -b terrain
** Failed to set swap interval. Results may be bounded above by refresh rate.
===
glmark2 2014.03
=
Hi Eric,
On Thu, Jun 22, 2017 at 8:08 PM, Eric Anholt wrote:
> I asked afrantzis today, and hopefully I'll get added as a co-maintainer
> so we can get maintenance patches like this in. Also, apparently
> something has been broken with his mail filters, so PRs weren't being
> seen at all.
Exce
Hi Lucas,
On Tue, Jun 13, 2017 at 7:10 PM, Lucas Stach wrote:
> Hi Fabio,
>
> the attached patch should fix the issue. I should really try to get
> this upstream, as some people complained about this already...
It seems that Eric has already sent a fix for this segfault issue in
this pull reques
Hi Lucas,
On Tue, Jun 13, 2017 at 7:20 PM, Fabio Estevam wrote:
> Excellent! This fixes the segfault. Thanks a lot!
Got a different segfault now. Please see below.
Thanks
[ideas] speed=duration:[ 218.073898] etnaviv-gpu 13.gpu: hangcheck detected
gpu lockup!
[ 218.080195] etnaviv-
Hi Lucas,
On Tue, Jun 13, 2017 at 7:10 PM, Lucas Stach wrote:
> Hi Fabio,
>
> the attached patch should fix the issue. I should really try to get
> this upstream, as some people complained about this already...
Excellent! This fixes the segfault. Thanks a lot!
___
Hi,
I am running kernel 4.11.4 with Etnaviv 17.1.2 on a imx6qsabresd board
and when I try to run glmark I am getting a segmentation fault:
# glmark2-es2-drm
** Failed to set swap interval. Results may be bounded above by refresh rate.
===
gl
Hi Lucas,
On Sun, Jun 4, 2017 at 4:06 PM, Lucas Stach wrote:
> Hi all,
>
> I decided to take a look at our current piglit status and the following are
> some stright foward fixes for some of the issues.
>
> The first 3 patches fix some resource copy issues, that may send the blitter
> into an inf
On Sat, Apr 22, 2017 at 12:44 PM, Christian Gmeiner
wrote:
> 2017-04-18 0:36 GMT+02:00 Fabio Estevam :
>> The return code can be simplified by using the logical not operator.
>>
>> Signed-off-by: Fabio Estevam
>
> Reviewed-by: Christian Gmeiner
>
> Btw.
The return code can be simplified by using the logical not operator.
Signed-off-by: Fabio Estevam
---
src/gallium/drivers/freedreno/freedreno_fence.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/freedreno/freedreno_fence.c
b/src/gallium/drivers
The return code can be simplified by using the logical not operator.
Signed-off-by: Fabio Estevam
---
src/gallium/drivers/etnaviv/etnaviv_fence.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_fence.c
b/src/gallium/drivers/etnaviv
On Mon, Mar 27, 2017 at 11:42 AM, Rob Clark wrote:
> I'm undecided about whether or not to keep the autotools build. I
> know there is some OE recipe floating around to build kmscube (since
> it really is the killer-app of the embedded world :-P), but otherwise
> probably aren't many/any distro'
Hi Rob,
On Sun, Mar 26, 2017 at 10:59 AM, Rob Clark wrote:
> Figured I should figure out what this meson stuff is all about. After a
> bit of hunting around to find examples to look at (and interruptions) it
> took maybe ~1hr to convert (for someone who never looked at meson
> before). The buil
'for' loop initial declarations are only allowed in
C99 mode
for (uint32_t i = 0; i < texh/2; i++) {
^
Add the -std=c99 option in CFLAGS to fix this problem.
Signed-off-by: Fabio Estevam
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile
Hi Eric,
On Tue, Mar 21, 2017 at 9:01 AM, Eric Engestrom
wrote:
> I think I'd prefer not going backwards. Does your compiler support C99?
> If so, I'd suggest using it explicitly by adding -std=c99 to the CFLAGS
> in Makefile.am.
Yes, that works too. Just sent a patch adding -std=c99.
Thanks
_
et = select(drm.fd + 1, &fds, NULL, NULL, NULL);
^
drm-legacy.c:101:4: warning: implicit declaration of function 'FD_ISSET'
[-Wimplicit-function-declaration]
} else if (FD_ISSET(0, &fds)) {
^
Signed-off-by: Fabio Estevam
---
drm-legacy.c | 1 +
1 file changed, 1 i
uv':
cube-tex.c:292:2: error: 'for' loop initial declarations are only allowed in
C99 mode
for (uint32_t i = 0; i < texh/2; i++) {
^
Signed-off-by: Fabio Estevam
---
Changes since v1:
- s/initialize/declare to match the build error
cube-tex.c | 12 ++--
1 file
'get_fd_uv':
cube-tex.c:292:2: error: 'for' loop initial declarations are only allowed in
C99 mode
for (uint32_t i = 0; i < texh/2; i++) {
^
Signed-off-by: Fabio Estevam
---
cube-tex.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/cube-tex
Hi Emil,
On Sun, Mar 19, 2017 at 7:57 AM, Emil Velikov wrote:
> On 18 March 2017 at 21:47, Fabio Estevam wrote:
>> There is no need to use brackets for single line if statements,
>> so simply remove them.
>>
>> Signed-off-by: Fabio Estevam
> R-b and pushed t
There is no need to use brackets for single line if statements,
so simply remove them.
Signed-off-by: Fabio Estevam
---
kmscube.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kmscube.c b/kmscube.c
index 8057e66..fcfd902 100644
--- a/kmscube.c
+++ b/kmscube.c
inside init_tex() to fix the following
build warning:
cube-tex.c: In function 'init_tex':
cube-tex.c:438:2: warning: enumeration value 'SMOOTH' not handled in switch
[-Wswitch]
switch (mode) {
^
Signed-off-by: Fabio Estevam
---
cube-tex.c | 3 +++
1 file changed, 3 inserti
Hi Eric,
On Tue, Mar 14, 2017 at 10:33 AM, Eric Engestrom
wrote:
> Signed-off-by: Eric Engestrom
> ---
> drm-legacy.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drm-legacy.c b/drm-legacy.c
> index 2392a3d..8e49075 100644
> --- a/drm-legacy.c
> +++ b/drm-legacy.c
> @@ -33,6 +33,
Hi Wladimir,
On Tue, Mar 14, 2017 at 2:47 PM, Wladimir J. van der Laan
wrote:
> Yea, variants would be the way to render to RGBA succesfully
> on vivantes.
>
> Until then it's best to revert those two patches.
>
> Reverting only the one (latest) patch can give red/blue swapped issues when
> doin
Hi Otavio,
On Tue, Mar 14, 2017 at 1:58 PM, Otavio Salvador
wrote:
> On Tue, Mar 14, 2017 at 12:31 PM, Fabio Estevam wrote:
> ...
>> The cover of the movies are just black rectangles instead of showing
>> the actual movie pictures.
> ...
>
> I am attaching the two pa
Hi,
On a imx6q-sabresd board running kernel 4.9.14, mesa 17.0.1 and QT5.8:
# export QT_QPA_EGLFS_KMS_CONFIG=/media/sabresd.json
where sabresd.json contains:
{
"device": "/dev/dri/card1",
"hwcursor": false,
"pbuffers": true,
"outputs": [
{
"name": "HDMI-1",
"mode": "off"
Hi Emil,
On Mon, Mar 13, 2017 at 1:12 PM, Emil Velikov wrote:
> Since all these were getting a bit of a drag I've addressed most of
> the major issues.
> Can you please pull latest master and send any applicable fixes on top of it.
With the latest master all the kmscube errors are gone! Thanks!
ote: each undeclared identifier is reported only once for
each function it appears in
cube-tex.c:359:29: error: 'DRM_FORMAT_GR88' undeclared (first use in this
function)
EGL_LINUX_DRM_FOURCC_EXT, DRM_FORMAT_GR88,
Include to fix it.
Signed-off-by: Fabio Estevam
---
cube-tex.c | 1 +
1 file
: Gary Bisson
Signed-off-by: Fabio Estevam
---
Changes since v2:
- Only include
drm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drm.h b/drm.h
index c41683b..5225c6c 100644
--- a/drm.h
+++ b/drm.h
@@ -24,6 +24,7 @@
#ifndef _DRM_H
#define _DRM_H
+#include
#include
#include
ote: each undeclared identifier is reported only once for
each function it appears in
cube-tex.c:359:29: error: 'DRM_FORMAT_GR88' undeclared (first use in this
function)
EGL_LINUX_DRM_FOURCC_EXT, DRM_FORMAT_GR88,
Include to fix it.
Signed-off-by: Fabio Estevam >
---
Changes since v1:
with Ubuntu 16.04.
Reported-by: Gary Bisson
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Indicate kmscube in the Subject (Ilia)
drm.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drm.h b/drm.h
index c41683b..6ac7a82 100644
--- a/drm.h
+++ b/drm.h
@@ -24,6 +24,8 @@
#ifndef
On Mon, Mar 13, 2017 at 11:07 AM, Ilia Mirkin wrote:
> On Mon, Mar 13, 2017 at 10:04 AM, Fabio Estevam wrote:
>> Hi Ilia,
>>
>> On Mon, Mar 13, 2017 at 11:03 AM, Ilia Mirkin wrote:
>>> Which repository do these patches apply to? Also the proper way of
>>&g
Hi Ilia,
On Mon, Mar 13, 2017 at 11:03 AM, Ilia Mirkin wrote:
> Which repository do these patches apply to? Also the proper way of
> including drm headers is
These patches apply against kmscube repository:
https://cgit.freedesktop.org/mesa/kmscube
Regards,
Fabio E
identifier is reported only once for
each function it appears in
cube-tex.c:359:29: error: ‘DRM_FORMAT_GR88’ undeclared (first use in this
function)
EGL_LINUX_DRM_FOURCC_EXT, DRM_FORMAT_GR88,
Include to fix it.
Signed-off-by: Fabio Estevam >
---
cube-tex.c | 1 +
1 file changed, 1 insert
with Ubuntu 16.04.
Reported-by: Gary Bisson
Signed-off-by: Fabio Estevam
---
drm.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drm.h b/drm.h
index c41683b..6ac7a82 100644
--- a/drm.h
+++ b/drm.h
@@ -24,6 +24,8 @@
#ifndef _DRM_H
#define _DRM_H
+#include
+#include
#include
include
+#include
#include
#include
This should fix your issue as well as the one I see on my x86 host PC
and also this one on sparc64:
http://autobuild.buildroot.net/results/d7e/d7e82c67e0b04b0aea990bfb19dd6e4fd914bebe/build-end.log
Could you please give it a try?
Regards,
Fabio Esteva
1.4
As this is not an error message, change it to debug level in
order to have a cleaner log output.
Signed-off-by: Fabio Estevam
---
src/loader/loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/loader/loader.c b/src/loader/loader.c
index 3b28a0e..9b4752d 100644
1, sizeof(*drm.plane));
^
drm-atomic.c:346:14: warning: incompatible implicit declaration of built-in
function 'calloc'
drm-atomic.c:346:14: note: include '' or provide a declaration of
'calloc'
Signed-off-by: Fabio Estevam
---
Hi Rob,
This one is against your recent
On Mon, Feb 13, 2017 at 11:09 AM, Fabio Estevam wrote:
> Hi Emil,
>
> On Mon, Feb 13, 2017 at 10:10 AM, Emil Velikov
> wrote:
>> Hi all,
>>
>> Mesa 17.0.0 is now available.
>
> ftp://ftp.freedesktop.org/pub/mesa misses the 17.0.0 directory.
17.0
Hi Emil,
On Mon, Feb 13, 2017 at 10:10 AM, Emil Velikov wrote:
> Hi all,
>
> Mesa 17.0.0 is now available.
ftp://ftp.freedesktop.org/pub/mesa misses the 17.0.0 directory.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedeskto
53 matches
Mail list logo
