Re: [Mesa-dev] [PATCH] i965: Require pixel alignment for GPU copy blit

2014-09-23 Thread Cody Northrop
a 16-bit > > type and sure enough it works to have an offset aligned to two bytes. > > > > Reviewed-by: Neil Roberts > > > > - Neil > > > > Cody Northrop writes: > > > >> The blitter will start at a pixel's natural alignment. For PBOs, if th

[Mesa-dev] [PATCH] i965: Require pixel alignment for GPU copy blit

2014-09-15 Thread Cody Northrop
cture rendering incorrect icon colors. The fix has been tested on Ubuntu and SteamOS on Haswell. Signed-off-by: Cody Northrop Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83908 --- src/mesa/drivers/dri/i915/intel_blit.c | 5 +++-- src/mesa/drivers/dri/i965/intel_blit.c | 5 +++-- 2

[Mesa-dev] [PATCH] glsl: Fix aggregates with dynamic initializers.

2014-07-10 Thread Cody Northrop
master. v3: Remove unneeded check for arrays, which are covered by process_array_constructor(), recommended by Timothy Arceri. Signed-off-by: Cody Northrop Reviewed-by: Courtney Goeltzenleuchter Reviewed-by: Kenneth Graunke Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79373

Re: [Mesa-dev] [PATCH v2] glsl: Fix aggregates with dynamic initializers.

2014-07-10 Thread Cody Northrop
t 22:16 +1000, Timothy Arceri wrote: > > On Tue, 2014-07-01 at 14:45 -0700, Kenneth Graunke wrote: > > > From: Cody Northrop > > > > > > Vectors are falling in to the ir_dereference_array() path. > > > > > > Without this change, the following glsl ab

[Mesa-dev] [PATCH] glsl: Fix aggregates with dynamic initializers.

2014-07-01 Thread Cody Northrop
Vectors are falling in to the ir_dereference_array() path. Without this change, the following glsl aborts the debug driver, or gets the wrong answer in release: mat2x2 a = mat2( vec2( 1.0, vertex.x ), vec2( 0.0, 1.0 ) ); Also submitting piglit tests, will reference in bug. Signed-off-by: Cody

[Mesa-dev] [PATCH] i965/fs: Update discard jump to preserve uniform loads via sampler.

2014-07-01 Thread Cody Northrop
17 2 null { align1 WE_all 1Q }; after(8) : (-f0.1.any8h) halt(8) 17 2 null { align1 WE_all 1Q }; after(16): (-f0.1.any16h) halt(16) 17 2 null { align1 WE_all 1H }; v2: Cleaned up comments and conditional ordering. Signed-off-by: Cody Northrop Reviewed-by: Mike Stroyan Reviewed-by: Ke

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Cody Northrop
ully Matt or Ken can review this... > > > > On 06/12/2014 12:35 PM, Cody Northrop wrote: > > > Commit 17c7ead7 exposed a bug in how uniform loading happens in the > > > presence of discard. It manifested itself in an application as > randomly > > > incorrect

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Cody Northrop
ully Matt or Ken can review this... > > > > On 06/12/2014 12:35 PM, Cody Northrop wrote: > > > Commit 17c7ead7 exposed a bug in how uniform loading happens in the > > > presence of discard. It manifested itself in an application as > randomly > > > incorrect

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-24 Thread Cody Northrop
On Tue, Jun 24, 2014 at 9:17 AM, Ian Romanick wrote: > Send patches with git-send-email and no other method. Save this message > and apply it to origin/master using git-am to see why. > > Hopefully Matt or Ken can review this... > > On 06/12/2014 12:35 PM, Cody Northrop

[Mesa-dev] i965: Uniform loading via samplers with discard

2014-06-12 Thread Cody Northrop
r feedback. Curious if anyone sees a better fix. -C >From 871671c4ab8ff00e85b434865e8855fc356efa8f Mon Sep 17 00:00:00 2001 From: Cody Northrop Date: Thu, 12 Jun 2014 09:07:18 -0600 Subject: [PATCH] i965/fs: Update discard jump to preserve uniform loads via sampler. The series that imp

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-06 Thread Cody Northrop
Whoops, yes, you're right. ftell() of SEEK_END and strlen() are returning the same value, which does not include the terminating zero. Updated patch below. We use this quite a bit, much faster than editing large apitrace files Thanks, -C Signed-off-by: Cody Northrop --- src/mesa

[Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-05 Thread Cody Northrop
The fixed size is insufficient for shaders I'm debugging. Rather than just bump it up, make it dynamic. Thanks, -C Signed-off-by: Cody Northrop --- src/mesa/main/shaderapi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/shaderapi.c

[Mesa-dev] MaxAnisotropy with GL_NEAREST on i965

2014-05-22 Thread Cody Northrop
Greetings, I ran into a problem with how Mesa on i965 handles MaxAnisotropy. The app I'm looking at sets sampler state min and mag filters to GL_NEAREST, but also sets GL_TEXTURE_MAX_ANISOTROPY_EXT, like so: glSamplerParameteri(pointSampler, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glSample

Re: [Mesa-dev] [PATCH 13/19] linker: Modify cross_validate_outputs_to_inputs to match using explicit locations

2014-04-02 Thread Cody Northrop
> > consumer_inputs, > > - > consumer_interface_inputs)); > > + > consumer_interface_inputs, > > +junk)); > > > > /* Create an output variable,