Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

2018-04-10 Thread Bas Vermeulen
On Mon, Apr 9, 2018 at 11:19 PM, Gert Wollny wrote: > Am Montag, den 09.04.2018, 14:03 -0400 schrieb Marek Olšák: > > On Mon, Apr 9, 2018 at 10:51 AM, Bas Vermeulen > > wrote: > Which solution is better depends on what is done more often: reading > the index or writing to t

Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

2018-04-09 Thread Bas Vermeulen
union and the index in one struct, and use a function to (re)calculate the index. Which would you prefer? Bas Vermeulen On Tue, Mar 20, 2018 at 6:33 PM, Gert Wollny wrote: > Am Dienstag, den 20.03.2018, 15:33 +0100 schrieb Nicolai Hähnle: > > Nice, did you actually get it to work enti

[Mesa-dev] radeonsi: Patches to enable the use of OpenCL on a big endian system

2018-04-09 Thread Bas Vermeulen
sent through the rings. Together, these patches allow me to execute OpenCL kernels correctly on the T2080 mentioned above. Bas Vermeulen ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] radeonsi: convert dispatch packet to little endian

2018-04-09 Thread Bas Vermeulen
OpenCL program work correctly. Signed-off-by: Bas Vermeulen --- src/gallium/drivers/radeonsi/si_compute.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index

[Mesa-dev] [PATCH 1/2] radeonsi: correct si_vgt_param_key on big endian machines

2018-04-09 Thread Bas Vermeulen
Using mesa OpenCL failed on a big endian PowerPC machine because si_vgt_param_key is using bitfields and a 32 bit int for an index into an array. Fix si_vgt_param_key to work correctly on both little endian and big endian machines. Signed-off-by: Bas Vermeulen --- src/gallium/drivers/radeonsi

[Mesa-dev] Mixed endianness with OpenCL

2018-03-23 Thread Bas Vermeulen
are mangled somehow. My question is, does the radeonsi gallium driver process result buffers somewhere in the code? Pointers are more than welcome. I'm guessing the values are processed/mangled some way, and I would love to make this work correctly. Bas Verm

[Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

2018-03-20 Thread Bas Vermeulen
Using mesa OpenCL failed on a big endian PowerPC machine because si_vgt_param_key is using bitfields and a 32 bit int for an index into an array. Fix si_vgt_param_key to work correctly on both little endian and big endian machines. Signed-off-by: Bas Vermeulen --- src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

2018-03-20 Thread Bas Vermeulen
d of my own #if. Bas Vermeulen On Tue, Mar 20, 2018 at 3:33 PM, Nicolai Hähnle wrote: > Nice, did you actually get it to work entirely on a big endian machine? > > Bit fields aren't super portable, but this looks good enough. However, I > think we should use the PIPE_ARCH_LITT