Re: [Mesa-dev] [PATCH] Fix glGetInteger*(GL_SAMPLER_BINDING).

2013-03-07 Thread Alan Hourihane
On 03/07/13 00:12, Brian Paul wrote: On 03/06/2013 11:46 AM, Alan Hourihane wrote: On 03/06/13 18:36, Brian Paul wrote: On 03/06/2013 11:23 AM, Alan Hourihane wrote: If the sampler object has been deleted on another context, an alternative context may reference the old sampler. So ensure the

Re: [Mesa-dev] [PATCH] Fix glGetInteger*(GL_SAMPLER_BINDING).

2013-03-06 Thread Alan Hourihane
On 03/06/13 18:36, Brian Paul wrote: On 03/06/2013 11:23 AM, Alan Hourihane wrote: If the sampler object has been deleted on another context, an alternative context may reference the old sampler. So ensure the sampler object still exists. Alan, is this specified somewhere in a spec? I can&#

[Mesa-dev] [PATCH] Fix glGetInteger*(GL_SAMPLER_BINDING).

2013-03-06 Thread Alan Hourihane
If the sampler object has been deleted on another context, an alternative context may reference the old sampler. So ensure the sampler object still exists. Signed-off-by: Alan Hourihane --- src/mesa/main/get.c| 12 +++- src/mesa/main/samplerobj.c |2 +- src/mesa/main

[Mesa-dev] [PATCH] Unreference sampler object when it's currently bound to, texture unit.

2013-03-06 Thread Alan Hourihane
This change specifically unbinds a sampler object from the texture unit if it's bound to a unit. The spec calls for default object when deleting sampler objects which are currently bound. Signed-off-by: Alan Hourihane --- src/mesa/main/samplerobj.c | 10 ++ 1 files change

Re: [Mesa-dev] [PATCH] Add missing GL_TEXTURE_CUBE_MAP entry in _mesa_legal_texture_dimensions

2013-03-05 Thread Alan Hourihane
On 03/05/13 16:36, Ian Romanick wrote: On 03/05/2013 07:09 AM, Brian Paul wrote: On 03/05/2013 05:08 AM, Alan Hourihane wrote: Add's the missing GL_TEXTURE_CUBE_MAP entry in _mesa_legal_texture_dimensions. Signed-off-by: Alan Hourihane --- src/mesa/main/teximage.c | 1 + 1 files chang

Re: [Mesa-dev] [PATCH] Add missing GL_TEXTURE_CUBE_MAP entry in _mesa_legal_texture_dimensions

2013-03-05 Thread Alan Hourihane
On 03/05/13 15:09, Brian Paul wrote: On 03/05/2013 05:08 AM, Alan Hourihane wrote: Add's the missing GL_TEXTURE_CUBE_MAP entry in _mesa_legal_texture_dimensions. Signed-off-by: Alan Hourihane --- src/mesa/main/teximage.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[Mesa-dev] [PATCH] Add missing GL_TEXTURE_CUBE_MAP entry in _mesa_legal_texture_dimensions

2013-03-05 Thread Alan Hourihane
Add's the missing GL_TEXTURE_CUBE_MAP entry in _mesa_legal_texture_dimensions. Signed-off-by: Alan Hourihane --- src/mesa/main/teximage.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 0dcf88a..9d4a170 1

Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-16 Thread Alan Hourihane
On 08/16/11 10:26, Alan Hourihane wrote: > On 08/16/11 10:05, Michel Dänzer wrote: >> On Die, 2011-08-16 at 16:55 +0800, Cooper Yuan wrote: >>> We still call flush method of DRI2_Flush extension in other functions >>> of egl_dri2 driver. for example, dri2_copy_buffers()

Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-16 Thread Alan Hourihane
On 08/16/11 10:05, Michel Dänzer wrote: > On Die, 2011-08-16 at 16:55 +0800, Cooper Yuan wrote: >> We still call flush method of DRI2_Flush extension in other functions >> of egl_dri2 driver. for example, dri2_copy_buffers(), because we >> expect all the rendering to this drawable have been flushed