Re: [Mesa-dev] [2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

2019-11-01 Thread Paul Gofman
On 11/2/19 00:09, Ian Romanick wrote: > > It's not strictly a requirement, but having some kind of a test is very > highly desirable. I will try to do that next week. I can guess piglit/tests/spec/arb_texture_view/mipgen.c is the right place for that. ___

Re: [Mesa-dev] [2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

2019-11-01 Thread Ian Romanick
On 11/1/19 12:47 PM, Paul Gofman wrote: > On 11/1/19 22:19, Ilia Mirkin wrote: >> It looks like the _mesa_generate_mipmap fallback has a similar problem >> (which would happen for glGenerateMipmap with e.g. a s3tc format). > > It looks to me it doesn't. I hit this path in the tests I am running >

Re: [Mesa-dev] [2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

2019-11-01 Thread Paul Gofman
On 11/1/19 22:19, Ilia Mirkin wrote: > It looks like the _mesa_generate_mipmap fallback has a similar problem > (which would happen for glGenerateMipmap with e.g. a s3tc format). It looks to me it doesn't. I hit this path in the tests I am running with 3D textures (I made sure of that by inserting

Re: [Mesa-dev] [2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

2019-11-01 Thread Ilia Mirkin
It looks like the _mesa_generate_mipmap fallback has a similar problem (which would happen for glGenerateMipmap with e.g. a s3tc format). I think this could all use some piglit tests that iterate through all or at least many different formats, including both renderable and non-renderable ones. Ch

[Mesa-dev] [1/2] i965: Handle texture view min level in brw_generate_mipmap()

2019-11-01 Thread Paul Gofman
Currently minlevel set with glTextureView() is ignored for mipmap generation and original texture's first layer is used as the source layer in glGenerateMipmap(). Signed-off-by: Paul Gofman --- Spotted while debugging Wine d3d11 unit test failures with Nouveau and Intel drivers. src/mesa/d

[Mesa-dev] [2/2] state_tracker: Handle texture view min level in st_generate_mipmap()

2019-11-01 Thread Paul Gofman
Signed-off-by: Paul Gofman --- src/mesa/state_tracker/st_gen_mipmap.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_gen_mipmap.c b/src/mesa/state_tracker/st_gen_mipmap.c index b71a8ee57bb..c5cf7063836 100644 --- a/src/mesa/state_tracker/st_gen_

Re: [Mesa-dev] [PATCH] egl: Mention if swrast is being forced

2019-11-01 Thread Emil Velikov
On Fri, 1 Nov 2019 at 14:32, Chris Wilson wrote: > > Quoting Eric Engestrom (2019-10-31 14:06:40) > > On Thursday, 2019-10-31 07:35:04 +, Chris Wilson wrote: > > > The system can be disabling HW acceleration unbeknowst to the user, > > > leading to a long debug session trying to work out which

Re: [Mesa-dev] [PATCH] egl: Mention if swrast is being forced

2019-11-01 Thread Chris Wilson
Quoting Eric Engestrom (2019-10-31 14:06:40) > On Thursday, 2019-10-31 07:35:04 +, Chris Wilson wrote: > > The system can be disabling HW acceleration unbeknowst to the user, > > leading to a long debug session trying to work out which component is > > failing. A quick mention that it is the en