Re: [Mesa-dev] [PATCH] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

Any concern for this CL? I think it's pretty safe to merge this since any way android egl wrapper doesn't like HAL_PIXEL_FORMAT_BGRA_ and won't return it for native window format and then won't set it as native window format. https://android.googlesource.com/platform/frameworks/native/+/refs/h

[Mesa-dev] [Bug 111265] [TRACKER] Mesa 19.2 feature tracker

https://bugs.freedesktop.org/show_bug.cgi?id=111265 Bug 111265 depends on bug 111275, which changed state. Bug 111275 Summary: Feature: CCS_E modifier support and dri_query_image fixes https://bugs.freedesktop.org/show_bug.cgi?id=111275 What|Removed |Added -

Re: [Mesa-dev] [PATCH] panfrost: Kill a useless NULL test in panfrost_job_submit()

Reviewed-by: Alyssa Rosenzweig On Tue, Aug 13, 2019 at 08:35:21PM +0200, Boris Brezillon wrote: > The !job test is done after dereferencing the job pointer, which means > it's either always false or we have a NULL pointer exception. > > Replace that test by an assert() at the beginning of the fu

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement custom block/instruction iterators

> > > Would it be possible > > > to extend the shared list.h helpers (might this contain functionality > > > interesting to other drivers as well)? > > > > Hm, not without making them more complex I'm afraid. And since > > most users are happy with the current implementation I'm not entirely > >

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement custom block/instruction iterators

On Tue, 13 Aug 2019 22:25:49 +0200 Boris Brezillon wrote: > On Tue, 13 Aug 2019 12:59:03 -0700 > Alyssa Rosenzweig wrote: > > > Could you explain a little bit more why this is neded? What do these > > helpers do that the generic list.h helpers can't? > > The _safe attribute in generic helper

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement custom block/instruction iterators

> > Could you explain a little bit more why this is neded? What do these > > helpers do that the generic list.h helpers can't? > > The _safe attribute in generic helpers is just about handling the case > where the current item is removed from the list (or a new one is > inserted and you want to sk

Re: [Mesa-dev] [PATCH 1/2] panfrost: Don't use mir_foreach_instr_in_block_safe() when not needed

> I don't see any remove_ins()/insert_before() call in there. Do you see > any reason for using the _safe() variant here? Er, I think I meant the outer loop, which has a remove/insert pair at the bottom to change the current instruction. signature.asc Description: PGP signature _

Re: [Mesa-dev] dEQP + llvmpipe

On Tue, Aug 13, 2019 at 4:49 PM Eric Anholt wrote: > > Ilia Mirkin writes: > > > Hi Eric, > > > > I see that you recently added testing dEQP with llvmpipe in the CI. It > > looks like a number of your expected failures would be resolved by > > disabling some llvmpipe optimizations. You can do thi

Re: [Mesa-dev] dEQP + llvmpipe

Ilia Mirkin writes: > Hi Eric, > > I see that you recently added testing dEQP with llvmpipe in the CI. It > looks like a number of your expected failures would be resolved by > disabling some llvmpipe optimizations. You can do this by running with > > GALLIVM_DEBUG=no_rho_approx,no_brilinear,no_q

Re: [Mesa-dev] [PATCH] i965/gen11: fix genX_bits.h include path

On Tue, Aug 13, 2019 at 05:50:30PM +0200, Mauro Rossi wrote: > Instead of "genX_bits.h" use "genxml/genX_bits.h" > as already done in other similar cases > > Besides being more correct, it also fixes building error in Android. Ugh, sorry for that. Reviewed-by: Rafael Antognolli > Fixes: f0d292

Re: [Mesa-dev] [PATCH 1/2] panfrost: Don't use mir_foreach_instr_in_block_safe() when not needed

On Tue, 13 Aug 2019 12:55:57 -0700 Alyssa Rosenzweig wrote: > > +++ b/src/panfrost/midgard/midgard_opt_perspective.c > > @@ -71,7 +71,7 @@ midgard_opt_combine_projection(compiler_context *ctx, > > midgard_block *block) > > unsigned frcp_component = 0; > > unsign

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement custom block/instruction iterators

On Tue, 13 Aug 2019 12:59:03 -0700 Alyssa Rosenzweig wrote: > Could you explain a little bit more why this is neded? What do these > helpers do that the generic list.h helpers can't? The _safe attribute in generic helpers is just about handling the case where the current item is removed from the

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement custom block/instruction iterators

Could you explain a little bit more why this is neded? What do these helpers do that the generic list.h helpers can't? Would it be possible to extend the shared list.h helpers (might this contain functionality interesting to other drivers as well)? What about the new next_ins argument -- should th

Re: [Mesa-dev] [PATCH 1/2] panfrost: Don't use mir_foreach_instr_in_block_safe() when not needed

> +++ b/src/panfrost/midgard/midgard_opt_perspective.c > @@ -71,7 +71,7 @@ midgard_opt_combine_projection(compiler_context *ctx, > midgard_block *block) > unsigned frcp_component = 0; > unsigned frcp_from = 0; > > -mir_foreach_instr_in_block_safe

[Mesa-dev] dEQP + llvmpipe

Hi Eric, I see that you recently added testing dEQP with llvmpipe in the CI. It looks like a number of your expected failures would be resolved by disabling some llvmpipe optimizations. You can do this by running with GALLIVM_DEBUG=no_rho_approx,no_brilinear,no_quad_lod in the environment. Some

[Mesa-dev] [PATCH 1/2] panfrost: Don't use mir_foreach_instr_in_block_safe() when not needed

mir_foreach_instr_in_block_safe() is only needed if the caller intend to remove the current item from the list. Downgrade to mir_foreach_instr_in_block() when this is not the case. Signed-off-by: Boris Brezillon --- src/panfrost/midgard/midgard_compile.c | 2 +- src/panfrost/midgard/midg

[Mesa-dev] [PATCH 2/2] panfrost: Implement custom block/instruction iterators

The generic list helpers are too restrictive for us: we want to be able to update the instruction pointer within the foreach body, and the list_assert() check done in list_for_each_entry() prevents it. Sometimes we also want to update the next_ins pointer (in case we delete/replace the next instruc

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

Hi, On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli wrote: > > On 8/13/19 3:32 PM, Mauro Rossi wrote: > > Hi, > > > > On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli > > wrote: > > > > Hi; > > > > On 8/13/19 2:43 PM, Mauro Rossi wrote: > > > Hi Tapani, > >

[Mesa-dev] [PATCH] panfrost: Kill a useless NULL test in panfrost_job_submit()

The !job test is done after dereferencing the job pointer, which means it's either always false or we have a NULL pointer exception. Replace that test by an assert() at the beginning of the function. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_job.c | 4 +--- 1 file chan

[Mesa-dev] [Bug 110471] No Man Sky GPU hang

https://bugs.freedesktop.org/show_bug.cgi?id=110471 --- Comment #5 from Haxk20 --- That workaround works for me but has huge graphical artifacts. Like blue triangles all over the screen. Basically unplayable. -- You are receiving this mail because: You are the QA Contact for the bug.___

Re: [Mesa-dev] [PATCH 1/9] panfrost: Implement callbacks for PRIMITIVES queries

On Fri, 9 Aug 2019 13:00:44 -0700 Alyssa Rosenzweig wrote: > We're just going to compute them in the driver but let's get the > structures setup to handle them. Implementation from v3d. > > Signed-off-by: Alyssa Rosenzweig The whole patchset is Reviewed-by: Boris Brezillon > --- > src/gal

[Mesa-dev] [PATCH] i965/gen11: fix genX_bits.h include path

Instead of "genX_bits.h" use "genxml/genX_bits.h" as already done in other similar cases Besides being more correct, it also fixes building error in Android. Fixes: f0d2923 ("i965/gen11: Emit SLICE_HASH_TABLE when pipes are unbalanced.") Signed-off-by: Mauro Rossi --- src/mesa/drivers/dri/i965/

[Mesa-dev] [Bug 111393] Warnings about Formats with "inconsistent channel types"

https://bugs.freedesktop.org/show_bug.cgi?id=111393 Bug ID: 111393 Summary: Warnings about Formats with "inconsistent channel types" Product: Mesa Version: git Hardware: Other OS: All Status: NEW

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

On 8/13/19 3:32 PM, Mauro Rossi wrote: Hi, On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli > wrote: Hi; On 8/13/19 2:43 PM, Mauro Rossi wrote: > Hi Tapani, > > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi mailto:issor.or...@gmail.com>

Re: [Mesa-dev] [PATCH v7 0/5] EGL_KHR_partial_update support

On Mon, 12 Aug 2019 12:07:03 +0200 Boris Brezillon wrote: > This is an attempt at resurrecting Daniel's MR [1] which was already > resurrecting Harish's EGL_KHR_partial_update series [2]. This version > implements Marek's suggestion to pass the set_damage_region() directly > to the gallium driver

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

Hi, On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli wrote: > Hi; > > On 8/13/19 2:43 PM, Mauro Rossi wrote: > > Hi Tapani, > > > > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi > > wrote: > > > > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi >