https://bugs.freedesktop.org/show_bug.cgi?id=110116
--- Comment #1 from Tapani Pälli ---
I've briefly tested, stars render OK on HSW but are displayed as rectangles on
KBL.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug._
Hi Brian,
On Thursday, 14 March 2019 15:04:28 CET Brian Paul wrote:
> > Ok, so basically you are saying that you improve the current situation with
> > this
> > current series, still leaving a race condition open. But a good final fix
> > to the race
> > condition is underway.
>
> Yeah, I can p
Hi Brian,
the full package looks great and makes a lot of sense!
Reviewed-by: Mathias Fröhlich
best
Mathias
On Thursday, 14 March 2019 20:37:09 CET Brian Paul wrote:
> When st_texture_release_all_sampler_views() is called the texture may
> have sampler views belonging to several contexts.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pandecode/decode.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c
b/src/gallium/drivers/panfrost/pandecode/decode.c
index e6932744939..28bc0509feb 100
Mipmaps are still broken, but at least this way we don't crash on some
apps using mipmaps.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_resource.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_resource.c
b/src/gallium/drivers/panfro
This is required for gl_PointCoord to show up on decodes.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pandecode/decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c
b/src/gallium/drivers/panfrost/pande
I don't know why this was on to begin with...?
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_screen.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_screen.c
b/src/gallium/drivers/panfrost/pan_screen.c
index 9cd65ca8ff8..9672048bca
In addition to fixing actual primconvert bugs, this prevents an infinite
loop when trying to draw POINTS.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
https://bugs.freedesktop.org/show_bug.cgi?id=110116
QwertyChouskie changed:
What|Removed |Added
OS|All |Linux (All)
CC|
https://bugs.freedesktop.org/show_bug.cgi?id=110116
Bug ID: 110116
Summary: Neverball particles are broken (GL_POINT_SPRITE)
Product: Mesa
Version: 18.3
Hardware: Other
OS: All
Status: NEW
Severity: normal
On Thu, Mar 14, 2019 at 9:58 PM Roland Scheidegger wrote:
>
> Am 15.03.19 um 02:18 schrieb Rob Clark:
> > On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger
> > wrote:
> >>
> >> Am 14.03.19 um 22:06 schrieb Rob Clark:
> >>> On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger
> >>> wrote:
>
Am 15.03.19 um 02:18 schrieb Rob Clark:
> On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote:
>>
>> Am 14.03.19 um 22:06 schrieb Rob Clark:
>>> On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger
>>> wrote:
Am 14.03.19 um 14:13 schrieb Rob Clark:
> On Tue, Mar 12, 2019 at 1:59
On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote:
>
> Am 14.03.19 um 22:06 schrieb Rob Clark:
> > On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger
> > wrote:
> >>
> >> Am 14.03.19 um 14:13 schrieb Rob Clark:
> >>> On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger
> >>> wrote:
>
This looks all good to me.
For the series:
Reviewed-by: Roland Scheidegger
Am 14.03.19 um 20:37 schrieb Brian Paul:
> It's no longer used.
> ---
> src/gallium/auxiliary/util/u_inlines.h | 20
> 1 file changed, 20 deletions(-)
>
> diff --git a/src/gallium/auxiliary/util/u_in
On Thu, Mar 14, 2019 at 7:08 PM Jason Ekstrand wrote:
> From: Eleni Maria Stea
>
> Added support for setting the locations when the pipeline has been
> created with the dynamic state bit enabled according to the Vulkan
> Specification section [26.5. Custom Sample Locations] for the function:
>
>
Am 14.03.19 um 22:06 schrieb Rob Clark:
> On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote:
>>
>> Am 14.03.19 um 14:13 schrieb Rob Clark:
>>> On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger
>>> wrote:
Am 12.03.19 um 16:16 schrieb Rob Clark:
> This previously was not call
On Thu, Mar 14, 2019 at 7:08 PM Jason Ekstrand wrote:
> Eleni,
>
> I made a comment on one of your patches and then I started getting lost in
> the churn. It's easier to see what's going on if things are reordered and
> refactored a bit. Unfortunately, what needed to be done was hard to
> expla
From: Eleni Maria Stea
The VkPhysicalDeviceSampleLocationPropertiesEXT struct is filled with
implementation dependent values and according to the table from the
Vulkan Specification section [36.1. Limit Requirements]:
pname | max | min
pname:sampleLocationSampleCounts |-|ename:VK_S
From: Eleni Maria Stea
Implemented the vkGetPhysicalDeviceMultisamplePropertiesEXT according to
the Vulkan Specification section [36.2. Additional Multisampling
Capabilities].
v2: 1- Moved the vkGetPhysicalDeviceMultisamplePropertiesEXT from the
anv_sample_locations.c to the anv_device.c
From: Eleni Maria Stea
In src/intel/vulkan/genX_blorp_exec.c we included the file:
common/gen_sample_positions.h but not use it. Removed.
Reviewed-by: Sagar Ghuge
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/genX_blorp_exec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/intel/vu
---
src/intel/vulkan/anv_genX.h | 4 ++
src/intel/vulkan/genX_pipeline.c | 40 +--
src/intel/vulkan/genX_state.c| 84
3 files changed, 70 insertions(+), 58 deletions(-)
diff --git a/src/intel/vulkan/anv_genX.h b/src/intel/vulkan/anv_genX.h
in
From: Eleni Maria Stea
We only emit sample locations when the extension is enabled by the user.
In all other cases the default locations are emitted once when the device
is initialized to increase performance.
---
src/intel/vulkan/genX_cmd_buffer.c | 1 +
src/intel/vulkan/genX_pipeline.c | 3 +
From: Eleni Maria Stea
Allowing the user to set custom sample locations non-dynamically, by
filling the extension structs and chaining them to the pipeline structs
according to the Vulkan specification section [26.5. Custom Sample
Locations] for the following structures:
'VkPipelineSampleLocatio
From: Eleni Maria Stea
Added the VK_EXT_sample_locations to the anv_extensions.py list to
generate the related entrypoints.
Reviewed-by: Sagar Ghuge
---
src/intel/vulkan/anv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan
Eleni,
I made a comment on one of your patches and then I started getting lost in
the churn. It's easier to see what's going on if things are reordered and
refactored a bit. Unfortunately, what needed to be done was hard to
explain and it was easier for me to just do the code motion and re-send
From: Eleni Maria Stea
Enabled the VK_EXT_sample_locations for Intel Gen >= 7.
v2: Replaced device.info->gen >= 7 with True, as Anv doesn't support
anything below Gen7. (Lionel Landwerlin)
Reviewed-by: Sagar Ghuge
---
src/intel/vulkan/anv_extensions.py | 2 +-
1 file changed, 1 insertion(
From: Eleni Maria Stea
This commit adds a "locations" parameter to emit_multisample and
emit_sample_pattern which, if provided, will override the default
sample locations.
---
src/intel/common/gen_sample_positions.h | 57 +
src/intel/vulkan/anv_genX.h | 6 +-
src/intel
From: Eleni Maria Stea
Added support for setting the locations when the pipeline has been
created with the dynamic state bit enabled according to the Vulkan
Specification section [26.5. Custom Sample Locations] for the function:
'vkCmdSetSampleLocationsEXT'
The reason that we preferred to store
---
src/intel/vulkan/genX_pipeline.c | 29 +
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c
index 975052deb79..8ba206ed8c4 100644
--- a/src/intel/vulkan/genX_pipeline.c
+++ b/src/intel/
https://bugs.freedesktop.org/show_bug.cgi?id=100316
--- Comment #4 from Jordan Justen ---
(In reply to Danylo from comment #3)
> I've sent the patch for more general manifestation of the issue:
> https://patchwork.freedesktop.org/patch/247067/
Just noting that Danylo submitted a merge request fo
Looks great!
For series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, March 14, 2019 12:37 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Jose Fonseca; Roland Scheidegger; Mathias Fröhlich
Subject: [PATCH 8/8] gallium/
Rob Clark writes:
> On Thu, Mar 14, 2019 at 3:35 PM Eric Anholt wrote:
>>
>> Rob Clark writes:
>>
>> > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner
>> > wrote:
>> >>
>> >> Use u_transfer_helper_resource_create(..) instead which uses the
>> >> resource_create(..) function specified in u_tr
On Thu, Mar 14, 2019 at 2:52 PM Eleni Maria Stea wrote:
> Allowing the user to set custom sample locations non-dynamically, by
> filling the extension structs and chaining them to the pipeline structs
> according to the Vulkan specification section [26.5. Custom Sample
> Locations] for the follow
To all X.Org Foundation Members:
In order to give members more time to process the proposed changes to the bylaw
the elections committee decided to delay the start of voting by one week.
Updated Schedule:
Nomination period Start: Jan 31 00:00 UTC
Nomination period End: Feb 28 23:59 UTC
Dea
To all X.Org Foundation Members:
My previous emails about the 2019 X.Org elections failed to mention on
important ballot items that we'd like to vote on, in addition to the new board
members: the Bylaw change
The updated Bylaws to be voted on can be found here:
https://gitlab.freedesktop.org/
On Thu, Mar 14, 2019 at 3:35 PM Eric Anholt wrote:
>
> Rob Clark writes:
>
> > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner
> > wrote:
> >>
> >> Use u_transfer_helper_resource_create(..) instead which uses the
> >> resource_create(..) function specified in u_transfer_vtbl.
> >>
> >> Signed-
On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote:
>
> Am 14.03.19 um 14:13 schrieb Rob Clark:
> > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger
> > wrote:
> >>
> >> Am 12.03.19 um 16:16 schrieb Rob Clark:
> >>> This previously was not called out clearly, but based on a survey of the
On 2019-03-14 4:40 p.m., Luc Verhaegen wrote:
> On Thu, Mar 14, 2019 at 08:36:13PM +, Wentland, Harry wrote:
>> On 2019-03-12 6:49 a.m., Luc Verhaegen wrote:
>>>
>>> Are these candidates the only thing we will be voting on?
>>>
>>
>> You're right. The FDO question totally slipped me mind.
>>
>>
On Thu, Mar 14, 2019 at 08:36:13PM +, Wentland, Harry wrote:
> On 2019-03-12 6:49 a.m., Luc Verhaegen wrote:
> >
> > Are these candidates the only thing we will be voting on?
> >
>
> You're right. The FDO question totally slipped me mind.
>
> We'll also be voting on the bylaw change I sent
On 2019-03-12 6:49 a.m., Luc Verhaegen wrote:
> On Tue, Mar 12, 2019 at 12:24:00AM +, Wentland, Harry wrote:
>> To all X.Org Foundation Members:
>>
>> The election for the X.Org Foundation Board of Directors will begin on
>> 14 March 2019. We have 6 candidates who are running for 4 seats. They
Am 14.03.19 um 14:13 schrieb Rob Clark:
> On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote:
>>
>> Am 12.03.19 um 16:16 schrieb Rob Clark:
>>> This previously was not called out clearly, but based on a survey of the
>>> code, it seems the expected behavior is to release the reference to any
Implemented the vkGetPhysicalDeviceMultisamplePropertiesEXT according to
the Vulkan Specification section [36.2. Additional Multisampling
Capabilities].
v2: 1- Moved the vkGetPhysicalDeviceMultisamplePropertiesEXT from the
anv_sample_locations.c to the anv_device.c (Jason Ekstrand)
2- S
We only emit sample locations when the extension is enabled by the user.
In all other cases the default locations are emitted once when the device
is initialized to increase performance.
---
src/intel/vulkan/anv_genX.h| 3 ++-
src/intel/vulkan/genX_cmd_buffer.c | 2 +-
src/intel/vulkan/g
In src/intel/vulkan/genX_blorp_exec.c we included the file:
common/gen_sample_positions.h but not use it. Removed.
Reviewed-by: Sagar Ghuge
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/genX_blorp_exec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/intel/vulkan/genX_blorp_exec.c
b
Allowing setting dynamic and non-dynamic sample locations on Gen7.
v2: Similarly to the previous patches, removed structs and functions
that were used to sort and store the sorted sample positions (Jason
Ekstrand)
---
src/intel/vulkan/anv_genX.h| 13 ++---
src/intel/vulkan/genX_cm
Enabled the VK_EXT_sample_locations for Intel Gen >= 7.
v2: Replaced device.info->gen >= 7 with True, as Anv doesn't support
anything below Gen7. (Lionel Landwerlin)
Reviewed-by: Sagar Ghuge
---
src/intel/vulkan/anv_extensions.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Allowing the user to set custom sample locations non-dynamically, by
filling the extension structs and chaining them to the pipeline structs
according to the Vulkan specification section [26.5. Custom Sample
Locations] for the following structures:
'VkPipelineSampleLocationsStateCreateInfoEXT'
'Vk
Added support for setting the locations when the pipeline has been
created with the dynamic state bit enabled according to the Vulkan
Specification section [26.5. Custom Sample Locations] for the function:
'vkCmdSetSampleLocationsEXT'
The reason that we preferred to store the boolean valid inside
Implemented the requirements from the VK_EXT_sample_locations extension
specification to allow setting custom sample locations on Intel Gen >= 7.
Some decisions explained:
The grid size was set to 1x1 because the hardware only supports a single
set of sample locations for the whole framebuffer.
The VkPhysicalDeviceSampleLocationPropertiesEXT struct is filled with
implementation dependent values and according to the table from the
Vulkan Specification section [36.1. Limit Requirements]:
pname | max | min
pname:sampleLocationSampleCounts |-|ename:VK_SAMPLE_COUNT_4_BIT
pname:m
Added the VK_EXT_sample_locations to the anv_extensions.py list to
generate the related entrypoints.
Reviewed-by: Sagar Ghuge
---
src/intel/vulkan/anv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index
As with the preceding patch for sampler views, this patch does
basically the same thing but for shaders. However, reference counting
isn't needed here (instead of calling cso_delete_XXX_shader() we call
st_save_zombie_shader().
The Redway3D Watch is one app/demo that needs this change. Otherwise
As with svga, llvmpipe drivers in previous patches.
Compile tested only.
---
src/gallium/drivers/swr/swr_state.cpp | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/gallium/drivers/swr/swr_state.cpp
b/src/gallium/drivers/swr/swr_state.cpp
index d7baa71..42d196f 100644
--- a/src/gallium/
This was used to avoid freeing a sampler view which was created by a
context that was already deleted. But the state tracker does not
allow that.
---
src/gallium/drivers/llvmpipe/lp_state_sampler.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/gallium/drivers/llvmpipe/lp_state_samp
In all instances here we can replace pipe_sampler_view_release(pipe,
view) with pipe_sampler_view_reference(view, NULL) because the views
in question are private to the state tracker context. So there's no
danger of freeing a sampler view with the wrong context.
Testing done: google chrome, misc
When st_texture_release_all_sampler_views() is called the texture may
have sampler views belonging to several contexts. If we unreference a
sampler view and its refcount hits zero, we need to be sure to destroy
the sampler view with the same context which created it.
This was not the case with th
It's no longer used.
---
src/gallium/auxiliary/util/u_inlines.h | 20
1 file changed, 20 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_inlines.h
b/src/gallium/auxiliary/util/u_inlines.h
index fa1e920..567d3d0 100644
--- a/src/gallium/auxiliary/util/u_inlines.h
+++ b
This function was used in the past to avoid deleting a sampler view
for a context that no longer exists. But the Mesa state tracker
ensures that cannot happen. Use the standard refcounting function
instead.
Also, remove the code which checked for context mis-matches in
svga_sampler_view_destroy(
As with previous patches for svga, llvmpipe, swr drivers.
Compile tested only.
---
src/gallium/drivers/i915/i915_state.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/gallium/drivers/i915/i915_state.c
b/src/gallium/drivers/i915/i915_state.c
index ddc2709..03d2
Rob Clark writes:
> On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner
> wrote:
>>
>> Use u_transfer_helper_resource_create(..) instead which uses the
>> resource_create(..) function specified in u_transfer_vtbl.
>>
>> Signed-off-by: Christian Gmeiner
>> ---
>> src/gallium/auxiliary/util/u_tran
On Wed, 2019-03-06 at 13:39 +1000, Dave Airlie wrote:
> On Wed, 6 Mar 2019 at 01:01, Erik Faye-Lund
> wrote:
> > When we try to do a vrend transfer from a renderable texture, we
> > end up
> > using glReadPixels to read the data. However, OpenGL ES has
> > restrictions on what formats are allowed
Yup. Not getting used at all.
Reviewed-by: Jason Ekstrand
On Thu, Mar 14, 2019 at 12:10 PM Rafael Antognolli <
rafael.antogno...@intel.com> wrote:
> It seems pretty useless nowadays.
> ---
> src/mesa/drivers/dri/i965/brw_blorp.c | 36 +--
> 1 file changed, 12 insertion
It seems pretty useless nowadays.
---
src/mesa/drivers/dri/i965/brw_blorp.c | 36 +--
1 file changed, 12 insertions(+), 24 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c
b/src/mesa/drivers/dri/i965/brw_blorp.c
index 97a5f6a9937..e09a8cef762 100644
--- a/s
On 08/03/2019 22:52, Brian Paul wrote:
After a while of running google-chrome and viewing Bing maps, we'd see
"context mismatch in svga_sampler_view_destroy()" messages and
eventually crash because we leaked too many sampler views (the kernel
module would have too many sampler views).
When a tex
https://bugs.freedesktop.org/show_bug.cgi?id=109159
--- Comment #4 from Samuel Pitoiset ---
Any news on this?
This test always pass on my side.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.__
Looking at this a bit more, I'm not sure that just short-circuiting
actually covers all the cases. Unfortunately, we don't know what all the
cases are because the SPIR-V spec doesn't say. I'm trying to work towards
fixing that right now.
--Jason
On Wed, Mar 6, 2019 at 5:25 AM Juan A. Suarez Rom
https://bugs.freedesktop.org/show_bug.cgi?id=107563
Samuel Pitoiset changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Alyssa Rosenzweig writes:
> This function is replicated across vc4/v3d/freedreno and is needed in
> Panfrost; let's make this shared code.
>
> Signed-off-by: Alyssa Rosenzweig
> ---
> src/util/u_drm.h | 46 ++
> 1 file changed, 46 insertions(+)
> cre
Hi Brian,
On Thursday, 14 March 2019 14:55:11 CET Brian Paul wrote:
> yeah, looks good. Thanks.
>
> Reviewed-by: Brian Paul
>
> I don't remember- do you need me to push your patches for you?
Thanks for the review!
I have rights to push.
Thanks for asking!!
best
Mathias
__
> hmm, I guess there are already two or three other places that already
> copy/pasta'd this specifically for modifiers.. so I'm ok with the less
> generic name, since it (IMHO) makes the code calling it more clear.
This was my reasoning, yeah... I'm not sure why it is so generic,
honestly (should
Reviewed-by: Alyssa Rosenzweig
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #5 from Timur Kristóf ---
Okay, I think I got it. Can you please try with this patch:
https://gitlab.freedesktop.org/Venemo/mesa/commit/c1efd5b26d210b017118d29ecf16aaaeeb34a420
It gets rid of the problem for me.
--
You are receivi
Two ioctls had wrong DRM_IO* flags.
Signed-off-by: Tomeu Vizoso
---
include/drm-uapi/panfrost_drm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm-uapi/panfrost_drm.h b/include/drm-uapi/panfrost_drm.h
index a0ead4979ccc..508b9621d9db 100644
--- a/include/drm-
On Thu, Mar 14, 2019 at 4:09 AM Juan A. Suarez Romero
wrote:
> On Fri, 2019-03-08 at 13:29 -0600, Jason Ekstrand wrote:
>
> On Fri, Mar 8, 2019 at 9:30 AM Juan A. Suarez Romero
> wrote:
>
> On Thu, 2019-03-07 at 07:15 -0600, Jason Ekstrand wrote:
> > Woah, is this legal SPIR-V? I think a second
On 03/14/2019 12:24 AM, Mathias Fröhlich wrote:
Hi Brian,
On Sunday, 10 March 2019 21:32:39 CET Brian Paul wrote:
On Friday, 8 March 2019 23:52:09 CET Brian Paul wrote:
After a while of running google-chrome and viewing Bing maps, we'd see
"context mismatch in svga_sampler_view_destroy()" mess
r-b
On Thu, Mar 14, 2019 at 2:24 PM Samuel Pitoiset
wrote:
>
> HTILE should always be initialized when transitioning from
> VK_IMAGE_LAYOUT_UNDEFINED to other image layouts. Otherwise,
> if an app does a transition from UNDEFINED to GENERAL, the
> driver doesn't initialize HTILE and it tries to d
On 03/14/2019 06:33 AM, mathias.froehl...@gmx.net wrote:
From: Mathias Fröhlich
Hi Brian,
You mean an assert like this?
yeah, looks good. Thanks.
Reviewed-by: Brian Paul
I don't remember- do you need me to push your patches for you?
-Brian
This patch also made it together with the re
HTILE should always be initialized when transitioning from
VK_IMAGE_LAYOUT_UNDEFINED to other image layouts. Otherwise,
if an app does a transition from UNDEFINED to GENERAL, the
driver doesn't initialize HTILE and it tries to decompress
the depth surface. For some reasons, this results in VM fault
On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote:
>
> Am 12.03.19 um 16:16 schrieb Rob Clark:
> > This previously was not called out clearly, but based on a survey of the
> > code, it seems the expected behavior is to release the reference to any
> > sampler views beyond the new range bein
On Thu, Mar 14, 2019 at 12:19 AM Alyssa Rosenzweig wrote:
>
> Signed-off-by: Alyssa Rosenzweig
> Cc: Rob Clark
thanks, r-b
> ---
> .../drivers/freedreno/freedreno_resource.c| 20 ---
> 1 file changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/src/gallium/drivers/f
On Thu, Mar 14, 2019 at 5:51 AM Eric Engestrom wrote:
>
> On Thursday, 2019-03-14 04:19:02 +, Alyssa Rosenzweig wrote:
> > This function is replicated across vc4/v3d/freedreno and is needed in
> > Panfrost; let's make this shared code.
> >
> > Signed-off-by: Alyssa Rosenzweig
> > ---
> > src
From: Mathias Fröhlich
Hi Brian,
You mean an assert like this?
This patch also made it together with the rest of the series through intels CI.
best
Mathias
Make sure the inde_size parameter is meant to be in bytes.
Signed-off-by: Mathias Fröhlich
---
src/mesa/main/varray.h | 3 +++
1 f
From: Mathias Fröhlich
Brian,
For reference the v2 with the updated comments.
Thanks and best
Mathias
Provide a set of functions that maps or unmaps all VBOs held
in a VAO. The functions will be used in the following patches.
v2: Update comments.
Signed-off-by: Mathias Fröhlich
---
src/me
On 13/3/19 23:17, Emil Velikov wrote:
> Hi Jose,
>
> On Wed, 21 Nov 2018 at 18:45, Jose Maria Casanova Crespo
> wrote:
>>
>> Fixes:
>> KHR-GLES*.core.tessellation_shader.single.xfb_captures_data_from_correct_stage
>>
> This and the follow-up patch "glsl: fix recording of variables for XFB
> in T
On Thursday, 2019-03-14 04:19:02 +, Alyssa Rosenzweig wrote:
> This function is replicated across vc4/v3d/freedreno and is needed in
> Panfrost; let's make this shared code.
>
> Signed-off-by: Alyssa Rosenzweig
> ---
> src/util/u_drm.h | 46 ++
> 1
On Fri, 2019-03-08 at 13:29 -0600, Jason Ekstrand wrote:
> On Fri, Mar 8, 2019 at 9:30 AM Juan A. Suarez Romero
> wrote:
> > On Thu, 2019-03-07 at 07:15 -0600, Jason Ekstrand wrote:
> >
> > > Woah, is this legal SPIR-V? I think a second OpSelectionMerge is required.
> >
> >
> >
> > I'd say it
https://bugs.freedesktop.org/show_bug.cgi?id=109764
soredake changed:
What|Removed |Added
CC||fds...@krutt.org
--
You are receiving this
https://bugs.freedesktop.org/show_bug.cgi?id=108596
soredake changed:
What|Removed |Added
CC||fds...@krutt.org
--
You are receiving this
https://bugs.freedesktop.org/show_bug.cgi?id=110078
Michel Dänzer changed:
What|Removed |Added
Status|NEW |RESOLVED
Product|Mesa
https://bugs.freedesktop.org/show_bug.cgi?id=105904
Andre Klapper changed:
What|Removed |Added
QA Contact|dani.ta...@outlook.com |mesa-dev@lists.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=98135
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=98243
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=99076
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=98223
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=98133
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=98241
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=98245
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=98242
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=98132
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=94116
Andre Klapper changed:
What|Removed |Added
Blocks|110097 |
--
You are receiving this mail because
1 - 100 of 125 matches
Mail list logo
