[Mesa-dev] [Bug 109443] Build failure with MSVC 2017 when using Scons >= 3.0.2

2019-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109443 Alex Granni changed: What|Removed |Added Summary|Build failure with MSVC |Build failure with MSVC

Re: [Mesa-dev] [PATCH 1/3] egl/sl: split out swrast probe into separate function

2019-02-17 Thread Mathias Fröhlich
Emil, indeed this is easier to read. For patch #1 and #2 you get Reviewed-by: Mathias Fröhlich For patch #3, I don't know vgem good enough to judge the big picture. The change within mesa itself looks technically correct. best Mathias On Tuesday, 5 February 2019 16:31:06 CET Emil Velikov

Re: [Mesa-dev] [PATCH] intel: Add more PCI Device IDs for Coffee Lake and Ice Lake.

2019-02-17 Thread Jonathan Gray
Compared to linux and libdrm Mesa is missing a VLV and ICL id. 0x0f30 ff049b6ce21d2814451afd4a116d001712e0116b drm/i915: bind driver to ValleyView chipsets 0x8A70 d55cb4fa2cf0105bfb16b60a2846737b91fdc173 drm/i915/icl: Add the ICL PCI IDs The Intel Media SDK describes these as /* VLV */

[Mesa-dev] [PATCH] panfrost: Stub out separate stencil functions

2019-02-17 Thread Alyssa Rosenzweig
This is not yet functional, but it resolves a crash in various apps and provides a framework for further work. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 27 ++--- src/gallium/drivers/panfrost/pan_resource.h | 2 ++ 2 files changed, 25 ins

[Mesa-dev] [PATCH 4/7] panfrost: Update extended branch disassembly

2019-02-17 Thread Alyssa Rosenzweig
Partial support was previously included in the disassembler, but based on a buggy form of the ISA. This corrects the disassembly. Additionally, we now prefix extended branches with "brx", to visually differentiate from compact branches prefixed with "br". Signed-off-by: Alyssa Rosenzweig --- src

[Mesa-dev] [PATCH 3/7] panfrost: Rectify doubleplusungood extended branch

2019-02-17 Thread Alyssa Rosenzweig
Midgard features "compact branches" and "extended branches", i.e. corresponds to short jumps and far jumps. The form of the extended branch was previously incorrect in the ISA headers; this patch corrects it. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard.h | 3

[Mesa-dev] [PATCH 7/7] panfrost: Verify and print brx condition in disasm

2019-02-17 Thread Alyssa Rosenzweig
The condition code in extended branches is repeated 8 times for unclear reasons; accordingly, the code would be disassembled as "unknown", "unknown", etc. This patch correctly masks off the lower two bits to find the true code to print, verifying that the code is repeated as believed to be

[Mesa-dev] [PATCH 6/7] panfrost: Dynamically set discard branch targets

2019-02-17 Thread Alyssa Rosenzweig
discard and discard_if are both implemented with the branching pipeline on Midgard; essentially, we branch to the end of the fragment shader in a special "discard" mode, setting the condition as necessary. Previously, we hardcoded the form of this instruction, which worked for very simple shaders b

[Mesa-dev] [PATCH 5/7] panfrost/midgard: Emit extended branches

2019-02-17 Thread Alyssa Rosenzweig
Previously, we only emitted compact branches; however, the offset range of these branches is too small for many real world shaders. This patch implements support for emitting extended branches and switches to always using them for control flow. This incurs a code size and possibly performance penal

[Mesa-dev] [PATCH 0/7] panfrost: Improve branching in Midgard compiler

2019-02-17 Thread Alyssa Rosenzweig
This patch series generally improves the state of branching in the Midgard compiler. Notably, in addition to resolving a number of bugs breaking branching in real apps, it implements support for extended branches (far jumps). In total, the series enables much more sophisticated branching, fixing a

[Mesa-dev] [PATCH 2/7] panfrost/midgard: Fix nested/chained if-else

2019-02-17 Thread Alyssa Rosenzweig
An if-else statement is compiled to a conditional branch (from the start to the second block) and an unconditional branch (from the end of the first block to the end of the else). We previously incorrectly computed the block index of the unconditional branch to be exactly one after that of the cond

[Mesa-dev] [PATCH 1/7] panfrost/midgard: Refactor tag lookahead code

2019-02-17 Thread Alyssa Rosenzweig
Each Midgard instruction is scheduled to a particular instruction type ("tag"). Presumably the hardware prefetches memory based on tag, so it is required to report out the first tag to the command stream and the next tag of a branch target. This procedure was implemented in two separate parts of th

[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

2019-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99553 Bug 99553 depends on bug 108572, which changed state. Bug 108572 Summary: Could not start gimp (probably due to opencl) https://bugs.freedesktop.org/show_bug.cgi?id=108572 What|Removed |Added ---

[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

2019-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99553 Timothy Arceri changed: What|Removed |Added Depends on||108572 Referenced Bugs: https://bugs.

Re: [Mesa-dev] [PATCH] i965: Be resilient in the face of GPU hangs

2019-02-17 Thread Kenneth Graunke
On Saturday, February 16, 2019 4:46:27 AM PST Chris Wilson wrote: > If we hang the GPU and end up banning our context, we will no longer be > able to submit and abort with an error (exit(1) no less). As we submit > minimal incremental batches that rely on the logical context state of > previous bat

Re: [Mesa-dev] [PATCH v2 2/3] i965: Add INTEL_DEBUG=hang

2019-02-17 Thread Kenneth Graunke
On Saturday, February 16, 2019 4:41:30 AM PST Chris Wilson wrote: > Introduce a new debug option to wilfully cause the GPU to hang and for > the kernel to accuse of being neglectful. > --- > src/intel/Makefile.sources| 2 + > src/intel/common/gen_debug.c |