[Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for structs

2019-01-21 Thread Timothy Arceri
This fixes the arb_gpu_shader5 interpolateAt* tests that contain structs. --- Extra piglit tests for structs: https://patchwork.freedesktop.org/patch/279466/ src/amd/common/ac_nir_to_llvm.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/amd

[Mesa-dev] [PATCH 1/2] radeonsi/nir: add missing piece for bindless image support

2019-01-21 Thread Timothy Arceri
This fixes some piglit tests and is was TGSI does. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 65da6384c7..0ac737a062 100644 --- a/src/g

[Mesa-dev] [PATCH 2/2] ac/nir_to_llvm: add bindless support for uniform handles

2019-01-21 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 28 1 file changed, 28 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index c558873bbe..161a8b2c34 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2019-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #76 from Thomas Crider --- I found the issue - I had my mesa compiled without glvnd due to an issue with it and dying light. the glxcmds patch only works without glvnd. I would need to patch that portion into libglvnd for it to work,

Re: [Mesa-dev] [PATCH v3 25/42] intel/compiler: workaround for SIMD8 half-float MAD in gen8

2019-01-21 Thread Jason Ekstrand
On Mon, Jan 21, 2019 at 4:55 AM Iago Toral wrote: > On Fri, 2019-01-18 at 11:51 -0600, Jason Ekstrand wrote: > > On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga > wrote: > > Broadwell hardware has a bug that manifests in SIMD8 executions of > 16-bit MAD instructions when any of the sources is

Re: [Mesa-dev] [PATCH] nir: Mark deref UBO and SSBO access as non-scalar

2019-01-21 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Jan 21, 2019 at 11:38 PM Jason Ekstrand wrote: > > Fixes: 63b9aa2e2574 "spirv: Add support for using derefs for..." > --- > src/compiler/nir/nir_lower_phis_to_scalar.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/compiler

[Mesa-dev] [PATCH] nir: Mark deref UBO and SSBO access as non-scalar

2019-01-21 Thread Jason Ekstrand
Fixes: 63b9aa2e2574 "spirv: Add support for using derefs for..." --- src/compiler/nir/nir_lower_phis_to_scalar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_phis_to_scalar.c b/src/compiler/nir/nir_lower_phis_to_scalar.c index 3d7155c04f6..41ae

[Mesa-dev] [Bug 109405] [BISECTED] [REGRESSION] KHR-GL45.enhanced_layouts.glsl_contant_immutablity aborts in second execution

2019-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109405 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH mesa] configure: EGL requirements only apply if EGL is built

2019-01-21 Thread Eric Engestrom
Fixes: 2c4f6ceeb466cb15df34 "configure.ac: Fail if egl x11 platform dependencies are not available" Signed-off-by: Eric Engestrom --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index c7473d77eff2345145ff..7530f65ad4a09

[Mesa-dev] [PATCH v11 15/20] clover/spirv: Add functions for validating SPIR-V binaries

2019-01-21 Thread Pierre Moreau
Changes since: * v10: - Reuse format_validation_msg in is_valid_spirv. - Remove LVL2STR macro in format_validation_msg. * v9: Add `clover_cpp_std` to the overrides of the `libclspirv` target in Meson. * v7: Add DEFINES to libclspirv and libclover, in autotools, as they would otherwi

Re: [Mesa-dev] [PATCH v3 21/42] intel/compiler: set correct precision fields for 3-source float instructions

2019-01-21 Thread Jason Ekstrand
On Mon, Jan 21, 2019 at 3:17 AM Iago Toral wrote: > On Fri, 2019-01-18 at 06:54 -0600, Jason Ekstrand wrote: > > > On January 18, 2019 04:47:51 Iago Toral wrote: > > On Thu, 2019-01-17 at 14:18 -0600, Jason Ekstrand wrote: > > On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga > wrote: > > Sour

Re: [Mesa-dev] [PATCH v3 02/42] intel/compiler: add a NIR pass to lower conversions

2019-01-21 Thread Jason Ekstrand
On Mon, Jan 21, 2019 at 2:09 AM Iago Toral wrote: > On Fri, 2019-01-18 at 06:46 -0600, Jason Ekstrand wrote: > > On January 18, 2019 01:48:25 Iago Toral wrote: > > On Thu, 2019-01-17 at 13:42 -0600, Jason Ekstrand wrote: > > On Tue, Jan 15, 2019 at 7:54 AM Iago Toral Quiroga > wrote > > > (...)

[Mesa-dev] [Bug 109405] [BISECTED] [REGRESSION] KHR-GL45.enhanced_layouts.glsl_contant_immutablity aborts in second execution

2019-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109405 --- Comment #1 from tele4...@hotmail.com --- Hello, this commit was backed out and replaced by https://gitlab.freedesktop.org/mesa/mesa/commit/6ca652faf368427e3e6d57ef5456f78203b8207e . Did your bisect account for this? -- You are receiving thi

[Mesa-dev] [Bug 109405] [BISECTED] [REGRESSION] KHR-GL45.enhanced_layouts.glsl_contant_immutablity aborts in second execution

2019-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109405 Bug ID: 109405 Summary: [BISECTED] [REGRESSION] KHR-GL45.enhanced_layouts.glsl_contant_immutablity aborts in second execution Product: Mesa Version: git

Re: [Mesa-dev] Double free error on etnaviv driver.

2019-01-21 Thread Nazarov Sergey
Hi, Lucas! Yes, it works. So, it's not a Mesa problem, it's buildroot problem. Thanks, Sergey. 18.01.2019, 18:26, "Lucas Stach" : > Hi Sergey, > > I've just been made aware of a peculiarity of the buildroot toolchain > configuration, which might well explain why you are seeing the obvious > crash,

[Mesa-dev] Add extension EXT_sRGB_write_control

2019-01-21 Thread Gert Wollny
Dear all, I'd like to push this series [1] to enable the extension EXT_sRGB_write control by the end of this week if there are no objections. I ran it trough the intel-ci [2] with only some unrelated unstable tests. many thanks for any reviews, Gert [1] https://gitlab.freedesktop.org/

Re: [Mesa-dev] [PATCH v3 00/42] intel: VK_KHR_shader_float16_int8 implementation

2019-01-21 Thread Iago Toral
I think you covered everithing at this point, thanks Jason!I am addressing all your review feedback and will send a v4 when I have everything ready. On Fri, 2019-01-18 at 14:23 -0600, Jason Ekstrand wrote: > I think I've gotten through everything at this point. If I've missed > anything, please le

Re: [Mesa-dev] [PATCH v3 26/42] intel/compiler: split is_partial_write() into two variants

2019-01-21 Thread Iago Toral
On Fri, 2019-01-18 at 14:23 -0600, Jason Ekstrand wrote: > Ugh... I really don't like this... But I also don't have a better > idea off-hand. The unfortunate reality is that this IR really isn't > designed to be able to handle this sort of thing. My #1 concern here > is that I don't think it doe

Re: [Mesa-dev] [PATCH 2/8] i965: r8stencil_mt/needs_update renamed to shadow_mt/needs_update

2019-01-21 Thread Eleni Maria Stea
On 1/19/19 12:55 AM, Nanley Chery wrote: > The series I pointed you to earlier has a patch like this, but it's more > complete. It also modifies the comment above the data structure being > modified. Do you want to review it? > > https://patchwork.freedesktop.org/patch/253197/ > > I think what pe

Re: [Mesa-dev] [PATCH v3 25/42] intel/compiler: workaround for SIMD8 half-float MAD in gen8

2019-01-21 Thread Iago Toral
On Fri, 2019-01-18 at 11:51 -0600, Jason Ekstrand wrote: > On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga > wrote: > > Broadwell hardware has a bug that manifests in SIMD8 executions of > > > > 16-bit MAD instructions when any of the sources is a Y or W > > component. > > > > We pack these c

Re: [Mesa-dev] [PATCH] anv: Only parse pImmutableSamplers if the descriptor has samplers

2019-01-21 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 19/01/2019 19:04, Jason Ekstrand wrote: --- src/intel/vulkan/anv_descriptor_set.c | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c

Re: [Mesa-dev] [PATCH v3 21/42] intel/compiler: set correct precision fields for 3-source float instructions

2019-01-21 Thread Iago Toral
On Fri, 2019-01-18 at 06:54 -0600, Jason Ekstrand wrote: > > > > > > On January 18, 2019 04:47:51 Iago Toral wrote: > > On Thu, 2019-01-17 at 14:18 -0600, Jason Ekstrand wrote: > > > On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga < > > > ito...@igalia.com> wrote: > > > > Source0 and Desti

Re: [Mesa-dev] [PATCH 4/4] etnaviv: hook up linear texture sampling support

2019-01-21 Thread Lucas Stach
Am Montag, den 21.01.2019, 07:50 +0100 schrieb Christian Gmeiner: > If the GPU supports linear sampling, linear addressing mode > will be used as default. > > > Signed-off-by: Christian Gmeiner > --- >  src/gallium/drivers/etnaviv/etnaviv_resource.c | 10 +++--- >  src/gallium/drivers/etnaviv/

Re: [Mesa-dev] [PATCH 1/4] etnaviv: extend etna_resource with an addressing mode

2019-01-21 Thread Lucas Stach
Hi Christian, first of all, thanks for figuring this out. This is really nice to finally know how it works. Am Montag, den 21.01.2019, 07:49 +0100 schrieb Christian Gmeiner: > Defines how sampler (and pixel pipes) needs to access the data > represented with a resource. The used default is mode is

Re: [Mesa-dev] [PATCH v3 02/42] intel/compiler: add a NIR pass to lower conversions

2019-01-21 Thread Iago Toral
On Fri, 2019-01-18 at 06:46 -0600, Jason Ekstrand wrote: > On January 18, 2019 01:48:25 Iago Toral wrote: > > > On Thu, 2019-01-17 at 13:42 -0600, Jason Ekstrand wrote: > > > On Tue, Jan 15, 2019 at 7:54 AM Iago Toral Quiroga < > > > ito...@igalia.com> wrote (...) > > > > + nir_ssa_def *tmp =