[Mesa-dev] [Bug 108596] The Gallium3D Heads-Up Display (HUD) not available under Vulkan.

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108596 Bug ID: 108596 Summary: The Gallium3D Heads-Up Display (HUD) not available under Vulkan. Product: Mesa Version: 18.2 Hardware: Other OS: All St

[Mesa-dev] [PATCH] egl_dri2: check if driver_name is NULL before releasing it

2018-10-29 Thread Zhaowei Yuan
Pointer dri2_dpy->driver_name is probably NULL when calling dri2_display_destory, check this before releasing it. Signed-off-by: Zhaowei Yuan --- src/egl/drivers/dri2/egl_dri2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/driver

Re: [Mesa-dev] [PATCH] i965: Respect GL_TEXTURE_SRGB_DECODE_EXT in GenerateMipmaps()

2018-10-29 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/30/18 2:01 AM, Kenneth Graunke wrote: Apparently, we're supposed to look at the texture object's built-in sampler object's sRGB decode setting in order to decide whether to decode/downsample/re-encode, or simply downsample as-is. Previously, I had always done th

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #12 from Ahmed Elsayed --- Created attachment 142271 --> https://bugs.freedesktop.org/attachment.cgi?id=142271&action=edit Mafia 3 after the last update It looks better now, but still needs some improvements. -- You are receivin

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #11 from Ahmed Elsayed --- I made a system restore to roll back to the stable Mesa release, and installed the new Mesa 18.3 driver released yesterday. The Witcher III: still the same. Mafia III: the graphic glitches decreased but s

[Mesa-dev] [PATCH 15/15] anv/android: turn on VK_ANDROID_external_memory_android_hardware_buffer

2018-10-29 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_extensions.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index ab9240f9fd8..ca414284fdd 100644 --- a/src/intel/vulkan/anv_extensions.py +++ b/src/intel/vulkan/anv

[Mesa-dev] [PATCH 10/15] anv/android: support creating images from external format

2018-10-29 Thread Tapani Pälli
Since we don't know the exact format at creation time, some initialization is done only when bound with memory in vkBindImageMemory. v2: demand dedicated allocation in vkGetImageMemoryRequirements2 if image has external format v3: refactor prepare_ahw_image, support vkBindImageMemory2, ca

[Mesa-dev] [PATCH 11/15] anv: support VkExternalFormatANDROID in vkCreateSamplerYcbcrConversion

2018-10-29 Thread Tapani Pälli
If external format is used, we store the external format identifier in conversion to be used later when creating VkImageView. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/intel/vulkan/anv_formats.c b/src/i

[Mesa-dev] [PATCH 13/15] anv: support VkSamplerYcbcrConversionInfo in vkCreateImageView

2018-10-29 Thread Tapani Pälli
If a conversion struct was passed, then we resolve the format from conversion structure. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_image.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 14/15] anv: ignore VkSamplerYcbcrConversion on non-yuv formats

2018-10-29 Thread Tapani Pälli
This fulfills a requirement for clients that want to utilize same code path for images with external formats (VK_FORMAT_UNDEFINED) and "regular" RGBA images where format is known. This is similar to how OES_EGL_image_external works. To support this, we allow color conversion samplers for non-YUV f

[Mesa-dev] [PATCH 08/15] anv/android: support import/export of AHardwareBuffer objects

2018-10-29 Thread Tapani Pälli
v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB) v3: properly handle usage bits when creating from image v4: refactor, code cleanup (Jason) Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c | 128 + src/intel/vulkan/anv_device.c |

[Mesa-dev] [PATCH 12/15] anv: introduce helper to resolve vk_format from anv_format

2018-10-29 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 18 ++ src/intel/vulkan/anv_private.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index 1d3b1f67928..166b50f5a07 100644 --- a/src/intel/vu

[Mesa-dev] [PATCH 09/15] anv/android: add ahardwarebuffer external memory properties

2018-10-29 Thread Tapani Pälli
v2: have separate memory properties for android, set usage flags for buffers correctly v3: code cleanup (Jason) + limit maxArrayLayers to 1 for AHardwareBuffer based images Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 46 ++ 1 file cha

[Mesa-dev] [PATCH 05/15] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

2018-10-29 Thread Tapani Pälli
Use the anv_format address in formats table as implementation-defined external format identifier for now. When adding YUV format support this might need to change. v2: code cleanup (Jason) v3: set anv_format address as identifier Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c |

[Mesa-dev] [PATCH 04/15] anv: add from/to helpers with android and vulkan formats

2018-10-29 Thread Tapani Pälli
v2: handle R8G8B8X8 as R8G8B8_UNORM (Jason) Signed-off-by: Tapani Pälli --- src/intel/vulkan/vk_format_info.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/src/intel/vulkan/vk_format_info.h b/src/intel/vulkan/vk_format_info.h index a1cc6952c8f..2990e23c601

[Mesa-dev] [PATCH 06/15] anv: add anv_ahw_usage_from_vk_usage helper function

2018-10-29 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c | 31 +++ src/intel/vulkan/anv_private.h | 3 +++ 2 files changed, 34 insertions(+) diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c index 67e9adee73e..d0a20dd85c5 100644 --- a

[Mesa-dev] [PATCH 07/15] anv: refactor, remove else block in AllocateMemory

2018-10-29 Thread Tapani Pälli
This makes it cleaner to introduce more cases where we import memory from different types of external memory buffers. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_device.c | 64 +++ 1 file changed, 34 insertions(+), 30 deletions(-) diff --git a/src/intel/

[Mesa-dev] [PATCH 00/15] VK_ANDROID_external_memory_android_hardware_buffer

2018-10-29 Thread Tapani Pälli
Hi; Here are fixes to earlier series with some refactoring, addressing Jason's comments and fixing some bugs I found when running Android CTS suite. With these changes following android.graphics.cts.BasicVulkanGpuTest tests start to pass: testBasicBufferImportAndRenderingExternalFormat test

[Mesa-dev] [PATCH 02/15] anv: refactor make_surface to use data from anv_image

2018-10-29 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_image.c | 78 ++ src/intel/vulkan/anv_private.h | 5 +++ 2 files changed, 46 insertions(+), 37 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index c92e032a239..be467815

[Mesa-dev] [PATCH 01/15] anv: add create_flags as part of anv_image

2018-10-29 Thread Tapani Pälli
This will make it possible for next patch to rip anv_image_create_info out from make_surface function. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_image.c | 1 + src/intel/vulkan/anv_private.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/int

[Mesa-dev] [PATCH 03/15] anv: make anv_get_image_format_features public

2018-10-29 Thread Tapani Pälli
This will be utilized later by GetAndroidHardwareBufferPropertiesANDROID. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 22 +++--- src/intel/vulkan/anv_private.h | 5 + 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/anv_f

[Mesa-dev] [PATCH 12/14] mesa/vbo: Move src/mesa/vbo/vbo_exec_array.c -> src/mesa/main/draw.c

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich The array type draw is no longer directly dependent on the vbo module. Thus move array type draws into mesa/main/draw.c. Rename symbols starting with vbo_* to _mesa_* and apply some reindenting to make it consistent. Signed-off-by: Mathias Fröhlich --- src/mapi/glapi/gen

[Mesa-dev] [PATCH 05/14] vbo: Test for VBO_SAVE_PRIM_WEAK in _mesa_prim::mode is false.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich When setting the _mesa_prim::mode field we always filter out all non OpenGL primitive mode bits. So this tested bit cannot be there anymore and the test evaluates to zero. The zero is removed with the next patch to ease review. Signed-off-by: Mathias Fröhlich --- src/mes

[Mesa-dev] [PATCH 10/14] vbo: Preserve vbo_save::no_current_update on primitive restart.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich With this change we preserve the no_current_update property when we observe a glPrimitiveRestart call. That means that we now also get the no_current_update optimization for display lists that are made out of indexed draws using primitive restart. Signed-off-by: Mathias Fr

[Mesa-dev] [PATCH 11/14] vbo: Pull the _mesa_set_draw_vao calls out of the if clauses.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich These calls are just the same in each if branch. So pull that before the if. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_array.c | 114 -- 1 file changed, 38 insertions(+), 76 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_

[Mesa-dev] [PATCH 09/14] vbo: Make no_current_update an argument to vbo_save_NotifyBegin.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Instead of coding additional information into the primitive mode, make the only remaining flag there a direct argument to vbo_save_NotifyBegin. Signed-off-by: Mathias Fröhlich --- src/mesa/main/dlist.c | 2 +- src/mesa/vbo/vbo.h | 3 ++- src/mesa/vbo/vbo

[Mesa-dev] [PATCH 14/14] mesa: Collect all the draw functions in draw.{h, c}.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Some of these functions were distributed across different implementation and header files. Put them at a central place. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 1 + src/mesa/main/draw.c | 43 ++ src/mesa/main/dr

[Mesa-dev] [PATCH 13/14] mesa/vbo: Move _vbo_draw_indirect -> _mesa_draw_indirect

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/driverfuncs.c | 4 +- src/mesa/main/draw.c | 74 +++ src/mesa/main/draw.h | 11 src/mesa/vbo/vbo.h| 10 src/mesa/vbo/vbo_co

[Mesa-dev] [PATCH 07/14] vbo: Remove the now unused VBO_SAVE_PRIM_WEAK define.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index d00700166e..65293c93f0 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo/vbo_save.h @@ -137,7 +137,

[Mesa-dev] [PATCH 02/14] vbo: Remove the VBO_SAFE_FALLBACK flag.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich On finishing a display list playback the VBO_SAFE_FALLBACK bit is still kept in vbo_save_context::replay_flags. But examining replay_flags and the display list flags that feed this value the corresponding bit is never set these days anymore. So, since it is nowhere set or c

[Mesa-dev] [PATCH 06/14] vbo: Remove the always false branch dlist replay.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich The previous patch left a constant if (0) in the code. Clean that up now. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save_loopback.c | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/src/mesa/vbo/vbo_save_loopbac

[Mesa-dev] [PATCH 04/14] vbo: Remove VBO_SAVE_PRIM_WEAK from vbo_save_NotifyBegin calls.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Now looking at the implementation of vbo_save_NotifyBegin. The VBO_SAVE_PRIM_WEAK flag, delivered in the primitive mode argument to vbo_save_NotifyBegin, is not evaluated anymore. The two users of the mode argument are the primitive mode itself, where the VBO_SAVE_PRIM_WEAK

[Mesa-dev] [PATCH 03/14] vbo: Remove set but not used weak field from _mesa_prim.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich The only reader of the weak field in _mesa_prim is pretty console printing. By that, remove the weak field from _mesa_prim. Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker/st_cb_rasterpos.c | 1 - src/mesa/vbo/vbo.h | 3 +-- src/mesa/vbo/

[Mesa-dev] [PATCH 08/14] vbo: Move no_current_update out of _mesa_prim.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich The _mesa_prim::no_current_update flag should tell the compiled display list if the current attributes that are placed in the dlists vbo shall take a defined state past replay of a display list. Immediate mode draws compiled into display lists should set the current values.

[Mesa-dev] [PATCH 01/14] vbo: Remove unused vbo_save_fallback function.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save.c | 15 --- src/mesa/vbo/vbo_save.h | 1 - 2 files changed, 16 deletions(-) diff --git a/src/mesa/vbo/vbo_save.c b/src/mesa/vbo/vbo_save.c index 73bc49a24b..7e77123ba8 100644 --- a/src/mesa/vbo/vbo_sa

[Mesa-dev] [PATCH 00/14] Various cleanups on display lists and draw code.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, The series collects some of that cleanup opportunities that I found while working on the vao changes from this spring. There are two groups of changes. The first bunch removes unreachable code paths from the dlist code and removes related functions and flags. That is a

[Mesa-dev] [PATCH] i965: Respect GL_TEXTURE_SRGB_DECODE_EXT in GenerateMipmaps()

2018-10-29 Thread Kenneth Graunke
Apparently, we're supposed to look at the texture object's built-in sampler object's sRGB decode setting in order to decide whether to decode/downsample/re-encode, or simply downsample as-is. Previously, I had always done the decoding/encoding. Fixes SKQP's Skia_Unit_Tests.SRGBMipMaps test. ---

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/1] util: Change remaining uint32 cache ids to sha1

2018-10-29 Thread Timothy Arceri
On 26/10/18 9:18 pm, Juan A. Suarez Romero wrote: On Fri, 2018-10-26 at 14:52 +1100, Timothy Arceri wrote: Pushed. Thanks again! Ccing stable in case the Fixes tag isnt enough for this to get picked up (since the previous cache fix this fixes was also backported) Enqueued for 18.2. I didn't

Re: [Mesa-dev] [PATCH] glsl/linker: Fix out variables linking during single stage

2018-10-29 Thread Timothy Arceri
On 29/10/18 10:05 pm, Vadim Shovkoplias wrote: Hi Timothy, Thanks for the review. Piglit patch is updated with the additional out var: https://patchwork.freedesktop.org/patch/258899/ Original reporter confirmed that issue is finally fixed with the current patch and closed it. Can I ask to pu

[Mesa-dev] [ANNOUNCE] Mesa 18.2.4 release candidate

2018-10-29 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.4 is now available. Currently we have: - 22 queued - 0 nominated (outstanding) - and 1 rejected patch The current queue consists of: Different fixes for different drivers: freedreno, radeonsi, swr, anv and radv. Also there are fixes for ac, gallium

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add support for Raven2

2018-10-29 Thread Marek Olšák
On Sat, Oct 27, 2018 at 4:35 AM Gustaw Smolarczyk wrote: > sob., 27 paź 2018 o 04:28 Marek Olšák napisał(a): > > > > From: Marek Olšák > > > > --- > > src/amd/addrlib/amdgpu_asic_addr.h | 2 ++ > > src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +- > > src/amd/common/ac_gpu_i

[Mesa-dev] [PATCH] radeonsi: add support for Raven2 (v2)

2018-10-29 Thread Marek Olšák
From: Marek Olšák v2: fix enabling primitive binning --- src/amd/addrlib/amdgpu_asic_addr.h | 2 ++ src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +- src/amd/common/ac_gpu_info.c| 6 ++ src/amd/common/ac_llvm_util.c | 2 ++ src/amd

Re: [Mesa-dev] [PATCH 05/15] ac: revert new LLVM 7.0 behavior for fdiv

2018-10-29 Thread Marek Olšák
Fixed in master. Marek On Mon, Oct 29, 2018 at 6:50 AM Connor Abbott wrote: > ctx->f32_1 probably needs to be replaced by the appropriately-sized > float, like LLVMConstReal(1., ...) > On Mon, Oct 29, 2018 at 11:45 AM Timothy Arceri > wrote: > > > > Hi Marek, > > > > It's late and I haven't du

Re: [Mesa-dev] [PATCH 1/3] radeonsi/gfx9: set optimal OVERWRITE_COMBINER_WATERMARK

2018-10-29 Thread Marek Olšák
The values can't be set per CB. Marek On Mon, Oct 29, 2018 at 7:04 AM Samuel Pitoiset wrote: > Are the values similar when they are set per CB instead of globally? > > On 10/27/18 4:28 AM, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/gallium/drivers/radeonsi/si_pipe.h | 1 +

Re: [Mesa-dev] [PATCH 11/11] util: move u_cpu_detect to util

2018-10-29 Thread Dylan Baker
Quoting Brian Paul (2018-10-29 12:24:13) > On 10/29/2018 12:57 PM, Dylan Baker wrote: > > CC: v...@freedesktop.org > > CC: Roland Scheidegger > > Bugzilla: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2Fshow_bug.cgi%3Fid%3D107870&data=02%7C01%7Cbrianp%

Re: [Mesa-dev] [PATCH] i965/icl: Disable prefetching of sampler state entries

2018-10-29 Thread Kenneth Graunke
On Wednesday, October 24, 2018 11:33:53 AM PDT Anuj Phogat wrote: > From: Topi Pohjolainen > > In the same spirit as commit a5889d70f2074201ceaeac4f96a9a0c0b1f68a31 > "i965/icl: Disable binding table prefetching". Fixes some 110+ > intermittent piglit failures with tex-miplevel-selection variants

Re: [Mesa-dev] [PATCH 11/11] util: move u_cpu_detect to util

2018-10-29 Thread Brian Paul
On 10/29/2018 12:57 PM, Dylan Baker wrote: > CC: v...@freedesktop.org > CC: Roland Scheidegger > Bugzilla: > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2Fshow_bug.cgi%3Fid%3D107870&data=02%7C01%7Cbrianp%40vmware.com%7Cc877b18570db4c38c0dc08d63dd09044%7Cb

[Mesa-dev] [PATCH] Revert "imx: make use of loader_open_render_node(..) helper"

2018-10-29 Thread Christian Gmeiner
This reverts commit 773d6ea6e715d207bda3a53a9dfc8acf686035b0. Since kernel 4.17 (drm/etnaviv: remove the need for a gpu-subsystem DT node) the etnaviv DRM driver doesn't have an associated DT node anymore. This is technically correct, as the etnaviv device is a virtual device driving multiple hard

Re: [Mesa-dev] Meson windows v5 (10/19/2018) review

2018-10-29 Thread Dylan Baker
Quoting Jose Fonseca (2018-10-25 04:02:42) > On 21/10/18 20:54, Liviu Prodea wrote: > > 1. When using Meson 0.48.x both -Dc_args -Dcpp_args and -Db_vscrt > > methods of selecting the CRT are ineffective on changing the CRT from MD > > to MT resulting in build failure if LLVM is built with MT CRT.

Re: [Mesa-dev] [PATCH 1/2] intel/icl: Disable combining of vertices from separate instances

2018-10-29 Thread Kenneth Graunke
On Monday, October 29, 2018 5:38:57 AM PDT Topi Pohjolainen wrote: > This is new hardware feature, and should be disabled until it is > clear our VS kernels are prepared for it. Thread payload has new > bit (See Bspec: Pipeline Stages - 3D Pipeline Geometry - > Vertex Shader (VS) Stage - Payloads -

[Mesa-dev] [Bug 107870] Undefined symbols for architecture x86_64: "_util_cpu_caps"

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107870 --- Comment #4 from Dylan Baker --- New series sent out to fix this. -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

[Mesa-dev] [PATCH 03/11] gallium/util: move debug_print_usage_enum to the u_debug_gallium

2018-10-29 Thread Dylan Baker
This isn't used in mesa, maybe vmware uses this in a closed source state tracker? --- src/gallium/auxiliary/util/u_debug.c | 19 --- src/gallium/auxiliary/util/u_debug.h | 3 --- src/gallium/auxiliary/util/u_debug_gallium.c | 19 +++ src/gallium/aux

[Mesa-dev] [PATCH 01/11] gallium: split u_prim_name out of u_debug.h

2018-10-29 Thread Dylan Baker
This allows us to pull u_prim.h out of u_debug.h --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/meson.build | 1 + src/gallium/auxiliary/util/u_debug.c | 26 -- src/gallium/auxiliary/util/u_prim.c| 48 ++ 4 files changed, 50

[Mesa-dev] [PATCH 08/11] gallium/util: remove u_inlines.h from u_debug.c

2018-10-29 Thread Dylan Baker
It's not used, and I'm not pulling u_inlines into src/util. --- src/gallium/auxiliary/util/u_debug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_debug.c b/src/gallium/auxiliary/util/u_debug.c index 2584a1f297d..f6ed0138c1f 100644 --- a/src/gallium/auxiliary/uti

[Mesa-dev] [PATCH 11/11] util: move u_cpu_detect to util

2018-10-29 Thread Dylan Baker
CC: v...@freedesktop.org CC: Roland Scheidegger Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107870 Fixes: 80825abb5d1a7491035880253ffd531c55acae6b ("move u_math to src/util") --- Roland, you noticed that the previous attempt to fix this issue broke windows. I've run scons with m

[Mesa-dev] [PATCH 07/11] gallium/util: remove p_format.h from u_debug.h

2018-10-29 Thread Dylan Baker
--- src/gallium/auxiliary/tgsi/tgsi_ureg.h | 1 + src/gallium/auxiliary/util/u_debug.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.h b/src/gallium/auxiliary/tgsi/tgsi_ureg.h index c974ed02069..f23e3fa98f8 100644 --- a/src/gallium/auxi

[Mesa-dev] [PATCH 10/11] util: Move u_debug to utils

2018-10-29 Thread Dylan Baker
This needs to be tested with autotools and scons --- src/gallium/auxiliary/Makefile.sources | 2 -- src/gallium/auxiliary/meson.build | 2 -- src/gallium/auxiliary/util/u_cpu_detect.c | 2 +- src/gallium/auxiliary/util/u_debug_stack.c | 2 +- src/gallium/auxiliary/util/u_debug_sy

[Mesa-dev] [PATCH 02/11] gallium/util: start splitting u_debug into generic and gallium specific components

2018-10-29 Thread Dylan Baker
In order to pull u_debug into src/util we need to break the generically useful bits from the bits that are tightly coupled to gallium. --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/meson.build| 2 + src/gallium/auxiliary/util/u_debug.c | 10 ---

[Mesa-dev] [PATCH 09/11] util: Move os_misc to util

2018-10-29 Thread Dylan Baker
this is needed by u_debug --- src/gallium/auxiliary/Makefile.sources | 2 -- src/gallium/auxiliary/meson.build| 2 -- src/gallium/auxiliary/util/u_debug.h | 2 +- src/gallium/drivers/i915/i915_screen.c | 2 +- src/gallium/drivers/llvmpipe/lp_screen.c | 2 +- src

[Mesa-dev] [PATCH 00/11] Fix MacOS build

2018-10-29 Thread Dylan Baker
After pulling u_math into src/util to fix 32 bit windows builds of nir, I broke the MacOS build. This series fixes that platform by pulling down cpu_info into src/util as well. I would have liked to replace some of the duplication that cpu_info has with core mesa bits, but this is really needed bef

[Mesa-dev] [PATCH 05/11] gallium/util: move debug_print_tranfer_flags to u_debug_galilum

2018-10-29 Thread Dylan Baker
This also appears to be unused. --- src/gallium/auxiliary/util/u_debug.c | 18 -- src/gallium/auxiliary/util/u_debug.h | 3 --- src/gallium/auxiliary/util/u_debug_gallium.c | 13 + src/gallium/auxiliary/util/u_debug_gallium.h | 3 +++ 4 files changed,

[Mesa-dev] [PATCH 06/11] gallium/util: move memory debug declarations into u_debug_gallium

2018-10-29 Thread Dylan Baker
--- src/gallium/auxiliary/util/u_debug.c | 1 - src/gallium/auxiliary/util/u_debug.h | 7 --- src/gallium/auxiliary/util/u_debug_gallium.h | 6 ++ src/gallium/auxiliary/util/u_debug_memory.c | 1 + src/gallium/state_trackers/wgl/stw_device.c | 1 + 5 files changed, 8 inse

[Mesa-dev] [PATCH 04/11] gallium/util: move debug_print_bind_flags to u_debug_gallium

2018-10-29 Thread Dylan Baker
This also appears to be unused. --- src/gallium/auxiliary/util/u_debug.c | 33 src/gallium/auxiliary/util/u_debug.h | 4 --- src/gallium/auxiliary/util/u_debug_gallium.c | 33 src/gallium/auxiliary/util/u_debug_gallium.h | 3 ++ 4 files c

Re: [Mesa-dev] [PATCH] intel/blorp: Define the clear value bounds for HiZ clears

2018-10-29 Thread Juan A. Suarez Romero
On Mon, 2018-10-29 at 11:20 -0700, Nanley Chery wrote: > On Mon, Oct 29, 2018 at 08:37:13AM -0500, Jason Ekstrand wrote: > > That's likely because Nanley forgot to CC this one too stable: > > > > https://cgit.freedesktop.org/mesa/mesa/commit/?id=5bcf479524b96554cab7d2429dacf650b4054638 > > > > O

Re: [Mesa-dev] [PATCH] intel/blorp: Define the clear value bounds for HiZ clears

2018-10-29 Thread Nanley Chery
On Mon, Oct 29, 2018 at 12:48:50PM +0100, Juan A. Suarez Romero wrote: > On Thu, 2018-10-25 at 16:25 -0700, nanleych...@gmail.com wrote: > > From: Nanley Chery > > > > Follow the restriction of making sure the clear value is between the min > > and max values defined in CC_VIEWPORT. Avoids a simu

Re: [Mesa-dev] [PATCH] intel/blorp: Define the clear value bounds for HiZ clears

2018-10-29 Thread Nanley Chery
On Mon, Oct 29, 2018 at 08:37:13AM -0500, Jason Ekstrand wrote: > That's likely because Nanley forgot to CC this one too stable: > > https://cgit.freedesktop.org/mesa/mesa/commit/?id=5bcf479524b96554cab7d2429dacf650b4054638 > Our submittingpatches.html doc says that using the Fixes tag should be

[Mesa-dev] [PATCH 4/4] intel/sanitize_gpu: add debug message on mmap fail

2018-10-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_sanitize_gpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/intel_sanitize_gpu.c b/src/intel/tools/intel_sanitize_gpu.c index 4f1a2d2ead5..8f4f2ff8ec6 100644 --- a/src/intel/tools/intel_sanitize_

[Mesa-dev] [PATCH 3/4] intel/sanitize_gpu: deal with non page multiple buffer sizes

2018-10-29 Thread Lionel Landwerlin
We can only map at page aligned offsets. We got that wrong with buffer size where (size % 4096) != 0 (anv has a WA buffer of 1024). Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_sanitize_gpu.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/intel/

[Mesa-dev] [PATCH 2/4] intel/sanitize_gpu: add help/gdb options to wrapper

2018-10-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_sanitize_gpu.in | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/intel_sanitize_gpu.in b/src/intel/tools/intel_sanitize_gpu.in index 3dac954c408..7e4c96d8738 100755 --- a/src

[Mesa-dev] [PATCH 1/4] intel/dump_gpu: add missing gdb option

2018-10-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_dump_gpu.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/tools/intel_dump_gpu.in b/src/intel/tools/intel_dump_gpu.in index aa187ba8614..a1d92bb9bfa 100755 --- a/src/intel/tools/intel_dump_gpu.in +++ b/src/intel/tools/i

Re: [Mesa-dev] [PATCH v2 2/3] i965/gen10+: Enable object level preemption.

2018-10-29 Thread Rafael Antognolli
On Mon, Oct 29, 2018 at 05:29:10PM +, Chris Wilson wrote: > Quoting Rafael Antognolli (2018-10-29 17:19:53) > > +void > > +brw_enable_obj_preemption(struct brw_context *brw, bool enable) > > +{ > > + const struct gen_device_info *devinfo = &brw->screen->devinfo; > > + assert(devinfo->gen >=

Re: [Mesa-dev] [PATCH] i965: Don't bother to call blorp if the blit is zero-sized

2018-10-29 Thread Jason Ekstrand
FYI, I don't consider this patch to be the correct approach for solving the problem. There are other callers that could run into trouble; in particular any super-small blits like 0.5-wide. I think we likely want to either do a full audit of all blorp_blit callers or somehow solve it in blorp_blit

Re: [Mesa-dev] [PATCH v3 4/7] nir: Add a pass for lowering integer division by constants

2018-10-29 Thread Jason Ekstrand
On Mon, Oct 29, 2018 at 12:00 PM Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > Hi Jason, > > thx for doing this pass, I was about to do the same (then we'd have 3 :P). > I'm not completely sure, but it looks like you're implementation is > based on "Division by Invariant Integ

Re: [Mesa-dev] [PATCH v2 2/3] i965/gen10+: Enable object level preemption.

2018-10-29 Thread Chris Wilson
Quoting Rafael Antognolli (2018-10-29 17:19:53) > +void > +brw_enable_obj_preemption(struct brw_context *brw, bool enable) > +{ > + const struct gen_device_info *devinfo = &brw->screen->devinfo; > + assert(devinfo->gen >= 9); > + > + if (enable == brw->object_preemption) > + return; > +

[Mesa-dev] [AppVeyor] mesa master #9175 completed

2018-10-29 Thread AppVeyor
Build mesa 9175 completed Commit 9007c0ed26 by Brian Paul on 10/29/2018 5:15 PM: nir: fix yet another MSVC build break\n\nTrivial. Configure your notification preferences ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH mesa 02/12] nouveau: remove unused class member

2018-10-29 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin I suspect this was to take advantage of the 32-bit addressing modes available on Fermi. No code was ever written for this though (or if it was, it's now long-deleted). On Mon, Oct 29, 2018 at 1:16 PM Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > --- > src/g

[Mesa-dev] [PATCH v2 2/3] i965/gen10+: Enable object level preemption.

2018-10-29 Thread Rafael Antognolli
Set bit when initializing context. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 5 src/mesa/drivers/dri/i965/brw_state.h| 3 ++- src/mesa/drivers/dri/i965/brw_state_upload.c | 25 +

[Mesa-dev] [PATCH v2 1/3] intel/genxml: Add register for object preemption.

2018-10-29 Thread Rafael Antognolli
Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen10.xml | 8 src/intel/genxml/gen11.xml | 8 src/intel/genxml/gen9.xml | 8 3 files changed, 24 insertions(+) diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen10.xml index abd5da297d6..acded759335 10

[Mesa-dev] [PATCH v2 0/3] Add object level preemption to i965.

2018-10-29 Thread Rafael Antognolli
Re-sending the series, this time adding preemption support only to i965, since We still don't have vulkan tests for this. The proposed piglit test for this series can be found here: https://gitlab.freedesktop.org/rantogno/piglit/commits/review/context_preemption_v2 Cc: Kenneth Graunke Rafael An

[Mesa-dev] [PATCH v2 3/3] i965/gen9: Add workarounds for object preemption.

2018-10-29 Thread Rafael Antognolli
Gen9 hardware requires some workarounds to disable preemption depending on the type of primitive being emitted. We implement this by adding a new atom that tracks BRW_NEW_PRIMITIVE. Whenever it happens, we check the current type of primitive and enable/disable object preemption. For now, we just

Re: [Mesa-dev] [PATCH mesa 03/12] nouveau: fix memset(0) of non-trivial structs

2018-10-29 Thread Ilia Mirkin
Is this legal in C++98? I don't think we require C++11 mesa-wide, at least not yet... On Mon, Oct 29, 2018 at 1:16 PM Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 3 +-- > src/gallium/drivers/nouveau/codegen/nv50_ir_targ

[Mesa-dev] [PATCH mesa 12/12] egl: add messages to a few assert() and turn a couple into unreachable()

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 8 src/egl/main/eglconfig.c| 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 7d9e24d79ddf833802fb..93e34ff93aa5c96a89

[Mesa-dev] [PATCH mesa 10/12] util: s/0/NULL/ for pointer

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/util/u_dynarray.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h index c1aa79c8ac6ca8fce810..9bed2b9c25c879672e22 100644 --- a/src/util/u_dynarray.h +++ b/src/util/u_dynarray.h @@ -134,7 +134,

[Mesa-dev] [PATCH mesa 07/12] i965: turn "unreachable" assert() into unreachable()

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c index b6bf96706f837606dcd6..627a18027cd13ada959b 10

[Mesa-dev] [PATCH mesa 09/12] i965: move #ifdef to fix -Wswitch when SSE 4.1 is not supported

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c index 836f83d4a43a45e76b48..89d7a69d217829742c01 10

[Mesa-dev] [PATCH mesa 04/12] r600: fix memset(0) of non-trivial structs

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gallium/drivers/r600/sb/sb_expr.cpp | 10 +- src/gallium/drivers/r600/sb/sb_if_conversion.cpp | 4 ++-- src/gallium/drivers/r600/sb/sb_ir.h | 2 +- src/gallium/drivers/r600/sb/sb_peephole.cpp | 4 ++-- 4 files changed, 10

[Mesa-dev] [PATCH mesa 02/12] nouveau: remove unused class member

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.h b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.h index 4136b1ecfebcd7d7d1a5..e

[Mesa-dev] [PATCH mesa 11/12] egl: remove wayland special case which is also the default case

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index c5fa935657e8165be49c..7d9e24d79ddf833802fb 100644 --- a/src/egl/drivers/dri2/egl_dri

[Mesa-dev] [PATCH mesa 08/12] i965: add missing case to fix -Wswitch

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c index 627a18027cd13ada959b..836f83d4a43a45e76b

[Mesa-dev] [PATCH mesa 01/12] scons: drop unused HAVE_STDINT_H macro

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- scons/llvm.py | 3 --- src/gallium/drivers/svga/SConscript| 4 src/gallium/drivers/svga/svga_hw_reg.h | 6 -- src/gallium/winsys/svga/drm/SConscript | 1 - 4 files changed, 14 deletions(-) diff --git a/scons/llvm.py b/scons/

[Mesa-dev] [PATCH mesa 03/12] nouveau: fix memset(0) of non-trivial structs

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 3 +-- src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp b/src/gallium/drivers/no

[Mesa-dev] [PATCH mesa 05/12] mesa: fix memset(0) of non-trivial structs

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 +-- src/mesa/state_tracker/st_glsl_to_tgsi_private.cpp | 7 ++- src/mesa/state_tracker/st_glsl_to_tgsi_private.h | 1 + 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/me

[Mesa-dev] [PATCH mesa 06/12] mesa: fix struct/class mismatch

2018-10-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- src/mesa/state_tracker/st_glsl_to_tgsi_array_merge.cpp | 2 +- src/mesa/state_tracker/st_glsl_to_tgsi_array_merge.h | 2 +- src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 4 ++-- 4 files c

Re: [Mesa-dev] [PATCH mesa 1/4] vulkan/wsi: simplify meson file tracking

2018-10-29 Thread Eric Engestrom
On Monday, 2018-10-29 10:11:53 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-10-29 09:46:46) > > On Monday, 2018-10-29 09:07:30 -0700, Dylan Baker wrote: > > > Quoting Eric Engestrom (2018-10-28 06:45:05) > > > > Meson already automatically tracks included headers, so there's no need > >

[Mesa-dev] [PATCH] nir: Document the function inlining process

2018-10-29 Thread Jason Ekstrand
This has thrown a few people off recently and it's good to have the process and all the rational for it documented somewhere. A comment at the top of nir_inline_functions seems as good a place as any. Cc: Matt Turner Cc: Karol Herbst --- src/compiler/nir/nir_inline_functions.c | 68 +++

Re: [Mesa-dev] [PATCH mesa 1/4] vulkan/wsi: simplify meson file tracking

2018-10-29 Thread Dylan Baker
Quoting Eric Engestrom (2018-10-29 09:46:46) > On Monday, 2018-10-29 09:07:30 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-10-28 06:45:05) > > > Meson already automatically tracks included headers, so there's no need > > > to add them everywhere; cleans up the code a bit. > > > > > >

[Mesa-dev] [Bug 108594] [RADV] Graphics distortion in Evil within 1 if reflections enabled

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108594 Vladimir changed: What|Removed |Added CC||nickfa...@gmail.com --- Comment #1 from Vlad

Re: [Mesa-dev] [PATCH v3 4/7] nir: Add a pass for lowering integer division by constants

2018-10-29 Thread Daniel Schürmann
Hi Jason, thx for doing this pass, I was about to do the same (then we'd have 3 :P). I'm not completely sure, but it looks like you're implementation is based on "Division by Invariant Integers using Multiplication" from T. Granlund and P. L. Montgomery? I think, it should be mentioned then. A

[Mesa-dev] [Bug 108594] [RADV] Graphics distortion in Evil within 1 if reflections enabled

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108594 Bug ID: 108594 Summary: [RADV] Graphics distortion in Evil within 1 if reflections enabled Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (A

Re: [Mesa-dev] [PATCH mesa 1/4] vulkan/wsi: simplify meson file tracking

2018-10-29 Thread Eric Engestrom
On Monday, 2018-10-29 09:07:30 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-10-28 06:45:05) > > Meson already automatically tracks included headers, so there's no need > > to add them everywhere; cleans up the code a bit. > > > > Signed-off-by: Eric Engestrom > > --- > > src/vulkan/w

  1   2   >