Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

On Tue, Jul 10, 2018 at 4:44 PM, Gert Wollny wrote: > Am Dienstag, den 10.07.2018, 09:19 +1000 schrieb Dave Airlie: > > > > Just FYI in future please don't push mesa patches until the renderer > > side patch has landed, this is to avoid the abi accidentally > > diverging around the caps. > Sure,

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

Am Dienstag, den 10.07.2018, 09:19 +1000 schrieb Dave Airlie: > > Just FYI in future please don't push mesa patches until the renderer > side patch has landed, this is to avoid the abi accidentally > diverging around the caps. Sure, I'll keep that in mind, and sorry for rushing to push this. How

[Mesa-dev] [PATCH] gallium/u_transfer_helper: Initialize the stride of MSAA maps.

We just never set the value that was returned for MSAA mappings (directly reading back an MSAA framebuffer). Since we're handing back ss_map, it should be ss_map's stride from our nested transfer. Fixes piglit /home/anholt/src/piglit/bin/fbo-depthstencil -samples=4 casees. --- src/gallium/auxili

[Mesa-dev] [PATCH] anv: Use separate MOCS settings for external BOs on gen8

On all other platforms, it's safe to use the usual PTE settings for both internal and external BOs. On Broadwell, however, we can't get the right caching behavior for scanout without disabling eLLC and we really don't want to do this on everything. In order to do this, we add an anv-specific BO f

[Mesa-dev] [PATCH mesa 3/3] radv: Add new VK_MESA_query_timestamp extension to radv driver [v2]

This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ×tamp). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to correlate GPU and CPU timestamps. Signed-off-by: Keith Packard v2:

[Mesa-dev] [PATCH 0/3] Add MESA_query_timestamp extension (v2)

Here's an updated version of the extension to get GPU timestamps. This version returns both CPU and GPU timestamps which could (in theory) be more tightly correlated than just getting the time of one and then the other sequentially. The idea is that we'd eventually add a suitable kernel ioctl to ge

[Mesa-dev] [PATCH mesa 1/3] vulkan: Define new VK_MESA_query_timestamp extension [v3]

This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ×tamp). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to correlate GPU and CPU timestamps. v2: Adopt Jason Ekstrand's codi

[Mesa-dev] [PATCH mesa 2/3] anv: Add new VK_MESA_query_timestamp extension to anv driver [v3]

This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ×tamp). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to correlate GPU and CPU timestamps. v2: Adopt Jason Ekstrand's codi

[Mesa-dev] [PATCH] nir/vars_to_ssa: Don't build deref nodes for non-local variables

--- src/compiler/nir/nir_lower_vars_to_ssa.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c b/src/compiler/nir/nir_lower_vars_to_ssa.c index 3f37acaed33..cd679be5be5 100644 --- a/src/compiler/nir/nir_lower_vars_to_s

Re: [Mesa-dev] [PATCH v5] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

On Thu, Jun 14, 2018 at 10:50:57PM +0300, Eleni Maria Stea wrote: > On 06/14/2018 10:27 PM, Nanley Chery wrote: > > > +Jason, Ken > > > > Hello, > > > > I recently did some miptree work relating to the r8stencil_mt and I > > think I now have a more informed opinion about how things should be > >

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #33 from Ben Crocker --- AFAIK, there IS PPC32 LE; we just don't support it in Red Hat products. So, I can't tell you much more. Sorry! What are the chances you can convert to using PPC64LE across the board? -- You are receiving

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #32 from Ben Crocker --- I suspect that, if you run your Talos II big-endian, you will have the same results as on your G5; big-endian machines have not had the attention from the LLVM developers that little-endian machines have. I

Re: [Mesa-dev] [PATCH 2/2] intel/aubinator_error_decode: Allow for more sections

Reviewed-by: Lionel Landwerlin On 10/07/18 00:01, Jason Ekstrand wrote: Error states coming from actual Vulkan applications tend to have fairly long command buffers and lots of chained batches. 30 total BOs isn't nearly enough. This commit bumps it to 256, makes some things use the actual num

Re: [Mesa-dev] [PATCH 1/2] intel/batch_decoder: Recurse for all 2nd level batches

Reviewed-by: Lionel Landwerlin On 10/07/18 00:01, Jason Ekstrand wrote: Our attempt to restart the loop with the second level batch worked at one point but got broken at some point. It was too fragile anyway and we're not likely to have enough secondaries to actually overflow the stack so we m

Re: [Mesa-dev] [PATCH] intel/tools/dump_gpu: Add option to print ppgtt mappings.

Thanks! Reviewed-by: Lionel Landwerlin On 09/07/18 21:28, Rafael Antognolli wrote: Using -vv will increase the verbosity, by printing the ppgtt mappings as they get written into the aub file. Cc: Lionel Landwerlin --- src/intel/tools/intel_dump_gpu.c | 25 - src/i

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

On 29 June 2018 at 20:57, Erik Faye-Lund wrote: > On Fri, Jun 29, 2018 at 12:52 PM Erik Faye-Lund wrote: >> >> On Fri, Jun 29, 2018 at 12:39 PM Gert Wollny >> wrote: >> > >> > Use caps to obtain the multisample sample positions for up to 16 >> > positions and implement the according Gallium int

[Mesa-dev] [PATCH 1/2] intel/batch_decoder: Recurse for all 2nd level batches

Our attempt to restart the loop with the second level batch worked at one point but got broken at some point. It was too fragile anyway and we're not likely to have enough secondaries to actually overflow the stack so we may as well recurse in both cases. --- src/intel/common/gen_batch_decoder.c

[Mesa-dev] [PATCH 2/2] intel/aubinator_error_decode: Allow for more sections

Error states coming from actual Vulkan applications tend to have fairly long command buffers and lots of chained batches. 30 total BOs isn't nearly enough. This commit bumps it to 256, makes some things use the actual number of sections instead of the #define, and adds asserts if we ever go over

Re: [Mesa-dev] [PATCH] nir: delete not needed for reinserted nir_cf_list

Yeah, I think this is probably better. Reviewed-by: Jason Ekstrand On Thu, Jul 5, 2018 at 5:50 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > It wasn't causing problems since there's nothing to delete, but better > be consistent with the rest of existing codebase. > --- >

Re: [Mesa-dev] [PATCH] radv: using tls to store llvm related info and speed up compiles (v9)

Reviewed-by: Bas Nieuwenhuizen On Mon, Jul 9, 2018 at 11:14 PM, Dave Airlie wrote: > From: Dave Airlie > > This uses the common compiler passes abstraction to help radv > avoid fixed cost compiler overheads. This uses a linked list per > thread stored in thread local storage, with an entry in t

[Mesa-dev] [PATCH] radv: using tls to store llvm related info and speed up compiles (v9)

From: Dave Airlie This uses the common compiler passes abstraction to help radv avoid fixed cost compiler overheads. This uses a linked list per thread stored in thread local storage, with an entry in the list for each target machine. This should remove all the fixed overheads setup costs of cre

[Mesa-dev] [PATCH] gallium/u_transfer_helper: Fix MSAA mappings with nonzero x/y.

We created a temporary with box->{width,height} and then tried to map width,height from a nonzero offset when we meant to just map the whole temporary. Fixes segfaults in V3D in dEQP-GLES3.functional.prerequisite.read_pixels with --deqp-egl-config-name=rgbad24s8ms4 and also piglit's read-front

Re: [Mesa-dev] [PATCH v2 05/11] util/set: add a basic unit test

On Mon, Jul 09, 2018 at 10:53:19AM -0700, Caio Marcelo de Oliveira Filho wrote: > --- > src/util/Makefile.am| 3 +- > src/util/meson.build| 1 + > src/util/tests/set/Makefile.am | 42 + > src/util/tests/set/meson.build | 30 ++ >

Re: [Mesa-dev] [PATCH] radv: using tls to store llvm related info and speed up compiles (v8)

On Mon, Jul 9, 2018 at 11:03 PM, Dave Airlie wrote: > On 9 July 2018 at 05:58, Bas Nieuwenhuizen wrote: >> On Thu, Jul 5, 2018 at 2:03 AM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> This uses the common compiler passes abstraction to help radv >>> avoid fixed cost compiler overheads. This

[Mesa-dev] [PATCH] radv: using tls to store llvm related info and speed up compiles (v9)

From: Dave Airlie This uses the common compiler passes abstraction to help radv avoid fixed cost compiler overheads. This uses a linked list per thread stored in thread local storage, with an entry in the list for each target machine. This should remove all the fixed overheads setup costs of cre

Re: [Mesa-dev] [PATCH] radv: using tls to store llvm related info and speed up compiles (v8)

On 9 July 2018 at 05:58, Bas Nieuwenhuizen wrote: > On Thu, Jul 5, 2018 at 2:03 AM, Dave Airlie wrote: >> From: Dave Airlie >> >> This uses the common compiler passes abstraction to help radv >> avoid fixed cost compiler overheads. This uses a linked list per >> thread stored in thread local sto

[Mesa-dev] [Bug 107170] Build fails if building against X server/libxrandr with no leases support

https://bugs.freedesktop.org/show_bug.cgi?id=107170 Bug ID: 107170 Summary: Build fails if building against X server/libxrandr with no leases support Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] scons: Fix CC env quoting.

Am 09.07.2018 um 21:57 schrieb Jose Fonseca: > Handle the case where there are spaces in CC env var (ie, compiler + > options.) > > This updates the CC check to match what newer SCons do internally. > --- > scons/gallium.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH] intel/tools/dump_gpu: Add option to print ppgtt mappings.

Using -vv will increase the verbosity, by printing the ppgtt mappings as they get written into the aub file. Cc: Lionel Landwerlin --- src/intel/tools/intel_dump_gpu.c | 25 - src/intel/tools/intel_dump_gpu.in | 6 ++ 2 files changed, 30 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH mesa] egl: drop unused _EGL_BUILT_IN_DRIVER_DRI2

Unused since b174a1ae720cb404738c "egl: Simplify the "driver" interface". Signed-off-by: Eric Engestrom --- src/egl/Android.mk | 1 - src/egl/Makefile.am | 3 +-- src/egl/meson.build | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/egl/Android.mk b/src/egl/Android.mk ind

[Mesa-dev] [Bug 107169] [regression] Upgrade from 18.0.4 to 18.1.0 causes severe stuttering in games

https://bugs.freedesktop.org/show_bug.cgi?id=107169 Bug ID: 107169 Summary: [regression] Upgrade from 18.0.4 to 18.1.0 causes severe stuttering in games Product: Mesa Version: 18.0 Hardware: x86-64 (AMD64) O

[Mesa-dev] [PATCH] scons: Fix CC env quoting.

Handle the case where there are spaces in CC env var (ie, compiler + options.) This updates the CC check to match what newer SCons do internally. --- scons/gallium.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scons/gallium.py b/scons/gallium.py index 7cb2a32549..c05d86

Re: [Mesa-dev] [PATCH 1/2] glsl: slim the kill_entry struct used in const propagation

Caio Marcelo de Oliveira Filho writes: > Since 4654439fdd7 "glsl: Use hash tables for > opt_constant_propagation() kill sets." uses a hash_table for storing > kill_entries, so the structs can be simplified. > > Remove the exec_node from kill_entry since it is not used in an > exec_list anymore. >

Re: [Mesa-dev] [PATCH] glsl: Take sampler2DRect and sampler2DRectShadow as reserved

Eric Anholt writes: > [ Unknown signature status ] > zhaowei yuan writes: > >> "sampler2DRect" and "sampler2DRectShadow" are specified as >> reserved from GLSL 1.1 and GLSL ES 1.0 >> >> Signed-off-by: zhaowei yuan >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106906 > > It looks lik

[Mesa-dev] [PATCH 1/2] glsl: slim the kill_entry struct used in const propagation

Since 4654439fdd7 "glsl: Use hash tables for opt_constant_propagation() kill sets." uses a hash_table for storing kill_entries, so the structs can be simplified. Remove the exec_node from kill_entry since it is not used in an exec_list anymore. Remove the 'var' from kill_entry since it is now red

[Mesa-dev] [PATCH 2/2] glsl: remove struct kill_entry in constant propagation

The only value in kill_entry is the writemask, which can be stored in the data pointer of the hash table entry. Suggested by Eric Anholt. --- Kept this as a separate patch since I felt the casting would be controversial. .../glsl/opt_constant_propagation.cpp | 33 --- 1

Re: [Mesa-dev] [PATCH 32/53] intel/fs: Mark LINTERP opcode as writing accumulator implicitly on pre-Gen7.

https://gitlab.freedesktop.org/jekstrand/mesa/commit/e4928d31f13d5501f03979159711c0f4d08005aa On Mon, Jul 9, 2018 at 11:16 AM Dylan Baker wrote: > Quoting Dylan Baker (2018-06-29 08:28:09) > > Quoting Jason Ekstrand (2018-05-24 14:56:14) > > > From: Francisco Jerez > > > > > > --- > > > src/in

[Mesa-dev] [PATCH] nir: Add flipping of gl_PointCoord.y in nir_lower_wpos_ytransform.

This is controlled by a new nir_shader_compiler_options flag, and fixes dEQP-GLES3.functional.shaders.builtin_variable.pointcoord on V3D. --- src/broadcom/compiler/nir_to_vir.c | 1 + src/compiler/nir/nir.h | 3 ++ src/compiler/nir/nir_lower_wpos_ytransform.c | 29

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #28 from pritzl3...@gmail.com --- (In reply to Samuel Pitoiset from comment #27) > I guess it also hangs with RADV_PERFTEST=nobatchchain ? Yes I just gave it a try and it hangs in the same way. I am now on kernel 4.16.13 Mesa 18.2.0

Re: [Mesa-dev] [PATCH] swrast: Fix eglMakeCurrent(dpy, NULL, NULL, ctx) (v2)

Adam Jackson writes: > Fixes 14 piglits, mostly in egl_khr_create_context. > > v2: Also short-circuit the same-context-no-drawables case (Eric Anholt) > > Fixes: https://github.com/anholt/libepoxy/issues/177 > Signed-off-by: Adam Jackson r-b signature.asc Description: PGP signature __

Re: [Mesa-dev] [PATCH 32/53] intel/fs: Mark LINTERP opcode as writing accumulator implicitly on pre-Gen7.

Quoting Dylan Baker (2018-06-29 08:28:09) > Quoting Jason Ekstrand (2018-05-24 14:56:14) > > From: Francisco Jerez > > > > --- > > src/intel/compiler/brw_shader.cpp | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/intel/compiler/brw_shader.cpp > > b/src/inte

Re: [Mesa-dev] [RFC 10/10] glsl: use only copy_propagation_elements

On Thu, Jul 05, 2018 at 03:28:45PM -0700, Eric Anholt wrote: > Caio Marcelo de Oliveira Filho writes: > > > Now that the elements version handles both cases, remove the > > non-elements version. > > I made some progress on reviewing the series today. I think this is > very worthwhile to pursue,

Re: [Mesa-dev] [PATCH 04/10] glsl: separate copy propagation state

> Since this copy_propagation_state covers just the acp and not the kills > list (whcih is still part of the copy propagation state in the visitor > class), could we call it "acp"? I'm considering moving the kills list inside that state, hence the more general name. > > @@ -191,26 +283,21 @@ >

Re: [Mesa-dev] [PATCH 01/10] glsl: don't let an 'if' then-branch kill const propagation for else-branch

> Possible follow-up change for someone looking at compiler perf: > kill_entry doesn't seem to need to be a list since > 4654439fdd766f79a78fe0d812fd916f5815e7e6, and we could probably just > store the write_mask in the entry->data field and not have struct > kill_entry at all! That makes sense. I

Re: [Mesa-dev] [PATCH 06/10] util/set: helper to remove entry by key

On Thu, Jul 05, 2018 at 01:56:11PM -0700, Eric Anholt wrote: > Caio Marcelo de Oliveira Filho writes: > > > --- > > This one should be trivial to unit test, with a present and non-present > key. Done. Do you want the equivalent hash_table function even if I don't have use for it in the code at

Re: [Mesa-dev] [PATCH 05/10] util/set: add a clone function

On Thu, Jul 05, 2018 at 01:55:51PM -0700, Eric Anholt wrote: > Caio Marcelo de Oliveira Filho writes: > > > --- > > Could you add a little unit test with it? Maybe make a table with a > couple entries and a deleted entry, and verify that the clone has both > entries and not the deleted one? Do

[Mesa-dev] [RFC v2 11/11] glsl: use only copy_propagation_elements

Now that the elements version handles both cases, remove the non-elements version. --- src/compiler/Makefile.sources | 1 - src/compiler/glsl/glsl_parser_extras.cpp | 1 - src/compiler/glsl/ir_optimization.h| 1 - src/compiler/glsl/meson.build | 1 - src

[Mesa-dev] [PATCH v2 01/11] glsl: don't let an 'if' then-branch kill const propagation for else-branch

When handling 'if' in constant propagation, if a certain variable was killed when processing the first branch of the 'if', then the second would get any propagation from previous nodes. This is similar to the change done for copy propagation code. x = 1; if (...) { z = x; // This

[Mesa-dev] [PATCH v2 08/11] glsl: change opt_copy_propagation_elements data structures

Instead of keeping multiple acp_entries in lists, have a single acp_entry per variable. With this, the implementation of clone is more convenient and now fully implemented. In the previous code, clone was only partial. Before this patch, each acp_entry struct represented a write to a variable incl

[Mesa-dev] [RFC v2 10/11] glsl: teach copy_propagation_elements to deal with whole variables

Keep information in acp_entry whether the entry is full or not, and use the ACP in more nodes when visiting the instructions: - add_copy: write whole variables to the ACP state (regardless the type). - visit(ir_dereference_variable *): perform the propagation here if we have a full candidate.

[Mesa-dev] [PATCH v2 02/11] glsl: do second pass of const propagation in loops

When handling loops in constant propagation, implement the "FINISHME" comment like copy propagation: perform a first pass to find values that can't be propagated, then perform a second pass with the ACP containing still valid values. Certain values are killed because the loop may run more than one

[Mesa-dev] [PATCH v2 06/11] util/set: add a clone function

v2: Add unit test. (Eric Anholt) --- src/util/set.c | 23 +++ src/util/set.h | 3 +++ src/util/tests/set/set_test.cpp | 32 3 files changed, 58 insertions(+) diff --git a/src/util/set.c b/src/util/set.c index

[Mesa-dev] [PATCH v2 04/11] glsl: separate copy propagation state

Separate higher level logic of visiting instructions and chosing when to store and use new copy data from the datastructure holding the copy propagation information. This will also make easier later patches that change the structure. v2: Remove empty destructor and clarify how hash tables are dest

[Mesa-dev] [PATCH v2 07/11] util/set: helper to remove entry by key

v2: Add unit test. (Eric Anholt) --- src/util/set.c | 9 + src/util/set.h | 2 ++ src/util/tests/set/set_test.cpp | 28 3 files changed, 39 insertions(+) diff --git a/src/util/set.c b/src/util/set.c index b2aa5ba13d5..feef96

[Mesa-dev] [PATCH v2 09/11] glsl: don't let an 'if' then-branch kill copy propagation (elements) for else-branch

When handling 'if' in copy propagation elements, if a certain variable was killed when processing the first branch of the 'if', then the second would get any propagation from previous nodes. x = y; if (...) { z = x; // This would turn into z = y. x = 22; // x gets killed.

[Mesa-dev] [PATCH v2 00/11] GLSL Copy Propagation

This series contains improvements to GLSL copy (and constant) propagation. In most cases the numbers do not change (at least in the Intel configurations I've tested) because the NIR passes pick up the slack. It all started with the patches "don't let an 'if' ...", which are about cases like b

[Mesa-dev] [PATCH v2 05/11] util/set: add a basic unit test

--- src/util/Makefile.am| 3 +- src/util/meson.build| 1 + src/util/tests/set/Makefile.am | 42 + src/util/tests/set/meson.build | 30 ++ src/util/tests/set/set_test.cpp | 55 + 5 files changed, 130

[Mesa-dev] [PATCH v2 03/11] glsl: don't let an 'if' then-branch kill copy propagation for else-branch

When handling 'if' in copy propagation, if a certain variable was killed when processing the first branch of the 'if', then the second would get any propagation from previous nodes. x = y; if (...) { z = x; // This would turn into z = y. x = 22; // x gets killed. } els

Re: [Mesa-dev] [PATCH] intel: tools: dump_gpu: fix ppgtt mapping

Reviewed-by: Rafael Antognolli On Fri, Jul 06, 2018 at 11:02:05AM +0100, Lionel Landwerlin wrote: > We were not properly writing page tables when the virtual address > range spans multiple subtrees of the tables. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/intel_dump_gpu.c | 4

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #4 from zefkerri...@gmail.com --- (In reply to Samuel Pitoiset from comment #3) > We are not ignoring, we are just busy with something else. I will have a > look as soon as possible, don't worry. Samuel, thank you! -- You are recei

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #31 from erhar...@mailbox.org --- I see. I am in no hurry either, 'cause I don't depend on llvmpipe working on PPC32 BE. Leaves me wondering if there is PPC32 LE? I just reported this 'cause I use PPC32 BE regularly and it looked like

Re: [Mesa-dev] [PATCH v2] spirv: Fix InterpolateAt* instructions for vecs with dynamic index

Reviewed-by: Jason Ekstrand On Mon, Jul 9, 2018 at 5:21 AM Alejandro Piñeiro wrote: > From: Neil Roberts > > If the glsl is something like this: > > in vec4 some_input; > interpolateAtCentroid(some_input[idx]) > > then it now gets generated as if it were: > > interpolateAtCentroid(some_i

[Mesa-dev] [PATCH] st/mesa: call resource_changed when binding a EGLImage to a texture

When a EGLImage is newly bound to a texture, we need to make sure the driver is informed that the resource might have changed. Fixes stale texture content on Etnaviv when binding an existing EGLImage to an existing texture object. Signed-off-by: Lucas Stach --- src/mesa/state_tracker/st_cb_eglim

[Mesa-dev] [PATCH] swrast: Fix eglMakeCurrent(dpy, NULL, NULL, ctx) (v2)

Fixes 14 piglits, mostly in egl_khr_create_context. v2: Also short-circuit the same-context-no-drawables case (Eric Anholt) Fixes: https://github.com/anholt/libepoxy/issues/177 Signed-off-by: Adam Jackson --- src/mesa/drivers/dri/swrast/swrast.c | 37 ++-- 1 file changed

Re: [Mesa-dev] [PATCH] intel/compiler: emit actual barriers for working-group level barriers

Reviewed-by: Jason Ekstrand On Mon, Jul 9, 2018 at 2:09 AM Iago Toral wrote: > Any feedback about this? We need this to fix some new CTS tests. > > On Thu, 2018-06-21 at 13:52 +0200, Iago Toral Quiroga wrote: > > Until now we have assumed that we could skip emitting these barriers > > in the ge

Re: [Mesa-dev] [PATCH v2 4/4] radv: add support for VK_EXT_conditional_rendering

On 07/09/2018 06:10 PM, Jason Ekstrand wrote: On Mon, Jul 9, 2018 at 8:29 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: On 07/09/2018 05:28 PM, Jason Ekstrand wrote: > Are there any tests for this anywhere? Unfortunately, not yet. Someone should write some then

Re: [Mesa-dev] [PATCH v2 4/4] radv: add support for VK_EXT_conditional_rendering

On Mon, Jul 9, 2018 at 8:29 AM Samuel Pitoiset wrote: > > On 07/09/2018 05:28 PM, Jason Ekstrand wrote: > > Are there any tests for this anywhere? > > Unfortunately, not yet. > Someone should write some then. :-) I recently wrote tests for VK_EXT_vertex_attribute_divisor and we discovered that

[Mesa-dev] [PATCH 6/9] etnaviv: add 2D GPU YUV->RGB blitter

This adds a blit path using the 2D GPU for a linear YUV to tiled RGB blit. This allows to implement importing of planar YUV textures with a single copy. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/Makefile.sources |2 + src/gallium/drivers/etnaviv/etnaviv_2d.c | 166 ++

[Mesa-dev] [PATCH 8/9] etnaviv: use filter blit for 2D YUV import on old GC320

The GC320 without the 2D tiling feature doesn't support regular blits with YUV input, as well as the tiled output. So on those cores we need need to do a filter blit for the YUV->RGB conversion to a temporary linear buffer and then do a tiling blit into the texture buffer using the RS engine on the

[Mesa-dev] [PATCH 2/9] etnaviv: reject imports of tiler incompatible linear buffers

We don't have a fallback to get them into a render/sampler compatible layout (yet). Rejecting the import at least forwards this issue to the client application, which might have a way to deal with this. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 8 1

[Mesa-dev] [PATCH 7/9] etnaviv: export etna_submit_rs_state

The new 2D YUV blit needs this in some cases, so make it available. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_rs.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv

[Mesa-dev] [PATCH 3/9] etnaviv: clear out next pointer when allocating resource

We copy the template resource content into the newly allocated resource. If the template derived from a planar resource this leads to a non reference counted copy of the next resource pointer. Make sure to clear this out when allocating a new resource. Signed-off-by: Lucas Stach --- src/gallium/

[Mesa-dev] [PATCH 9/9] etnaviv: handle YUV textures with the 2D GPU

This allows color space conversion and tiling in a single step, as well as handling multi-planar formats like NV12, which are really useful when dealing with hardware video decoders. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +- src/gallium/drivers/etnav

[Mesa-dev] [PATCH 5/9] etnaviv: create optional 2d pipe in screen

The 2D pipe is useful to implement fast planar and interleaved YUV buffer imports. Not all systems have a 2D capable core, so this is strictly optional. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_context.c | 6 ++ src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + src

[Mesa-dev] [PATCH 1/9] etnaviv: improve PIPE_BIND_LINEAR handling

We weren't handling this flag at all, which broke some assumptions made by the users of the resource_create interface. As we can't render to a linear surface and the usefulness of yet another layout transition to handle this case seems limited, we only respect the flag when the resource isn't used

[Mesa-dev] [PATCH 4/9] etnaviv: remember data offset into BO

Imported resources might not start at offset 0 into the buffer object. Make sure to remember the offset that is provided with the handle on import. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_resource.h | 1 + 2 files

[Mesa-dev] [PATCH 0/9] Etnaviv direct YUV support

Driver support for YUV textures is mostly limited to OES_external, which is suboptimal for etnaviv, as this incurs an additional copy blit on each texture bind, due to the way the OES_external extension is defined and the Vivante GPUs inability to sample from linear resources. Also emulating planar

[Mesa-dev] [PATCH v3] radv: make sure to wait for CP DMA when needed

This might fix some synchronization issues. I don't know if that will affect performance but it's required for correctness. v3: - wait for CP DMA in CmdPipelineBarrier() - clear the busy value when CP_DMA_SYNC is requested v2: - wait for CP DMA in CmdWaitEvents() - track if CP DMA is used

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #27 from Samuel Pitoiset --- I guess it also hangs with RADV_PERFTEST=nobatchchain ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

Re: [Mesa-dev] [PATCH v1 0/3] Android kms_swrast support

Hey Mauro, On 09/07/18 14:27, Mauro Rossi wrote: Hi Robert, Il giorno lun 9 lug 2018 alle ore 13:01 Robert Foss > ha scritto: NOTE: This series has not been tested successfully, and I'm seeing a segfault       during the boot process. Which I'm cur

Re: [Mesa-dev] [PATCH V2] Check if the window is non-NULL before setting swap interval.

On Thu, Jul 5, 2018 at 7:02 PM Emil Velikov wrote: > > On 5 July 2018 at 17:17, Eric Engestrom wrote: > > On Thursday, 2018-07-05 14:43:02 +0100, Emil Velikov wrote: > >> On 5 July 2018 at 10:53, Eric Engestrom wrote: > >> > On Monday, 2018-07-02 14:12:44 +0530, samiuddi wrote: > >> >> This fixe

Re: [Mesa-dev] [PATCH v2 4/4] radv: add support for VK_EXT_conditional_rendering

On 07/09/2018 05:28 PM, Jason Ekstrand wrote: Are there any tests for this anywhere? Unfortunately, not yet. On Mon, Jul 9, 2018 at 5:56 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: Inherited commands buffers are not supported. v2: - disable predication for blit

Re: [Mesa-dev] [PATCH v2 4/4] radv: add support for VK_EXT_conditional_rendering

Are there any tests for this anywhere? On Mon, Jul 9, 2018 at 5:56 AM Samuel Pitoiset wrote: > Inherited commands buffers are not supported. > > v2: - disable predication for blit and copy commands > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 29 ++

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #30 from Ben Crocker --- An LLVM developer tells me that llvmpipe on PPC32 BE doesn't work, and probably won't ever work. He suggests using swrast instead. -- You are receiving this mail because: You are the QA Contact for the bug

Re: [Mesa-dev] [PATCH v1 0/3] Android kms_swrast support

Hi Robert, Il giorno lun 9 lug 2018 alle ore 13:01 Robert Foss < robert.f...@collabora.com> ha scritto: > > NOTE: This series has not been tested successfully, and I'm seeing a > segfault > during the boot process. Which I'm currently looking into. > What is your testing setup (hwcomposer

Re: [Mesa-dev] [PATCH v1 2/3] platform/android: Enable kms_swrast fallback

Hey Eric, Thanks for the quick reviews! On 09/07/18 15:45, Eric Engestrom wrote: On Monday, 2018-07-09 13:01:49 +0200, Robert Foss wrote: Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a non-zero val

Re: [Mesa-dev] [PATCH v1 2/3] platform/android: Enable kms_swrast fallback

On Monday, 2018-07-09 13:01:49 +0200, Robert Foss wrote: > Add support for the ForceSoftware option, which is togglable > on the Android platform through setting the "drm.gpu.force_software" > property to a non-zero value. > > kms_swrast is also enabled as a fallback for when a driver is not > abl

[Mesa-dev] [Bug 107156] earth tessellation bug

https://bugs.freedesktop.org/show_bug.cgi?id=107156 --- Comment #4 from ximik --- No, in the Arch repository there is only the last Mesa-git driver. a rollback to the old version is not possible, and on a stable version of the driver, DXVK does not work. -- You are receiving this mail because

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #3 from Samuel Pitoiset --- We are not ignoring, we are just busy with something else. I will have a look as soon as possible, don't worry. -- You are receiving this mail because: You are the QA Contact for the bug. You are the ass

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #2 from zefkerri...@gmail.com --- (In reply to ximik from comment #1) > on the video on the embedded link is visible. same problem. card r290x, the > driver of the message 18-18.2 git > > > link https://mega.nz/#!Pr5nmYTQ!uGrPyzSW32

[Mesa-dev] [PATCH v2 4/4] radv: add support for VK_EXT_conditional_rendering

Inherited commands buffers are not supported. v2: - disable predication for blit and copy commands Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 29 + src/amd/vulkan/radv_device.c | 7 +++ src/amd/vulkan/radv_extensions.py | 1 + s

Re: [Mesa-dev] [PATCH 1/2] radv: introduce radv_subpass_attachment data structure

On 07/09/2018 10:36 AM, Bas Nieuwenhuizen wrote: On Mon, Jul 9, 2018 at 10:19 AM, Samuel Pitoiset wrote: On 07/08/2018 09:50 PM, Bas Nieuwenhuizen wrote: On Sun, Jul 8, 2018 at 5:47 PM, Samuel Pitoiset wrote: Needed for VK_KHR_create_renderpass2. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

Am 09.07.2018 um 09:54 schrieb Erik Faye-Lund: > On 06. juli 2018 18:43, Roland Scheidegger wrote: >> Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund: >>> OpenGL 4.4 and OpenGL ES 3.1 both require the maximum >>> vertex attrib stride to be at least 2048. If this isn't >>> the case, we shouldn't expos

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

Am 09.07.2018 um 11:51 schrieb Gert Wollny: > Am Montag, den 09.07.2018, 09:54 +0200 schrieb Erik Faye-Lund: >> On 06. juli 2018 18:43, Roland Scheidegger wrote: >>> >>> Personally I think it's _much_ better to lie about the supported GL >>> version rather than the maximum vertex attrib stride (I d

[Mesa-dev] [PATCH v2] spirv: Fix InterpolateAt* instructions for vecs with dynamic index

From: Neil Roberts If the glsl is something like this: in vec4 some_input; interpolateAtCentroid(some_input[idx]) then it now gets generated as if it were: interpolateAtCentroid(some_input)[idx] This is necessary because the index will get generated as a series of nir_bcsel instructions

[Mesa-dev] [PATCH mesa] meson: fix windows build

The python installer on Windows installs two `python.exe`, one for python2 and one for python3 and no `python2.exe` nor `python3.exe`. This seems utterly broken to me, but luckily for us meson handles this craziness for us, but only since version 0.46. This is higher than we require for now, but

[Mesa-dev] [PATCH v1 0/3] Android kms_swrast support

NOTE: This series has not been tested successfully, and I'm seeing a segfault during the boot process. Which I'm currently looking into. This series implements kms_swrast support for the Android platform. It's available here: https://gitlab.collabora.com/robertfoss/mesa/tree/kms_swrast_v1

[Mesa-dev] [PATCH v1 1/3] egl/android: Add Android property for forcing software rendering

In order to simplify Android bringup on new devices, provide the property "drm.gpu.force_software" which forces kms_swrast to be used. Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since RFC: - Fixed EGLBoolean comparison - Added r-b src/egl/main/egldriver.c | 10 ++

[Mesa-dev] [PATCH v1 3/3] android: Build kms_swrast for the Android platform

From: Rob Herring Signed-off-by: Rob Herring Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since RFC: - Added r-b src/gallium/Android.mk | 2 +- src/gallium/auxiliary/pipe-loader/Android.mk | 1 + src/gallium/drivers/softpipe/Android.mk | 4

[Mesa-dev] [PATCH v1 2/3] platform/android: Enable kms_swrast fallback

Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a non-zero value. kms_swrast is also enabled as a fallback for when a driver is not able to be loaded for for a drm node that was opened. Signed-off-by: Ro

  1   2   >