[Mesa-dev] [Bug 106881] glUniform4fv does not work

2018-06-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106881 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

[Mesa-dev] [Bug 106881] glUniform4fv does not work

2018-06-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106881 --- Comment #5 from Tapani Pälli --- (In reply to xinghua from comment #4) > (In reply to Tapani Pälli from comment #3) > > IMO this looks like a shader cache issue that got fixed by following commit. > > Please pull the latest Mesa and test aga

[Mesa-dev] [Bug 106881] glUniform4fv does not work

2018-06-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106881 xinghua changed: What|Removed |Added CC||yang...@intel.com, |

Re: [Mesa-dev] [PATCH 2/3] i965: Split merge_inputs and clear_buffers.

2018-06-11 Thread Mathias Fröhlich
Hi Chris, Thanks for looking into that! On Saturday, 2 June 2018 10:02:36 CEST Chris Wilson wrote: > Quoting mathias.froehl...@gmx.net (2018-05-17 07:38:27) > > From: Mathias Fröhlich > > > > The merge_inputs function handles that part that changes when the > > inputs change. The clear_buffers

Re: [Mesa-dev] [PATCH 1/3] i965: Move down genX_upload_sbe in profiles.

2018-06-11 Thread Mathias Fröhlich
Hi Chris, thanks for looking into that! On Saturday, 2 June 2018 09:58:14 CEST Chris Wilson wrote: > Quoting mathias.froehl...@gmx.net (2018-05-17 07:38:26) > > From: Mathias Fröhlich > > > > Avoid looping over all VARYING_SLOT_MAX urb_setup array > > entries from genX_upload_sbe. Prepare an ar

[Mesa-dev] [PATCH mesa 7/9] vulkan: Add EXT_acquire_xlib_display [v3]

2018-06-11 Thread Keith Packard
This extension adds the ability to borrow an X RandR output for temporary use directly by a Vulkan application. For DRM, we use the Linux resource leasing mechanism. v2: Clean up xlib_lease detection * Use separate temporary '_xlib_lease' variable to hold the option valu

[Mesa-dev] [PATCH mesa 5/9] anv: Add EXT_direct_mode_display to anv driver [v2]

2018-06-11 Thread Keith Packard
Add support for the EXT_direct_mode_display extension. This just provides the vkReleaseDisplayEXT function. v2: Add extension to list in alphabetical order Suggested-by: Jason Ekstrand Signed-off-by: Keith Packard --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_wsi_di

[Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-11 Thread Keith Packard
This adds support for the KHR_display extension to the anv Vulkan driver. The driver now attempts to open the master DRM node when the KHR_display extension is requested so that the common winsys code can perform the necessary operations. v2: Make sure primary fd is usable When KHR_displa

[Mesa-dev] [PATCH mesa 6/9] radv: Add EXT_direct_mode_display to radv driver

2018-06-11 Thread Keith Packard
Add support for the EXT_direct_mode_display extension. This just provides the vkReleaseDisplayEXT function. Signed-off-by: Keith Packard --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_wsi_display.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/src/amd/vulka

[Mesa-dev] [PATCH mesa 4/9] vulkan: Add EXT_direct_mode_display [v2]

2018-06-11 Thread Keith Packard
Add support for the EXT_direct_mode_display extension. This just provides the vkReleaseDisplayEXT function. v2: Adopt Jason Ekstrand's coding conventions Declare variables at first use, eliminate extra whitespace between types and names. Wrap lines to 80 columns.

[Mesa-dev] [PATCH mesa 8/9] anv: Add EXT_acquire_xlib_display to anv driver [v3]

2018-06-11 Thread Keith Packard
This extension adds the ability to borrow an X RandR output for temporary use directly by a Vulkan application to the anv driver. v2: Simplify addition of VK_USE_PLATFORM_XLIB_XRANDR_KHR to vulkan_wsi_args Suggested-by: Eric Engestrom v3: Add extension to list in

[Mesa-dev] [PATCH mesa 3/9] radv: Add KHR_display extension to radv [v4]

2018-06-11 Thread Keith Packard
This adds support for the KHR_display extension to the radv Vulkan driver. The driver now attempts to open the master DRM node when the KHR_display extension is requested so that the common winsys code can perform the necessary operations. v2: * Simplify addition of VK_USE_PLATFORM_DISPLAY

[Mesa-dev] [PATCH mesa 9/9] radv: Add EXT_acquire_xlib_display to radv driver [v2]

2018-06-11 Thread Keith Packard
This extension adds the ability to borrow an X RandR output for temporary use directly by a Vulkan application to the radv driver. v2: Simplify addition of VK_USE_PLATFORM_XLIB_XRANDR_KHR to vulkan_wsi_args Suggested-by: Eric Engestrom Signed-off-by: Keith Packard ---

[Mesa-dev] [PATCH mesa 0/0] Vulkan: Add DRM lease support

2018-06-11 Thread Keith Packard
Here's an updated patch series for DRM lease support using KHR_display and other standard Vulkan extensions. This series incorporates review from Eric Engestrom and Jason Ekstrom. Thanks to both of them! -keith ___ mesa-dev mailing list mesa-dev@lists.

[Mesa-dev] [PATCH mesa 1/9] vulkan: Add KHR_display extension using DRM [v8]

2018-06-11 Thread Keith Packard
This adds support for the KHR_display extension support to the vulkan WSI layer. Driver support will be added separately. v2: * fix double ;; in wsi_common_display.c * Move mode list from wsi_display to wsi_display_connector * Fix scope for wsi_display_mode andwsi_display

[Mesa-dev] [Bug 106881] glUniform4fv does not work

2018-06-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106881 --- Comment #3 from Tapani Pälli --- IMO this looks like a shader cache issue that got fixed by following commit. Please pull the latest Mesa and test again. --- 8< --- commit e266b320590ebbeadf7c98b0b493d89886534ccb Author: Jordan Justen Date

[Mesa-dev] [PATCH] anv: implement basic VK_AMD_shader_info support

2018-06-11 Thread Timothy Arceri
From: Timothy Arceri For now this just allows an app to query VK_SHADER_INFO_TYPE_DISASSEMBLY_AMD which for now only returns shader-db information. This will allow us to use anv with vkpipeline-db. We should add shader disassembly in the future so that RenderDoc can display it, but that will req

[Mesa-dev] [PATCH 2/2] vkpipeline-db: add support for anv

2018-06-11 Thread Timothy Arceri
From: Timothy Arceri --- anv-report.py | 191 ++ run.c | 75 +--- 2 files changed, 239 insertions(+), 27 deletions(-) create mode 100755 anv-report.py diff --git a/anv-report.py b/anv-report.py new file mode 100755 index

[Mesa-dev] [PATCH 1/2] vkpipeline-db: add sType to pipeline info

2018-06-11 Thread Timothy Arceri
From: Timothy Arceri This avoids hitting asserts in anv. --- run.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/run.c b/run.c index eafbd7d..a962887 100644 --- a/run.c +++ b/run.c @@ -264,6 +264,7 @@ create_graphics_pipeline(VkDevice device, struct pipeline_info *info, return

[Mesa-dev] [PATCH 2/2] vkpipeline-db: add support for anv

2018-06-11 Thread Timothy Arceri
From: Timothy Arceri --- anv-report.py | 191 ++ run.c | 75 +--- 2 files changed, 239 insertions(+), 27 deletions(-) create mode 100755 anv-report.py diff --git a/anv-report.py b/anv-report.py new file mode 100755 index

[Mesa-dev] [PATCH 1/2] vkpipeline-db: add sType to pipeline info

2018-06-11 Thread Timothy Arceri
From: Timothy Arceri This avoids hitting asserts in anv. --- run.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/run.c b/run.c index eafbd7d..a962887 100644 --- a/run.c +++ b/run.c @@ -264,6 +264,7 @@ create_graphics_pipeline(VkDevice device, struct pipeline_info *info, return

Re: [Mesa-dev] [PATCH mesa 07/21] vulkan: Add EXT_acquire_xlib_display [v2]

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > As with patch 1, I've gone through and made a pile of style changes to > bring things back under 80 characters. You can find it on this > branch: I've adopted that style across the whole series. >> struct wsi_display { >> @@ -1414,5 +1421,468 @@ wsi_release_display(Vk

Re: [Mesa-dev] [PATCH mesa 05/21] anv: Add EXT_direct_mode_display to anv driver

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > Alphabetize, please. :-) They're not actually in alphabetical order; EXT comes after KHR? I've ordered the EXT extensions within the existing EXT list, and added the MESA and GOOGLE extensions at the end. -- -keith signature.asc Description: PGP signature __

Re: [Mesa-dev] [PATCH mesa 04/21] vulkan: Add EXT_direct_mode_display

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > This seems a bit odd. Why is the FD not stored in the display? What if > you acquire multiple displays for two-player VR? If the master FD passed > in is not -1, we could just create a VkDisplayKHR object containing > it. You want to share the master_fd passed in at i

Re: [Mesa-dev] [PATCH mesa 02/21] anv: Add KHR_display extension to anv [v4]

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: >> +#define MM_PER_PIXEL (1.0/96.0 * 25.4) >> > > I don't think you need this. :-) Now you have me wondering when it was needed :-) > Other than that and the comment on patch 1 about stuff that should probably > go here, this looks good to me. Yeah, if you're not con

Re: [Mesa-dev] [PATCH 05/48] gallium: fix ddebug on windows

2018-06-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 11, 2018 at 6:55 PM, Dylan Baker wrote: > by including the proper headers for getpid and for mkdir. > --- > src/gallium/auxiliary/driver_ddebug/dd_util.h | 6 +- > src/gallium/auxiliary/meson.build | 6 ++ > 2 files changed, 11 in

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > Sorry for the multitude of replies. :-( It's all the same to me; you've been busy! >>radv_wsi_proc_addr, >> - &physical_device->instance->alloc); >> + &physical_device->instance->a

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > If you move the VK_OUTARRAY_MAKE up higher, both of the "goto bail"s can be > "return vk_outarray_status(&conn)". Not a big deal though; what you have > is probably fine. I'll leave it then. >> +prop->currentStackIndex = stack_index++; >> > > In your branch

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Roland Scheidegger
Am 12.06.2018 um 01:17 schrieb Rob Clark: > On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger > wrote: >> Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: >>> On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark >> > wrote: >>> >>> Signed-off-by: Rob Clark >>

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > I apologize for how nit-picky this is going to get but it's starting to > bother me... I'm glad you showed me what you wanted; always nice to have help! I've reformatted and restructured the code along the lines that you've suggested here for the entire series. In partic

[Mesa-dev] [PATCH 09/23] intel/eu: Use descriptor constructors for pixel interpolator messages.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu.h | 12 src/intel/compiler/brw_eu_emit.c | 23 ++- 2 files changed, 22 insertions(+), 13 deletions(-) diff --git a/src/intel/compiler/brw_eu.h b/src/intel/compiler/brw_eu.h index f595f5c6726..230be6026be 100644 --- a/src/intel/co

[Mesa-dev] [PATCH 05/23] intel/eu: Provide desc immediate argument up front to brw_send_indirect_message().

2018-06-11 Thread Francisco Jerez
The current approach of returning a setup instruction where additional descriptor fields can be specified is still supported in order to keep things working, but it will be removed later in this series. --- src/intel/compiler/brw_eu.h | 3 ++- src/intel/compiler/brw_eu_emit.c

[Mesa-dev] [PATCH 23/23] intel/fs: Handle FS_OPCODE_REP_FB_WRITE in implied_mrf_writes().

2018-06-11 Thread Francisco Jerez
It can have implied MRF writes ATM. --- src/intel/compiler/brw_fs.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index 314d580cc1f..4625ddc723c 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@ -

[Mesa-dev] [PATCH 14/23] intel/eu: Get rid of the return value of brw_send_indirect_surface_message().

2018-06-11 Thread Francisco Jerez
All users of brw_send_indirect_surface_message() should be providing a full descriptor immediate up front by now, this isn't necessary anymore. --- src/intel/compiler/brw_eu_emit.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.

[Mesa-dev] [PATCH 20/23] intel/eu: Rework opcode description tables to allow efficient look-up by either HW or IR opcode.

2018-06-11 Thread Francisco Jerez
This rewrites the current opcode description tables as a more compact flat data structure. The purpose is to allow efficient constant-time look-up by either HW or IR opcode, which will allow us to drop the hard-coded correspondence between HW and IR opcodes -- See the next commits for the rational

[Mesa-dev] [PATCH 03/23] intel/eu: Use brw_set_desc() along with a helper to set common descriptor controls.

2018-06-11 Thread Francisco Jerez
This replaces brw_set_message_descriptor() with the composition of brw_set_desc() and a new inline helper function that packs the common message descriptor controls into an integer. The goal is to represent all message descriptors as a 32-bit integer which is written at once into the instruction,

[Mesa-dev] [PATCH 16/23] intel/eu: Assert that the instruction is send-like in brw_set_desc_ex().

2018-06-11 Thread Francisco Jerez
Constructing a descriptor in-place as part of the immediate of an ALU instruction is no longer supported. --- src/intel/compiler/brw_eu_emit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c index 86c5c4bb

[Mesa-dev] [PATCH 12/23] intel/eu: Use descriptor constructors for dataport scattered byte surface messages.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu_emit.c | 60 ++-- 1 file changed, 27 insertions(+), 33 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c index c1a1004c033..cdf839d3053 100644 --- a/src/intel/compiler/brw_eu_emit.c +++ b

[Mesa-dev] [PATCH 07/23] intel/eu: Use descriptor constructors for dataport read messages.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu.h | 33 + src/intel/compiler/brw_eu_emit.c | 77 ++- src/intel/compiler/brw_fs_generator.cpp | 32 ++--- src/intel/compiler/brw_vec4_generator.cpp | 33 +++-- 4 files changed, 80 insertio

[Mesa-dev] [PATCH 15/23] intel/eu: Get rid of the return value of brw_send_indirect_message().

2018-06-11 Thread Francisco Jerez
The return value is not used anymore. This allows simplifying the code slightly, and in addition it should frustrate anybody's attempts to continue using the obsolete piecemeal approach to construct a message descriptor in combination with brw_send_indirect_message(). --- src/intel/compiler/brw_e

[Mesa-dev] [PATCH 13/23] intel/eu: Use descriptor constructors for dataport typed surface messages.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu_emit.c | 82 +--- 1 file changed, 35 insertions(+), 47 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c index cdf839d3053..f414a5753f6 100644 --- a/src/intel/compiler/brw_eu_emit.c +++ b

[Mesa-dev] [PATCH 19/23] intel/eu: Fix up various type conversions in brw_eu.c that are illegal C++.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu.c | 12 ++-- src/intel/compiler/brw_eu.h | 6 +++--- src/intel/compiler/brw_vec4_generator.cpp | 2 +- src/intel/compiler/test_eu_compact.cpp| 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/intel

[Mesa-dev] [PATCH 18/23] intel/ir: Uncomment definition of several unused hardware opcodes.

2018-06-11 Thread Francisco Jerez
There are a number of opcode_desc table entries for many of these unused opcodes. A symbolic opcode enum will be required in a future commit in order to keep them in the opcode description tables. The alternative would be to remove the unused opcodes from the opcode description tables. --- src/i

[Mesa-dev] [PATCH 10/23] intel/eu: Provide single descriptor argument to brw_send_indirect_surface_message().

2018-06-11 Thread Francisco Jerez
Instead of the current message_len, response_len and header_present arguments. --- src/intel/compiler/brw_eu_emit.c | 65 ++-- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c ind

[Mesa-dev] [PATCH 06/23] intel/eu: Use descriptor constructors for sampler messages.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu.h | 34 ++- src/intel/compiler/brw_eu_emit.c | 45 +++ src/intel/compiler/brw_fs_generator.cpp | 72 ++- src/intel/compiler/brw_vec4_generator.cpp | 59 - 4 files

[Mesa-dev] [PATCH 17/23] intel/fs: Initialize mlen for gen7 varying pull constant load messages.

2018-06-11 Thread Francisco Jerez
This makes the message length available at the IR level, which should save some guesswork in a future commit. --- src/intel/compiler/brw_fs.cpp | 2 +- src/intel/compiler/brw_fs_generator.cpp | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/intel/compi

[Mesa-dev] [PATCH 21/23] intel/eu: Encode and decode native instruction opcodes from/to IR opcodes.

2018-06-11 Thread Francisco Jerez
Change brw_inst_set_opcode() and brw_inst_opcode() to call brw_opcode_encode/decode() transparently in order to translate between hardware and IR opcodes, and update the EU compaction code in order to do the same as needed, so we can eventually drop the one-to-one correspondence between hardware an

[Mesa-dev] [PATCH 08/23] intel/eu: Use descriptor constructors for dataport write messages.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu.h | 39 src/intel/compiler/brw_eu_emit.c | 100 -- src/intel/compiler/brw_vec4_generator.cpp | 22 +++ 3 files changed, 63 insertions(+), 98 deletions(-) diff --git a/src/intel/compiler/brw_eu.h b/

[Mesa-dev] [PATCH 11/23] intel/eu: Use descriptor constructors for dataport untyped surface messages.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu.h | 13 ++ src/intel/compiler/brw_eu_emit.c | 88 +--- 2 files changed, 51 insertions(+), 50 deletions(-) diff --git a/src/intel/compiler/brw_eu.h b/src/intel/compiler/brw_eu.h index 230be6026be..05536c3aaff 100644 --- a/s

[Mesa-dev] [PATCH 00/23] intel: Assorted code generation improvements.

2018-06-11 Thread Francisco Jerez
This series contains a few code generation refactors and clean-ups that are starting to pile up in an internal branch. By itself this series shouldn't cause any functional changes, but there's no reason why it couldn't be reviewed already which would lessen our pain keeping the branch up-to-date.

[Mesa-dev] [PATCH 04/23] TRIVIAL: intel/eu: Use a local devinfo variable in brw_shader_time_add().

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu_emit.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c index 7389e8e3bde..9f449fb9d34 100644 --- a/src/intel/compiler/brw_eu_emit.c +++ b/src/intel/compiler/brw_eu_emit

[Mesa-dev] [PATCH 22/23] intel/ir: Drop hard-coded correspondence between IR and HW opcodes.

2018-06-11 Thread Francisco Jerez
Having the IR opcodes locked to their hardware representation is risky because it causes opcodes as different as BRC and IFF to compare equal at the IR level (luckily the back-end only ever uses one opcode from each group, right now), and it prevents us from supporting instructions that change thei

[Mesa-dev] [PATCH 02/23] intel/eu: Define helper to specify the descriptor immediates of a SEND instruction.

2018-06-11 Thread Francisco Jerez
--- src/intel/compiler/brw_eu.h | 9 + src/intel/compiler/brw_eu_emit.c | 17 + 2 files changed, 26 insertions(+) diff --git a/src/intel/compiler/brw_eu.h b/src/intel/compiler/brw_eu.h index 0f07eeb3d6d..5a396339fde 100644 --- a/src/intel/compiler/brw_eu.h +++ b/src/

[Mesa-dev] [PATCH 01/23] intel/eu: Add brw_inst.h helpers for the SEND(C) descriptor and extended descriptor.

2018-06-11 Thread Francisco Jerez
This introduces helpers that can be used to specify or extract the whole descriptor of a SEND message instruction at once. Because the the instruction encoding of these is rather awkward on some generations using the generic brw_inst.h macros doesn't seem like an option. --- src/intel/compiler/br

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-11 Thread Rob Clark
On Mon, Jun 11, 2018 at 6:24 PM, Laura Ekstrand wrote: > I really like the rotate on hover effect for the gears. I would rather that > we use 2D WebGL for it if we could, though, since Mesa enables WebGL on > certain platforms. > webgl can be a bit heavy for startup time although it might be kin

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-11 Thread Laura Ekstrand
It's done already, it was a one-liner: https://gitlab.freedesktop.org/ldeks/mesa/commits/website1_75_v2 On Mon, Jun 11, 2018 at 5:15 PM, Stuart Young wrote: > Laura: Brilliant. Don't let it hang any deployment though. There's so much > more good in this that losing the favicon for a while is def

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-11 Thread Stuart Young
Laura: Brilliant. Don't let it hang any deployment though. There's so much more good in this that losing the favicon for a while is definitely worth it. On Tue, 12 Jun 2018 at 08:27, Laura Ekstrand wrote: > I really like the rotate on hover effect for the gears. I would rather > that we use 2D

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Rob Clark
On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger wrote: > Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: >> On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark > > wrote: >> >> Signed-off-by: Rob Clark > > >> --- >> I can't say for s

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 3:59 PM, Roland Scheidegger wrote: > Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: > > On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark > > wrote: > > > > Signed-off-by: Rob Clark > > > > --- > > I can't s

[Mesa-dev] [PATCH 39/48] meson: Set visibility and compat args for graw

2018-06-11 Thread Dylan Baker
--- src/gallium/targets/graw-gdi/meson.build | 1 + src/gallium/targets/graw-null/meson.build | 2 ++ src/gallium/targets/graw-xlib/meson.build | 1 + 3 files changed, 4 insertions(+) diff --git a/src/gallium/targets/graw-gdi/meson.build b/src/gallium/targets/graw-gdi/meson.build index e04b454a

[Mesa-dev] [PATCH 46/48] appveyor: Add support for meson as well as scons

2018-06-11 Thread Dylan Baker
This currently builds softpipe only --- appveyor.yml | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index bd33e2e9554..06063feba93 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -42,6 +42,9 @@ os: Visual Studio 2015 e

[Mesa-dev] [PATCH 24/48] docs/meson.html: fix numerous issues spotted by xmllint

2018-06-11 Thread Dylan Baker
--- docs/meson.html | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 6697dbb34ef..7541e7a71b0 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -1,9 +1,9 @@ http://www.w3.org/TR/html4/loose.dtd";> - + Compilation and I

[Mesa-dev] [PATCH 35/48] util/tests: Use define instead of VLA

2018-06-11 Thread Dylan Baker
To allow the this test to be built with MSVC, which doesn't support VLAs. --- src/util/tests/hash_table/clear.c | 13 +++-- src/util/tests/hash_table/delete_management.c | 13 +++-- src/util/tests/hash_table/insert_many.c | 11 ++- src/util/tests/hash_tabl

[Mesa-dev] [PATCH 33/48] meson: don't define GLX_USE_TLS for windows

2018-06-11 Thread Dylan Baker
Because the macros for exporting dll symbols and using TLS are mutually exclusive. --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index bbcfb8ed8cb..a244694fd4a 100644 --- a/meson.build +++ b/meson.build @@ -327,7 +327,10 @@ if wit

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Roland Scheidegger
Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: > On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark > wrote: > > Signed-off-by: Rob Clark > > --- > I can't say for sure that this will work on all drivers, but it is > what the blo

[Mesa-dev] [PATCH 12/48] meson: don't allow glvnd on windows

2018-06-11 Thread Dylan Baker
--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 1bdeeb95ec5..fb07c2dd0de 100644 --- a/meson.build +++ b/meson.build @@ -354,7 +354,9 @@ endif with_glvnd = get_option('glvnd') if with_glvnd - if with_glx == 'xlib' or with_g

[Mesa-dev] [PATCH 45/48] meson: allow python2 to be installed as python

2018-06-11 Thread Dylan Baker
On mac and Windows it may not be installed as python2, so search for python as well. Also check that what we find actually is python2 --- meson.build | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index e1b3afbe688..6fd02dd4c6c 10064

[Mesa-dev] [PATCH 20/48] meson: build graw-gdi target

2018-06-11 Thread Dylan Baker
--- src/gallium/meson.build | 4 ++- src/gallium/targets/graw-gdi/meson.build | 36 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/gallium/targets/graw-gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.bui

[Mesa-dev] [PATCH 10/48] meson: Add a platform for windows

2018-06-11 Thread Dylan Baker
This mirrors the haiku build which uses a platform. --- meson.build | 16 ++-- meson_options.txt | 1 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 634a7a21758..9c8b9ca9ba5 100644 --- a/meson.build +++ b/meson.build @@ -222,14

[Mesa-dev] [PATCH 07/48] glsl: fix general_ir_test with mingw

2018-06-11 Thread Dylan Baker
Somewhere down in the depths of the mingw headers 'interface' is defined, change it to iface like a similar patch did. --- src/compiler/glsl/tests/general_ir_test.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/tests/general_ir_test.cpp b/s

[Mesa-dev] [PATCH 44/48] meson: add windows specific linker flags

2018-06-11 Thread Dylan Baker
--- meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/meson.build b/meson.build index a244694fd4a..e1b3afbe688 100644 --- a/meson.build +++ b/meson.build @@ -847,6 +847,27 @@ else endforeach endif +# set linker arguments +if host_machine.system() == 'wind

[Mesa-dev] [PATCH 15/48] meson: Add windows defines to glapi

2018-06-11 Thread Dylan Baker
These are needed to control the export or symbols due to differences between the way windows and *nix handle symbol exports. --- src/mapi/es1api/meson.build | 10 +- src/mapi/es2api/meson.build | 10 +- src/mapi/glapi/meson.build| 13 - src/mapi/shar

[Mesa-dev] [PATCH 41/48] meson: Fix gtest linkage on msvc

2018-06-11 Thread Dylan Baker
We need to add an extra flag (/SUBSYSTEM:CONSOLE) to get the msvc linker to find main() in a static library. --- src/gtest/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gtest/meson.build b/src/gtest/meson.build index 91a49240416..ed0d6974bd3 100644 --- a/src/gtest/meso

[Mesa-dev] [PATCH 19/48] meson: build libgl-gdi target

2018-06-11 Thread Dylan Baker
--- src/gallium/meson.build | 1 + src/gallium/targets/libgl-gdi/meson.build | 44 +++ 2 files changed, 45 insertions(+) create mode 100644 src/gallium/targets/libgl-gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index a4f28d

[Mesa-dev] [PATCH 16/48] meson: Add necessary defines for mesa_gallium on windows

2018-06-11 Thread Dylan Baker
--- src/mesa/meson.build | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/meson.build b/src/mesa/meson.build index cba361c0988..c1606b4551e 100644 --- a/src/mesa/meson.build +++ b/src/mesa/meson.build @@ -716,11 +716,19 @@ libmesa_classic = static_library(

[Mesa-dev] [PATCH 21/48] meson: fix gallium-osmesa to build for windows

2018-06-11 Thread Dylan Baker
--- src/gallium/state_trackers/osmesa/meson.build | 12 ++-- src/gallium/targets/osmesa/meson.build| 9 - 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/osmesa/meson.build b/src/gallium/state_trackers/osmesa/meson.build index 91

[Mesa-dev] [PATCH 18/48] meson: build wgl state tracker

2018-06-11 Thread Dylan Baker
--- src/gallium/meson.build| 3 ++ src/gallium/state_trackers/wgl/meson.build | 50 ++ 2 files changed, 53 insertions(+) create mode 100644 src/gallium/state_trackers/wgl/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index 775

[Mesa-dev] [PATCH 17/48] meson: build gallium gdi winsys

2018-06-11 Thread Dylan Baker
--- src/gallium/meson.build | 6 ++ src/gallium/winsys/sw/gdi/meson.build | 27 +++ 2 files changed, 33 insertions(+) create mode 100644 src/gallium/winsys/sw/gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index 561af9d33

[Mesa-dev] [PATCH 48/48] tests/vma: fix build with MSVC

2018-06-11 Thread Dylan Baker
--- src/util/tests/vma/vma_random_test.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma/vma_random_test.cpp index de887fead30..26914a56d2c 100644 --- a/src/util/tests/vma/vma_random_test.cpp +++ b/src/util/tests/vma/vma_ra

[Mesa-dev] [PATCH 37/48] glsl/tests: define ssize_t on windows

2018-06-11 Thread Dylan Baker
--- src/compiler/glsl/tests/blob_test.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/tests/blob_test.c b/src/compiler/glsl/tests/blob_test.c index 1cc97236e7e..21b8b1efdc1 100644 --- a/src/compiler/glsl/tests/blob_test.c +++ b/src/compiler/glsl/tests/blob_test.c @@ -2

[Mesa-dev] [PATCH 22/48] meson: Don't check for posix_memalign on windows

2018-06-11 Thread Dylan Baker
There's a mingw bug for this, it exports __builtin_posix_memalign but not posix_memalign, so the check will succeed, but compiling will fail. --- meson.build | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index ed63276b63e..0b0203bc03d

[Mesa-dev] [PATCH 23/48] meson: Add support for wrapping llvm

2018-06-11 Thread Dylan Baker
For building on Windows (when not using cygwin), the assumption is that LLVM will have to be handled via a binary wrap. In this case the user wanting to use LLVM is this way will need to create a directory in subprojects (any name is fine), and pass that name via the -Dllvm-wrap option (for example

[Mesa-dev] [PATCH 42/48] meson: disable graw tests on mingw

2018-06-11 Thread Dylan Baker
I can't figure out why symbols are being exposed that shouldn't. --- src/gallium/tests/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 15b9f549647..1d08da2ac10 100644 --- a/src/gallium/tests/me

[Mesa-dev] [PATCH 27/48] meson: don't look for rt on windows

2018-06-11 Thread Dylan Baker
--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 67577241953..42e2540146c 100644 --- a/meson.build +++ b/meson.build @@ -1053,7 +1053,9 @@ elif with_dri_i965 and get_option('shader-cache') endif # Determine whether or not th

[Mesa-dev] [PATCH 47/48] appveyor: use chocolatey (cinst) to isntall winflexbixon

2018-06-11 Thread Dylan Baker
--- appveyor.yml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 06063feba93..f544314e730 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,13 +34,11 @@ branches: clone_depth: 100 cache: -- win_flex_bison-2.5.9.zip - llvm-3.3.1-msvc

[Mesa-dev] [PATCH 29/48] meson: don't look for nm binary on windows

2018-06-11 Thread Dylan Baker
--- meson.build | 5 - src/mapi/es1api/meson.build | 2 +- src/mapi/es2api/meson.build | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index f3e9676f8bf..abe45e933ba 100644 --- a/meson.build +++ b/meson.build @@ -1468,8 +1468,11

[Mesa-dev] [PATCH 40/48] meosn: don't build gallium trivial tests on windows

2018-06-11 Thread Dylan Baker
They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 0ee04350c87..15b9f549647 100644 --- a

[Mesa-dev] [PATCH 38/48] nir/meson: fix c vs cpp args for nir test

2018-06-11 Thread Dylan Baker
--- src/compiler/nir/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/meson.build b/src/compiler/nir/meson.build index 598c68aff9f..b6677ae7793 100644 --- a/src/compiler/nir/meson.build +++ b/src/compiler/nir/meson.build @@ -231,7 +231,7 @@ if with_t

[Mesa-dev] [PATCH 32/48] meson: add switches for SWR with MSVC

2018-06-11 Thread Dylan Baker
--- src/gallium/drivers/swr/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index b95c8bc1bf8..ec4d80e4bb2 100644 --- a/src/gallium/drivers/swr/meson.build +++ b/src/gallium/drivers/swr/mes

[Mesa-dev] [PATCH 31/48] meson: disable sse4.1 optimizations with msvc

2018-06-11 Thread Dylan Baker
There isn't an obvious command line switch here, /arch:AVX *might* be the right thing, but meson doesn't know what to do here either and leaves the -msse4.1 and -mstackrealign. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index abe45

[Mesa-dev] [PATCH 02/48] add a git ignore for subprojects

2018-06-11 Thread Dylan Baker
--- subprojects/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 subprojects/.gitignore diff --git a/subprojects/.gitignore b/subprojects/.gitignore new file mode 100644 index 000..68a882edba6 --- /dev/null +++ b/subprojects/.gitignore @@ -0,0 +1,3 @@ +* +!*.wrap +!

[Mesa-dev] [PATCH 34/48] meson: Add idep_getopt for tests

2018-06-11 Thread Dylan Baker
There are quite a few tests that require getopt, when using MSVC we need to use the bundled version of getopt since there isn't a system version. --- src/compiler/glsl/glcpp/meson.build | 2 +- src/compiler/glsl/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff -

[Mesa-dev] [PATCH 26/48] meson: fix pipe-loader compilation for windows

2018-06-11 Thread Dylan Baker
--- src/gallium/auxiliary/pipe-loader/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/meson.build b/src/gallium/auxiliary/pipe-loader/meson.build index 32e8188c68b..207e4b0fac4 100644 --- a/src/gallium/auxiliary/pipe-loade

[Mesa-dev] [PATCH 28/48] meson: Add support for using win_flex and win_bison on windows

2018-06-11 Thread Dylan Baker
--- meson.build | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 42e2540146c..f3e9676f8bf 100644 --- a/meson.build +++ b/meson.build @@ -1257,8 +1257,31 @@ endif # pthread stubs. Lets not and say we didn't -prog_b

[Mesa-dev] [PATCH 13/48] meson: add windows compiler checks and libraries

2018-06-11 Thread Dylan Baker
--- meson.build | 126 ++-- 1 file changed, 82 insertions(+), 44 deletions(-) diff --git a/meson.build b/meson.build index fb07c2dd0de..4247d195bc1 100644 --- a/meson.build +++ b/meson.build @@ -688,6 +688,8 @@ if has_mako.returncode() != 0 endif

[Mesa-dev] [PATCH 43/48] meson: don't build or run mesa-sha1 test on windows

2018-06-11 Thread Dylan Baker
It crashes hard (pop-up window and all). --- src/util/meson.build | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/util/meson.build b/src/util/meson.build index c777984e28d..cf1eb64362d 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@ -1

[Mesa-dev] [PATCH 36/48] meson: Don't build glsl cache_test for windows

2018-06-11 Thread Dylan Baker
--- src/compiler/glsl/tests/meson.build | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..725bc37438e 100644 --- a/src/compiler/glsl/tests/meson.build +++ b/src

[Mesa-dev] [PATCH 25/48] util/xmlconfig: include strndup.h for windows

2018-06-11 Thread Dylan Baker
--- src/util/xmlconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c index 60a6331c86c..de3548b6b9d 100644 --- a/src/util/xmlconfig.c +++ b/src/util/xmlconfig.c @@ -36,6 +36,7 @@ #include #include #include +#include "strndup.h" #include "x

[Mesa-dev] [PATCH 11/48] meson: don't build glx or dri by default on windows

2018-06-11 Thread Dylan Baker
--- meson.build | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 9c8b9ca9ba5..1bdeeb95ec5 100644 --- a/meson.build +++ b/meson.build @@ -266,9 +266,13 @@ if with_glx == 'auto' elif with_platform_haiku with_glx = 'disabled' el

[Mesa-dev] [PATCH 30/48] meson: for incluse of inttypes.h for glcpp with msvc

2018-06-11 Thread Dylan Baker
Because we provide a copy if MSVC doesn't, and we need it to make flex do what we want. --- src/compiler/glsl/glcpp/meson.build | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index 09d44

  1   2   >