Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-06 Thread Tapani Pälli
On 05/04/2018 05:59 PM, Nanley Chery wrote: On Fri, May 04, 2018 at 09:03:32AM +0300, Tapani Pälli wrote: Hi Nanley; Hey Tapani, On 05/03/2018 10:03 PM, Nanley Chery wrote: Before this patch, if we failed to initialize an MCS buffer, we'd end up in a state in which the miptree thinks it h

[Mesa-dev] [PATCH 05/11] st/mesa: Make feedback draw and rasterpos use _DrawVAO.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Instead of playing with Array._DrawArrays, make the feedback draw path use Array._DrawVAO. Also st_RasterPos needs to use the VAO then. v2: Use helper methods to get the offset values for array and binding. Update comments. Signed-off-by: Mathias Fröhlich --- src/me

[Mesa-dev] [PATCH 06/11] st/mesa: Remove the now unused gl_vertex_array.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Was meant to be temporary in gallium. Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker/st_cb_feedback.c | 32 ++-- src/mesa/state_tracker/st_context.c | 3 --- src/mesa/state_tracker/st_context.h | 3 --- src/mesa/state_tra

[Mesa-dev] [PATCH 02/11] st/mesa: Use _DrawVAO for edgeflag enabled check.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker/st_atom.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c index 45a45960a3..df1a94e831 100644 --- a/src/mesa/stat

[Mesa-dev] [PATCH 10/11] mesa: Remove Array._DrawArrays.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Only tnl based drivers still use this array. So remove it from core mesa and use Array._DrawVAO instead. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/nouveau/nouveau_vbo_t.c | 4 ++-- src/mesa/main/arrayobj.c | 1 - src/mesa/main/attrib.

[Mesa-dev] [PATCH 01/11] mesa: Compute effective buffer bindings in the vao.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Compute VAO buffer binding information past the position/generic0 mapping. Scan for duplicate buffer bindings and collapse them into derived effective buffer binding index and effective attribute mask variables. Provide a set of helper functions to access the distilled info

[Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Finally make use of the binding information in the VAO when setting up arrays for draw. v2: Emit less relocations also for interleaved userspace arrays. Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker/st_atom_array.c | 432 - 1

[Mesa-dev] [PATCH 11/11] mesa/vbo/tnl: Move gl_vertex_array related stuff to tnl.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich The only remaining users of gl_vertex_array are tnl based drivers. So move everything related to that into tnl and rename it accordingly. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/nouveau/nouveau_vbo_t.c | 38 +-- src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 08/11] i965: Remove the gl_vertex_array indirection.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich For now store binding and attrib in brw_vertex_element. The i965 driver still provides lots of opportunity to make use of the unique binding information in the VAO which is currently not taken from the VAO. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 09/11] i965: Remove the now unused gl_vertex_array.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Was meant to be temporary in i965. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_context.h | 4 src/mesa/drivers/dri/i965/brw_draw.c| 7 --- 2 files changed, 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mes

[Mesa-dev] [PATCH 07/11] i965: Implement all_varyings_in_vbos in terms of Array._DrawVAO.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_draw.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index 25ba372c44..c5f04264fa 100644

[Mesa-dev] [PATCH 03/11] st/mesa: Make the input_to_index array available.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich The input_to_index array is already available internally when preparing vertex programs. Store the map in struct st_vertex_program. Also store the bitmask of mesa vertex processing inputs in struct st_vp_variant. Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker

[Mesa-dev] [PATCH 00/11] Use binding information from DrawVAO v2.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Brian, The second version of 'we are getting there somehow'. The series builds up unique binding information internal to a VAO. This shall help drivers to get as few buffer objects as possible. The first patch implements building up this unique binding information. Then

Re: [Mesa-dev] [PATCH 3/5] ffvertex: Don't try to read output registers in fog calculation

2018-05-06 Thread Ian Romanick
On 05/06/2018 05:31 PM, Timothy Arceri wrote: > On 05/05/18 07:28, Kenneth Graunke wrote: > >> On Thursday, April 26, 2018 2:28:41 PM PDT Ian Romanick wrote: >>> From: Ian Romanick >>> >>> This code was clearly never tested.  It's a good thing that no driver >>> ever tried to enable this path. >>

[Mesa-dev] [Bug 106315] The witness + dxvk suffers flickering garbage

2018-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106315 Matthew Scheirer changed: What|Removed |Added CC||matt.schei...@gmail.com -- You are

[Mesa-dev] [Bug 103852] Rendering errors when running dolphin-emu with Vulkan backend, radv (Super Smash Bros. Melee)

2018-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103852 --- Comment #18 from Ben Clapp --- Bug still present on 18.0.2. I noticed flickering back and forth between a black screen and the game screen when resizing the window, so I made a short video demonstrating this: https://www.youtube.com/watch?v=

Re: [Mesa-dev] [PATCH 3/5] ffvertex: Don't try to read output registers in fog calculation

2018-05-06 Thread Timothy Arceri
On 05/05/18 07:28, Kenneth Graunke wrote: On Thursday, April 26, 2018 2:28:41 PM PDT Ian Romanick wrote: From: Ian Romanick This code was clearly never tested. It's a good thing that no driver ever tried to enable this path. Signed-off-by: Ian Romanick --- src/mesa/main/ffvertex_prog.c |

Re: [Mesa-dev] [PATCH 1/2] mesa: add R10G10B10{A, X}2 to MESA <-> DRI format translations

2018-05-06 Thread Dylan Baker
On May 4, 2018 5:44:25 PM PDT, Chad Versace wrote: >Thanks for the patches. The code looks good. All my suggestions are >merely nitpicks to make the patches follow Mesa conventions. > >In general, if you have questions about commit message style, examine >the git log for previous patches that to

Re: [Mesa-dev] [RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

2018-05-06 Thread Mario Kleiner
On Sun, May 6, 2018 at 1:51 PM, Tobias Klausmann wrote: > Hi, > > fyi: there is another bugreport #106372 [1], where i bisected the problem in > the xserver and found a problematic commit, with code which can easily be > reverted (patch in the bugreport), maybe you could check if that fixes the >

[Mesa-dev] [Bug 106420] segfault in dri2_allocate_textures(), radeonsi_dri.so 18.1-rc3 using mpv

2018-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106420 --- Comment #1 from Axel Rohde --- Additional system info: libdrm 2.4.91 Linux debi2 4.16.0-1-amd64 #1 SMP Debian 4.16.5-1 (2018-04-29) x86_64 GNU/Linux libva 2.1.0 -- You are receiving this mail because: You are the QA Contact for the bug. Yo

[Mesa-dev] [Bug 106420] segfault in dri2_allocate_textures(), radeonsi_dri.so 18.1-rc3 using mpv

2018-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106420 Bug ID: 106420 Summary: segfault in dri2_allocate_textures(), radeonsi_dri.so 18.1-rc3 using mpv Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Li

Re: [Mesa-dev] [PATCH] wsi/x11: Don't cal pixmap_from_buffers if modifiers is not supported

2018-05-06 Thread Lionel Landwerlin
Oops, missed that v2. Still : Reviewed-by: Lionel Landwerlin On 05/05/18 19:11, Jason Ekstrand wrote: In the prime case, our modifier is always DRM_FORMAT_MOD_LINEAR and we would end up calling dri3_pixmap_from_buffers on an X server which does not support it. Bugzilla: https://bugs.freedeskt

Re: [Mesa-dev] [PATCH] wsi/x11: Don't cal pixmap_from_buffers if modifiers is not supported

2018-05-06 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin s/cal/call/ :) On 05/05/18 19:08, Jason Ekstrand wrote: In the prime case, our modifier is always DRM_FORMAT_MOD_LINEAR and we would end up calling dri3_pixmap_from_buffers on an X server which does not support it. Bugzilla: https://bugs.freedesktop.org/show_bug

Re: [Mesa-dev] [PATCH] intel/genxml: Fix a few invalid field widths

2018-05-06 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 05/05/18 19:39, Chris Wilson wrote: A couple of typos found by inspecting field.end - field.start, revealed a few wide integers declared as bool and some that ended before they started. Cc: Lionel Landwerlin - - - - - - +

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-06 Thread Jason Ekstrand
Rb On May 5, 2018 06:35:46 Bas Nieuwenhuizen wrote: This was setting the LINEAR modifier if neither the X server nor the driver supported modifiers. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" CC: 18.1 CC: Abel G

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-06 Thread Jason Ekstrand
On May 6, 2018 05:58:52 Daniel Stone wrote: Hi, On 5 May 2018 at 19:07, Jason Ekstrand wrote: On Sat, May 5, 2018 at 6:34 AM, Bas Nieuwenhuizen wrote: @@ -1043,7 +1043,8 @@ x11_image_init(VkDevice device_h, struct x11_swapchain *chain, uint32_t bpp = 32; if (chain->base.use_prime_blit)

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-06 Thread Daniel Stone
Hi, On 5 May 2018 at 19:07, Jason Ekstrand wrote: > On Sat, May 5, 2018 at 6:34 AM, Bas Nieuwenhuizen > wrote: >> @@ -1043,7 +1043,8 @@ x11_image_init(VkDevice device_h, struct >> x11_swapchain *chain, >> uint32_t bpp = 32; >> >> if (chain->base.use_prime_blit) { >> - result = wsi_

Re: [Mesa-dev] [RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

2018-05-06 Thread Tobias Klausmann
Hi, fyi: there is another bugreport #106372 [1], where i bisected the problem in the xserver and found a problematic commit, with code which can easily be reverted (patch in the bugreport), maybe you could check if that fixes the issue as well! PS: I looked into bugzilla last weekend where i

[Mesa-dev] [PATCH] mesa/formatquery: remove online compression check on is_resource_supported

2018-05-06 Thread Alejandro Piñeiro
is_resource_supported returns if the combination of target/internalformat is supported in at least one operation. Online compression is only mandatory for glTexImage2D. Some formats doesn't support online compression, but can be used in any case, with glCompressed*D methods. Without this commit, E

Re: [Mesa-dev] [RFC PATCH] mesa/st/cb_clear: in st_Clear also validate the render state (needed by virgl)

2018-05-06 Thread Gert Wollny
Dear Ilia, it took me a while but I think I understand now, thanks for all your explanations. Am Freitag, den 04.05.2018, 18:11 -0400 schrieb Ilia Mirkin: > > Rasterizer state doesn't affect the gallium clear callback. clear > just clears -- it's a memset. However rasterizer state affects > g