Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Roman Gilg
On Sat, May 5, 2018 at 8:50 PM, Mario Kleiner wrote: > Thanks. Can you see if you get any freezes in kwin_x11 by "violent > alt-tabbing" with patch 1? I've seen two such freezes within 8 hours > of normal use yesterday, each occuring when i alt-tabbed (normally) > and the switcher side panel moved

Re: [Mesa-dev] [PATCH] intel/genxml: Fix a few invalid field widths

2018-05-05 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Sat, May 5, 2018 at 11:39 AM, Chris Wilson wrote: > A couple of typos found by inspecting field.end - field.start, revealed > a few wide integers declared as bool and some that ended before they > started. > > Cc: Lionel Landwerlin --- > src/intel/genxml/gen4.xm

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mario Kleiner
On Sat, May 5, 2018 at 4:44 PM, Roman Gilg wrote: > Without this patch plasmashell on Xserver/Mesa master freezes on me > when opening the launcher menu (Kickoff). With the patch haven't > experienced freezes yet. > > Haven't tested the Steam client yet. Might be a different problem though. > > Te

[Mesa-dev] [PATCH] intel/genxml: Fix a few invalid field widths

2018-05-05 Thread Chris Wilson
A couple of typos found by inspecting field.end - field.start, revealed a few wide integers declared as bool and some that ended before they started. Cc: Lionel Landwerlin --- src/intel/genxml/gen4.xml | 12 ++-- src/intel/genxml/gen45.xml | 12 ++-- src/intel/genxml/gen5.xml |

[Mesa-dev] [PATCH] intel/genxml: Fix a few invalid field widths

2018-05-05 Thread Chris Wilson
A couple of typos found by inspecting field.end - field.start, revealed a few wide integers declared as bool and some that ended before they started. Cc: Lionel Landwerlin - - - - - - + + + + + + diff --git a/src/intel/genxml/g

[Mesa-dev] [Bug 106411] Invalid gl_InstanceID value with combination of gl_DrawIDARB under OpenGL

2018-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106411 Bug ID: 106411 Summary: Invalid gl_InstanceID value with combination of gl_DrawIDARB under OpenGL Product: Mesa Version: 18.0 Hardware: Other OS: All

[Mesa-dev] [PATCH] wsi/x11: Don't cal pixmap_from_buffers if modifiers is not supported

2018-05-05 Thread Jason Ekstrand
In the prime case, our modifier is always DRM_FORMAT_MOD_LINEAR and we would end up calling dri3_pixmap_from_buffers on an X server which does not support it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" --- src/vulkan

[Mesa-dev] [PATCH] wsi/x11: Don't cal pixmap_from_buffers if modifiers is not supported

2018-05-05 Thread Jason Ekstrand
In the prime case, our modifier is always DRM_FORMAT_MOD_LINEAR and we would end up calling dri3_pixmap_from_buffers on an X server which does not support it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" --- src/vulkan

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-05 Thread Jason Ekstrand
On Sat, May 5, 2018 at 6:34 AM, Bas Nieuwenhuizen wrote: > This was setting the LINEAR modifier if neither the > X server nor the driver supported modifiers. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 > Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" > CC: 18.

Re: [Mesa-dev] [PATCH 1/1] clover: Add explicit virtual destructors to argument and scalar_argument class

2018-05-05 Thread Jan Vesely
On Fri, 2018-05-04 at 10:56 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > These are needed to destroy the v vector. > > Fixes memory leaks on kernel launch. > > Signed-off-by: Jan Vesely > > --- > > src/gallium/state_trackers/clover/core/kernel.hpp | 2 ++ > > 1 file changed, 2 inser

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
Thank you for the clarification. On Sat, 5 May 2018 at 14:31 Daniel Stone wrote: > On 5 May 2018 at 10:15, Mike Lothian wrote: > > Out of interest can you try running the vulkan smoketest, I'm seeing > this: > > > > smoketest > > terminate called after throwing an instance of 'std::runtime_erro

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Roman Gilg
Without this patch plasmashell on Xserver/Mesa master freezes on me when opening the launcher menu (Kickoff). With the patch haven't experienced freezes yet. Haven't tested the Steam client yet. Might be a different problem though. Tested-by: Roman Gilg On Fri, May 4, 2018 at 3:45 PM, Mario Kle

[Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-05 Thread Bas Nieuwenhuizen
This was setting the LINEAR modifier if neither the X server nor the driver supported modifiers. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" CC: 18.1 CC: Abel Garcia Dorta CC: Daniel Stone --- src/vulkan/wsi/wsi_co

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Daniel Stone
On 5 May 2018 at 10:15, Mike Lothian wrote: > Out of interest can you try running the vulkan smoketest, I'm seeing this: > > smoketest > terminate called after throwing an instance of 'std::runtime_error' > what(): VkResult -101004 returned > Aborted (core dumped) VK_ERROR_OUT_OF_DATE_KHR i

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-05-05 Thread Jason Ekstrand
On Wed, May 2, 2018 at 2:35 AM, Michel Dänzer wrote: > From: Michel Dänzer > > And only free no longer needed back buffers there as well. > > We want to stick to the same back buffer throughout a frame, otherwise > we can run into various issues. > > Bugzilla: https://bugs.freedesktop.org/105906

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #15 from mercuriete --- Created attachment 139368 --> https://bugs.freedesktop.org/attachment.cgi?id=139368&action=edit Xorg log -- You are receiving this mail because: You are the assignee for the bug.___

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #14 from mercuriete --- I think i am. I am using a laptop with prime configuration. So I think when using plasma kde (kwin_x11 compositor) i am using X11 over intel. What I not sure is what DDX drivers i am using. I think i am usi

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
Which is: VK_ERROR_OUT_OF_DATE_KHR = -101004, On Sat, 5 May 2018 at 10:15 Mike Lothian wrote: > Out of interest can you try running the vulkan smoketest, I'm seeing this: > > smoketest > terminate called after throwing an instance of 'std::runtime_error' > what(): VkResult -101004 re

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
Out of interest can you try running the vulkan smoketest, I'm seeing this: smoketest terminate called after throwing an instance of 'std::runtime_error' what(): VkResult -101004 returned Aborted (core dumped) On Sat, 5 May 2018 at 05:25 Mario Kleiner wrote: > On Sat, May 5, 2018 at 4:08 A

Re: [Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-05 Thread Chris Wilson
Quoting James Xiong (2018-05-05 01:56:01) > This series align the buffer size up to page instead of a bucket size > to improve memory allocation efficiency. It doesn't though. It still retrieves up to the bucket size, so with a little cache poisoning (or a series of unfortunate events) it will be

Re: [Mesa-dev] [PATCH v3] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

2018-05-05 Thread Alejandro Piñeiro
On 04/05/18 21:06, Eleni Maria Stea wrote: > Hi Eero, > > On Fri, 4 May 2018 18:29:55 +0300 > Eero Tamminen wrote: > >> You mean returning CAVEAT_SUPPORT in params for compressed formats >> which are transparently converted to uncompressed data? > Well, that would be the best solution I think, if

Re: [Mesa-dev] [PATCH 4/4] i965/drm: Purge the bucket when its cached buffer is evicted

2018-05-05 Thread Chris Wilson
Quoting James Xiong (2018-05-05 01:56:05) > From: "Xiong, James" > > When one of cached buffers is found to be evicted by kernel, > most likely the buffers freed earlier than this buffer are > gone too, go through the cached list in the bucket and purge. The order in this list bears little relev

Re: [Mesa-dev] [PATCH 06/10] i965: Add virtual memory allocator infrastructure to brw_bufmgr.

2018-05-05 Thread Chris Wilson
Quoting Chris Wilson (2018-05-04 22:27:27) > Quoting Kenneth Graunke (2018-05-04 02:12:36) > > + if (brw_using_softpin(bufmgr) && bo->gtt_offset == 0ull) { > > + bo->gtt_offset = vma_alloc(bufmgr, memzone, bo->size, 1); > > + > > + if (bo->gtt_offset == 0ull) > > + goto err_free

Re: [Mesa-dev] [PATCH 06/10] i965: Add virtual memory allocator infrastructure to brw_bufmgr.

2018-05-05 Thread Chris Wilson
Quoting Kenneth Graunke (2018-05-04 02:12:36) > This introduces a new fast virtual memory allocator integrated with our > BO cache bucketing. For larger objects, it falls back to the simple > free-list allocator (util_vma). > > This puts the allocators in place but doesn't enable softpin yet. > -