Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Jason Ekstrand
Rather lively discussion we've got going here... On Sun, Apr 8, 2018 at 3:23 PM, Rob Clark wrote: > On Sun, Apr 8, 2018 at 5:54 PM, Bas Nieuwenhuizen > wrote: > > On Sun, Apr 8, 2018 at 11:40 PM, Rob Clark wrote: > >> On Sun, Apr 8, 2018 at 5:20 PM, Bas Nieuwenhuizen > >> wrote: > >>>

[Mesa-dev] [Bug 105943] configure.ac bash-ism

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105943 Jason Ekstrand changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] configure.ac bash-isms

2018-04-08 Thread Jason Ekstrand
Please send your patches to the mailing list, not bugzilla. On April 8, 2018 14:20:25 sylvain.bertr...@gmail.com wrote: Hi, I detected 2 bash-isms in configure.ac. 2 "one-liner" "trivial" patches are provided on the bugzilla https://bugs.freedesktop.org/show_bug.cgi?id=105943 regards, --

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Rob Clark
On Sun, Apr 8, 2018 at 5:54 PM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 11:40 PM, Rob Clark wrote: >> On Sun, Apr 8, 2018 at 5:20 PM, Bas Nieuwenhuizen >> wrote: >>> + >>> + /** The mode of the underlying variable */ >>> + nir_variable_mode mode; >>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Bas Nieuwenhuizen
On Sun, Apr 8, 2018 at 11:40 PM, Rob Clark wrote: > On Sun, Apr 8, 2018 at 5:20 PM, Bas Nieuwenhuizen > wrote: >> + >> + /** The mode of the underlying variable */ >> + nir_variable_mode mode; > > In fact, it seems like deref->mode is unused outside of

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Rob Clark
On Sun, Apr 8, 2018 at 5:20 PM, Bas Nieuwenhuizen wrote: > + > + /** The mode of the underlying variable */ > + nir_variable_mode mode; In fact, it seems like deref->mode is unused outside of nir_print and nir_validate.. for logical addressing

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Bas Nieuwenhuizen
On Sun, Apr 8, 2018 at 10:43 PM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 10:23 PM, Bas Nieuwenhuizen > wrote: >> On Tue, Apr 3, 2018 at 8:32 PM, Jason Ekstrand wrote: >>> This commit adds a new instruction type to NIR for handling derefs. >>> Nothing uses it yet but this adds the data

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Bas Nieuwenhuizen
+ + /** The mode of the underlying variable */ + nir_variable_mode mode; >>> >>> In fact, it seems like deref->mode is unused outside of nir_print and >>> nir_validate.. for logical addressing we can get the mode from the >>> deref_var->var at the star

[Mesa-dev] configure.ac bash-isms

2018-04-08 Thread sylvain . bertrand
Hi, I detected 2 bash-isms in configure.ac. 2 "one-liner" "trivial" patches are provided on the bugzilla https://bugs.freedesktop.org/show_bug.cgi?id=105943 regards, -- Sylvain ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.f

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Rob Clark
On Sun, Apr 8, 2018 at 4:26 PM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 6:06 PM, Rob Clark wrote: >> On Sun, Apr 8, 2018 at 11:15 AM, Bas Nieuwenhuizen >> wrote: >>> On Sun, Apr 8, 2018 at 3:29 PM, Rob Clark wrote: On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen wrote: >>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Bas Nieuwenhuizen
On Sun, Apr 8, 2018 at 10:23 PM, Bas Nieuwenhuizen wrote: > On Tue, Apr 3, 2018 at 8:32 PM, Jason Ekstrand wrote: >> This commit adds a new instruction type to NIR for handling derefs. >> Nothing uses it yet but this adds the data structure as well as all of >> the code to validate, print, clone,

[Mesa-dev] [Bug 105442] Hang when running nine ff lighting shader with radeonsi

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105442 Axel Davy changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Bas Nieuwenhuizen
On Sun, Apr 8, 2018 at 6:06 PM, Rob Clark wrote: > On Sun, Apr 8, 2018 at 11:15 AM, Bas Nieuwenhuizen > wrote: >> On Sun, Apr 8, 2018 at 3:29 PM, Rob Clark wrote: >>> On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen >>> wrote: On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark wrote: > On Tue

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Bas Nieuwenhuizen
On Tue, Apr 3, 2018 at 8:32 PM, Jason Ekstrand wrote: > This commit adds a new instruction type to NIR for handling derefs. > Nothing uses it yet but this adds the data structure as well as all of > the code to validate, print, clone, and [de]serialize them. > --- > src/compiler/nir/nir.c

[Mesa-dev] [Bug 105942] Graphical artefacts after update to mesa 18.0.0-2

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105942 --- Comment #2 from kaspar.t...@gmail.com --- An RX 480. The screen appears after queuing for a game in dota. Once the matchmaking system finds a suitable game for you, such pop-up will appear in the game for you so you can decide to either join

Re: [Mesa-dev] [PATCH v3 003/104] nir/builder: Add deref building helpers

2018-04-08 Thread Rob Clark
On Sun, Apr 8, 2018 at 7:21 AM, Rob Clark wrote: > On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: >> --- >> src/compiler/nir/nir_builder.h | 106 >> + >> 1 file changed, 106 insertions(+) >> >> diff --git a/src/compiler/nir/nir_builder.h b/src/comp

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Rob Clark
On Sun, Apr 8, 2018 at 11:15 AM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 3:29 PM, Rob Clark wrote: >> On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen >> wrote: >>> On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark wrote: On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote:

[Mesa-dev] [Bug 105943] configure.ac bash-ism

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105943 --- Comment #5 from Ilia Mirkin --- Submit patches. https://www.mesa3d.org/submittingpatches.html -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 105943] configure.ac bash-ism

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105943 --- Comment #4 from Sylvain BERTRAND --- Created attachment 138686 --> https://bugs.freedesktop.org/attachment.cgi?id=138686&action=edit another bashism -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 105943] configure.ac bash-ism

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105943 --- Comment #3 from Sylvain BERTRAND --- found another one -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Bas Nieuwenhuizen
On Sun, Apr 8, 2018 at 3:29 PM, Rob Clark wrote: > On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen > wrote: >> On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark wrote: >>> On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: This commit adds a new instruction type to NIR for handling derefs. >>

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Rob Clark
On Sun, Apr 8, 2018 at 8:58 AM, Bas Nieuwenhuizen wrote: > On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark wrote: >> On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: >>> This commit adds a new instruction type to NIR for handling derefs. >>> Nothing uses it yet but this adds the data structure as

[Mesa-dev] [Bug 105943] configure.ac bash-ism

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105943 --- Comment #2 from Sylvain BERTRAND --- Created attachment 138684 --> https://bugs.freedesktop.org/attachment.cgi?id=138684&action=edit configure.ac bash-ism -- You are receiving this mail because: You are the QA Contact for the bug. You ar

[Mesa-dev] [Bug 105943] configure.ac bash-ism

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105943 Sylvain BERTRAND changed: What|Removed |Added Attachment #138683|0 |1 is obsolete|

[Mesa-dev] [Bug 105943] configure.ac bash-ism

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105943 --- Comment #1 from Sylvain BERTRAND --- Created attachment 138683 --> https://bugs.freedesktop.org/attachment.cgi?id=138683&action=edit configure.ac bash-ism -- You are receiving this mail because: You are the QA Contact for the bug. You ar

[Mesa-dev] [Bug 105943] configure.ac bash-ism

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105943 Bug ID: 105943 Summary: configure.ac bash-ism Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority:

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Bas Nieuwenhuizen
On Sun, Apr 8, 2018 at 1:38 PM, Rob Clark wrote: > On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: >> This commit adds a new instruction type to NIR for handling derefs. >> Nothing uses it yet but this adds the data structure as well as all of >> the code to validate, print, clone, and [de]

[Mesa-dev] [Bug 105942] Graphical artefacts after update to mesa 18.0.0-2

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105942 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Bas Ni

[Mesa-dev] [Bug 105942] Graphical artefacts after update to mesa 18.0.0-2

2018-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105942 Bug ID: 105942 Summary: Graphical artefacts after update to mesa 18.0.0-2 Product: Mesa Version: 18.0 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH v3 004/104] nir: Add _deref versions of all of the _var intrinsics

2018-04-08 Thread Rob Clark
On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir.h | 2 +- > src/compiler/nir/nir_builder.h | 37 > src/compiler/nir/nir_intrinsics.py | 72 > ++ > src/compiler/nir/nir_validate.c| 34

Re: [Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-08 Thread Rob Clark
On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: > This commit adds a new instruction type to NIR for handling derefs. > Nothing uses it yet but this adds the data structure as well as all of > the code to validate, print, clone, and [de]serialize them. > --- > src/compiler/nir/nir.c

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-08 Thread Juan A. Suarez Romero
On Fri, 2018-04-06 at 11:20 -0700, Mark Janes wrote: > Emil Velikov writes: > > > On 5 April 2018 at 20:33, Mark Janes > > wrote: > > > Emil Velikov writes: > > > > > > > On 4 April 2018 at 22:50, Mark Janes > > > > wrote: > > > > > Leo Liu writes: > > > > > > > > > > > On 04/04/2018 12:40

Re: [Mesa-dev] [PATCH v3 003/104] nir/builder: Add deref building helpers

2018-04-08 Thread Rob Clark
On Sun, Apr 8, 2018 at 7:21 AM, Rob Clark wrote: > On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: >> --- >> src/compiler/nir/nir_builder.h | 106 >> + >> 1 file changed, 106 insertions(+) >> >> diff --git a/src/compiler/nir/nir_builder.h b/src/comp

Re: [Mesa-dev] [PATCH v3 003/104] nir/builder: Add deref building helpers

2018-04-08 Thread Rob Clark
On Tue, Apr 3, 2018 at 2:32 PM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_builder.h | 106 > + > 1 file changed, 106 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h > index 8f7ddf1..69c7261 100644 > -