Re: [Mesa-dev] [PATCH] r600: don't emit vfetch if tess eval isn't accessing any inputs.

Hi Dave, tested on BARTS: the patch changes TESS_EVAL to end with a proper EOP in  trivial-tess-gs_no-gs-inputs (it doesn't fix the piglit though). However, it introduces a regression in vs-tcs-tes-tessinner-tessouter-inputs-quads    vs-tes-tessinner-tessouter-inputs-quads because in th

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #6 from Tapani Pälli --- Hello, could you please retry with using "sna" as the acceleration method? I will attach here required configuration file for testing this. You will need to copy this file to /usr/share/X11/xorg.conf.d/. --

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #7 from Tapani Pälli --- Created attachment 135480 --> https://bugs.freedesktop.org/attachment.cgi?id=135480&action=edit enable sna -- You are receiving this mail because: You are the QA Contact for the bug.__

[Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

We can write to the same output but in different components, like in this example: layout(location = 0, component = 0) out ivec2 dEQP_FragColor_0; layout(location = 0, component = 2) out ivec2 dEQP_FragColor_1; Therefore, they are not two different outputs but only one. Fixes: dEQP-VK.glsl.440.

Re: [Mesa-dev] [PATCH] anv: fix bug when using component qualifier in FS outputs

On Wed, 2017-11-08 at 08:19 -0800, Jason Ekstrand wrote: > On Thu, Nov 2, 2017 at 12:28 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > > > We can write to the same output but in different components, like > > in this example: > > > > layout(location = 0, component = 0) out ivec2

Re: [Mesa-dev] [PATCH 12/14] intel/blorp: Add indirect clear color support to mcs_partial_resolve

On Tue, Nov 14, 2017 at 3:28 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 13/11/17 16:12, Jason Ekstrand wrote: > >> This is a bit complicated because we have to get the indirect clear >> color in there somehow. In order to not do any more work in the shader >> than needed,

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

Does someone know what's going on with that? Build started git clone -q --depth=100 --branch=master git://anongit.freedesktop.org/mesa/mesa C:\projects\mesa remote: fatal: unable to read 7a5d62c8e87c50bacaf697e05230ba49a71a0129 remote: aborting due to possible repository corruption on the remote

[Mesa-dev] [AppVeyor] mesa master #6163 failed

Build mesa 6163 failed Commit 65123ee62c by Roland Scheidegger on 11/9/2017 6:53 PM: r600: set the number type correctly for float rts in cb setup\n\nFloat rts were always set as unorm instead of float.\nNot sure of the consequences, but at least it looks like

[Mesa-dev] [Bug 103748] [softpipe] pigilt arb_internalformat_query2-image-texture regression

https://bugs.freedesktop.org/show_bug.cgi?id=103748 --- Comment #1 from Marek Olšák --- Not a regression. The test uses GL 3.0 and TBOs are now enabled with 3.0, which means TBO subtests are enabled for the first time. The test also had some TBO bugs and might have more. This is untested territor

Re: [Mesa-dev] [PATCH] mapi: Use correct shared library name on macOS.

I think "suffix" would be better for the title "name". Also, library -> libraries. With that changed: Reviewed-by: Dylan Baker Quoting Vinson Lee (2017-11-14 17:17:49) > Signed-off-by: Vinson Lee > --- > src/mapi/es1api/ABI-check | 7 ++- > src/mapi/es2api/ABI-check | 7 ++- > 2 files

Re: [Mesa-dev] [PATCH] r600: shader CF_OP_VTX also doesn't use the EOP bit.

On 15 November 2017 at 04:50, Gert Wollny wrote: > Although the EOP bit is documented for the vertex fetch clause, it is not > properly interpreted. As a result the piglit > spec/arb_tessellation_shader/execution/trivial-tess-gs_no-gs-inputs > creates a TESS_EVAL shader that does not have an EOP

[Mesa-dev] [PATCH] r600: don't emit vfetch if tess eval isn't accessing any inputs.

From: Dave Airlie This should avoid emitting anything in the shader if we aren't accessing any inputs. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/galli

[Mesa-dev] [PATCH] mapi: Use correct shared library name on macOS.

Signed-off-by: Vinson Lee --- src/mapi/es1api/ABI-check | 7 ++- src/mapi/es2api/ABI-check | 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mapi/es1api/ABI-check b/src/mapi/es1api/ABI-check index bd9d0288d60d..0a867343c79a 100755 --- a/src/mapi/es1api/ABI-check

[Mesa-dev] [PATCH 1/2] meson: don't build gallium subdir unless we're building gallium

This will allow us to simplify some guards within the gallium directory. Signed-off-by: Dylan Baker --- src/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/meson.build b/src/meson.build index 9232cc4ab18..00bbaa8989c 100644 --- a/src/meson.build +++ b/src/m

[Mesa-dev] [PATCH 2/2] meson: Guard the gallium dri componenet

Currently the target has a redundant guard, and the state tracker isn't properly guarded. Signed-off-by: Dylan Baker --- src/gallium/meson.build | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/meson.build b/src/gallium/meson.build index 7ccf4819079..07a97f72

Re: [Mesa-dev] [PATCH] mesa/teximage: add more targets for CompressedTexImage3D

On Wed, Nov 08, 2017 at 04:52:02PM +0100, Juan A. Suarez Romero wrote: > From section 8.7, page 179 of OpenGL ES 3.2 spec: > > An INVALID_OPERATION error is generated by CompressedTexImage3D > if internalformat is one of the the formats in table 8.17 and target > is not TEXTURE_2D_ARRAY, TEX

Re: [Mesa-dev] [PATCH] r600: fix cubemap arrays

Makes sense. Reviewed-by: Roland Scheidegger Am 14.11.2017 um 23:28 schrieb Dave Airlie: > From: Dave Airlie > > A lot of cubemap array piglits fail, port the texture type > picking code from radeonsi which seems to fix most of them. > > For images I will port the rest of the code. > > Fixes

Re: [Mesa-dev] [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/

>From: Brian Paul >Sent: Tuesday, November 14, 2017 3:42 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Neha Bhende >Subject: [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/ ... >diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.h >b/src/gallium/auxiliary/tgsi/tgsi_util.h >inde

[Mesa-dev] [PATCH 11/11] docs: update features/relnotes for r600 shader image support.

From: Dave Airlie Signed-off-by: Dave Airlie --- docs/features.txt | 14 +++--- docs/relnotes/17.4.0.html | 2 ++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 86d07ba..f3665de 100644 --- a/docs/features.txt +++ b/doc

[Mesa-dev] [PATCH 05/11] r600/shader: implement getting thread id.

From: Dave Airlie We need the thread id to use the immediate buffer readback mechanism, so add support for calculating it. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/src/gallium/d

[Mesa-dev] [PATCH 02/11] r600: allocate immed buffer resource for images.

From: Dave Airlie In order to image readback we have to execute a MEM_RAT instruction that needs a buffer to transfer the result into until the shader can fetch it. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_buffer_common.c | 2 ++ src/gallium/drivers/r600/r600_pipe_common.h

[Mesa-dev] [PATCH 08/11] r600/sb: disable SB for images.

From: Dave Airlie Until we can work further on sb, disable it for images for now. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index d7c

[Mesa-dev] [PATCH 10/11] r600: enable ARB_shader_image_load_store, ARB_shader_image_size

From: Dave Airlie This also enables GL4.2 for gpus with hw fp64 (cayman, cypress) Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r60

[Mesa-dev] [PATCH 03/11] r600: implement basic memory barrier.

From: Dave Airlie This isn't 100% perfect (fglrx also fails a bunch of those tests) but implement the start of a memory barrier for image support. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe_common.c | 5 - src/gallium/drivers/r600/r600_state_common.c | 24 +

[Mesa-dev] [PATCH 07/11] r600/shader: add support for load/store/atomic ops on images.

From: Dave Airlie This adds support to the shader assembler for load/store/atomic ops on images which are handled via the RAT operations. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 316 - 1 file changed, 312 insertions(+), 4 deletion

[Mesa-dev] [PATCH 01/11] r600: handle writes_memory properly

From: Dave Airlie This implements proper handling for shaders with side effects. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 10 +++--- src/gallium/drivers/r600/evergreend.h | 6 ++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 09/11] r600: handle image size support.

From: Dave Airlie This adds support for the RESQ opcode with the workaround required due to hw bugs for buffers and cube arrays. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 78 ++-- src/gallium/drivers/r600/r600_shader.h | 2 + s

[Mesa-dev] [PATCH 04/11] r600/shader: add flag to denote if shader uses images

From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 1 + src/gallium/drivers/r600/r600_shader.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 0fa2a1f..3da0be3 100

[Mesa-dev] [PATCH 06/11] r600: add core pieces of image support.

From: Dave Airlie This adds the atoms and gallium api implementations, along with support for compress/decompress paths for shader images. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 294 ++- src/gallium/drivers/r600/r600_blit.c

[Mesa-dev] r600 evergreen+ shader image support

I've been hacking on this on/off for quite a while now, and I think I'm finally happy with where is has reached. It's not 100% on piglits, but it's quite close, and better than fglrx does, so I'd probably prefer to land it before doing too much more destructive hacking on it! If you have a cayman

[Mesa-dev] [Bug 103748] [softpipe] pigilt arb_internalformat_query2-image-texture regression

https://bugs.freedesktop.org/show_bug.cgi?id=103748 Bug ID: 103748 Summary: [softpipe] pigilt arb_internalformat_query2-image-texture regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux

Re: [Mesa-dev] [PATCH] i965: Implement another VF cache invalidate workaround on Gen8+.

Reviewed-by: Rafael Antognolli On Tue, Nov 14, 2017 at 03:24:36PM -0800, Kenneth Graunke wrote: > ...and provide a better citation for the existing one. > > v2: > - Apply the workaround to Gen8 too, as intended (caught by Topi). > - Restructure to add bits instead of an extra flush (based on a s

[Mesa-dev] [PATCH 2/2] svga: s/unsigned/enum tgsi_texture_type/

--- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index 5fc93e2..c718eae 100644 --- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c

[Mesa-dev] [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/

--- src/gallium/auxiliary/tgsi/tgsi_util.c | 6 +++--- src/gallium/auxiliary/tgsi/tgsi_util.h | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.c b/src/gallium/auxiliary/tgsi/tgsi_util.c index afe5690..6fc0530 100644 --- a/src/ga

[Mesa-dev] [PATCH 8/8] radv: enable nir component packing

SaschaWillems Vulkan demo tessellation: ~4000fps -> ~4600fps Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_pipeline.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 9046960ad2..dad2b035c1 100644 --- a/src/

[Mesa-dev] [PATCH 5/8] nir: add varying component packing helpers

v2: update shader info input/output masks when pack components Reviewed-by: Bas Nieuwenhuizen (v1) --- src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_linking_helpers.c | 272 + 2 files changed, 274 insertions(+) diff --git a/src/compiler/nir

[Mesa-dev] [PATCH 4/8] i965: call nir_lower_io_to_scalar() at link time for BDW and above

This will allow dead components of varyings to be removed. BDW shader-db results: total instructions in shared programs: 13190730 -> 13108459 (-0.62%) instructions in affected programs: 2110903 -> 2028632 (-3.90%) helped: 14043 HURT: 486 total cycles in shared programs: 541148990 -> 540544072 (-

[Mesa-dev] [PATCH 6/8] i965: enable varying component packing for BDW+

shader-db results BDW: total instructions in shared programs: 13192895 -> 13182437 (-0.08%) instructions in affected programs: 827145 -> 816687 (-1.26%) helped: 5199 HURT: 116 total cycles in shared programs: 539249342 -> 539156566 (-0.02%) cycles in affected programs: 21894552 -> 21801776 (-0.42

[Mesa-dev] [PATCH 7/8] radv: enable nir varying array splitting

--- src/amd/vulkan/radv_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index f006dc98c0..9046960ad2 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -1675,20 +1675,23 @@ radv_link_

[Mesa-dev] [PATCH 3/8] i965: enable varying array splitting

total instructions in shared programs: 13210579 -> 13199325 (-0.09%) instructions in affected programs: 89043 -> 77789 (-12.64%) helped: 430 HURT: 0 total cycles in shared programs: 539530190 -> 539493750 (-0.01%) cycles in affected programs: 584860 -> 548420 (-6.23%) helped: 437 HURT: 110 total

[Mesa-dev] [PATCH 1/8] nir: add varying array splitting pass

--- src/compiler/Makefile.sources | 1 + src/compiler/nir/meson.build | 1 + src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_io_arrays_to_elements.c | 371 + 4 files changed, 374 insertions(+)

[Mesa-dev] [PATCH 2/8] i965: move update_xfb_info() call out of loop

We can just call it once. Also a following patch will also introduce link time component packing which modifies the outputs_written bit mask, we want to avoid calling update_xfb_info() until after packing is completed. --- src/mesa/drivers/dri/i965/brw_link.cpp | 7 +-- 1 file changed, 5 inser

Re: [Mesa-dev] [PATCH 14/14] anv: Add support for MSAA fast-clears

Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] i RESEND More NIR linking optimisations

This is a resend/rebase of the series I sent a couple of weeks ago, its rebased on some of Jason's changes to i965 NIR linking that landed in master. This series adds a varying array splitting pass as well a previous component packing series I sent out previously. This allows avoiding the workarou

Re: [Mesa-dev] [PATCH 13/14] anv/blorp: Add an mcs_partial_resolve helper

Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/14] intel/blorp: Add indirect clear color support to mcs_partial_resolve

On 13/11/17 16:12, Jason Ekstrand wrote: This is a bit complicated because we have to get the indirect clear color in there somehow. In order to not do any more work in the shader than needed, we set it up as it's own vertex binding which points directly at the clear color address specified by t

[Mesa-dev] [PATCH] i965: Implement another VF cache invalidate workaround on Gen8+.

...and provide a better citation for the existing one. v2: - Apply the workaround to Gen8 too, as intended (caught by Topi). - Restructure to add bits instead of an extra flush (based on a similar patch by Rafael Antognolli). --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 41 +++

Re: [Mesa-dev] [PATCH] i965: Remove DWord length from MI_FLUSH_DW definition

On Tuesday, November 14, 2017 2:52:35 PM PST Anuj Phogat wrote: > This fixes the changes introduced in commit 6165fda59b. > > Signed-off-by: Anuj Phogat > Cc: > Cc: Nanley Chery > Cc: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_defines.h | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [Mesa-dev] [PATCH 1/3] radv: drop radv_cmd_dirty_mask_t typedef

For the series Reviewed-by: Bas Nieuwenhuizen On Tue, Nov 14, 2017 at 5:27 PM, Samuel Pitoiset wrote: > I don't think we will need a 64-bit unsigned integer for the > dirty flags in the future, and there is still 20 bits left. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pip

Re: [Mesa-dev] [PATCH 1/2] radv: do not add the image BO in radv_set_color_clear_regs()

Reviewed-by: Bas Nieuwenhuizen On Tue, Nov 14, 2017 at 4:38 PM, Samuel Pitoiset wrote: > radv_fill_buffer() ensures that the image BO is added to the list. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH 2/2] radv: do not add the image BO in radv_set_dcc_need_cmask_elim_pred()

Reviewed-by: Bas Nieuwenhuizen On Tue, Nov 14, 2017 at 4:38 PM, Samuel Pitoiset wrote: > radv_fill_buffer() ensures that the image BO is added to the list. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH] radv: use an unsigned 32-bit integer for radv_queue::family_index

Reviewed-by: Bas Nieuwenhuizen On Tue, Nov 14, 2017 at 5:29 PM, Samuel Pitoiset wrote: > VkDeviceQueueCreateInfo::queueFamilyIndex is an unsigned 32-bit > integer. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 2 +- > src/amd/vulkan/radv_private.h | 2 +- > 2 files

Re: [Mesa-dev] [PATCH] i965: Remove DWord length from MI_FLUSH_DW definition

On Tue, Nov 14, 2017 at 02:52:35PM -0800, Anuj Phogat wrote: > This fixes the changes introduced in commit 6165fda59b. > > Signed-off-by: Anuj Phogat > Cc: > Cc: Nanley Chery > Cc: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_defines.h | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [Mesa-dev] [PATCH 01/14] anv/cmd_buffer: Advance the address when initializing clear colors

On Tue, Nov 14, 2017 at 02:30:31PM +, Lionel Landwerlin wrote: > On 13/11/17 22:07, Jason Ekstrand wrote: > > On Mon, Nov 13, 2017 at 1:30 PM, Nanley Chery > > wrote: > > > > On Mon, Nov 13, 2017 at 08:12:41AM -0800, Jason Ekstrand wrote: > > > Found by i

[Mesa-dev] [PATCH 2/2] i965: Implement ARB_texture_filter_minmax

On gen >= 9, minmax reduction modes are available as a flag in SAMPLER_STATE. --- docs/features.txt | 2 +- src/mesa/drivers/dri/i965/brw_formatquery.c | 4 src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ src/mesa/drivers/dri/i965/intel_extension

[Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

This extension provides a new texture and sampler parameter (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce a filtered texel value by computing a component-wise minimum (MIN) or maximum (MAX) of the texels that would normally be averaged. --- CTS tests KHR-GL45.texture_filter_minm

[Mesa-dev] [PATCH] i965: Remove DWord length from MI_FLUSH_DW definition

This fixes the changes introduced in commit 6165fda59b. Signed-off-by: Anuj Phogat Cc: Cc: Nanley Chery Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drive

Re: [Mesa-dev] [PATCH] svga: issue debug warning for unsupported two-sided stencil state

Looks good to me. Reviewed-by: Neha Bhende Regards, Neha From: mesa-dev on behalf of Brian Paul Sent: Friday, November 10, 2017 6:40:26 PM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] svga: issue debug warning for unsupported two-sided s

[Mesa-dev] [PATCH 1/3] i965: Program DWord Length in MI_FLUSH_DW

Signed-off-by: Anuj Phogat Cc: --- This series has already been pushed upstream. Nanley and Ken has taken a look at the patches. I'll send out a separate patch for a small change suggested by them. src/mesa/drivers/dri/i965/brw_pipe_control.c | 2 +- src/mesa/drivers/dri/i965/intel_blit.c

Re: [Mesa-dev] [PATCH 1/2] r600/shader: reserve first register of vertex shader.

On 15 November 2017 at 01:12, Andres Gomez wrote: > Dave, this nominated patch landed without mentioning any specific > stable queue. > > From what I'm seeing, they depend on ea1b97714d9b which didn't make it > for 17.2 so I'm dropping it for that queue. > > Let me know what you think. Oh interes

[Mesa-dev] [PATCH 2/3] i965/gen8+: Fix the number of dwords programmed in MI_FLUSH_DW

Number of dwords in MI_FLUSH_DW changed from 4 to 5 in gen8+. Signed-off-by: Anuj Phogat Cc: --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 7 +-- src/mesa/drivers/dri/i965/intel_blit.c | 17 ++--- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/src/me

[Mesa-dev] [PATCH 3/3] i965: Make use of brw_load_register_imm32() helper function

Signed-off-by: Anuj Phogat Cc: Nanley Chery --- src/mesa/drivers/dri/i965/brw_draw.c | 6 +- src/mesa/drivers/dri/i965/brw_state_upload.c | 22 -- src/mesa/drivers/dri/i965/gen7_l3_state.c| 17 ++--- src/mesa/drivers/dri/i965/gen7_sol_state.c |

Re: [Mesa-dev] [PATCH 4/6] glx: Lift sending the MakeCurrent request to top-level code

On 11/14/2017 02:18 PM, Adam Jackson wrote: > On Tue, 2017-11-14 at 14:03 -0800, Ian Romanick wrote: > >>> static void >>> indirect_unbind_context(struct glx_context *gc, struct glx_context *new) >>> { >> >> Mark the parameters UNUSED so that I don't get extra warnings. :) > > How do I provoke

Re: [Mesa-dev] [PATCH] i965: disable BLORP color clears for gen 4-5

On Tue, Nov 14, 2017 at 11:11 AM, Matt Turner wrote: > On Thu, Nov 9, 2017 at 9:23 AM, Jason Ekstrand > wrote: > > This is a really rubbish solution. Yes, it fixes a crash in MPV but > unless > > we disable all blorp on gen4-5 (which I don't think is possible > anymore), we > > haven't actually

[Mesa-dev] [PATCH] r600: fix cubemap arrays

From: Dave Airlie A lot of cubemap array piglits fail, port the texture type picking code from radeonsi which seems to fix most of them. For images I will port the rest of the code. Fixes: getteximage-depth gl_texture_cube_map_array-* fbo-generatemipmap-cubemap array getteximage-targets cube_ar

Re: [Mesa-dev] [PATCH 10/14] intel/blorp: Drop blorp_resolve_ccs_attachment

Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nir/clone: Free clone_state after use

In nir_cf_list_clone(), a state_clone object is initialized but never freed, causing a memory leak. If the remap_table argument is NULL, init_state will create a hash table for it, and that's what free_clone_state is supposed to free. --- src/compiler/nir/nir_clone.c | 3 +++ 1 file changed, 3 ins

Re: [Mesa-dev] [PATCH 4/6] glx: Lift sending the MakeCurrent request to top-level code

On Tue, 2017-11-14 at 14:03 -0800, Ian Romanick wrote: > > static void > > indirect_unbind_context(struct glx_context *gc, struct glx_context *new) > > { > > Mark the parameters UNUSED so that I don't get extra warnings. :) How do I provoke these warnings in my own build? - ajax

Re: [Mesa-dev] [PATCH] svga: issue debug warning for unsupported two-sided stencil state

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, November 10, 2017 6:40:26 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: issue debug warning for unsupported two-sided stencil state We only have a single stencil

Re: [Mesa-dev] [PATCH v3 15/15] meson: build gallium xa state tracker

Quoting Marc Dietrich (2017-11-14 02:51:38) > Hi Dylan, > > Am Dienstag, 14. November 2017, 02:09:19 CET schrieb Dylan Baker: > > v2: - set with_gallium_xa when -Dgallium-xa=true > > - install pkg config file > > --- > > meson.build | 22 > > meson_optio

Re: [Mesa-dev] [PATCH 6/6] glx: Implement GLX_EXT_no_config_context (v3)

On 11/14/2017 12:13 PM, Adam Jackson wrote: > This more or less ports EGL_KHR_no_config_context to GLX. > > v2: Enable the extension only for those backends that support it. > v3: Fix glvnd path and dri2_convert_glx_attribs() > > Khronos: https://github.com/KhronosGroup/OpenGL-Registry/pull/102 >

Re: [Mesa-dev] [PATCH v3 14/15] meson: build gallium va state tracker

Quoting Marc Dietrich (2017-11-14 01:49:42) > Hi Dylan, > > Am Dienstag, 14. November 2017, 02:09:18 CET schrieb Dylan Baker: > > v2: - set with_gallium_va when -Dgallium-va=true > > - Fix megadrivers install > > - only use cflags from pkg-config, don't add linker flags. > > - Don't ge

Re: [Mesa-dev] [PATCH v3 09/15] meson: extend install_megadrivers script to handle symmlinking

Quoting Eric Engestrom (2017-11-14 06:47:33) > On Monday, 2017-11-13 17:09:13 -0800, Dylan Baker wrote: > > which is required for the gallium media state trackers. > > --- > > bin/install_megadrivers.py | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/bin/install_megadrivers.p

Re: [Mesa-dev] [PATCH 4/6] glx: Lift sending the MakeCurrent request to top-level code

A couple style nits below. At least some of this patch will have to change pending possible changes to patch 3. Aside from that, I think this is ok. On 11/14/2017 12:13 PM, Adam Jackson wrote: > Somewhat terrifyingly, we never sent this for direct contexts, which > means the server never knew th

Re: [Mesa-dev] [PATCH 5/6] glx: Prepare driFetchDrawable for no-config contexts

On 11/14/2017 12:13 PM, Adam Jackson wrote: > When we look up the DRI drawable state we need to associate an fbconfig > with the drawable. With GLX_EXT_no_config_context we can no longer infer > that from the context and must instead query the server. > > Signed-off-by: Adam Jackson > --- > src/

Re: [Mesa-dev] [PATCH v3 04/15] meson: build r600 driver

Quoting Marc Dietrich (2017-11-14 01:45:43) > Hi Dylan, > > Am Dienstag, 14. November 2017, 02:09:08 CET schrieb Dylan Baker: > > Signed-off-by: Dylan Baker > > Tested-by: Aaron Watry > > --- > > meson.build | 22 -- > > src/gallium/drivers/r600/meson.build | 128 >

Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

Quoting Jon Turney (2017-11-14 04:05:21) > On 13/11/2017 17:41, Dylan Baker wrote: > > I thought I'd fixed this already, > > Reviewed-by: Dylan Baker > > This workaround is already in place for dep_xxf86vm. > > I took a brief look, and didn't see anywhere the same problem could > occur with any

[Mesa-dev] [Bug 103658] addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression

https://bugs.freedesktop.org/show_bug.cgi?id=103658 Vinson Lee changed: What|Removed |Added Keywords||bisected --- Comment #2 from Vinson Lee -

Re: [Mesa-dev] [PATCH 11/14] intel/blorp: Add a helper for filling out VERTEX_BUFFER_STATE

On Tue, Nov 14, 2017 at 10:05 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 13/11/17 16:12, Jason Ekstrand wrote: > >> There are enough #ifs in there that it's kind-of pointless to duplicate >> it for each buffer. >> --- >> src/intel/blorp/blorp_genX_exec.h | 69

Re: [Mesa-dev] [PATCH 07/14] intel/blorp: Take a range of layers in blorp_ccs_resolve

On Tue, Nov 14, 2017 at 9:34 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 13/11/17 16:12, Jason Ekstrand wrote: > >> --- >> src/intel/blorp/blorp.h | 3 ++- >> src/intel/blorp/blorp_clear.c | 7 +-- >> src/mesa/drivers/dri/i965/brw_blorp.c | 2 +-

Re: [Mesa-dev] [PATCH 3/6] glx: Move vertex array protocol state into the indirect backend

On Tue, 2017-11-14 at 13:15 -0800, Ian Romanick wrote: > On 11/14/2017 12:13 PM, Adam Jackson wrote: > > diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c > > index cfae12f6c0..b552b5768a 100644 > > --- a/src/glx/indirect_glx.c > > +++ b/src/glx/indirect_glx.c > > @@ -148,9 +148,21 @@ in

Re: [Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

If there is no objection, the patches will be pushed by the end of the week. Thanks, Boyuan -Original Message- From: Zhang, Boyuan Sent: November-08-17 1:08 PM To: mesa-dev@lists.freedesktop.org Cc: alexdeuc...@gmail.com; dy...@pnwbakers.com; mar...@gmail.com; ckoenig.leichtzumer...@gma

Re: [Mesa-dev] [PATCH 3/6] glx: Move vertex array protocol state into the indirect backend

On 11/14/2017 12:13 PM, Adam Jackson wrote: > Only relevant for indirect contexts, so let's get that code out of the > common path. > > Signed-off-by: Adam Jackson > --- > src/glx/glxcurrent.c | 12 > src/glx/indirect_glx.c | 18 +++--- > 2 files changed, 15 insertions

Re: [Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

This patch is Reviewed-by: Ian Romanick On 11/14/2017 12:13 PM, Adam Jackson wrote: > This also fixes a bug, the error path through MakeCurrent didn't > translate the error code by the extension's error base. > > Signed-off-by: Adam Jackson > --- > src/glx/glxcmds.c| 10 +- > src/

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

Zhang, Boyuan wrote: Zhang, Boyuan wrote: On 14/11/17 10:53, Andy Furniss wrote: Zhang, Boyuan wrote: -Original Message- From: Zhang, Boyuan Sent: November-13-17 11:41 AM To: Andy Furniss; Koenig, Christian; Mark Thompson; mesa-dev@lists.freedesktop.org Subject: RE: [Mesa-dev] [PATC

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

Hi all, I am sorry that I didn't have enough discussion about why new window system code is needed for Tizen on mesa. This is a brief architecture of Tizen Window System. +--+ |

[Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

This also fixes a bug, the error path through MakeCurrent didn't translate the error code by the extension's error base. Signed-off-by: Adam Jackson --- src/glx/glxcmds.c| 10 +- src/glx/glxcurrent.c | 20 +++- 2 files changed, 4 insertions(+), 26 deletions(-) diff -

[Mesa-dev] [PATCH 5/6] glx: Prepare driFetchDrawable for no-config contexts

When we look up the DRI drawable state we need to associate an fbconfig with the drawable. With GLX_EXT_no_config_context we can no longer infer that from the context and must instead query the server. Signed-off-by: Adam Jackson --- src/glx/dri_common.c | 22 -- src/glx/glx

[Mesa-dev] [PATCH 3/6] glx: Move vertex array protocol state into the indirect backend

Only relevant for indirect contexts, so let's get that code out of the common path. Signed-off-by: Adam Jackson --- src/glx/glxcurrent.c | 12 src/glx/indirect_glx.c | 18 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/glx/glxcurrent.c b/sr

[Mesa-dev] [PATCH 1/6] glx: Simplify some dummy vtable interactions

The dummy vtable has these slots as NULL already, no need to check for the dummy context explicitly. Signed-off-by: Adam Jackson --- src/glx/glxcmds.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index c707d0cedf..bc93d62510

[Mesa-dev] [PATCH 4/6] glx: Lift sending the MakeCurrent request to top-level code

Somewhat terrifyingly, we never sent this for direct contexts, which means the server never knew the context/drawable bindings. To handle this sanely, pull the request code up out of the indirect backend, and rewrite the context switch path to call it as appropriate. This attempts to preserve the

[Mesa-dev] [PATCH 6/6] glx: Implement GLX_EXT_no_config_context (v3)

This more or less ports EGL_KHR_no_config_context to GLX. v2: Enable the extension only for those backends that support it. v3: Fix glvnd path and dri2_convert_glx_attribs() Khronos: https://github.com/KhronosGroup/OpenGL-Registry/pull/102 Reviewed-by: Kenneth Graunke Signed-off-by: Adam Jackson

[Mesa-dev] [PATCH 0/6] glx: Implement GLX_EXT_no_config_context

The first three here are mostly cleanup, but after that it got complicated. 4/6 addresses a longstanding bug in the GLX client code where direct contexts would generate no protocol on MakeCurrent, which means the server was unable to know what drawables were bound to a context. We're not presently

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

Zhang, Boyuan wrote: >> >> On 14/11/17 10:53, Andy Furniss wrote: Zhang, Boyuan wrote: > > > -Original Message- > From: Zhang, Boyuan > Sent: November-13-17 11:41 AM > To: Andy Furniss; Koenig, Christian; Mark Thompson; > mesa-dev@lists.freedesktop.org >>>

Re: [Mesa-dev] [PATCH 1/3] broadcom/vc4: fix indentation in vc4_screen.c

Andres Rodriguez writes: > Stumbled into this when adding a new PIPE_CAP. > > Signed-off-by: Andres Rodriguez Reviewed this one, and pushed the series with nh's reviews added. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-d

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

Zhang, Boyuan wrote: On 14/11/17 10:53, Andy Furniss wrote: Zhang, Boyuan wrote: -Original Message- From: Zhang, Boyuan Sent: November-13-17 11:41 AM To: Andy Furniss; Koenig, Christian; Mark Thompson; mesa-dev@lists.freedesktop.org Subject: RE: [Mesa-dev] [PATCH 10/18] radeon/vcn:

Re: [Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc4

On Tue, Nov 14, 2017 at 6:37 AM, Emil Velikov wrote: > The fourth release candidate for Mesa 17.3.0 is now available. > > As per the issue tracker [1] we still have a number of outstanding bugs > blocking the release. > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=103491 > > Andreas Boll (3)

Re: [Mesa-dev] [PATCH] i965: disable BLORP color clears for gen 4-5

On Thu, Nov 9, 2017 at 9:23 AM, Jason Ekstrand wrote: > This is a really rubbish solution. Yes, it fixes a crash in MPV but unless > we disable all blorp on gen4-5 (which I don't think is possible anymore), we > haven't actually fixed it for real. Are you planning to look into it? It's one week

[Mesa-dev] [PATCH] r600: shader CF_OP_VTX also doesn't use the EOP bit.

Although the EOP bit is documented for the vertex fetch clause, it is not properly interpreted. As a result the piglit spec/arb_tessellation_shader/execution/trivial-tess-gs_no-gs-inputs creates a TESS_EVAL shader that does not have an EOP clause, which might result in a GPU lockup. This patch f

[Mesa-dev] [PATCH 1/3] vulkan/wsi: Add a wsi_image structure

From: Daniel Stone This is used to hold information about the allocated image, rather than an ever-growing function argument list. v2 (Jason Ekstrand): - Rename wsi_image_base to wsi_image Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/amd/vulkan/radv_wsi.c | 31 +

  1   2   >