[Mesa-dev] [PATCH] mesa: Avoid set comprehension.

2017-06-28 Thread Vinson Lee
Fix build error on CentOS 6.9 with Python 2.6. GENmain/format_fallback.c File "./main/format_fallback.py", line 42 names = {fmt.name for fmt in formats} ^ SyntaxError: invalid syntax Fixes: a1983223d883 ("mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]") Si

Re: [Mesa-dev] [PATCH] i965: skip varyings without slot

2017-06-28 Thread Timothy Arceri
On 27/06/17 21:20, Juan A. Suarez Romero wrote: On Tue, 2017-06-27 at 09:29 +1000, Timothy Arceri wrote: On 16/06/17 18:12, Juan A. Suarez Romero wrote: Commit 00620782c9 (i965: use nir_shader_gather_info() over do_set_program_inouts()) changed how we compute the outputs written. In the previ

[Mesa-dev] [PATCH v1 3/3] gallium/hud: Prevent buffer overflow in hud_thread_busy_install

2017-06-28 Thread Robert Foss
Switch to using strncopy to avoid potential overflow of name array in struct hud_graph. Coverity-id: 1413760 Signed-off-by: Robert Foss --- src/gallium/auxiliary/hud/hud_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_cpu.c b/src/gallium/

[Mesa-dev] [PATCH v1 1/3] gallium/hud: Add define for struct hud_graph name array

2017-06-28 Thread Robert Foss
Define the length of the name field of struct hud_graph with HUD_GRAPH_NAME_LEN. Signed-off-by: Robert Foss --- src/gallium/auxiliary/hud/hud_private.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_private.h b/src/gallium/auxiliary/hud/hud_p

[Mesa-dev] [PATCH v1 2/3] gallium/hud: Prevent buffer overflow in hud_thread_counter_install

2017-06-28 Thread Robert Foss
Switch to using strncopy to avoid potential overflow of name array in struct hud_graph. Coverity-id: 1413761 Signed-off-by: Robert Foss --- src/gallium/auxiliary/hud/hud_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_cpu.c b/src/gallium/

Re: [Mesa-dev] [PATCH] svga: add texture size/levels sanity check code in svga_texture_create()

2017-06-28 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, June 28, 2017 3:13 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: add texture size/levels sanity check code in svga_texture_create() The state tra

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #7 from Trevor SANDY --- You can see in options listing of the logged output I posted all the component versions of my MSYS/MINGW dev env. I'm using... - MSYS bash at /usr/bin - MSYS python at /usr/bin (#02 below) For python, be ca

Re: [Mesa-dev] [PATCH 5/5] dri3: Use SwapBuffer flips for back- and fake front

2017-06-28 Thread Axel Davy
Hi, To my knowledge, this is invalid to switch the front fake buffer with the back buffer. The front buffer is supposed to take into account what the app draws with the xserver commands, etc. Plus, if there is draw->width and back->width, I guess they can be different size, thus switching

[Mesa-dev] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-28 Thread Trevor Sandy
Please help ! My mesa build consistently fails with starting with this log trace: src/gallium/drivers/swr/rasterizer/common/simd16intrin.h:127:35: *error*: expected initializer before '_simd16_setzero_ps' SIMD16_EMU_AVX512_0(simd16scalar, _simd16_setzero_ps, _mm256_setzero_ps). Builds on Linux and

Re: [Mesa-dev] [PATCH 5/5] dri3: Use SwapBuffer flips for back- and fake front

2017-06-28 Thread Axel Davy
On 28/06/2017 20:40, Thomas Hellstrom wrote: On 06/28/2017 07:36 PM, Axel Davy wrote: Hi, To my knowledge, this is invalid to switch the front fake buffer with the back buffer. The front buffer is supposed to take into account what the app draws with the xserver commands, etc. SwapBuffers

[Mesa-dev] [PATCH 4/5] vc4: Use vc4_setup_slices for resource import

2017-06-28 Thread Eric Anholt
Rather than open-coding populating the first slice inside resource import, use vc4_setup_slices to do it for us. v2: Rebase on VC4_DEBUG=surf change --- src/gallium/drivers/vc4/vc4_resource.c | 52 +- 1 file changed, 19 insertions(+), 33 deletions(-) diff --git a/

[Mesa-dev] [PATCH 1/5] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-28 Thread Eric Anholt
I want to remove vc4's dependency on headers from libdrm as well, but storing multiple copies of drm_fourcc.h in our tree would be silly. --- {src/intel/drm => include/drm-uapi}/README | 0 {src/intel/drm => include/drm-uapi}/drm.h| 0 {src/intel/drm => include/drm-uapi}/drm_fourcc.h

[Mesa-dev] [PATCH 2/5] vc4: Switch back to using a local copy of vc4_drm.h.

2017-06-28 Thread Eric Anholt
Needing to get our uapi header from libdrm has only complicated things. Follow intel's lead and drop our requirement for it. Generated from the same commit mentioned in the README. --- configure.ac | 2 - include/drm-uapi/vc4_drm.h | 318 +++

[Mesa-dev] [PATCH 5/5] vc4: Set shareable BOs as T tiled if possible

2017-06-28 Thread Eric Anholt
X11 and GL compositor performance on VC4 has been terrible because of our SHARED-usage buffers all being forced to linear. This swaps SHARED && !LINEAR buffers over to being tiled. This is an expected win for all GL compositors during rendering (a full copy of each shared texture per draw call),

[Mesa-dev] [PATCH 3/5] vc4: Make the miptree debug code available under VC4_DEBUG=surf

2017-06-28 Thread Eric Anholt
I kept flipping the bool on for debug, so let's just make it available. --- src/gallium/drivers/vc4/vc4_resource.c | 8 +++- src/gallium/drivers/vc4/vc4_screen.c | 2 ++ src/gallium/drivers/vc4/vc4_screen.h | 1 + 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/d

[Mesa-dev] [PATCH] android: anv: drop libdrm_intel dependency

2017-06-28 Thread Mauro Rossi
In addition to Rob Herring "Android: i965: remove libdrm_intel dependency", we can drop libdrm_intel dependency in anv for Android. Please check if libdrm has to stay as shared dependency and drop this comment line. Fixes: 7dd20bc ("anv/i965: drop libdrm_intel dependency completely") --- src/in

Re: [Mesa-dev] [PATCH] svga: update a few surface format names

2017-06-28 Thread Neha Bhende
Looks good to me. Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Wednesday, June 28, 2017 3:44:35 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: update a few surface format names To sync with in-ho

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #6 from George Kyriazis --- I tried compiling just osmesa, but still got the same issue. I've always had trouble using bash with python on windows (bash from Cygwin). Regardless of whether I use python from the windows python distr

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #5 from Trevor SANDY --- George, One more point. I did not use the windows command environment. My toolchain is MSYS2/Mingw64. My command environment is Bash. Looking at your command output, it looks like you are using mingw64 under

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #4 from Trevor SANDY --- George, I haven't personally experienced this error but I did come across it in several places. In fact, Bug 94072 - error: The command line is too long when building MESA on Windows with MinGW-W64 I think c

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 George Kyriazis changed: What|Removed |Added CC||george.kyria...@intel.com --- Comment

[Mesa-dev] [PATCH] svga: update a few surface format names

2017-06-28 Thread Brian Paul
To sync with in-house changes. --- .../drivers/svga/include/svga3d_surfacedefs.h | 8 +++--- src/gallium/drivers/svga/include/svga3d_types.h| 8 +++--- src/gallium/drivers/svga/svga_format.c | 32 +++--- 3 files changed, 24 insertions(+), 24 deletions(-) dif

[Mesa-dev] [PATCH] svga: add texture size/levels sanity check code in svga_texture_create()

2017-06-28 Thread Brian Paul
The state tracker should never ask us to create a texture with invalid dimensions / mipmap levels. Do some assertions to check that. No Piglit regressions. --- src/gallium/drivers/svga/svga_resource_texture.c | 33 1 file changed, 33 insertions(+) diff --git a/src/galli

[Mesa-dev] [PATCH 1/2] st/mesa: check for incomplete texture in st_finalize_texture()

2017-06-28 Thread Brian Paul
Return early from st_finalize_texture() if we have an incomplete texture. This avoids trying to create a texture resource with invalid parameters (too many mipmap levels given the base dimension). Specifically, the Piglit fbo-incomplete-texture-03 test winds up calling pipe_screen::resource_creat

[Mesa-dev] [PATCH 2/2] st/mesa: fix texture image resource selection in st_render_texture()

2017-06-28 Thread Brian Paul
If we're rendering to an incomplete/inconsistent (cube) texture, the different faces/levels of the texture may be stored in different resources. Before, we always used the texture object resource. Now, we use the texture image resource. In normal circumstances, that's the same resource. But in

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101467 --- Comment #2 from Bruce Cherniak --- For the curious, this is the same result as allowing llvmpipe to build larger scenes by setting the defines LP_SCENE_MAX_SIZE and LP_SCENE_MAX_RESOURCE_SIZE to *large* values. This suggests that when/if th

Re: [Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

2017-06-28 Thread Rob Herring
On Wed, Jun 28, 2017 at 5:07 PM, Rob Herring wrote: > From: Eero Tamminen Ignore this. Rob ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] Android: i965: remove libdrm_intel dependency

2017-06-28 Thread Rob Herring
Commit 7dd20bc3ee8f ("anv/i965: drop libdrm_intel dependency completely") removed the libdrm_intel dependency for automake, but Android builds still depended on it. Now the build requires a newer version of i915_drm.h and fails on Android builds: src/mesa/drivers/dri/i965/brw_performance_query.c:6

[Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

2017-06-28 Thread Rob Herring
From: Eero Tamminen Commit f8d69beed49c64f883bb8ffb28d4960306baf575 moving sampler handling to genxml messed up change done by commit 6a7c5257cac23cd9767aa4bc8fdab68925b11157. This broke rendering in SynMark CSDof and TexFilterAniso tests. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=

[Mesa-dev] [PATCH v3 5/5] android: build imx-drm winsys

2017-06-28 Thread Robert Foss
From: Tomeu Vizoso Add Android.mk for winsys/imx/drm. Signed-off-by: Tomeu Vizoso Reviewed-by: Tapani Pälli --- Changes since v2: - Rebased on upstream/master - Added commit message Changes since v1: Emil Velikov - Fix C_SOURCES include - Fix GALLIUM_LIBS assignment Android.mk

[Mesa-dev] [PATCH v3 3/5] gbm: add XBGR8888 support for dumb buffers

2017-06-28 Thread Robert Foss
From: Rob Herring Add GBM_FORMAT_XBGR format support which is needed for Android. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli Reviewed-by: Daniel Stone Reviewed-by: Emil Velikov --- Changes since v2: - Rebased on upstream/master Changes since v1: Emil Velikov - Added co

[Mesa-dev] [PATCH v3 2/5] gallium: os_process fixes for Android

2017-06-28 Thread Robert Foss
From: Rob Herring The function getprogname() is available on Android, since it reuses various BSD solutions C runtime. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli Reviewed-by: Emil Velikov --- Changes since v2: - Rebased on upstream/master Changes since v1: Emil Velikov - Ad

[Mesa-dev] [PATCH v3 4/5] android: add etnaviv driver build support

2017-06-28 Thread Robert Foss
From: Rob Herring Add etnaviv to Android makefiles. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli --- Changes since v2: - Rebased on upstream/master Changes since v1: Tapani Pälli - Remove copy-pasta Emil Velikov - Remove libmesa_loader inclusion - Remove copy-pasta

[Mesa-dev] [PATCH v3 1/5] etnaviv: Add unreachable statement to etna_amode to fix compilation warnings

2017-06-28 Thread Robert Foss
From: Tomeu Vizoso Signed-off-by: Robert Foss Reviewed-by: Tapani Pälli --- Chages since v2: - Rebased on upstream/master Changes since v1: Emil Velikov - Replaced return with unreachable call src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++ 1 file changed, 2 insertions(+) dif

[Mesa-dev] [PATCH v3 0/5] Android etnaviv and imx support

2017-06-28 Thread Robert Foss
This series enables etnaviv and imx for the android platform. This is done through updating the Android build scripts. Rob Herring (3): gallium: os_process fixes for Android gbm: add XBGR support for dumb buffers android: add etnaviv driver build support Tomeu Vizoso (2): etnaviv: Add

Re: [Mesa-dev] [PATCH v2] mesa: Add _mesa_format_fallback_rgba_to_rgbx()

2017-06-28 Thread Jason Ekstrand
On Tue, Jun 20, 2017 at 4:53 PM, Jason Ekstrand wrote: > From: Chad Versace > > The new function takes a mesa_format and, if the format is an alpha > format with a non-alpha variant, returns the non-alpha format. > Otherwise, it returns the original format. > > Example: > input -> output > >

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

2017-06-28 Thread Rob Herring
On Wed, Jun 28, 2017 at 4:23 PM, Chad Versace wrote: > On Wed 28 Jun 2017, Rob Herring wrote: >> On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace >> wrote: >> > The new function takes a mesa_format and, if the format is an alpha >> > format with a non-alpha variant, returns the non-alpha format. >>

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

2017-06-28 Thread Chad Versace
On Wed 28 Jun 2017, Rob Herring wrote: > On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace > wrote: > > The new function takes a mesa_format and, if the format is an alpha > > format with a non-alpha variant, returns the non-alpha format. > > Otherwise, it returns the original format. > > [...] > >

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

2017-06-28 Thread Chad Versace
On Wed 28 Jun 2017, Rob Herring wrote: > On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace > wrote: > > The new function takes a mesa_format and, if the format is an alpha > > format with a non-alpha variant, returns the non-alpha format. > > Otherwise, it returns the original format. > > [...] > >

[Mesa-dev] [PATCH v3 10/16] anv/cmd_buffer: Always enable CCS_D in render passes

2017-06-28 Thread Nanley Chery
The lifespan of the fast-clear data will surpass the render pass scope. We need CCS_D to be enabled in order to invalidate blocks previously marked as cleared and to sample cleared data correctly. v2: Avoid refactoring. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 5

Re: [Mesa-dev] [PATCH 15/30] i965: Use create_for_dri_image in intel_update_image_buffer

2017-06-28 Thread Chad Versace
Patches 14 and 15 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3 12/16] anv/cmd_buffer: Warn about not enabling CCS_E

2017-06-28 Thread Nanley Chery
Use the performance warning infrastructure to provide helpful information when testing applications. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel

[Mesa-dev] [PATCH v3 15/16] intel/blorp: Allow BLORP calls to be predicated

2017-06-28 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 3 +++ src/intel/blorp/blorp_genX_exec.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index d5226c2248..1e96fb42b0 100644 --- a/src/intel/blorp/blorp.h +++ b/src/intel/

[Mesa-dev] [PATCH v3 16/16] anv: Predicate fast-clear resolves

2017-06-28 Thread Nanley Chery
Image layouts only let us know that an image *may* be fast-cleared. For this reason we can end up with redundant resolves. Testing has shown that such resolves can measurably hurt performance and that predicating them can avoid the penalty. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_bl

[Mesa-dev] [PATCH v3 07/16] anv/cmd_buffer: Ensure fast-clear values are current

2017-06-28 Thread Nanley Chery
v2: Rewrite functions, change location of synchronization. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 114 + 1 file changed, 114 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c inde

[Mesa-dev] [PATCH v3 13/16] anv: Stop resolving CCS implicitly

2017-06-28 Thread Nanley Chery
With an earlier patch from this series, resolves are additionally performed on layout transitions. Remove the now unnecessary implicit resolves within render passes. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 150 ++--- src/intel/vulkan/a

[Mesa-dev] [PATCH v3 11/16] anv/cmd_buffer: Move aux_usage assignment up

2017-06-28 Thread Nanley Chery
For readability, bring the assignment of CCS closer to the assignment of NONE and MCS. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 62 ++ 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.

[Mesa-dev] [PATCH v3 14/16] anv/cmd_buffer: Skip some input attachment transitions

2017-06-28 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index d71c3c92c9..62a2f22782 100644 --- a/src/intel/vulk

[Mesa-dev] [PATCH v3 02/16] anv/image: Append CCS/MCS with a fast-clear state buffer

2017-06-28 Thread Nanley Chery
v2: Update comments, function signatures, and add assertions. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 78 ++ src/intel/vulkan/anv_private.h | 12 +++ 2 files changed, 90 insertions(+) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH v3 09/16] anv/cmd_buffer: Disable CCS on gen7 color attachments upfront

2017-06-28 Thread Nanley Chery
The next patch enables the use of CCS_D even when the color attachment will not be fast-cleared. Catch the gen7 case early to simplify the changes required. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-)

[Mesa-dev] [PATCH v3 08/16] anv: Transition more color buffer layouts

2017-06-28 Thread Nanley Chery
v2: Expound on comment for the pipe controls (Jason Ekstrand). Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 4 +- src/intel/vulkan/genX_cmd_buffer.c | 183 + 2 files changed, 167 insertions(+), 20 deletions(-) diff --git a/src/intel/

[Mesa-dev] [PATCH v3 05/16] anv/cmd_buffer: Restrict fast clears in the GENERAL layout

2017-06-28 Thread Nanley Chery
v2: Remove ::first_subpass_layout assertion (Jason Ekstrand). v3: Allow some fast clears in the GENERAL layout. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 22 ++ src/intel/vulkan/anv_private.h | 2 ++ src/intel/vulkan/genX_cmd_buffer.c | 17

[Mesa-dev] [PATCH v3 06/16] anv/gpu_memcpy: Add a lighter-weight GPU memcpy function

2017-06-28 Thread Nanley Chery
We'll be performing a GPU memcpy in more places to copy small amounts of data. Add an alternate function that thrashes less state. v2: - Make a new function (Jason Ekstrand). - Move the #define into the function. v3: - Update the function name (Jason). - Update comments. Signed-off-by: Nanley Che

[Mesa-dev] [PATCH v3 03/16] anv/cmd_buffer: Initialize the clear values buffer

2017-06-28 Thread Nanley Chery
v2: Rewrite functions. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 93 ++ 1 file changed, 84 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 53c58ca5b3..8601d70

[Mesa-dev] [PATCH v3 00/16] anv: Do CCS resolves at layout transitions

2017-06-28 Thread Nanley Chery
A quick test shows that this change still improves frame rates on a Dota 2 benchmark by about 3% at 1080p. Cc: Jason Ekstrand Nanley Chery (16): intel/isl: Add surface state clear value information anv/image: Append CCS/MCS with a fast-clear state buffer anv/cmd_buffer: Initialize the cle

[Mesa-dev] [PATCH v3 04/16] anv/cmd_buffer: Don't partially fast clear image layers

2017-06-28 Thread Nanley Chery
v2: Don't pass in the command buffer (Jason Ekstrand). v3: Remove an incorrect assertion and an if condition for gen7. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/src/intel

[Mesa-dev] [PATCH v3 01/16] intel/isl: Add surface state clear value information

2017-06-28 Thread Nanley Chery
This will be used to load and store clear values from surface state objects. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 + src/intel/isl/isl.h | 4 2 files changed, 13 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index bbbdb19df2..26e1676d61 100

Re: [Mesa-dev] [PATCH 16/30] i965/miptree: Move CCS allocation into create_for_dri_image

2017-06-28 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > Any form of CCS on gen9+ only works on Y-tiled images. The only caller > of create_for_bo which uses Y-tiled BOs is create_for_dri_image. If I understand ARC++ correctly, then intel_update_image_buffer() also calls intel_miptree_create_for_bo() for Andr

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101467 --- Comment #1 from Bruce Cherniak --- Well, technically the swr driver isn't "leaking" memory, it's just deferring deletion of the underlying storage until a sync point. Because the loop is simply: for (bigly_number_of_textures) { all

Re: [Mesa-dev] gallium: Reduce trace_dump_box_bytes size by box->x.

2017-06-28 Thread Marek Olšák
On Wed, Jun 28, 2017 at 6:54 PM, Cherniak, Bruce wrote: > >> On Jun 26, 2017, at 2:10 PM, Marek Olšák wrote: >> >> In my opinion, dumping resources isn't very useful. I think it would >> be better to remove that completely. > > From Michel's response, sounds like dumping resources is useful, so..

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

2017-06-28 Thread Rob Herring
On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace wrote: > The new function takes a mesa_format and, if the format is an alpha > format with a non-alpha variant, returns the non-alpha format. > Otherwise, it returns the original format. [...] > @@ -123,6 +124,17 @@ $(intermediates)/main/get_hash.h:

Re: [Mesa-dev] [PATCH 26/30] intel/isl: Add a row_pitch parameter to surf_get_ccs_surf

2017-06-28 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 4 +++- > src/intel/isl/isl.h | 3 ++- > src/intel/vulkan/anv_image.c | 2 +- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 +--- > 4 files changed

Re: [Mesa-dev] [PATCH 5/5] dri3: Use SwapBuffer flips for back- and fake front

2017-06-28 Thread Thomas Hellstrom
On 06/28/2017 08:48 PM, Axel Davy wrote: On 28/06/2017 20:40, Thomas Hellstrom wrote: On 06/28/2017 07:36 PM, Axel Davy wrote: Hi, To my knowledge, this is invalid to switch the front fake buffer with the back buffer. The front buffer is supposed to take into account what the app draws wit

[Mesa-dev] [Bug 100951] vkcube fails with vkMapMemory failed

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100951 --- Comment #1 from Fabian Maurer --- Still present with 7bbcf3ac70. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #2 from Trevor SANDY --- Hi George, Unfortunately no, I have not. My solution is Qt-based and I use QMake across all platforms (OSX, Linux and Win). For Win, I use the MinGW/GCC toolchain. Just the check, I ran the installation on

Re: [Mesa-dev] [PATCH] ac/nir: Use correct LLVM intrinsics for atomic ops on imageBuffers

2017-06-28 Thread Bas Nieuwenhuizen
Thanks, pushed. On Mon, Jun 26, 2017 at 6:17 PM, Alex Smith wrote: > The buffer intrinsics should be used instead of the image ones. > > Signed-off-by: Alex Smith > Cc: > --- > This applies on top of James Legg's recent series [1], since they both > touch the same function. > > [1] https://list

Re: [Mesa-dev] [PATCH v2 3/3] ac/nir: assert printfs will fit

2017-06-28 Thread Bas Nieuwenhuizen
Thanks, pushed patches 2& 3. On Mon, Jun 26, 2017 at 10:05 AM, Nicolai Hähnle wrote: > Patches 2 & 3: > > Reviewed-by: Nicolai Hähnle > > > On 23.06.2017 12:18, James Legg wrote: >> >> --- >> src/amd/common/ac_nir_to_llvm.c | 17 - >> 1 file changed, 12 insertions(+), 5 deleti

[Mesa-dev] [PATCH] ac/nir: remove last remnants of v16i8

2017-06-28 Thread Dave Airlie
From: Dave Airlie llvm doesn't need this workaround anymore. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_build.c | 1 - src/amd/common/ac_llvm_build.h | 1 - src/amd/common/ac_nir_to_llvm.c | 10 +++--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/amd/co

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #1 from George Kyriazis --- Trevor, have you tried compiling with devenv? We don't have a problem compiling 17.1.3 there. We haven't tried compiling with mingw. -- You are receiving this mail because: You are the assignee for th

[Mesa-dev] [PATCH] swr: Remove need to allocate vertex buffer scratch space all in one go.

2017-06-28 Thread Bruce Cherniak
Deferred deletion (via "fence_work") has obsoleted the need to allocate all client vertex buffer scratch space in a single chunk. Scratch allocations are now valid until the referenced fence is complete. --- src/gallium/drivers/swr/swr_state.cpp | 25 ++--- 1 file changed, 2 i

Re: [Mesa-dev] [PATCH 5/5] dri3: Use SwapBuffer flips for back- and fake front

2017-06-28 Thread Thomas Hellstrom
On 06/28/2017 07:36 PM, Axel Davy wrote: Hi, To my knowledge, this is invalid to switch the front fake buffer with the back buffer. The front buffer is supposed to take into account what the app draws with the xserver commands, etc. SwapBuffers should bring the contents of the back buffer

Re: [Mesa-dev] [PATCH 23/30] intel/isl: Add support for I915_FORMAT_MOD_Y_TILED_CCS

2017-06-28 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/intel/isl/isl_drm.c | 11 +++ > 1 file changed, 11 insertions(+) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/list

[Mesa-dev] [PATCH] vc4: Introduce XML-based packet header generation like Intel's.

2017-06-28 Thread Eric Anholt
I really liked this idea, as it should help with management of packet parsing tools like the CL dump. The python script is forked off of theirs because our packets are byte-based instead of dwords, and the changes to do so while avoiding performance regressions due to unaligned accesses were quite

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

2017-06-28 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 10:59 AM, Daniel Stone wrote: > Hi, > > On 28 June 2017 at 16:35, Jason Ekstrand wrote: > > On Wed, Jun 28, 2017 at 4:06 AM, Daniel Stone > wrote: > >> On 28 June 2017 at 02:05, Jason Ekstrand wrote: > >> > The long answer is that the DRI formats do not specify a colors

Re: [Mesa-dev] [PATCH 0/2] Fix distcheck

2017-06-28 Thread Lionel Landwerlin
Oops, thanks a lot! This series is : Reviewed-by: Lionel Landwerlin On 28/06/17 18:47, Juan A. Suarez Romero wrote: The following two patches fix distcheck. Juan A. Suarez Romero (2): intel: automake: include Makefile.drm.am intel: tools: add intel_aub.h as part of aubinator src/int

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

2017-06-28 Thread Daniel Stone
Hi, On 28 June 2017 at 16:35, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 4:06 AM, Daniel Stone wrote: >> On 28 June 2017 at 02:05, Jason Ekstrand wrote: >> > The long answer is that the DRI formats do not specify a colorspace. >> >> Also, strictly speaking, the DRI_IMAGE_FORMAT_* tokens do

[Mesa-dev] Mesa 17.1.4 release candidate

2017-06-28 Thread Andres Gomez
Hello list, The candidate for the Mesa 17.1.4 is now available. Currently we have:  - 54 queued  - 0 nominated (outstanding)  - and 2 rejected patch(es) In the current queue we have: In Mesa Core we include some fixes that involve flushing vertices before some state changes. The state tracker

[Mesa-dev] [PATCH 2/2] intel: tools: add intel_aub.h as part of aubinator

2017-06-28 Thread Juan A. Suarez Romero
Include intel_aub.h in the Makefile.tools.am --- src/intel/Makefile.tools.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/Makefile.tools.am b/src/intel/Makefile.tools.am index 45891e7..8071220 100644 --- a/src/intel/Makefile.tools.am +++ b/src/intel/Makefile.tool

[Mesa-dev] [PATCH 1/2] intel: automake: include Makefile.drm.am

2017-06-28 Thread Juan A. Suarez Romero
--- src/intel/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/Makefile.am b/src/intel/Makefile.am index 269d73d..dad54b7 100644 --- a/src/intel/Makefile.am +++ b/src/intel/Makefile.am @@ -62,6 +62,7 @@ EXTRA_DIST = include Makefile.blorp.am include Makefile.common.am i

[Mesa-dev] [PATCH 0/2] Fix distcheck

2017-06-28 Thread Juan A. Suarez Romero
The following two patches fix distcheck. Juan A. Suarez Romero (2): intel: automake: include Makefile.drm.am intel: tools: add intel_aub.h as part of aubinator src/intel/Makefile.am | 1 + src/intel/Makefile.tools.am | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.9.4

Re: [Mesa-dev] [PATCH 10/11] etnaviv: implement resource creation with modifier

2017-06-28 Thread Wladimir J. van der Laan
On Fri, Jun 23, 2017 at 05:50:27PM +0200, Lucas Stach wrote: > This allows to create buffers with a specific tiling layout, which is > primarily > used by GBM to allocate the EGL back buffers with the correct tiling/modifier > for use with the scanout engines. > > Signed-off-by: Lucas Stach > --

Re: [Mesa-dev] [PATCH 09/11] etnaviv: fill in modifier in etna_resource_get_handle

2017-06-28 Thread Wladimir J. van der Laan
On Fri, Jun 23, 2017 at 05:50:26PM +0200, Lucas Stach wrote: > This allows the state trackers to know the tiling layout of the > resource and pass this through the various userspace protocols. > Signed-off-by: Lucas Stach Comment inline. Reviewed-by: Wladimir J. van der Laan > --- > src/gall

Re: [Mesa-dev] [PATCH 22/30] i965/screen: Drop get_tiled_height

2017-06-28 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > It's no longer used. And the tree still builds. Reviewed-by: Chad Versace > --- > src/mesa/drivers/dri/i965/intel_screen.c | 20 +++- > 1 file changed, 3 insertions(+), 17 deletions(-) ___ me

Re: [Mesa-dev] [PATCH 07/11] etnaviv: implement resource import with modifier

2017-06-28 Thread Wladimir J. van der Laan
On Fri, Jun 23, 2017 at 05:50:24PM +0200, Lucas Stach wrote: > This implements resource import with modifier, deriving the correct > internal layout from the modifier and constructing a render compatible > base resource if needed. > > This removes the special cases for DDX and renderonly scanout a

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

2017-06-28 Thread Wladimir J. van der Laan
> > Why do this copy if to==from? > > Tile-status resolve. We currently don't support sampler TS (which is Ah of course. Might make sense to add a comment mentioning this, it's not straightforward when reading the code :) > probably worth implementing, as it has potentially large performance >

Re: [Mesa-dev] [PATCH 21/30] i965/screen: Use ISL for doing image import checks

2017-06-28 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_screen.c | 32 > > 1 file changed, 28 insertions(+), 4 deletions(-) This patch adds more code, but it's code I trust. Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH 20/30] i965/screen: Use ISL for allocating image BOs

2017-06-28 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_screen.c | 51 > ++-- > 1 file changed, 29 insertions(+), 22 deletions(-) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists

Re: [Mesa-dev] [PATCH] Android: use symlinks for driver loading

2017-06-28 Thread Rob Clark
On Wed, Jun 28, 2017 at 12:51 PM, Rob Herring wrote: > On Wed, Jun 28, 2017 at 11:46 AM, Eric Anholt wrote: >> Rob Herring writes: >> >>> Instead of having special driver loading logic for Android, create >>> symlinks to gallium_dri.so so we can use the standard loading logic. >>> >>> Signed-off

Re: [Mesa-dev] [PATCH 08/11] etnaviv: fold etna_screen_bo_get_handle into etna_resource_get_handle

2017-06-28 Thread Wladimir J. van der Laan
On Fri, Jun 23, 2017 at 05:50:25PM +0200, Lucas Stach wrote: > There is no point in keeping this indirection. Makes the code easier to > follow. > > Signed-off-by: Lucas Stach Seems to make sense - etna_screen_bo_get_handle doesn't actually do anything screen specific. Reviewed-by: Wladimir J.

Re: [Mesa-dev] [PATCH 0/5] dri3, gallium: Correctness and performance fixes

2017-06-28 Thread Thomas Hellstrom
On 06/22/2017 12:42 PM, Thomas Hellstrom wrote: A patch series that deals with dri3 correctness- and performance fixes. The corectness fixes attempts to deal with the fact that we need to wait for all pending swapbuffers before we touch the front buffer. Otherwise a front buffer change may be ov

Re: [Mesa-dev] [PATCH 19/30] intel/isl: Add a helper to convert tilings fro ISL to i915

2017-06-28 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 3 +++ > src/intel/isl/isl_drm.c | 23 +++ > 2 files changed, 26 insertions(+) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedeskt

Re: [Mesa-dev] [PATCH 5/5] dri3: Use SwapBuffer flips for back- and fake front

2017-06-28 Thread Thomas Hellstrom
On 06/22/2017 12:42 PM, Thomas Hellstrom wrote: Use flips for back- and fake front buffers. This might lead to fake front and real front being shared if the hardware is page-flip capable. In any case it will save a full-drawable copy and also the subsequent wait for the X server to submit that c

Re: [Mesa-dev] [PATCH 2/5] dri: Add a flushSwapBuffers method to the image loader extension

2017-06-28 Thread Thomas Hellstrom
On 06/22/2017 12:42 PM, Thomas Hellstrom wrote: This method may be used by dri drivers to make sure all outstanding buffer swaps have been flushed to hardware. Also add a dri3 implementation. Signed-off-by: Thomas Hellstrom --- include/GL/internal/dri_interface.h | 16 +++- src/g

Re: [Mesa-dev] gallium: Reduce trace_dump_box_bytes size by box->x.

2017-06-28 Thread Cherniak, Bruce
> On Jun 26, 2017, at 2:10 PM, Marek Olšák wrote: > > In my opinion, dumping resources isn't very useful. I think it would > be better to remove that completely. From Michel's response, sounds like dumping resources is useful, so... Back to my original question, is this a valid fix? It preven

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

2017-06-28 Thread Chad Versace
On Wed 28 Jun 2017, Daniel Stone wrote: > Hi, > > On 28 June 2017 at 02:05, Jason Ekstrand wrote: > > Would you feel more comfortable with a boolean sRGB parameter? That would > > make the answers to the above questions much more obvious at the cost of > > some code. > > s/boolean/enum/ and yo

Re: [Mesa-dev] [PATCH] Android: use symlinks for driver loading

2017-06-28 Thread Rob Herring
On Wed, Jun 28, 2017 at 11:46 AM, Eric Anholt wrote: > Rob Herring writes: > >> Instead of having special driver loading logic for Android, create >> symlinks to gallium_dri.so so we can use the standard loading logic. >> >> Signed-off-by: Rob Herring > > >> diff --git a/src/gallium/drivers/free

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

2017-06-28 Thread Chad Versace
On Tue 27 Jun 2017, Jason Ekstrand wrote: > On Tue, Jun 27, 2017 at 12:19 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Mon 26 Jun 2017, Pohjolainen, Topi wrote: > > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > > > From: Ben Widawsky <[2]b...@bwida

Re: [Mesa-dev] [PATCH] Android: use symlinks for driver loading

2017-06-28 Thread Eric Anholt
Rob Herring writes: > Instead of having special driver loading logic for Android, create > symlinks to gallium_dri.so so we can use the standard loading logic. > > Signed-off-by: Rob Herring > diff --git a/src/gallium/drivers/freedreno/Android.mk > b/src/gallium/drivers/freedreno/Android.mk >

[Mesa-dev] [PATCH 5/5] vulkan: util: add macros to extract extension/offset number from enums

2017-06-28 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/vulkan/util/vk_util.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/vulkan/util/vk_util.h b/src/vulkan/util/vk_util.h index 2ed601f881e..a152984d14d 100644 --- a/src/vulkan/util/vk_util.h +++ b/src/vulkan/util/vk_util.h @@ -199,4 +199,11 @

[Mesa-dev] [PATCH 0/5] Vulkan: add extensions numbers to generated enums

2017-06-28 Thread Lionel Landwerlin
Hi, We already have seen extensions like VK_IMG_format_pvrtc introduce new formats. The way the Vulkan specification seems to deal with new formats is to place them at an offset based on the associated extension number. The anv driver currently stores the formats in an array indexed by the format

  1   2   >