Re: [Mesa-dev] [PATCH 2/2] radeonsi: get rid of secondary input/output word

2017-05-09 Thread Nicolai Hähnle
Hi Axel, Any idea about how many GENERIC indices nine uses? It would be nice to be able to remove the second bitfield in radeonsi, and we still have some slack, so could support more than the 32 that are exposed for OpenGL. Thanks, Nicolai On 05.05.2017 19:35, Marek Olšák wrote: Hi Nicolai,

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-09 Thread Thomas Hellstrom
On 05/10/2017 03:59 AM, Michel Dänzer wrote: > On 09/05/17 07:28 PM, Thomas Hellstrom wrote: >> On 05/09/2017 11:29 AM, Michel Dänzer wrote: >>> On 09/05/17 06:12 PM, Thomas Hellstrom wrote: On 05/09/2017 10:47 AM, Michel Dänzer wrote: > On 09/05/17 05:32 PM, Thomas Hellstrom wrote: >>

Re: [Mesa-dev] [PATCH 4/4] i965: Switch BRW_NEW_CURBE_OFFSETS to BRW_NEW_PUSH_CONSTANT_ALLOCATION.

2017-05-09 Thread Pohjolainen, Topi
On Tue, May 09, 2017 at 04:10:29PM -0700, Kenneth Graunke wrote: > The BRW_NEW_CURBE_OFFSETS dirty bit is signalled when changing the > partitioning of the Constant Buffer URB section between the various > shader stages, on Gen4-5. > > BRW_NEW_PUSH_CONSTANT_ALLOCATION is basically the same thing o

[Mesa-dev] Bug in 17.1.0-rc4 source packaging for swr?

2017-05-09 Thread Chuck Atkins
I just tried to build 17.0.4-rc4 from the tarball with swr enabled and got errors about my python not having mako: make[5]: Entering directory '/tmp/atkins3/mesa/build/mesa-17.1.0-rc4_gcc-6.3.0_haswell/src/gallium/drivers/swr' GEN rasterizer/jitter/gen_builder.hpp Traceback (most recent cal

[Mesa-dev] radv patches for 17.1

2017-05-09 Thread Dave Airlie
In order to pass CTS for 17.1 with llvm 4.0, radv needs some extra patches cherry-picked. 09034aab64c7a6022a2c508658fead1442f08576 3c730639740f9b1243e95d06e6608cb54649be9a a52470402515c46cd9f33a5d83dc8d2bc9f7bae9 83e58b036e1c34f26c99d04615df2b530f3045d9 3bf3f9866c1387872521242921bb00c7fb7c2834 efa

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-09 Thread Michel Dänzer
On 09/05/17 07:28 PM, Thomas Hellstrom wrote: > On 05/09/2017 11:29 AM, Michel Dänzer wrote: >> On 09/05/17 06:12 PM, Thomas Hellstrom wrote: >>> On 05/09/2017 10:47 AM, Michel Dänzer wrote: On 09/05/17 05:32 PM, Thomas Hellstrom wrote: > On 05/09/2017 10:05 AM, Michel Dänzer wrote: >>

[Mesa-dev] [PATCH] mesa/i965: remove _CurrentFragmentProgram from gl_pipeline_object

2017-05-09 Thread Timothy Arceri
This was added in b527dd65c830a as a work around because fixed function fragment shaders were tracked in ctx->FragmentProgram._Current as a gl_program rather than gl_shader_program. However after my refactoring of the program and shader structs at the end of 2016 which culminated in c505d6d85222,

[Mesa-dev] [PATCH V2 11/15] mesa: add KHR_no_error support for FramebufferTextureLayer

2017-05-09 Thread Timothy Arceri
V2: use frame_buffer_texture_layer_no_error() helper --- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- src/mesa/main/fbobject.c | 15 +++ src/mesa/main/fbobject.h | 4 3 files changed, 20 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH V2 14/15] mesa: add KHR_no_error support for FramebufferTexture

2017-05-09 Thread Timothy Arceri
V2: use the framebuffer_texture_no_error() helper --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/fbobject.c| 14 ++ src/mesa/main/fbobject.h| 3 +++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [PATCH V2 15/15] mesa: add KHR_no_error support for NamedFramebufferTexture

2017-05-09 Thread Timothy Arceri
V2: use framebuffer_texture_no_error() helper --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/fbobject.c | 13 + src/mesa/main/fbobject.h | 3 +++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/m

[Mesa-dev] [PATCH V2 13/15] mesa: add framebuffer_texture_no_error() helper

2017-05-09 Thread Timothy Arceri
To be used to add KHR_no_error support while sharing code between the DSA and non-DSA OpenGL function. --- src/mesa/main/fbobject.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 7f16597..f4df151 100644 --- a/sr

[Mesa-dev] [PATCH V2 12/15] mesa: add KHR_no_error support for NamedFramebufferTextureLayer

2017-05-09 Thread Timothy Arceri
v2: use frame_buffer_texture_layer_no_error() helper --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/fbobject.c | 17 + src/mesa/main/fbobject.h | 5 + 3 files changed, 23 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH V2 10/16] mesa: add frame_buffer_texture_layer_no_error() helper

2017-05-09 Thread Timothy Arceri
To be used to add KHR_no_error support while sharing code between the DSA and non-DSA OpenGL function. --- src/mesa/main/fbobject.c | 28 1 file changed, 28 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index ba01d0c..3338974 100644 --

Re: [Mesa-dev] [PATCH] mesa: use u_bit_scan() in update_program_texture_state()

2017-05-09 Thread Timothy Arceri
I made this same change a while back but found I couldn't really measure any performance increase in practice. I suspect it's because we already limit the max loops with (1 << s) <= prog[i]->SamplersUsed and there is generally no big gaps in used samples. Did you manage to measure any improveme

Re: [Mesa-dev] [PATCH 10/13] mesa: add KHR_no_error support for FramebufferTextureLayer

2017-05-09 Thread Eric Anholt
Timothy Arceri writes: > --- > src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- > src/mesa/main/fbobject.c | 31 > +++ > src/mesa/main/fbobject.h | 4 > 3 files changed, 36 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH 2/5] genxml: Add alias for MOCS.

2017-05-09 Thread Rafael Antognolli
Use an alias for this field on 3DSTATE_INDEX_BUFFER on gen6+, so we can set the same value as the defines. Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen6.xml | 1 + src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 + src/intel/genxml/gen8.xml | 1 + src/intel/genxml

[Mesa-dev] [PATCH 3/5] i965: Port brw_cs_state tracked state to genxml.

2017-05-09 Thread Rafael Antognolli
Emit the respective commands using genxml code. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_state.h | 1 - src/mesa/drivers/dri/i965/gen7_cs_state.c | 162 -- src/mesa/drivers/dri/i965/genX_state_upload.c | 146 ++-

[Mesa-dev] [PATCH 1/5] i965/genxml: Mostly style fixes for emit_vertices code.

2017-05-09 Thread Rafael Antognolli
Several issues were caught on review after the original patch landed. This commit fixes them. v2: - Fix padding (Topi) - Remove .DestinationElementOffset change from this patch (Topi) Signed-off-by: Rafael Antognolli Reviewed-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/genX_state_

[Mesa-dev] [PATCH 5/5] i965: Port 3DSTATE_VF_TOPOLOGY on gen8+ to genxml.

2017-05-09 Thread Rafael Antognolli
With this last state ported, we can get rid of gen8_draw_upload.c. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_state.h | 1 - src/mesa/drivers/dri/i965/gen8_draw_upload.c | 53 --- src/

[Mesa-dev] [PATCH 4/5] i965: Port 3DSTATE_INDEX_BUFFER to genxml.

2017-05-09 Thread Rafael Antognolli
Also make the brw_get_index_type() function not shift its return, since that is genxml's job now. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_context.h | 6 ++-- src/mesa/drivers/dri/i965/brw_draw_upload.c | 39 - src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 07/13] mesa: add error version of get_texture_for_framebuffer()

2017-05-09 Thread Eric Anholt
Timothy Arceri writes: > This is a step towards KHR_no_error support. > --- > src/mesa/main/fbobject.c | 26 ++ > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index fb8fbe9..85744e3 100644 > --- a/

Re: [Mesa-dev] [PATCH 18/21] anv: Implement support for exporting semaphores as FENCE_FD

2017-05-09 Thread Jason Ekstrand
On Tue, May 9, 2017 at 4:49 PM, Chad Versace wrote: > I learned a lot by reviewing this patch. Before reviewing it, some parts > of the external_semaphore spec still confused me. But reviewing this > forced me to really learn the behavior of external semaphores. > > Other than some small security

Re: [Mesa-dev] [PATCH 18/21] anv: Implement support for exporting semaphores as FENCE_FD

2017-05-09 Thread Chad Versace
I learned a lot by reviewing this patch. Before reviewing it, some parts of the external_semaphore spec still confused me. But reviewing this forced me to really learn the behavior of external semaphores. Other than some small security nits, the only real issue I found was the error behavior of vk

Re: [Mesa-dev] [PATCH 2/4] i965: Only #if...#endif a single function or related section at a time.

2017-05-09 Thread Rafael Antognolli
On Tue, May 09, 2017 at 04:10:27PM -0700, Kenneth Graunke wrote: > Previously we guarded large swathes of code with #if GEN ... #endif > blocks. This made it difficult to see which generations include what. > > This patch splits up the #if..#endif sections so they surround a small > section of co

Re: [Mesa-dev] [PATCH 1/4] i965: Turn brw_get_line_width_float() into brw_get_line_width().

2017-05-09 Thread Rafael Antognolli
On Tue, May 09, 2017 at 04:10:26PM -0700, Kenneth Graunke wrote: > Drop the old brw_get_line_width() helper which return the unsigned > fixed-point encoding of the line width - it's been dead since the > conversion to GENXML (which does the encoding for us). > > Then rename brw_get_line_width_floa

[Mesa-dev] [PATCH 4/4] i965: Switch BRW_NEW_CURBE_OFFSETS to BRW_NEW_PUSH_CONSTANT_ALLOCATION.

2017-05-09 Thread Kenneth Graunke
The BRW_NEW_CURBE_OFFSETS dirty bit is signalled when changing the partitioning of the Constant Buffer URB section between the various shader stages, on Gen4-5. BRW_NEW_PUSH_CONSTANT_ALLOCATION is basically the same thing on Gen7+. So, save a bit, and use the new name. --- src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 3/4] i965: Drop BRW_NEW_PUSH_CONSTANT_ALLOCATION from Gen6 code.

2017-05-09 Thread Kenneth Graunke
Gen6 doesn't have a configurable push constant region. This is only used on Gen7+. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_sta

[Mesa-dev] [PATCH 1/4] i965: Turn brw_get_line_width_float() into brw_get_line_width().

2017-05-09 Thread Kenneth Graunke
Drop the old brw_get_line_width() helper which return the unsigned fixed-point encoding of the line width - it's been dead since the conversion to GENXML (which does the encoding for us). Then rename brw_get_line_width_float() to the shorter name. --- src/mesa/drivers/dri/i965/brw_util.h

[Mesa-dev] [PATCH 2/4] i965: Only #if...#endif a single function or related section at a time.

2017-05-09 Thread Kenneth Graunke
Previously we guarded large swathes of code with #if GEN ... #endif blocks. This made it difficult to see which generations include what. This patch splits up the #if..#endif sections so they surround a small section of code - usually a single function/atom, or sometimes a group of related functi

Re: [Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

2017-05-09 Thread Dave Airlie
On 6 May 2017 at 02:35, Daniel Stone wrote: > Hi Emil, > > On 4 May 2017 at 15:14, Emil Velikov wrote: >> On 4 May 2017 at 14:43, Daniel Stone wrote: >>> IOW, there is no change as far as I can see, but perhaps for the >>> meantime, we could use an unreachable() at the bottom of >>> modifier_to_

[Mesa-dev] [PATCH] mesa: use u_bit_scan() in update_program_texture_state()

2017-05-09 Thread Samuel Pitoiset
The check in update_single_program_texture() can also be removed. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstate.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 830b230b5d..c11a2e95fe 100644

Re: [Mesa-dev] [PATCH] renderonly: Initialize fields of struct winsys_handle.

2017-05-09 Thread Christian Gmeiner
2017-05-09 20:24 GMT+02:00 Eric Anholt : > vc4 was rejecting renderonly's import, because the offset field was > nonzero. Reviewed-by: Christian Gmeiner greets -- Christian Gmeiner, MSc https://www.youtube.com/user/AloryOFFICIAL https://soundcloud.com/christian-gmeiner _

Re: [Mesa-dev] [PATCH] nir: Embed the shader_info in the nir_shader again

2017-05-09 Thread Kenneth Graunke
On Monday, May 8, 2017 10:54:25 AM PDT Jason Ekstrand wrote: > Commit e1af20f18a86f52a9640faf2d4ff8a71b0a4fa9b changed the shader_info > from being embedded into being just a pointer. The idea was that > sharing the shader_info between NIR and GLSL would be easier if it were > a pointer pointing t

[Mesa-dev] [PATCH] renderonly: Initialize fields of struct winsys_handle.

2017-05-09 Thread Eric Anholt
vc4 was rejecting renderonly's import, because the offset field was nonzero. --- src/gallium/auxiliary/renderonly/renderonly.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/renderonly/renderonly.c b/src/gallium/auxiliary/renderonly/renderonly.c index 2fe10090163e..d3ed

[Mesa-dev] How does FakeGLX work since Mesa 10?

2017-05-09 Thread Tom Hudson
I'm trying to upgrade a Mesa 10 installation to Mesa 17. There have been plenty of changes, but only one breakage that's left me perplexed. https://cgit.freedesktop.org/mesa/mesa/commit/?id=c00b250c8061d042d9905e61b9077462ee91008b In this CL, Mesa stopped maintaining a __GLXcontext for FakeGLX; t

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

2017-05-09 Thread gregory hainaut
On Tue, 09 May 2017 09:31:18 -0700 Eric Anholt wrote: > Gregory Hainaut writes: > > > On 5/8/17, Emil Velikov wrote: > [...] > > > > Hello Emil, > > > > Yes you're right. And potentially it can be back-ported to stable > > branch. Besides it would allow to know which applications aren't X

Re: [Mesa-dev] i965: Use isl for hiz and stencil

2017-05-09 Thread Jason Ekstrand
On Tue, May 9, 2017 at 9:43 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, May 09, 2017 at 08:45:55AM -0700, Jason Ekstrand wrote: > > On Mon, May 8, 2017 at 11:10 PM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Mon, May 08, 2017 at 04:51:35PM -070

[Mesa-dev] [RFC] intel/isl: Rewrite gen7_choose_image_alignment_el

2017-05-09 Thread Jason Ekstrand
The Ivy Bridge PRM provides a nice table that handles most of the alignment cases in one place. For standard color buffers we have a little freedom of choice but for most depth, stencil and compressed it's hard-coded. Chad's original functions split halign and valign apart and implemented them al

[Mesa-dev] [PATCH] freedreno: fix clang error in fd_get_compute_param

2017-05-09 Thread Rob Herring
With commit 10c17f23b752 ("freedreno: core compute state support"), Android builds fail with the following error: external/mesa3d/src/gallium/drivers/freedreno/freedreno_screen.c:610:17: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]

Re: [Mesa-dev] i965: Use isl for hiz and stencil

2017-05-09 Thread Pohjolainen, Topi
On Tue, May 09, 2017 at 08:45:55AM -0700, Jason Ekstrand wrote: > On Mon, May 8, 2017 at 11:10 PM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Mon, May 08, 2017 at 04:51:35PM -0700, Jason Ekstrand wrote: > > > On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen < > > topi.pohjol

Re: [Mesa-dev] i965: Use isl for hiz and stencil

2017-05-09 Thread Pohjolainen, Topi
On Tue, May 09, 2017 at 08:48:08AM -0700, Jason Ekstrand wrote: > All of the below being said, I'm fine with landing things with a > BACK_TO_BACK layout and then making the switch to one isl_surf per miplevel > later if that's an easier path. I can give the "array of ISL surfaces" approach a spin

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

2017-05-09 Thread Eric Anholt
Gregory Hainaut writes: > On 5/8/17, Emil Velikov wrote: >> Having a look at Xlib might be good indeed. >> >> Then again, the solution you've proposed looks perfectly reasonable, >> IMHO. It handles the problem _now_ and should also work when/if we >> address Xlib. >> I'll take another look toda

Re: [Mesa-dev] [v2 37/39] intel/isl/gen7/hack: Use stencil vertical alignment of 8 instead of 4

2017-05-09 Thread Jason Ekstrand
Woah, wall of e-mails. :-) On Tue, May 9, 2017 at 5:02 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, May 09, 2017 at 02:44:35PM +0300, Pohjolainen, Topi wrote: > > On Tue, May 09, 2017 at 02:36:47PM +0300, Pohjolainen, Topi wrote: > > > On Tue, May 09, 2017 at 02:29:13PM +0

[Mesa-dev] [Bug 100928] exported opengl function in generated dll was mangled when building with msvc 2015 Update 3

2017-05-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100928 George Kyriazis changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

Re: [Mesa-dev] i965: Use isl for hiz and stencil

2017-05-09 Thread Jason Ekstrand
All of the below being said, I'm fine with landing things with a BACK_TO_BACK layout and then making the switch to one isl_surf per miplevel later if that's an easier path. On Tue, May 9, 2017 at 8:45 AM, Jason Ekstrand wrote: > On Mon, May 8, 2017 at 11:10 PM, Pohjolainen, Topi < > topi.pohjola

Re: [Mesa-dev] i965: Use isl for hiz and stencil

2017-05-09 Thread Jason Ekstrand
On Mon, May 8, 2017 at 11:10 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Mon, May 08, 2017 at 04:51:35PM -0700, Jason Ekstrand wrote: > > On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com > > > wrote: > > > > > Patches 1-17 are revision that > > >

Re: [Mesa-dev] [PATCH 11/11] radeonsi: dump compute descriptor lists

2017-05-09 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On May 8, 2017 5:39 PM, "Nicolai Hähnle" wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_debug.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/ radeonsi/si_debug.c

Re: [Mesa-dev] [v2 37/39] intel/isl/gen7/hack: Use stencil vertical alignment of 8 instead of 4

2017-05-09 Thread Pohjolainen, Topi
On Tue, May 09, 2017 at 02:44:35PM +0300, Pohjolainen, Topi wrote: > On Tue, May 09, 2017 at 02:36:47PM +0300, Pohjolainen, Topi wrote: > > On Tue, May 09, 2017 at 02:29:13PM +0300, Pohjolainen, Topi wrote: > > > On Tue, May 09, 2017 at 08:25:28AM +0300, Pohjolainen, Topi wrote: > > > > On Mon, May

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Volker Vogelhuber
Hi Daniel, Hi Volker, On 9 May 2017 at 12:32, Volker Vogelhuber wrote: On 09.05.2017 12:59, Philipp Zabel wrote: You create two separate EGLImages, calling eglCreateImage once for each plane. See for example: https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglup

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Daniel Stone
Hi Volker, On 9 May 2017 at 12:32, Volker Vogelhuber wrote: > On 09.05.2017 12:59, Philipp Zabel wrote: >> You create two separate EGLImages, calling eglCreateImage once for each >> plane. See for example: >> >> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstgluplo

Re: [Mesa-dev] [v2 37/39] intel/isl/gen7/hack: Use stencil vertical alignment of 8 instead of 4

2017-05-09 Thread Pohjolainen, Topi
On Tue, May 09, 2017 at 02:36:47PM +0300, Pohjolainen, Topi wrote: > On Tue, May 09, 2017 at 02:29:13PM +0300, Pohjolainen, Topi wrote: > > On Tue, May 09, 2017 at 08:25:28AM +0300, Pohjolainen, Topi wrote: > > > On Mon, May 08, 2017 at 03:31:55PM -0700, Jason Ekstrand wrote: > > > > On Wed, May 3,

Re: [Mesa-dev] [v2 37/39] intel/isl/gen7/hack: Use stencil vertical alignment of 8 instead of 4

2017-05-09 Thread Pohjolainen, Topi
On Tue, May 09, 2017 at 02:29:13PM +0300, Pohjolainen, Topi wrote: > On Tue, May 09, 2017 at 08:25:28AM +0300, Pohjolainen, Topi wrote: > > On Mon, May 08, 2017 at 03:31:55PM -0700, Jason Ekstrand wrote: > > > On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen > > > > > > wrote: > > > > > > > Sign

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Volker Vogelhuber
On 09.05.2017 12:59, Philipp Zabel wrote: On Tue, 2017-05-09 at 12:48 +0200, Volker Vogelhuber wrote: [...] Ok thanks for the clarification. There is only one missing part for the GL_TEXTURE_2D case. The second EGLImage is created internally when calling eglCreateImage with EGL_LINUX_DMA_BUF_EX

Re: [Mesa-dev] [v2 37/39] intel/isl/gen7/hack: Use stencil vertical alignment of 8 instead of 4

2017-05-09 Thread Pohjolainen, Topi
On Tue, May 09, 2017 at 08:25:28AM +0300, Pohjolainen, Topi wrote: > On Mon, May 08, 2017 at 03:31:55PM -0700, Jason Ekstrand wrote: > > On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen > > wrote: > > > > > Signed-off-by: Topi Pohjolainen > > > --- > > > src/intel/isl/isl_gen7.c | 6 +- > >

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Philipp Zabel
On Tue, 2017-05-09 at 12:48 +0200, Volker Vogelhuber wrote: [...] > Ok thanks for the clarification. There is only one missing part for the > GL_TEXTURE_2D case. The second EGLImage is created internally when > calling eglCreateImage with EGL_LINUX_DMA_BUF_EXT, so I only > have one return value I c

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Volker Vogelhuber
On 09.05.2017 11:42, Philipp Zabel wrote: On Tue, 2017-05-09 at 12:31 +0300, Tapani Pälli wrote: On 05/09/2017 12:29 PM, Tapani Pälli wrote: On 05/09/2017 12:14 PM, Volker Vogelhuber wrote: Hi, first sorry, for missing the subject in my mail to the mailing list, then thanks for the hint wi

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

2017-05-09 Thread Tapani Pälli
On 05/05/2017 10:14 AM, Randy Xu wrote: Follow up "i965: Solve Android native fence fd double close" The _EGLSync.SyncFd is not neccesary to keep after pass to dri driver. Test: Run Vulkan and GLES stress test and no crash. Yep I've verified as well that no crashes happen. Lots of tearing th

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

2017-05-09 Thread Gregory Hainaut
On 5/8/17, Emil Velikov wrote: > Having a look at Xlib might be good indeed. > > Then again, the solution you've proposed looks perfectly reasonable, > IMHO. It handles the problem _now_ and should also work when/if we > address Xlib. > I'll take another look today/tomorrow, but I think the series

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-09 Thread Thomas Hellstrom
On 05/09/2017 11:29 AM, Michel Dänzer wrote: > On 09/05/17 06:12 PM, Thomas Hellstrom wrote: >> On 05/09/2017 10:47 AM, Michel Dänzer wrote: >>> On 09/05/17 05:32 PM, Thomas Hellstrom wrote: On 05/09/2017 10:05 AM, Michel Dänzer wrote: > On 05/05/17 11:02 PM, Thomas Hellstrom wrote: >>

Re: [Mesa-dev] [PATCH 1/3] egl/x11: Honor the EGL_PLATFORM_X11_SCREEN_EXT attribute

2017-05-09 Thread Emil Velikov
On 3 May 2017 at 16:57, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > src/egl/drivers/dri2/platform_x11.c | 2 +- > src/egl/main/egldisplay.c | 19 --- > src/egl/main/egldisplay.h | 1 + > 3 files changed, 14 insertions(+), 8 deletions(-) > > dif

Re: [Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: don't warn if more than one, go over them

2017-05-09 Thread Emil Velikov
On 8 May 2017 at 14:49, Andres Gomez wrote: > On Mon, 2017-05-08 at 13:41 +0100, Emil Velikov wrote: >> On 8 May 2017 at 11:52, Andres Gomez wrote: >> > On Mon, 2017-05-08 at 10:56 +0100, Emil Velikov wrote: >> > > On 6 May 2017 at 15:09, Andres Gomez wrote: >> > > > If an identified commit was

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Philipp Zabel
On Tue, 2017-05-09 at 12:31 +0300, Tapani Pälli wrote: > > On 05/09/2017 12:29 PM, Tapani Pälli wrote: > > > > > > On 05/09/2017 12:14 PM, Volker Vogelhuber wrote: > >> Hi, > >> > >> first sorry, for missing the subject in my mail to the mailing list, > >> then thanks > >> for the hint with the

Re: [Mesa-dev] [PATCH 2/2] bin/*py: honor editorconfig formatting

2017-05-09 Thread Emil Velikov
On 5 May 2017 at 14:09, Andres Gomez wrote: "Replace the two stray tabs with respective space." > Signed-off-by: Andres Gomez Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mail

Re: [Mesa-dev] [PATCH v2 1/2] bin: use tabs for coding style on *.sh files

2017-05-09 Thread Emil Velikov
On 5 May 2017 at 15:49, Andres Gomez wrote: > v2: Instead of changing *.sh, adapt the editorconfig file (Emil). > Thank you. > Signed-off-by: Andres Gomez Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https:

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Tapani Pälli
On 05/09/2017 12:29 PM, Tapani Pälli wrote: On 05/09/2017 12:14 PM, Volker Vogelhuber wrote: Hi, first sorry, for missing the subject in my mail to the mailing list, then thanks for the hint with the "ext_image_dma_buf_import-sample_yuv". Unfortunately things don't become clearer. In the

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Tapani Pälli
On 05/09/2017 12:14 PM, Volker Vogelhuber wrote: Hi, first sorry, for missing the subject in my mail to the mailing list, then thanks for the hint with the "ext_image_dma_buf_import-sample_yuv". Unfortunately things don't become clearer. In the samples as far as I can see, there is also onl

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-09 Thread Michel Dänzer
On 09/05/17 06:12 PM, Thomas Hellstrom wrote: > On 05/09/2017 10:47 AM, Michel Dänzer wrote: >> On 09/05/17 05:32 PM, Thomas Hellstrom wrote: >>> On 05/09/2017 10:05 AM, Michel Dänzer wrote: On 05/05/17 11:02 PM, Thomas Hellstrom wrote: > Increases performance on vmwgfx since we're avoidin

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

2017-05-09 Thread Volker Vogelhuber
Hi, first sorry, for missing the subject in my mail to the mailing list, then thanks for the hint with the "ext_image_dma_buf_import-sample_yuv". Unfortunately things don't become clearer. In the samples as far as I can see, there is also only one sampler defined in the shader. So how are the

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-09 Thread Thomas Hellstrom
On 05/09/2017 10:47 AM, Michel Dänzer wrote: > On 09/05/17 05:32 PM, Thomas Hellstrom wrote: >> On 05/09/2017 10:05 AM, Michel Dänzer wrote: >>> On 05/05/17 11:02 PM, Thomas Hellstrom wrote: Increases performance on vmwgfx since we're avoiding full buffer damage and since we can't sync to

Re: [Mesa-dev] [PATCH 2/2] i965: Drop INTEL_DEBUG=stats.

2017-05-09 Thread Samuel Iglesias Gonsálvez
Series is: Reviewed-by: Samuel Iglesias Gonsálvez On Tue, 2017-05-09 at 01:48 -0700, Kenneth Graunke wrote: > For whatever reason, we had an INTEL_DEBUG=stats option that enabled > various statistics counters on Gen4-5 systems.  It's been around > forever, though I can't think of a single time t

[Mesa-dev] [PATCH 2/2] i965: Drop INTEL_DEBUG=stats.

2017-05-09 Thread Kenneth Graunke
For whatever reason, we had an INTEL_DEBUG=stats option that enabled various statistics counters on Gen4-5 systems. It's been around forever, though I can't think of a single time that it's been useful. On Gen6+, we enable statistics all the time because they're necessary to support various query

[Mesa-dev] [PATCH 1/2] i965: Disable ARB_pipeline_statistics_query on Gen4-5.

2017-05-09 Thread Kenneth Graunke
We apparently enabled this on all platforms in Mesa 10.6. However, it was only ever implemented for Gen6+. The Gen4-5 query code goes up in flames with an "Unrecognized query target" unreachable() error if you even attempt to use any of the new functionality. This wasn't caught because the Pigli

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-09 Thread Michel Dänzer
On 09/05/17 05:32 PM, Thomas Hellstrom wrote: > On 05/09/2017 10:05 AM, Michel Dänzer wrote: >> On 05/05/17 11:02 PM, Thomas Hellstrom wrote: >>> Increases performance on vmwgfx since we're avoiding full buffer damage and >>> since we can't sync to vertical retrace anyway. >>> >>> Signed-off-by: Th

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-09 Thread Thomas Hellstrom
Hi, Michel, On 05/09/2017 10:05 AM, Michel Dänzer wrote: > On 05/05/17 11:02 PM, Thomas Hellstrom wrote: >> Increases performance on vmwgfx since we're avoiding full buffer damage and >> since we can't sync to vertical retrace anyway. >> >> Signed-off-by: Thomas Hellstrom >> --- >> src/mesa/driv

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-09 Thread Michel Dänzer
On 05/05/17 11:02 PM, Thomas Hellstrom wrote: > Increases performance on vmwgfx since we're avoiding full buffer damage and > since we can't sync to vertical retrace anyway. > > Signed-off-by: Thomas Hellstrom > --- > src/mesa/drivers/dri/common/drirc | 7 +++ > 1 file changed, 7 insertions(

Re: [Mesa-dev] [PATCH] mesa: add KHR_no_error support for glUseProgram

2017-05-09 Thread Nicolai Hähnle
On 09.05.2017 03:17, Timothy Arceri wrote: On 08/05/17 19:36, Nicolai Hähnle wrote: On 08.05.2017 02:25, Timothy Arceri wrote: V3: use always_inline attribute (Suggested by Nicolai) Cc: Nicolai Hähnle --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 75 +