[Mesa-dev] [PATCH 12/13] mesa: add KHR_no_error support for FramebufferTexture

2017-05-07 Thread Timothy Arceri
--- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/fbobject.c| 27 +++ src/mesa/main/fbobject.h| 3 +++ 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml index d2c768d..10c157e 100644 --- a/

[Mesa-dev] [PATCH 11/13] mesa: add KHR_no_error support for NamedFramebufferTextureLayer

2017-05-07 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/fbobject.c | 32 ++ src/mesa/main/fbobject.h | 5 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state_a

[Mesa-dev] [PATCH 03/13] mesa: make _mesa_get_framebuffer_attachment_parameter() static

2017-05-07 Thread Timothy Arceri
--- src/mesa/main/fbobject.c | 18 +- src/mesa/main/fbobject.h | 7 --- 2 files changed, 9 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index df7cc17..ef4fecf 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject

[Mesa-dev] [PATCH 06/13] mesa: pass rb attachment to _mesa_framebuffer_texture()

2017-05-07 Thread Timothy Arceri
This change will help us add KHR_no_error support to the caller. --- src/mesa/drivers/common/meta.c | 8 +-- src/mesa/main/fbobject.c | 54 +- src/mesa/main/fbobject.h | 4 ++-- 3 files changed, 45 insertions(+), 21 deletions(-) diff --git

[Mesa-dev] [PATCH 08/13] mesa: add no error version of framebuffer_texture_with_dims()

2017-05-07 Thread Timothy Arceri
--- src/mesa/main/fbobject.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 85744e3..932d5fd 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -3297,20 +3297,43 @@ _mesa_framebuffer_textur

[Mesa-dev] [PATCH 05/13] mesa: add _mesa_get_and_validate_attachment() helper

2017-05-07 Thread Timothy Arceri
Will be used to add KHR_no_error support. We make this available external so it can be called from meta. --- src/mesa/main/fbobject.c | 37 + src/mesa/main/fbobject.h | 5 + 2 files changed, 30 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/fbob

[Mesa-dev] [PATCH 04/13] mesa: remove _mesa_problem() from a couple of locations

2017-05-07 Thread Timothy Arceri
_mesa_problem() is still useful in some places such as is if a backend compile fails, but for the majority of cases we should be able to remove it. OpenGL test suites are becoming very mature, we should place more trust in debug builds picking up missed cases. --- src/mesa/main/attrib.c | 6 ++-

[Mesa-dev] [PATCH 13/13] mesa: add KHR_no_error support for NamedFramebufferTexture

2017-05-07 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/fbobject.c | 26 ++ src/mesa/main/fbobject.h | 3 +++ 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state_ac

[Mesa-dev] [PATCH 10/13] mesa: add KHR_no_error support for FramebufferTextureLayer

2017-05-07 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- src/mesa/main/fbobject.c | 31 +++ src/mesa/main/fbobject.h | 4 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_framebuffer_obje

[Mesa-dev] [PATCH 09/13] mesa: add KHR_no_error support for FramebufferTexture*D functions

2017-05-07 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 6 ++--- src/mesa/main/fbobject.c | 33 +++ src/mesa/main/fbobject.h | 12 ++ 3 files changed, 48 insertions(+), 3 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_frameb

[Mesa-dev] [PATCH 07/13] mesa: add error version of get_texture_for_framebuffer()

2017-05-07 Thread Timothy Arceri
This is a step towards KHR_no_error support. --- src/mesa/main/fbobject.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index fb8fbe9..85744e3 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/

[Mesa-dev] [PATCH 01/13] mesa: remove _mesa from static framebuffer object function

2017-05-07 Thread Timothy Arceri
--- src/mesa/main/fbobject.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index d486d01..ad49b0e 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -278,22 +278,22 @@ get_attachment(struct gl_cont

[Mesa-dev] [PATCH 02/13] mesa: fix indentation

2017-05-07 Thread Timothy Arceri
--- src/mesa/main/fbobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index ad49b0e..df7cc17 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -296,21 +296,21 @@ get_fb0_attachment(struct gl_contex

Re: [Mesa-dev] [PATCH] mesa: Make _mesa_primitive_restart_index a static inline in the header.

2017-05-07 Thread Timothy Arceri
On 08/05/17 13:54, Kenneth Graunke wrote: It's now basically a single expression, so it probably makes sense to have it inlined into the callers. Looks reasonable. Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v2 05/27] configure: enable the surfaceless platform by default

2017-05-07 Thread Tapani Pälli
Yes please! Acked-by: Tapani Pälli On 05/04/2017 07:29 PM, Emil Velikov wrote: From: Emil Velikov A simple platform that you want to use in a many usecases. See the spec file details. It has no special requirements plus it takes less than a second to build. Cc: Tapani Pälli Cc: mesa-sta..

Re: [Mesa-dev] [PATCH] android: i965: add per-gen libmesa_i965_gen{4, 45, 5} static

2017-05-07 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/06/2017 05:03 PM, Mauro Rossi wrote: Needed to fix android building errors: external/mesa/src/mesa/drivers/dri/i965/brw_state_upload.c:148: error: undefined reference to 'gen5_init_atoms' external/mesa/src/mesa/drivers/dri/i965/brw_state_upload.c:150: error: u

[Mesa-dev] [PATCH] mesa: Make _mesa_primitive_restart_index a static inline in the header.

2017-05-07 Thread Kenneth Graunke
It's now basically a single expression, so it probably makes sense to have it inlined into the callers. Suggested by Marek. --- src/mesa/main/varray.c | 18 -- src/mesa/main/varray.h | 17 +++-- 2 files changed, 15 insertions(+), 20 deletions(-) diff --git a/src/mesa/

Re: [Mesa-dev] [PATCH] glsl: destroy function and subroutine hash tables

2017-05-07 Thread Timothy Arceri
Pushed, thanks! On 03/05/17 04:06, Grazvydas Ignotas wrote: Just like other type hash tables are destroyed in _mesa_glsl_release_types(), also destroy the ones for function and subroutine types. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl_types.cpp | 10 ++ 1 file changed

[Mesa-dev] [AppVeyor] mesa master #4289 failed

2017-05-07 Thread AppVeyor
Build mesa 4289 failed Commit 1f743a0edf by Grazvydas Ignotas on 5/2/2017 6:06 PM: glsl: destroy function and subroutine hash tables\n\nJust like other type hash tables are destroyed in\n_mesa_glsl_release_types(), also destroy the ones for function and\nsubrou

[Mesa-dev] [Bug 100782] [GLVND] X fails to start AMDGPU DDX when GLVND compiled into Mesa

2017-05-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100782 Shawn Starr changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Mesa-dev] [PATCH] st/xvmc: deal with drivers wanting different texture formats

2017-05-07 Thread Ilia Mirkin
Previously, texture formats were being used unconditionally without checking. However nv30 supports neither RGBX8 nor R4A4/A4R4 formats. Add sufficient fallbacks so that the nv30 driver can have working OSD. Tested on a NV44A/PCI. Signed-off-by: Ilia Mirkin --- I need to double-check that I did

[Mesa-dev] [PATCH] gallivm: Make sure module has the correct data layout when pass manager runs

2017-05-07 Thread Tom Stellard
The datalayout for modules was purposely not being set in order to work around the fact that the ExecutionEngine requires that the module's datalayout matches the datalayout of the TargetMachine that the ExecutionEngine is using. When the pass manager runs on a module with no datalayout, it uses t

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

2017-05-07 Thread Axel Davy
Hi, There should be very few X11 calls while rendering (basically only at the beginning or end of a frame). Why not just always run these calls in the main thread (and wait for glthread work to finish) ? That's basically what we do for gallium nine. Yours, Axel On 05/05/2017 17:37, Grego

Re: [Mesa-dev] [PATCH] docs: remove released versions from the calendar

2017-05-07 Thread Eric Engestrom
On Thursday, 2017-05-04 17:37:56 +0100, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom I guess updating the release calendar could be added as part of docs/releasing.html#release (at the end, just before #announce) > --- > docs/release-c

Re: [Mesa-dev] [PATCH v2 07/27] configure: error out when building GLX w/o the X11 platform

2017-05-07 Thread Eric Engestrom
On Thursday, 2017-05-04 17:29:52 +0100, Emil Velikov wrote: > From: Emil Velikov > > Building EGL/Vulkan/other without X11, while GLX is enabled is confusing > and misleading. In practise anyone aiming at the former will also > disable GLX. > > The inverse (some examples below) should still work

[Mesa-dev] [PATCH] mesa: add KHR_no_error support for glUseProgram

2017-05-07 Thread Timothy Arceri
V3: use always_inline attribute (Suggested by Nicolai) Cc: Nicolai Hähnle --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 75 +-- src/mesa/main/shaderapi.h | 2 ++ 3 files changed, 54 insertions(+), 25 deletions(-) diff --g

Re: [Mesa-dev] [PATCH 2/2] docs: extend until the end of August

2017-05-07 Thread Eric Engestrom
On Saturday, 2017-05-06 18:46:13 +0300, Andres Gomez wrote: > Completed the 17.1 cycle and added the beginning of the 17.2 one. > > Cc: Emil Velikov > Cc: Juan A. Suarez Romero > Signed-off-by: Andres Gomez Reviewed-by: Eric Engestrom As for patch 1/2, I guess I missed the discussion around

Re: [Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: don't warn if more than one, go over them

2017-05-07 Thread Eric Engestrom
On Saturday, 2017-05-06 17:09:35 +0300, Andres Gomez wrote: > If an identified commit was having more than one fix, we would warn > about that and only treat the first. > > Now, we don't warn but treat all of them. This was on my todo list, thanks for fixing this :) > > Signed-off-by: Andres Go

Re: [Mesa-dev] [PATCH] egl: Fix -Wint-to-pointer-cast

2017-05-07 Thread Eric Engestrom
On Friday, 2017-05-05 12:27:03 -0700, Chad Versace wrote: > main/egldisplay.c: In function '_eglParseX11DisplayAttribList': > main/egldisplay.c:491:38: warning: cast to pointer from integer of different > size [-Wint-to-pointer-cast] > display->Options.Platform = (void *)value; > > The

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-05-07 Thread Dieter Nützel
Am 26.04.2017 14:37, schrieb tournier.elie: Hello, I'm not an r600g person but I will be pleased to have a look to this work. Hello Elie, I know, read most of your posts about your 'former' fp64 lib which was indeed HW-agnostic. I'm currently working on the fp64 for r600g. Hope to be abl

Re: [Mesa-dev] [PATCH v2 21/27] st/xvmc: add DRI3 support

2017-05-07 Thread Ilia Mirkin
Tested-by: Ilia Mirkin Seems to work with a NV44A (with some hacks to deal with its non-pcie/agp-ness, but that's entirely separate). The "background" area when entering full-screen mode appears to not get cleared with dri3 like it does with dri2, although I think I've seen that with vdpau as wel

[Mesa-dev] [PATCH mesa] egl: avoid dereferencing a null display

2017-05-07 Thread Eric Engestrom
Fixes: ddb99127a6f6c ("egl/x11: Honor the EGL_PLATFORM_X11_SCREEN_EXT attribute") Signed-off-by: Eric Engestrom --- src/egl/main/egldisplay.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c index b047a5de42..c4b0fd6aab

Re: [Mesa-dev] [PATCH 1/7] radv/meta: add srgb conversion to end of resolve shader.

2017-05-07 Thread Dave Airlie
On 5 May 2017 at 01:46, Bas Nieuwenhuizen wrote: > Can't we just use a non-SRGB image view into the destination image? > That should save some operations. We could possibly here, but not in the subpass path, which a later patch enables. I wasn't sure it was worth the effort. Dave. _

Re: [Mesa-dev] [PATCH 1/5] radv: set base/ranges for push constant loads.

2017-05-07 Thread Bas Nieuwenhuizen
This series is Reviewed-by: Bas Nieuwenhuizen On Fri, May 5, 2017 at 2:59 AM, Dave Airlie wrote: > From: Dave Airlie > > This isn't necessary yet but I'd like to use the range in > some future patches. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_meta_blit2d.c | 2 ++ > sr

Re: [Mesa-dev] [PATCH 1/7] radv/meta: add srgb conversion to end of resolve shader.

2017-05-07 Thread Bas Nieuwenhuizen
This series is Reviewed-by: Bas Nieuwenhuizen On Thu, May 4, 2017 at 5:27 AM, Dave Airlie wrote: > From: Dave Airlie > > If we are resolving into an srgb dest, we need to convert > to linear so the store does the conversion back. > > This should fix some wierdness seen when we subresolves > hi

[Mesa-dev] [PATCH] util: move ALWAYS_INLINE macro to util/macro.h

2017-05-07 Thread Timothy Arceri
Also added clang check. macro.h is include by p_compiler.h so no other change is needed. --- src/gallium/include/pipe/p_compiler.h | 11 --- src/util/macros.h | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/gallium/include/pipe/p_

Re: [Mesa-dev] [PATCH 7/7] mesa: add KHR_no_error support for glUseProgram

2017-05-07 Thread Timothy Arceri
On 08/05/17 06:29, Nicolai Hähnle wrote: On 04.05.2017 16:28, Nicolai Hähnle wrote: On 04.05.2017 05:34, Timothy Arceri wrote: On 04/05/17 13:31, Dave Airlie wrote: +/* The ARB_separate_shader_object spec says: + * + * "The executable code for an individual shader stage is taken from + *

[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

2017-05-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100960 --- Comment #2 from Fabian Maurer --- Created attachment 131245 --> https://bugs.freedesktop.org/attachment.cgi?id=131245&action=edit screenshot(broken) on linux -- You are receiving this mail because: You are the QA Contact for the bug. You

[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

2017-05-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100960 --- Comment #1 from Fabian Maurer --- Created attachment 131244 --> https://bugs.freedesktop.org/attachment.cgi?id=131244&action=edit screenshot (working) on windows -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

2017-05-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100960 Bug ID: 100960 Summary: Special block from Minecraft mod rendered out of place Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 7/7] mesa: add KHR_no_error support for glUseProgram

2017-05-07 Thread Nicolai Hähnle
On 04.05.2017 16:28, Nicolai Hähnle wrote: On 04.05.2017 05:34, Timothy Arceri wrote: On 04/05/17 13:31, Dave Airlie wrote: +/* The ARB_separate_shader_object spec says: + * + * "The executable code for an individual shader stage is taken from + * the current program for that stage.

[Mesa-dev] [AppVeyor] mesa master #4285 completed

2017-05-07 Thread AppVeyor
Build mesa 4285 completed Commit dab6a2dfd9 by Jose Fonseca on 5/7/2017 4:58 PM: nir: Fix missing snprintf symbol on Windows.\n\nCopy nir_print.c's snprintf definition for now, to unbreak Windows\nbuilds.\n\nWe can and should cleanup all snprintf definitions in

Re: [Mesa-dev] [PATCH 02/13] mesa/dri: always link against shared glapi

2017-05-07 Thread Aaron Watry
I ran into the same thing... Do you by chance have '--with-dri-driverdir=' in your configure command? I had '--prefix=/usr/local' and '--with-dri-driverdir=/usr/local/dri', and removing the --with-dri-driverdir fixed my build. --Aaron On Sat, May 6, 2017 at 7:48 PM, Grazvydas Ignotas wrote: >

[Mesa-dev] [AppVeyor] mesa master #4283 failed

2017-05-07 Thread AppVeyor
Build mesa 4283 failed Commit c297e68828 by Dave Airlie on 4/28/2017 6:17 AM: radv: set PERF_MOD in sample state like radeonsi.\n\nThis just aligns the code with radeonsi.\n\nReviewed-by: Bas Nieuwenhuizen \nSigned-off-by: Dave Airlie Configure your

Re: [Mesa-dev] [PATCH] radv: apply the tess+GS hang workaround to Polaris12 as well

2017-05-07 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sun, May 7, 2017 at 11:54 AM, Dave Airlie wrote: > From: Dave Airlie > > As I pointed out for radeonsi, and AMD confirmed, so fix this > in radv as well. > > Cc: "17.1" > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/si_cmd_buffer.c | 3 ++- > 1 file cha

[Mesa-dev] [PATCH] radv: apply the tess+GS hang workaround to Polaris12 as well

2017-05-07 Thread Dave Airlie
From: Dave Airlie As I pointed out for radeonsi, and AMD confirmed, so fix this in radv as well. Cc: "17.1" Signed-off-by: Dave Airlie --- src/amd/vulkan/si_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cm