Re: [Mesa-dev] Mesa (master): Revert "configure.ac: Use PKG_CHECK_VAR for libclc."

2017-03-07 Thread Michel Dänzer
On 08/03/17 02:24 PM, Matt Turner wrote: > Module: Mesa > Branch: master > Commit: 0b361f9d35e4c079b7314c615e0dd5f7ed196758 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=0b361f9d35e4c079b7314c615e0dd5f7ed196758 > > Author: Matt Turner > Date: Tue Mar 7 21:23:57 2017 -0800 > >

[Mesa-dev] [Bug 100063] vsync setting of OpenGL programs is ignored

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100063 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] android: fix segfault within swap_buffers

2017-03-07 Thread Tapani Pälli
On 03/07/2017 07:33 PM, Emil Velikov wrote: On 6 March 2017 at 12:27, Tapani Pälli wrote: Function droid_swap_buffers may get called without dri2_surf->buffer set, in these cases we don't have a back buffer set either. Patch fixes segfault seen with 3DMark that uses android.opengl.GLSurfaceView

Re: [Mesa-dev] [PATCH] anv: change BLOCK_POOL_MEMFD_SIZE to exactly 2GB

2017-03-07 Thread Tapani Pälli
On 03/07/2017 07:16 PM, Emil Velikov wrote: On 7 March 2017 at 15:53, Eero Tamminen wrote: Hi, On 07.03.2017 17:08, Jason Ekstrand wrote: Interesting... This must only affect android for some weird reason because 32-bit builds have been working on regular Linux for some time now. There are

[Mesa-dev] [PATCH 5/5] [v2] gbm: Export a per plane getter for offset

2017-03-07 Thread Ben Widawsky
Unlike stride, there was no previous offset getter, so it can be right on the first try. v2: Return EINVAL when plane is greater than total planes to make it match the similar APIs. Avoid leak after fromPlanar (Daniel) Make sure when getting offsets we consider dumb images (Daniel) v3: Use Jason'

[Mesa-dev] [PATCH 4/5] gbm: Export a per plane getter for stride

2017-03-07 Thread Ben Widawsky
v2: Preserve legacy behavior when plane is 0 (Jason Ekstrand) EINVAL when input plane is greater than total planes (Jason Ekstrand) Don't leak the image after fromPlanar (Daniel) Move bo->image check below plane count preventing bad index succeeding (Daniel) v3: Fix DRIimage leak (using Jason's re

[Mesa-dev] [PATCH 2/5] [v2] gbm: Export a getter for per plane handles

2017-03-07 Thread Ben Widawsky
v2: Make the error return be -1 instead of 0 because I think 0 is actually valid. v3: Set errno to EINVAL when the specified plane is above the total planes. (Jason Ekstrand) Return the bo's handle if there is no image ie. for dumb images like cursor (Daniel) v4: - Add assertions about plane ==

[Mesa-dev] [PATCH 3/4] gallium/util: make use of new u_thread.h in u_queue.{c, h}

2017-03-07 Thread Timothy Arceri
--- src/gallium/auxiliary/util/u_queue.c | 6 +++--- src/gallium/auxiliary/util/u_queue.h | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_queue.c b/src/gallium/auxiliary/util/u_queue.c index e0ec290..0519667 100644 --- a/src/gallium/auxiliary/

[Mesa-dev] [PATCH 1/4] gallium/util: use standard malloc/calloc/free in u_queue.c

2017-03-07 Thread Timothy Arceri
This will help us moving the file to the shared src/util dir. --- src/gallium/auxiliary/util/u_queue.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/util/u_queue.c b/src/gallium/auxiliary/util/u_queue.c index 05ffc3e..e0ec290 1006

[Mesa-dev] [PATCH 2/4] util: add u_thread.h

2017-03-07 Thread Timothy Arceri
This is a minimal copy of os_thread.h from gallium in order to move u_queue.{c,h} to this directory. --- src/util/Makefile.sources | 1 + src/util/u_thread.h | 89 +++ 2 files changed, 90 insertions(+) create mode 100644 src/util/u_thread.h diff

[Mesa-dev] [PATCH 4/4] gallium/util: move u_queue.{c, h} to src/util

2017-03-07 Thread Timothy Arceri
This will allow us to use it outside of gallium for things like compressing shader cache entries. --- src/gallium/auxiliary/Makefile.sources | 2 -- src/util/Makefile.sources | 2 ++ src/{gallium/auxiliary => }/util/u_queue.c | 0 src/{gallium/auxiliary => }/util/u_queue.h | 0

Re: [Mesa-dev] [PATCH 9/9] anv: Implement support for exporting semaphores as FENCE_FD

2017-03-07 Thread Jason Ekstrand
On Tue, Mar 7, 2017 at 7:52 PM, Dave Airlie wrote: > > +#ifndef SYNC_IOC_MAGIC > > +/* duplicated from linux/sync_file.h to avoid build-time depnedency > > + * on new (v4.7) kernel headers. Once distro's are mostly using > > + * something newer than v4.7 drop this and #include > > + * instead.

Re: [Mesa-dev] [PATCH 9/9] anv: Implement support for exporting semaphores as FENCE_FD

2017-03-07 Thread Dave Airlie
> +#ifndef SYNC_IOC_MAGIC > +/* duplicated from linux/sync_file.h to avoid build-time depnedency > + * on new (v4.7) kernel headers. Once distro's are mostly using > + * something newer than v4.7 drop this and #include > + * instead. > + */ > +struct sync_merge_data { > + char name[32]; > +

[Mesa-dev] [PATCH 2/4] gallium/util: remove unused util_strbuf*

2017-03-07 Thread Timothy Arceri
Looks like they have been unused since 2008 b8a7eef242f6bb97d90f. --- src/gallium/auxiliary/util/u_string.h | 37 --- 1 file changed, 37 deletions(-) diff --git a/src/gallium/auxiliary/util/u_string.h b/src/gallium/auxiliary/util/u_string.h index 9765aaa..42c834f

[Mesa-dev] [PATCH 3/4] gallium/util: remove unused header from u_string.h

2017-03-07 Thread Timothy Arceri
--- src/gallium/auxiliary/util/u_string.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_string.h b/src/gallium/auxiliary/util/u_string.h index 42c834f..e88e13f 100644 --- a/src/gallium/auxiliary/util/u_string.h +++ b/src/gallium/auxiliary/util/u_string.h @@ -34,2

[Mesa-dev] [PATCH 4/4] gallium/util: move u_string.h to src/util/u_string.h

2017-03-07 Thread Timothy Arceri
This will help use move u_queue.c here eventually and also provide string function wrappers for anyone wishing to port disk_cache.c to windows. --- src/gallium/auxiliary/Makefile.sources | 1 - src/gallium/auxiliary/util/u_debug_symbol.c | 2 +- src/gallium/auxiliary/util/u_queue.c| 2

[Mesa-dev] [PATCH 1/4] gallium/util: remove unused util_memmove()

2017-03-07 Thread Timothy Arceri
This is not used anywhere and Visual Studio looks to have supported memmove() for a long time if not always. --- src/gallium/auxiliary/util/u_string.h | 20 1 file changed, 20 deletions(-) diff --git a/src/gallium/auxiliary/util/u_string.h b/src/gallium/auxiliary/util/u_stri

Re: [Mesa-dev] [PATCH 1/3] glsl_parser_extra: Add utility to copy symbols between symbol tables

2017-03-07 Thread Jordan Justen
On 2017-03-05 11:28:41, Eduardo Lima Mitev wrote: > Some symbols gathered in the symbols table during parsing are needed later > for the compile and link stages, so they are moved along the process. > Currently, only functions and non-temporary variables are copied between > symbol tables. However,

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #11 from Timothy Arceri --- (In reply to oiaohm from comment #9) > Jan Vesely > If the pointer size is the same and the timestamp is the same, the cache > will be reused, not deleted, and the problem does not exist. > > I have a lit

Re: [Mesa-dev] [PATCH] glx: allow 0 for glXSwapIntervalSGI

2017-03-07 Thread Ian Romanick
On 03/07/2017 05:09 PM, Grazvydas Ignotas wrote: > Makes vsync option work in The Talos Principle. NAK. The GLX_SGI_swap_control spec says: glXSwapIntervalSGI returns GLX_BAD_VALUE if parameter is less than or equal to zero. They should use glXSwapIntervalMESA instead. This is one of

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #10 from Ilia Mirkin --- There are lots of words, with lots of mentions of how Debian is awesome, but still no usage scenario. Let me help you. A usage scenario looks like: """ Step 1: run X Step 2: run Y Step 3: run Z Note how whe

Re: [Mesa-dev] [PATCH 4/5] gbm: Export a per plane getter for stride

2017-03-07 Thread Ben Widawsky
On 17-03-07 08:33:32, Jason Ekstrand wrote: On Mon, Mar 6, 2017 at 6:37 PM, Ben Widawsky wrote: v2: Preserve legacy behavior when plane is 0 (Jason Ekstrand) EINVAL when input plane is greater than total planes (Jason Ekstrand) Don't leak the image after fromPlanar (Daniel) Move bo->image chec

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #9 from oia...@gmail.com --- Jan Vesely If the pointer size is the same and the timestamp is the same, the cache will be reused, not deleted, and the problem does not exist. I have a little problem. I have x32 and i386. So pointer

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #8 from Jan Vesely --- (In reply to oiaohm from comment #5) > > Jan Vesely > >wouldn't it be easier if the subdirectories were based on timestamp itself? > > https://reproducible-builds.org/docs/timestamps/ > > Sorry the idea of

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #7 from oia...@gmail.com --- Please outline a particular usage scenario that would suffer from this. I do run some x32 ABI programs so I have syscall.x32=y set in boot-loader under Debian. These are build x32 ABI because they are o

[Mesa-dev] [PATCH] clover: use pipe_resource references

2017-03-07 Thread Jan Vesely
Signed-off-by: Jan Vesely --- Does this patch work as well? src/gallium/state_trackers/clover/core/resource.cpp | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/resource.cpp b/src/gallium/state_trackers/clover/core

[Mesa-dev] [Bug 100063] vsync setting of OpenGL programs is ignored

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100063 --- Comment #8 from Grazvydas Ignotas --- I wanted to do more testing today, but it doesn't seem to reproduce any more on my games, except for The Talos Principle. I can confirm vsync works correctly on Unigine Valley, Left 4 Dead 2, Black Mesa,

[Mesa-dev] [PATCH] glx: allow 0 for glXSwapIntervalSGI

2017-03-07 Thread Grazvydas Ignotas
Makes vsync option work in The Talos Principle. Signed-off-by: Grazvydas Ignotas --- no commit access perhaps this is stable worthy? src/glx/glxcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 53c9f9c..7be4e73 100644 --- a/sr

Re: [Mesa-dev] [PATCH] i965: Delete render ring prelude.

2017-03-07 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-03-07 16:39:47, Kenneth Graunke wrote: > This was a hook I came up when trying to do the initial performance > counter work years ago. Nothing's used it for a long time, and the > upcoming performance counter support doesn't want it either. > > So, goodbye ren

[Mesa-dev] [PATCH] i965: Delete render ring prelude.

2017-03-07 Thread Kenneth Graunke
This was a hook I came up when trying to do the initial performance counter work years ago. Nothing's used it for a long time, and the upcoming performance counter support doesn't want it either. So, goodbye render ring prelude. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/inte

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 Ilia Mirkin changed: What|Removed |Added Severity|critical|minor --- Comment #6 from Ilia Mirkin --

[Mesa-dev] [PATCH] glsl: builtin: always return clones of the builtins

2017-03-07 Thread Lionel Landwerlin
Builtins are created once and allocated using their own private ralloc context. When reparenting IR that includes builtins, we might be steal bits of builtins. This is problematic because these builtins might now be freed when the shader that includes then last is disposed. This might also lead to

Re: [Mesa-dev] [RFC PATCH 10/13] RFC: anv: Drop vkCreateDmaBufImageINTEL()

2017-03-07 Thread Lionel Landwerlin
Would you mind updating anv_entrypoints_gen.py too? Because it didn't have a spec, had to special case the entrypoint generation... Happy to see it replaced by something better! Thanks! On 06/03/17 20:40, Chad Versace wrote: This "extension" function predates Vulkan 1.0 and Vulkan WSI. We cre

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 oia...@gmail.com changed: What|Removed |Added Severity|minor |critical --- Comment #5 from oia...@g

[Mesa-dev] [PATCH] clover: fix Invalid read of size 8

2017-03-07 Thread Vedran Miletić
Piglit's tests/cl/custom/buffer-flags.c test in-0x0-out-0x8 subtest reports Invalid read of size 8 when ran under Valgrind due to pipe resource being destroyed prior to the mapping of the said resource. This patch amends the destructor to clear the mappings first. Signed-off-by: Vedran Miletić --

[Mesa-dev] [PATCH] [v2] gbm: Explicitly disallow a planar dumb BO

2017-03-07 Thread Ben Widawsky
As more GBM functionality support planes is being evaluated, it becomes clear that a dumb bo can never actually be planar. It's questionable whether it was ever feasible to do this, and later functionality will implicitly assume a dumb BO is non-planar. v2: Include stdbool.h Cc: Jason Ekstrand C

Re: [Mesa-dev] [PATCH 2/5] gbm: Export a getter for per plane handles

2017-03-07 Thread Jason Ekstrand
On Tue, Mar 7, 2017 at 2:31 PM, Ben Widawsky wrote: > On 17-03-07 08:28:09, Jason Ekstrand wrote: > >> On Mon, Mar 6, 2017 at 6:37 PM, Ben Widawsky wrote: >> >> v2: Make the error return be -1 instead of 0 because I think 0 is >>> actually valid. >>> >>> v3: Set errno to EINVAL when the specifie

Re: [Mesa-dev] [RFC PATCH 09/13] RFC: anv: Implement VK_MESAX_external_image_dma_buf

2017-03-07 Thread Jason Ekstrand
On Mon, Mar 6, 2017 at 12:40 PM, Chad Versace wrote: > For now, we support dma_buf images for only a single format, > VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D, > single-sample, non-mipmappped, non-array, non-cube. > --- > src/intel/vulkan/anv_device.c | 4

[Mesa-dev] [PATCH] gbm: Explicitly disallow a planar dumb BO

2017-03-07 Thread Ben Widawsky
As more GBM functionality support planes is being evaluated, it becomes clear that a dumb bo can never actually be planar. It's questionable whether it was ever feasible to do this, and later functionality will implicitly assume a dumb BO is non-planar. Cc: Jason Ekstrand Cc: Daniel Stone Cc: Kr

Re: [Mesa-dev] [RFC PATCH 10/13] RFC: anv: Drop vkCreateDmaBufImageINTEL()

2017-03-07 Thread Jason Ekstrand
Burn it to the ground! On Mon, Mar 6, 2017 at 12:40 PM, Chad Versace wrote: > This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created > it during the early days of bringing up the Vulkan driver. We used it > for testing the early driver because, in those early days, there was no

Re: [Mesa-dev] [RFC PATCH 08/13] RFC: anv: Implement VK_MESAX_external_memory_dma_buf

2017-03-07 Thread Jason Ekstrand
On Mon, Mar 6, 2017 at 12:40 PM, Chad Versace wrote: > For now, we support dma_bufs only for VkBuffers. The > VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf > VkImages, but we choose to defer that support until > VK_MESAX_external_image_dma_buf. > --- > src/intel/vulkan/anv_

Re: [Mesa-dev] [PATCH 05/13] anv: Set anv_surface::offset earlier

2017-03-07 Thread Jason Ekstrand
On Mon, Mar 6, 2017 at 12:40 PM, Chad Versace wrote: > Set anv_surface::offset *before* calling add_surface(). > > No intended change in behavior. This patch prepares for supporting > user-provided surface offsets, a feature required for > VK_MESAX_external_image_dma_buf. > --- > src/intel/vulka

Re: [Mesa-dev] [RFC PATCH 13/13] RFC: anv: Drop unneeded struct anv_image_create_info

2017-03-07 Thread Jason Ekstrand
Yes please! On Mon, Mar 6, 2017 at 12:40 PM, Chad Versace wrote: > Now that anv_image_create() is gone, there is no need for struct > anv_image_create_info. The struct just adds an unused layer of > indirection. > --- > src/intel/vulkan/anv_image.c | 38 +++--- > --

Re: [Mesa-dev] [PATCH 2/5] gbm: Export a getter for per plane handles

2017-03-07 Thread Ben Widawsky
On 17-03-07 08:28:09, Jason Ekstrand wrote: On Mon, Mar 6, 2017 at 6:37 PM, Ben Widawsky wrote: v2: Make the error return be -1 instead of 0 because I think 0 is actually valid. v3: Set errno to EINVAL when the specified plane is above the total planes. (Jason Ekstrand) Return the bo's handle

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Use PKG_CHECK_VAR for libclc.

2017-03-07 Thread Matt Turner
On Tue, Mar 7, 2017 at 1:08 PM, Brian Paul wrote: > How do you feel about reverting this patch and the wayland-scanner one? I am fine with that -- they were just trivial clean ups. I'll be happy to do it later today unless you'd like to do it first. ___

Re: [Mesa-dev] [Request for Comments] - Port documentation to Markdown

2017-03-07 Thread Matt Turner
On Mon, Mar 6, 2017 at 10:36 AM, Jean Hertel wrote: > A live preview can be found here: http://mesa.jeanhertel.com.br/ A common pet peeve among Mesa developers is writing "MESA". It looks like it's just a small-caps font doing it, but let's please not do that an add to the confusion. :) _

Re: [Mesa-dev] [Request for Comments] - Port documentation to Markdown

2017-03-07 Thread Jason Ekstrand
Hey Jean, On Tue, Mar 7, 2017 at 4:02 AM, Jean Hertel wrote: > Eric, > > >>On Monday, 2017-03-06 18:36:32 +, Jean Hertel wrote: > >> Hello guys, > >> > >> > >> I want to propose a port of the current HTML documentation to a > markdown-like syntax. > >> > > > >I was thinking of doing essentia

Re: [Mesa-dev] [PATCH v3 17/24] i965/vec4: consider subregister offset in live variables

2017-03-07 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On 07/03/17 14:10, Samuel Iglesias Gonsálvez wrote: >> >> >> On 04/03/17 01:13, Francisco Jerez wrote: >>> Samuel Iglesias Gonsálvez writes: >>> From: "Juan A. Suarez Romero" Take into account offset values less than a full register (32 bytes

Re: [Mesa-dev] [PATCH v3 21/24] i965: Use correct VertStride on align16 instructions.

2017-03-07 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On 04/03/17 01:44, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> From: Matt Turner >>> >>> In commit c35fa7a, we changed the "width" of DF source registers to 2, >>> which is conceptually fine. Unfortunately a VertStride of 2 is not >>>

Re: [Mesa-dev] [PATCH v3 20/24] i965/vec4: Fix exec size for MOVs SET_{HIGH, LOW}_32BIT.

2017-03-07 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On 04/03/17 01:26, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> From: Matt Turner >>> >>> Otherwise for a pack_double_2x32_split opcode, we emit: >>> >>>vec1 64 ssa_135 = pack_double_2x32_split ssa_133, ssa_134 >>> mov(8) g

Re: [Mesa-dev] [PATCH] spirv: Silence unused variable warnings in release mode

2017-03-07 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-03-07 12:55:01, Jason Ekstrand wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spirv/spirv_to_nir.c > index 1dd6651..8a02904 100644 > --- a/src/compil

Re: [Mesa-dev] [PATCH v3 16/24] i965/vec4: fix SIMD-width lowering for VEC4_OPCODE_FROM_DOUBLE in IVB/BYT

2017-03-07 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On 04/03/17 01:04, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> From: "Juan A. Suarez Romero" >>> >>> When splitting VEC4_OPCODE_FROM_DOUBLE in Ivybridge/Baytrail, the second >>> part should use a temporal register, and then move the va

Re: [Mesa-dev] [PATCH 16/16] anv/cmd_buffer: handle out of device memory during binding table emission

2017-03-07 Thread Jason Ekstrand
On Mon, Mar 6, 2017 at 11:16 PM, Iago Toral Quiroga wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > index 8b752c4..23d7493 100644 > --- a/

Re: [Mesa-dev] [PATCH 15/16] anv/cmd_buffer: skip vkCmdExecuteCommands() on broken command buffers

2017-03-07 Thread Jason Ekstrand
On Mon, Mar 6, 2017 at 11:16 PM, Iago Toral Quiroga wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > index 2c9aec8..8b752c4 100644 > --- a/src/intel/vulkan/

Re: [Mesa-dev] [PATCH 12/16] anv: ensure that we don't ever try to adjust relocations more than once

2017-03-07 Thread Jason Ekstrand
On Mon, Mar 6, 2017 at 11:15 PM, Iago Toral Quiroga wrote: > There is a CTS tests that creates that situation by forcing OOM during a > queue > submision and then trying again without the OOM enforcement. The driver > returns > the appropriate out of memory error on the first try, but the relocat

[Mesa-dev] [RESEND v4 11/16] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

2017-03-07 Thread Dylan Baker
hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/a

[Mesa-dev] [RESEND v4 06/16] anv: Update "do not edit" comments with proper filename

2017-03-07 Thread Dylan Baker
This does two things, first it updates both the .h and the .c file to have the same do not edit string. Second, it uses __file__ to ensure that even if the file is moved or renamed that the name will be correct. One thing to note is the use of '{{' and '}}' in the C template. This is to instruct p

[Mesa-dev] [RESEND v4 03/16] anv: make constants capitals in anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 +- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 872b

[Mesa-dev] [RESEND v4 14/16] anv: don't use Element.get in anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
This has the potential to mask errors, since Element.get works like dict.get, returning None if the element isn't found. I think the reason that Element.get was used is that vulkan has one extension that isn't really an extension, and thus is missing the 'protect' field. This patch changes the beh

[Mesa-dev] [RESEND v4 15/16] anv: use cElementTree in anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_

[Mesa-dev] [RESEND v4 10/16] anv: Generate anv_entrypoints header and code in one command

2017-03-07 Thread Dylan Baker
This produces the header and the code in one command, saving the need to call the same script twice, which parses the same XML file. Signed-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 5 - src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entryp

[Mesa-dev] [RESEND v4 09/16] anv: anv_entrypoints_gen.py: directly write files instead of piping

2017-03-07 Thread Dylan Baker
This changes the output to be written as a file rather than being piped. This had one critical advantage, it encapsulates the encoding. This prevents bugs where a symbol (generally unicode like ?? [copyright]) is printed and the system being built on doesn't have a unicode locale. v2: - Update And

[Mesa-dev] [RESEND v4 08/16] anv: convert C generation to template in anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints

[Mesa-dev] [RESEND v4 13/16] anv: use dict.get in anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vu

[Mesa-dev] [RESEND v4 05/16] anv: split main into two functions in anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 108 - 1 file changed, 56 insertions(+),

[Mesa-dev] [RESEND v4 01/16] anv: anv_entrypoints_gen.py: use a main function

2017-03-07 Thread Dylan Baker
This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 - 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 4e5d2ee..

[Mesa-dev] [RESEND v4 07/16] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-03-07 Thread Dylan Baker
This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 77 ++ 1 file changed, 42 insertions(+), 35 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoin

[Mesa-dev] [RESEND v4 02/16] anv: Use python style in anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions - don

[Mesa-dev] [RESEND v4 00/16] cleanup anv_entrpoints_gen.py

2017-03-07 Thread Dylan Baker
There are a number of small style cleanups and simplifications in this series, but the main changes are: - use a mako template to generate the header and code rather than prints - be python 3.x ready (the goal isn't to write python 3 code, but to write code that is easy to port or hybridize)

[Mesa-dev] [RESEND v4 04/16] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
It's slow, and has the potential for encoding issues. v2: - pass xml file location via argument - update Android.mk Signed-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 4 ++-- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [RESEND v4 12/16] anv: anv_entrypoints_gen.py: use reduce function.

2017-03-07 Thread Dylan Baker
Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index a63badb..6b2d422 100644 --- a/src

[Mesa-dev] [RESEND v4 16/16] anv: Remove dead prototype from entrypoints

2017-03-07 Thread Dylan Baker
Spotted by Emil. v2: - Add this patch Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index a08cfce..203df45 100644 --- a/src/intel/vulkan

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Use PKG_CHECK_VAR for libclc.

2017-03-07 Thread Brian Paul
On 03/07/2017 01:49 PM, Matt Turner wrote: On Tue, Mar 7, 2017 at 12:41 PM, Brian Paul wrote: On 03/06/2017 12:06 PM, Matt Turner wrote: --- configure.ac | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 37f6b60..d44a229 100644 --

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

2017-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99591 --- Comment #4 from Jure Repinc --- I tried with never version that is now available (vulkaninfo 1.0.41) and Mesa 17.0 and still get the crash: jlp@linux-l7tg:~> gdb vulkaninfo GNU gdb (GDB; openSUSE Tumbleweed) 7.11.1 Copyright (C) 2016 Free So

[Mesa-dev] [PATCH] spirv: Silence unused variable warnings in release mode

2017-03-07 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 1dd6651..8a02904 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -1149,6 +1149,7 @@ vtn_h

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Use PKG_CHECK_VAR for libclc.

2017-03-07 Thread Matt Turner
On Tue, Mar 7, 2017 at 12:41 PM, Brian Paul wrote: > On 03/06/2017 12:06 PM, Matt Turner wrote: >> >> --- >> configure.ac | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index 37f6b60..d44a229 100644 >> --- a/configure.ac >> +++ b

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Use PKG_CHECK_VAR for libclc.

2017-03-07 Thread Brian Paul
On 03/06/2017 12:06 PM, Matt Turner wrote: --- configure.ac | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 37f6b60..d44a229 100644 --- a/configure.ac +++ b/configure.ac @@ -2018,10 +2018,8 @@ if test "x$enable_opencl" = xyes; then

Re: [Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-03-07 Thread Ian Romanick
Since this will affect generated code that is tracked in GIT, a second patch should regenerate all those files. Otherwise the next patch that causes those files to be regenerated will include a bunch of spurious changes. This is one of the (very strong) arguments against this sort of architecture

Re: [Mesa-dev] [PATCH] radv: disabled scaled formats for transfers.

2017-03-07 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Mar 7, 2017 at 8:01 AM, Dave Airlie wrote: > From: Dave Airlie > > These really are only supported for vertex buffers. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_formats.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 dele

Re: [Mesa-dev] [PATCH 3/6] configure.ac: Use PKG_CHECK_VAR for wayland-scanner.

2017-03-07 Thread Frank Binns
On 07/03/17 19:22, Frank Binns wrote: On 07/03/17 17:57, Emil Velikov wrote: On 7 March 2017 at 17:29, Frank Binns wrote: Hi, On 06/03/17 19:06, Matt Turner wrote: Available since pkg-config-0.28 and pkgconf-0.8.10. The removal of the AC_PATH_PROG is intentional. Use pkg-config. It doesn'

Re: [Mesa-dev] [PATCH 0/3] radv: fix descriptor set bugs with dynamic buffers

2017-03-07 Thread Bas Nieuwenhuizen
Thanks, pushed. On Tue, Mar 7, 2017 at 1:53 AM, Fredrik Höglund wrote: > This series fixes some bugs related to multiple descriptor sets with > dynamic buffers. > > I've run the dEQP-VK.*descriptor* tests with these changes, and there > are no new passes and no new failures. > > This series is al

Re: [Mesa-dev] [PATCH 3/6] configure.ac: Use PKG_CHECK_VAR for wayland-scanner.

2017-03-07 Thread Frank Binns
On 07/03/17 17:57, Emil Velikov wrote: On 7 March 2017 at 17:29, Frank Binns wrote: Hi, On 06/03/17 19:06, Matt Turner wrote: Available since pkg-config-0.28 and pkgconf-0.8.10. The removal of the AC_PATH_PROG is intentional. Use pkg-config. It doesn't seem possible to cross-compile Mesa o

[Mesa-dev] [PATCH v4 02/16] anv: Use python style in anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions - don

[Mesa-dev] [PATCH v4 04/16] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

2017-03-07 Thread Dylan Baker
It's slow, and has the potential for encoding issues. v2: - pass xml file location via argument - update Android.mk Signed-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 4 ++-- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v4 01/16] anv: anv_entrypoints_gen.py: use a main function

2017-03-07 Thread Dylan Baker
This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 - 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 4e5d2ee..

[Mesa-dev] [PATCH v4 00/16] cleanup anv_entrpoints_gen.py

2017-03-07 Thread Dylan Baker
There are a number of small style cleanups and simplifications in this series, but the main changes are: - use a mako template to generate the header and code rather than prints - be python 3.x ready (the goal isn't to write python 3 code, but to write code that is easy to port or hybridize)

Re: [Mesa-dev] [PATCH 1/6] anv: Add a performance warning helper

2017-03-07 Thread Lionel Landwerlin
This series is : Reviewed-by: Lionel Landwerlin On 07/03/17 17:36, Jason Ekstrand wrote: This acts identically to anv_finishme except that it only dumps out these nice log messages if you run with INTEL_DEBUG=perf. --- src/intel/vulkan/anv_private.h | 14 ++ src/intel/vulkan/anv

Re: [Mesa-dev] [PATCH 2/5] gallium: add TGSI opcodes TEX_LZ and TXF_LZ

2017-03-07 Thread Brian Paul
On 03/07/2017 10:56 AM, Marek Olšák wrote: I'm adding this diff into the commit: Looks great. Thanks. I don't think I'll have time to fully review the series today though. -Brian diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index b77271a..18b42fb 10064

Re: [Mesa-dev] [PATCH 3/6] configure.ac: Use PKG_CHECK_VAR for wayland-scanner.

2017-03-07 Thread Emil Velikov
On 7 March 2017 at 17:29, Frank Binns wrote: > Hi, > > On 06/03/17 19:06, Matt Turner wrote: >> >> Available since pkg-config-0.28 and pkgconf-0.8.10. >> >> The removal of the AC_PATH_PROG is intentional. Use pkg-config. > > > It doesn't seem possible to cross-compile Mesa out of the box due > to

Re: [Mesa-dev] [PATCH 2/5] gallium: add TGSI opcodes TEX_LZ and TXF_LZ

2017-03-07 Thread Marek Olšák
I'm adding this diff into the commit: diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index b77271a..18b42fb 100644 --- a/src/gallium/docs/source/tgsi.rst +++ b/src/gallium/docs/source/tgsi.rst @@ -753,14 +753,18 @@ This instruction replicates its result. .. math:

Re: [Mesa-dev] [PATCH] anv: add support for allocating more than 1 block of memory

2017-03-07 Thread Jason Ekstrand
On Tue, Mar 7, 2017 at 12:22 AM, Juan A. Suarez Romero wrote: > On Mon, 2017-02-27 at 13:48 +0100, Juan A. Suarez Romero wrote: > > Current Anv allocator assign memory in terms of a fixed block size. > > > > But there can be cases where this block is not enough for a memory > > request, and thus

[Mesa-dev] [PATCH 4/6] anv: Get rid of the stub() macros

2017-03-07 Thread Jason Ekstrand
Except for a few unimplemented things on gen7, we don't really have stubs anymore so we should drop this. This commit replaces the few gen7 stub() calls with explicitly labeled finishme's and makes the sparse binding stuff silently no-op or return a FEATURE_NOT_PRESENT error. --- src/intel/vulkan

[Mesa-dev] [PATCH 5/6] anv: Drop the anv_validate block helper

2017-03-07 Thread Jason Ekstrand
Over the course of driver development, we've come up with a number of different schemes for adding giant blocks of asserts inside the driver. This one is only being used once in anv_pipeline.c and the way it's being used actually generates compiler warnings in release builds. This commit drops the

[Mesa-dev] [PATCH 1/6] anv: Add a performance warning helper

2017-03-07 Thread Jason Ekstrand
This acts identically to anv_finishme except that it only dumps out these nice log messages if you run with INTEL_DEBUG=perf. --- src/intel/vulkan/anv_private.h | 14 ++ src/intel/vulkan/anv_util.c| 13 + 2 files changed, 27 insertions(+) diff --git a/src/intel/vulkan/

[Mesa-dev] [PATCH 3/6] anv: Remove a pointless finishme

2017-03-07 Thread Jason Ekstrand
We've been supporting multiple shaders per module for some time now. --- src/intel/vulkan/anv_pipeline.c | 4 1 file changed, 4 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 64e409b..0db9f68 100644 --- a/src/intel/vulkan/anv_pipeline.c +++

[Mesa-dev] [PATCH 6/6] anv: Make the framebuffer-renderpass format assert non-fatal

2017-03-07 Thread Jason Ekstrand
This should let Dota 2 run on debug builds though it will spew errors like mad. Hopefully, Valve will get this fixed sooner rather than later. --- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel

[Mesa-dev] [PATCH 2/6] anv: Convert the HiZ finishme's to perf_warn

2017-03-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_image.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 59f730c..b28d135 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image.c @@ -191,13 +191,13 @@ make_su

Re: [Mesa-dev] [PATCH] android: fix segfault within swap_buffers

2017-03-07 Thread Emil Velikov
On 6 March 2017 at 12:27, Tapani Pälli wrote: > Function droid_swap_buffers may get called without dri2_surf->buffer set, > in these cases we don't have a back buffer set either. Patch fixes segfault > seen with 3DMark that uses android.opengl.GLSurfaceView for rendering it's UI. > > backtrace: >

Re: [Mesa-dev] [PATCH 08/16] anv/cmd_buffer: track error scenarios during command buffer recording

2017-03-07 Thread Jason Ekstrand
On Mon, Mar 6, 2017 at 11:15 PM, Iago Toral Quiroga wrote: > The vkCmd*() functions do not report errors, instead, any errors should be > reported by the time we call vkEndCommandBuffer(). This means that we > need to track things such as "out of host memory" and use that information > to avoid e

Re: [Mesa-dev] [PATCH 3/6] configure.ac: Use PKG_CHECK_VAR for wayland-scanner.

2017-03-07 Thread Frank Binns
Hi, On 06/03/17 19:06, Matt Turner wrote: Available since pkg-config-0.28 and pkgconf-0.8.10. The removal of the AC_PATH_PROG is intentional. Use pkg-config. It doesn't seem possible to cross-compile Mesa out of the box due to it using the 'host' scanner (found via pkgconfig) instead of the '

  1   2   >