[Mesa-dev] [Bug 99319] godot engine poor performance

https://bugs.freedesktop.org/show_bug.cgi?id=99319 Bronson changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) -- You are receiving this mail

[Mesa-dev] [Bug 99319] godot engine poor performance

https://bugs.freedesktop.org/show_bug.cgi?id=99319 Bug ID: 99319 Summary: godot engine poor performance Product: Mesa Version: 13.0 Hardware: Other OS: Linux (All) Status: NEW Severity: normal Pr

Re: [Mesa-dev] [PATCH 1/2] mesa: Bump the version to 17.0

Both look good to me. Thanks for doing that. Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] mesa: Bump the version to 17.0

I believe this is what we agreed on. I just got annoyed because my Fedora packaged mesa still says mesa 13.1. On Sat, Jan 7, 2017 at 8:31 PM, Jason Ekstrand wrote: > --- > VERSION| 2 +- > docs/relnotes/{13.1.0.html => 17.0.0.html} | 8 > 2 files ch

[Mesa-dev] [PATCH 2/2] relnotes: Claim OpenGL 4.5 rather than 4.4

--- docs/relnotes/17.0.0.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/relnotes/17.0.0.html b/docs/relnotes/17.0.0.html index 5e5b683..be91ded 100644 --- a/docs/relnotes/17.0.0.html +++ b/docs/relnotes/17.0.0.html @@ -22,11 +22,11 @@ People who are concerned w

[Mesa-dev] [PATCH 1/2] mesa: Bump the version to 17.0

--- VERSION| 2 +- docs/relnotes/{13.1.0.html => 17.0.0.html} | 8 2 files changed, 5 insertions(+), 5 deletions(-) rename docs/relnotes/{13.1.0.html => 17.0.0.html} (89%) diff --git a/VERSION b/VERSION index a2a3311..19547f8 100644 --- a/VERSION +++

Re: [Mesa-dev] [PATCH 08/12] glcpp: Use strpbrk in the line continuations pass

Well, running radamsa fuzzer right now and it's able to find quite a bit of various problems (difference in output/error reporting against master) in the hand-written parser without any effort. Some cases should be added to the test-suite maybe. Clearly the patch series requires more work, sad

Re: [Mesa-dev] [PATCH 1/8] glsl: Create and use a new ir_variable::count_attribute_slots() wrapper.

On Sat, Jan 7, 2017 at 1:12 PM, Kenneth Graunke wrote: > On Saturday, January 7, 2017 4:22:28 PM PST Marek Olšák wrote: > > Hi, this causes an assertion failure for many tessellation tests on > radeonsi: > > > > state_tracker/st_program.c:1295:st_translate_program_common: Assertion > > `attr >= V

[Mesa-dev] [PATCH V2] nir: add imprecise flrp optimisation

On BDW: total instructions in shared programs: 13061890 -> 13061877 (-0.00%) instructions in affected programs: 2441 -> 2428 (-0.53%) helped: 13 HURT: 0 total cycles in shared programs: 256612254 -> 256611784 (-0.00%) cycles in affected programs: 16418 -> 15948 (-2.86%) helped: 10 HURT: 2 V2: do

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

https://bugs.freedesktop.org/show_bug.cgi?id=94512 Grazvydas Ignotas changed: What|Removed |Added CC||nota...@gmail.com --- Comment #10 fr

[Mesa-dev] [Bug 99311] [regression, bisected, core] Commit 8b5749f65ac434961308ccb579fb8a816e4f29d5 breaks SDDM (white screen on launch)

https://bugs.freedesktop.org/show_bug.cgi?id=99311 Kenneth Graunke changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #15 from Christian --- (In reply to Michel Dänzer from comment #14) > (In reply to Christian from comment #13) > > Same problem, different version: > > mesa-13.0.2 > > llvm: sys-devel/llvm-3.9.1 > > Actually, it looks like it picks

[Mesa-dev] [Bug 99311] [regression, bisected, core] Updating to 1edc53a66b breaks SDDM (white screen on launch)

https://bugs.freedesktop.org/show_bug.cgi?id=99311 Kai changed: What|Removed |Added Component|Drivers/Gallium/radeonsi|Mesa core CC|

[Mesa-dev] [Bug 99311] [regression, bisected, core] Commit 8b5749f65ac434961308ccb579fb8a816e4f29d5 breaks SDDM (white screen on launch)

https://bugs.freedesktop.org/show_bug.cgi?id=99311 Kai changed: What|Removed |Added Summary|[regression,bisected,core] |[regression,bisected,core] |Upda

Re: [Mesa-dev] [PATCH 08/12] glcpp: Use strpbrk in the line continuations pass

Oh. Thanks! This is embarrassing. I have no idea how did I manage to miss it. Line continuations are so rare that only two games in my shader-db use them -- Talos Principle and Serious Sam (both use Serious Engine). And neither of them hit this condition. I probably need to fuzz this thing or s

Re: [Mesa-dev] [PATCH 1/8] glsl: Create and use a new ir_variable::count_attribute_slots() wrapper.

On Saturday, January 7, 2017 4:22:28 PM PST Marek Olšák wrote: > Hi, this causes an assertion failure for many tessellation tests on radeonsi: > > state_tracker/st_program.c:1295:st_translate_program_common: Assertion > `attr >= VARYING_SLOT_VAR0 || (attr >= VARYING_SLOT_TEX0 && attr <= > VARYING_

Re: [Mesa-dev] [PATCH 3/8] glsl: Mark whole variable used for ClipDistance and TessLevel*.

On Saturday, January 7, 2017 4:24:30 PM PST Marek Olšák wrote: > Hi, this causes an assertion failure for some tests in the GLSL > compiler on radeonsi: > > glsl/ir_set_program_inouts.cpp:129: void mark(gl_program*, > ir_variable*, int, int, gl_shader_stage): Assertion `var->data.mode == > ir_var_

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 80419, which changed state. Bug 80419 Summary: XCOM: Enemy Unknown Causes lockup https://bugs.freedesktop.org/show_bug.cgi?id=80419 What|Removed |Added --

Re: [Mesa-dev] [PATCH 07/10] nir: add imprecise flrp optimisation

On Sat, 2017-01-07 at 12:35 -0800, Jason Ekstrand wrote: > On Jan 7, 2017 12:07 PM, "Timothy Arceri" om> wrote: > On Sat, 2017-01-07 at 11:14 -0800, Matt Turner wrote: > > On Sat, Jan 7, 2017 at 3:58 AM, Timothy Arceri > > wrote: > > > On BDW: > > > > > > total instructions in shared programs: 13

Re: [Mesa-dev] [PATCH 07/10] nir: add imprecise flrp optimisation

On Jan 7, 2017 12:07 PM, "Timothy Arceri" wrote: On Sat, 2017-01-07 at 11:14 -0800, Matt Turner wrote: > On Sat, Jan 7, 2017 at 3:58 AM, Timothy Arceri > wrote: > > On BDW: > > > > total instructions in shared programs: 13061890 -> 13061877 (- > > 0.00%) > > instructions in affected programs: 24

Re: [Mesa-dev] [PATCH 07/10] nir: add imprecise flrp optimisation

On Sat, 2017-01-07 at 11:14 -0800, Matt Turner wrote: > On Sat, Jan 7, 2017 at 3:58 AM, Timothy Arceri > wrote: > > On BDW: > > > > total instructions in shared programs: 13061890 -> 13061877 (- > > 0.00%) > > instructions in affected programs: 2441 -> 2428 (-0.53%) > > helped: 13 > > HURT: 0 > >

Re: [Mesa-dev] [PATCH 08/12] glcpp: Use strpbrk in the line continuations pass

7 sty 2017 20:04 "Vladislav Egorov" napisał(a): To find newlines the line continuations removal pass uses strchr() twice -- first time to find '\n', second time to find '\r'. Now, if the shader uses Unix line separators '\n', the file could contain no '\r' at all, so each time it will scan to the

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

On 2017-01-07 15:46, Marek Olšák wrote: > > -The filters can be toggled per-app via driconf, or per-session via the > -corresponding environment variables. > +The filters can be via the corresponding environment variables. > I think you have missed a word here. Jacek ___

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

Here are screenshots of how far I got with that driconf replacement https://drive.google.com/open?id=0B5-qhFoZtgKPZmR2LVg0X3pOZnM It was more than two years ago, hadn't had time to work on it since. Screenshot 1, 2 and 3: There is a list of apps with settings in system drirc or user drirc. Opti

Re: [Mesa-dev] [PATCH 07/10] nir: add imprecise flrp optimisation

On Sat, Jan 7, 2017 at 3:58 AM, Timothy Arceri wrote: > On BDW: > > total instructions in shared programs: 13061890 -> 13061877 (-0.00%) > instructions in affected programs: 2441 -> 2428 (-0.53%) > helped: 13 > HURT: 0 > > total cycles in shared programs: 256612254 -> 256611784 (-0.00%) > cycles i

Re: [Mesa-dev] [PATCH 10/10] nir: add late opt to turn inot/b2f combos back to bcsel

On Sat, Jan 7, 2017 at 3:58 AM, Timothy Arceri wrote: > We turn these from bcsel into inot/b2f combos in order for other > optimisation passes to get further, once we have finished turn > the ones that remain and are used in more than a single expression > back into a bcsel. Run-on sentence. > >

[Mesa-dev] [PATCH 06/12] ralloc: Use strnlen() inside of strncat()

If the str is long or isn't null-terminated, strlen() could take a lot of time or even crash. I don't know why was it used in the first place, maybe for platforms without strnlen(), but strnlen() is already used inside of ralloc_strndup(), so this change should not additionally break anything. ---

[Mesa-dev] [PATCH 11/12] glcpp: Create fast path hand-written scanner

At this point up to ~80% of preprocessing time is spent in generated parser/lexer functions, so it's not possible to improve speed further without making changes to lexer and parser. In most of the cases all complex machinery of tokenizing, parsing and printing is completely unnecessary. On most of

[Mesa-dev] [PATCH 10/12] glcpp/tests: Allow different trailing whitespace

There is no point really to enforce exact amount of trailing whitespace in preprocessor output. Other preprocessors generate even less trailing whitespace than glcpp. The less trailing whitespace, the better. --- src/compiler/glsl/glcpp/tests/glcpp-test | 4 ++-- 1 file changed, 2 insertions(+), 2

[Mesa-dev] [PATCH 04/12] glcpp: Use string_buffer for continuations removal

Migrate removal of line continuations to string_buffer. Before this it used ralloc_strncat() to append strings, which internally each time calculates strlen() of its argument. Its argument is entire shader, so it multiple time scans the whole shader text. --- src/compiler/glsl/glcpp/glcpp.h | 11 +

[Mesa-dev] [PATCH 12/12] glcpp: Substitute trivial macros in the fast path

The vast majority of macros are trivial, simple numbers or identifiers. Substitute them in the fast path, no need to bailout for them to the slow path. --- src/compiler/glsl/glcpp/glcpp-lex.l | 77 +++-- 1 file changed, 74 insertions(+), 3 deletions(-) diff --git a

[Mesa-dev] [PATCH 09/12] glcpp: Avoid unnecessary linear_strdup

The lexer copies every identifier it finds. At first look it seems needless, because all these identifiers are already available stored inside of shader text, but my experiments with immutable explicitly sized strings (ptr, len) resulted in a lot of code change and didn't result in any speed increa

Re: [Mesa-dev] [PATCH 01/10] nir: Convert ineg(b2i(a)) to a if it's a boolean.

On Sat, Jan 7, 2017 at 3:58 AM, Timothy Arceri wrote: > From: Kenneth Graunke > > On BDW: > > total instructions in shared programs: 13071119 -> 13070371 (-0.01%) > instructions in affected programs: 83424 -> 82676 (-0.90%) > helped: 505 > HURT: 45 (all TCS, all hurt by a single instruction) I i

[Mesa-dev] [PATCH 03/12] glcpp: Use Bloom filter before identifier search

Absolute majority of identifiers in shaders are not macro references. Many shaders don't use preprocessing macros at all. Almost all queries to parser->defines hash-table will be unsuccessful. Note that all predefined macros start either with "GL_" or with "__". Moreover, even user-defined macros a

[Mesa-dev] [PATCH 02/12] glcpp: Avoid unnecessary strcmp()

strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" only if the identifier starts with '_', which is rare. --- src/compiler/glsl/glcpp/glcpp-parse.y | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y b/src/compi

[Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

glcpp's printing is an obvious low hanging fruit: 1. It unnecessarily uses formatted printing to print output of preprocessing. To print just one character '+' it first uses vsnprintf("%s", "+") to calculate number of characters in the formatted string (while it's known statically), then

[Mesa-dev] [PATCH 05/12] ralloc: Avoid calling vsnprintf() twice

Typical perf output of ralloc's printf-like functions looks like that: 0,14% ralloc_vasprintf_rewrite_tail 0,06% printf_length 0,05% __vsnprintf_chk 0,02% resize 0,01% __vsnprintf_chk@plt They spend most of the time inside of libc's formatted i/o functions they call twice -

[Mesa-dev] [PATCH 08/12] glcpp: Use strpbrk in the line continuations pass

To find newlines the line continuations removal pass uses strchr() twice -- first time to find '\n', second time to find '\r'. Now, if the shader uses Unix line separators '\n', the file could contain no '\r' at all, so each time it will scan to the end of the shader. Use strpbrk() standard functio

[Mesa-dev] [PATCH 07/12] glcpp: Skip unnecessary line continuations removal

Overwhelming majority of shaders don't use line continuations. In my shader-db only shaders from the Talos Principle and Serious Sam used them, less than 1% out of all shaders. Optimize for this case, don't do any copying if no line continuation was found. --- src/compiler/glsl/glcpp/pp.c | 10 +++

[Mesa-dev] [PATCH 00/12] Improve GLSL preprocessor performance

There is a lot of room for improvement in the preprocessor. Quick benchmark on artificial 4Mb "shader" (16x concatenated Blender PBR shader) of several popular C-like preprocessors (I wanted to also add D's Warp, but didn't manage to compile it): time mem page faults clang

Re: [Mesa-dev] [PATCH] drirc: Allow extension midshader for Divinity: Original Sin (EE)

that game still depends on ARB_shading_language_include and it checks for that extension by checking if the function pointers are there. One hacky solution is this: diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 63f4921..e1ab885 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -

Re: [Mesa-dev] [PATCH] mesa: set GLSL 1.20 for the fixed-function fragment shader

On Sat, Jan 7, 2017 at 5:23 PM, Roland Scheidegger wrote: > Am 07.01.2017 um 15:51 schrieb Marek Olšák: >> From: Marek Olšák >> >> This fixes broken depth texturing after: >> >> commit 22639a6e19f95902aef23474ad672bf489231ea7 >> Author: Timothy Arceri >> Date: Mon Nov 21 00:29:29 2016 +1100 >>

Re: [Mesa-dev] [PATCH v2 0/3] gallium driver for Vivante GPUs

Gentle ping for RB for the whole series. -- Christian Gmeiner, MSc https://www.youtube.com/user/AloryOFFICIAL https://soundcloud.com/christian-gmeiner 2016-12-23 23:04 GMT+01:00 Christian Gmeiner : > As the original patchstack is now about 300 patches, I have choosen to > squash the patches tog

Re: [Mesa-dev] [Bug 50338]radeon: TGSI takes more than two cfiles from r600_shader.

On Sat, Jan 7, 2017 at 10:30 AM, Jaime García Villena wrote: > I can't find the place where TGSI src registers are assigned into r600 GPR > or CFILE registers. I'm planning to make an exception for these kind of > chips, and prevent the 3rd CFILE assignation, somehow. > > Where does r600 shader op

Re: [Mesa-dev] [PATCH] drirc: Allow extension midshader for Divinity: Original Sin (EE)

Hey Marek, Marek Olšák wrote on 07.01.2017 15:48: > Pushed. thanks a lot! > Can you close the bugs if it's fixed? It is not, as you can read in a more concise form (all the info is also in the bug report) at the midshader

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

Hey Marek, thanks for the changes to the documentation! You can have my Reviewed-by: Kai Wasserbäch Cheers, Kai Marek Olšák wrote on 07.01.2017 15:46: > From: Marek Olšák > > ~/.drirc is created by the driconf tool (GPL license) and it overrides > system drirc settings and can't be changed

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

Hey Axel, Axel Davy wrote on 07.01.2017 14:28: > Expecting the user to use env vars it ok for power users, but not very > user-friendly for newbies, or just people who don't like using the command > line. > And that's exactly these users who are likely to use something like driconf. I would guess

Re: [Mesa-dev] [PATCH] mesa: set GLSL 1.20 for the fixed-function fragment shader

Am 07.01.2017 um 15:51 schrieb Marek Olšák: > From: Marek Olšák > > This fixes broken depth texturing after: > > commit 22639a6e19f95902aef23474ad672bf489231ea7 > Author: Timothy Arceri > Date: Mon Nov 21 00:29:29 2016 +1100 > > st/mesa: get Version from gl_program rather than gl_shader_

Re: [Mesa-dev] [PATCH 6/6] i965: Move TES input VUE map calculation out a layer.

Series is Reviewed-by: Jason Ekstrand On Jan 7, 2017 3:04 AM, "Timothy Arceri" wrote: > On Sat, 2017-01-07 at 02:56 -0800, Kenneth Graunke wrote: > > On Saturday, January 7, 2017 8:51:06 PM PST Timothy Arceri wrote: > > > On Sat, 2017-01-07 at 00:02 -0800, Kenneth Graunke wrote: > > > > In Vul

Re: [Mesa-dev] [PATCH 08/10] nir: add another comparison simplification

Rb On Jan 7, 2017 4:00 AM, "Timothy Arceri" wrote: > On BDW: > > total instructions in shared programs: 13061877 -> 13060965 (-0.01%) > instructions in affected programs: 133569 -> 132657 (-0.68%) > helped: 566 > HURT: 0 > > total cycles in shared programs: 256611784 -> 256599536 (-0.00%) > cycl

Re: [Mesa-dev] [PATCH 06/10] i965: Use the nir_move_comparisons pass.

On Jan 7, 2017 3:59 AM, "Timothy Arceri" wrote: From: Kenneth Graunke While the below stats are encouraging this pass will also become very usefull for avoiding regression once brw_do_channel_expressions() and brw_do_vector_splitting() are disabled. On Broadwell: total instructions in shared

Re: [Mesa-dev] [PATCH 04/10] nir: Introduce a nir_opt_move_comparisons() pass.

Looks functionally correct. I left a few simple comments. On Jan 7, 2017 3:59 AM, "Timothy Arceri" wrote: From: Kenneth Graunke This tries to move comparisons (a common source of boolean values) closer to their first use. For GPUs which use condition codes, this can eliminate a lot of tempor

Re: [Mesa-dev] [PATCH 03/10] nir: Turn -(b2f(a) + b2f(b)) >= 0 into !(a || b).

Uh... This hurts overall... The optimization makes sense but do we have some justification for the hurt? On Jan 7, 2017 3:59 AM, "Timothy Arceri" wrote: From: Kenneth Graunke On BDW: total instructions in shared programs: 13078708 -> 13078787 (0.00%) instructions in affected programs: 15926 -

[Mesa-dev] [Bug 50338]radeon: TGSI takes more than two cfiles from r600_shader.

Hello everyone. First of all, I apologize for the possible incomplete info from this post, or lack of organization. I'm unfamiliar with the Mesa3D development environment, but I'll try my best to behave. I post here because the topic seemed too specific for the "mesa-users" list. For TL;DR, one c

Re: [Mesa-dev] [PATCH 02/10] nir: Turn bcsel of +/- 1.0 and 0.0 into b2f sequences.

Rb On Jan 7, 2017 3:59 AM, "Timothy Arceri" wrote: > From: Kenneth Graunke > > On BDW: > > total instructions in shared programs: 13074882 -> 13068703 (-0.05%) > instructions in affected programs: 1823116 -> 1816937 (-0.34%) > helped: 4187 > HURT: 537 > > total cycles in shared programs: 256622

Re: [Mesa-dev] [PATCH 01/10] nir: Convert ineg(b2i(a)) to a if it's a boolean.

Rb (of you want another one) On Jan 7, 2017 3:59 AM, "Timothy Arceri" wrote: > From: Kenneth Graunke > > On BDW: > > total instructions in shared programs: 13071119 -> 13070371 (-0.01%) > instructions in affected programs: 83424 -> 82676 (-0.90%) > helped: 505 > HURT: 45 (all TCS, all hurt by a

Re: [Mesa-dev] [PATCH 3/8] glsl: Mark whole variable used for ClipDistance and TessLevel*.

Hi, this causes an assertion failure for some tests in the GLSL compiler on radeonsi: glsl/ir_set_program_inouts.cpp:129: void mark(gl_program*, ir_variable*, int, int, gl_shader_stage): Assertion `var->data.mode == ir_var_shader_out' failed. Test: piglit/bin/getuniform-03 -auto -fbo I won't loo

Re: [Mesa-dev] [PATCH 5/9] radeonsi: don't wait for compute shaders in texture_barrier

Hello After updating to mesa-git today, I am getting completely blank (black) window/screen content in applications such as KDE Plasma Desktop and Google Chrome. GPU: R9 390. I am not sure about the cause of this, but it is something committed to mesa-git since 2017-Jan-05 22:32:26 CET. Jan

Re: [Mesa-dev] [PATCH 1/8] glsl: Create and use a new ir_variable::count_attribute_slots() wrapper.

Hi, this causes an assertion failure for many tessellation tests on radeonsi: state_tracker/st_program.c:1295:st_translate_program_common: Assertion `attr >= VARYING_SLOT_VAR0 || (attr >= VARYING_SLOT_TEX0 && attr <= VARYING_SLOT_TEX7)' failed. Test: piglit/bin/shader_runner piglit/tests/spec/arb

Re: [Mesa-dev] [PATCH 2/8] glsl: Override the # of varying slots for ClipDistance and TessLevel*.

Hi, this breaks drawing for Qt apps on radeonsi. I won't look into it right now, maybe next week. Any idea what's wrong here? Marek On Wed, Jan 4, 2017 at 12:07 PM, Kenneth Graunke wrote: > Right now, this shouldn't have any effect, as all drivers use > LowerClipDist and LowerTessFactors to turn

[Mesa-dev] [PATCH] mesa: set GLSL 1.20 for the fixed-function fragment shader

From: Marek Olšák This fixes broken depth texturing after: commit 22639a6e19f95902aef23474ad672bf489231ea7 Author: Timothy Arceri Date: Mon Nov 21 00:29:29 2016 +1100 st/mesa: get Version from gl_program rather than gl_shader_program --- src/mesa/main/ff_fragment_shader.cpp | 3 ++- 1 f

Re: [Mesa-dev] [PATCH] drirc: Allow extension midshader for Divinity: Original Sin (EE)

Pushed. Can you close the bugs if it's fixed? Thanks, Marek On Sat, Jan 7, 2017 at 2:38 PM, Kai Wasserbäch wrote: > See also where > this was first observed as a requirement. > > Signed-off-by: Kai Wasserbäch > --- > src/mesa/drivers/dr

[Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

From: Marek Olšák ~/.drirc is created by the driconf tool (GPL license) and it overrides system drirc settings and can't be changed by Mesa updates. This drops support for the tool. It has been a source of major pain for us and it continues to cause problems. If people wanna keep this and enjoy

[Mesa-dev] [PATCH] drirc: Allow extension midshader for Divinity: Original Sin (EE)

See also where this was first observed as a requirement. Signed-off-by: Kai Wasserbäch --- src/mesa/drivers/dri/common/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

Expecting the user to use env vars it ok for power users, but not very user-friendly for newbies, or just people who don't like using the command line. And that's exactly these users who are likely to use something like driconf. Axel On 07/01/2017 14:23, Kai Wasserbäch wrote: Hey Marek, mayb

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

Hey Marek, maybe should be updated then as well? Just so the page doesn't recommend using driconf? Apart from that, the page is basically useless anyway so maybe deleting it altogether would be best? (What would be nicer to have would be a page listing al

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

I find ~/.drirc useful. You can add hacks missing in system drirc, or use device_id to set the card to use for the given game for dual gpu systems. Nine also has some drirc settings that are not hacks, but user options. I think it's driconf that should be fixed. It shouldn't copy the system

[Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

From: Marek Olšák ~/.drirc is created by the driconf tool (GPL license) and it overrides system drirc settings and can't be changed by Mesa updates. This drops support for the tool. It has been a source of major pain for us and it continues to cause problems. If people wanna keep this and enjoy

[Mesa-dev] [PATCH 07/10] nir: add imprecise flrp optimisation

On BDW: total instructions in shared programs: 13061890 -> 13061877 (-0.00%) instructions in affected programs: 2441 -> 2428 (-0.53%) helped: 13 HURT: 0 total cycles in shared programs: 256612254 -> 256611784 (-0.00%) cycles in affected programs: 16418 -> 15948 (-2.86%) helped: 10 HURT: 2 --- sr

[Mesa-dev] [PATCH 09/10] nir/algebraic: Add support for declaring that a given expression is use more than once

--- src/compiler/nir/nir_algebraic.py | 4 +++- src/compiler/nir/nir_search.c | 7 +++ src/compiler/nir/nir_search.h | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index 19ac6ee..04c7423 100

[Mesa-dev] [PATCH 10/10] nir: add late opt to turn inot/b2f combos back to bcsel

We turn these from bcsel into inot/b2f combos in order for other optimisation passes to get further, once we have finished turn the ones that remain and are used in more than a single expression back into a bcsel. On BDW: total instructions in shared programs: 13060965 -> 13060297 (-0.01%) instru

[Mesa-dev] [PATCH 03/10] nir: Turn -(b2f(a) + b2f(b)) >= 0 into !(a || b).

From: Kenneth Graunke On BDW: total instructions in shared programs: 13078708 -> 13078787 (0.00%) instructions in affected programs: 15926 -> 16005 (0.50%) helped: 19 HURT: 43 total cycles in shared programs: 256561142 -> 256562762 (0.00%) cycles in affected programs: 126122 -> 127742 (1.28%) h

[Mesa-dev] [PATCH 08/10] nir: add another comparison simplification

On BDW: total instructions in shared programs: 13061877 -> 13060965 (-0.01%) instructions in affected programs: 133569 -> 132657 (-0.68%) helped: 566 HURT: 0 total cycles in shared programs: 256611784 -> 256599536 (-0.00%) cycles in affected programs: 861016 -> 848768 (-1.42%) helped: 379 HURT: 7

[Mesa-dev] [PATCH 05/10] i965: Move nir_lower_locals_to_regs a bit later.

From: Kenneth Graunke I'm going to add a boolean scheduling pass that I want run late, but after copy propagation and dead code elimination. Yet, I don't want to have to think about registers. So, move the register conversion a little later. No impact on shader-db. Suggested by Jason Ekstrand

[Mesa-dev] [PATCH 04/10] nir: Introduce a nir_opt_move_comparisons() pass.

From: Kenneth Graunke This tries to move comparisons (a common source of boolean values) closer to their first use. For GPUs which use condition codes, this can eliminate a lot of temporary booleans and comparisons which reload the condition code register based on a boolean. V2: (Timothy Arceri

[Mesa-dev] [PATCH 06/10] i965: Use the nir_move_comparisons pass.

From: Kenneth Graunke While the below stats are encouraging this pass will also become very usefull for avoiding regression once brw_do_channel_expressions() and brw_do_vector_splitting() are disabled. On Broadwell: total instructions in shared programs: 13078787 -> 13060898 (-0.14%) instructio

[Mesa-dev] [PATCH 02/10] nir: Turn bcsel of +/- 1.0 and 0.0 into b2f sequences.

From: Kenneth Graunke On BDW: total instructions in shared programs: 13074882 -> 13068703 (-0.05%) instructions in affected programs: 1823116 -> 1816937 (-0.34%) helped: 4187 HURT: 537 total cycles in shared programs: 256622718 -> 256425382 (-0.08%) cycles in affected programs: 123790120 -> 123

[Mesa-dev] [PATCH 01/10] nir: Convert ineg(b2i(a)) to a if it's a boolean.

From: Kenneth Graunke On BDW: total instructions in shared programs: 13071119 -> 13070371 (-0.01%) instructions in affected programs: 83424 -> 82676 (-0.90%) helped: 505 HURT: 45 (all TCS, all hurt by a single instruction) total cycles in shared programs: 256601322 -> 256588932 (-0.00%) cycles

[Mesa-dev] Step towards dropping more GLSL IR opts

This is a collection of patches I've written and collected that aim to reduce the pain when dropping brw_do_channel_expressions() and brw_do_vector_splitting() two passes that combined take about 14% of the time it takes to run shader-db. This series includes Ken's move comparisions series with a c

Re: [Mesa-dev] [PATCH 6/6] i965: Move TES input VUE map calculation out a layer.

On Sat, 2017-01-07 at 02:56 -0800, Kenneth Graunke wrote: > On Saturday, January 7, 2017 8:51:06 PM PST Timothy Arceri wrote: > > On Sat, 2017-01-07 at 00:02 -0800, Kenneth Graunke wrote: > > > In Vulkan, we'll compile the TCS and TES at the same time, so I > > > can > > > just > > > pass the TCS o

Re: [Mesa-dev] [PATCH 6/6] i965: Move TES input VUE map calculation out a layer.

On Saturday, January 7, 2017 8:51:06 PM PST Timothy Arceri wrote: > On Sat, 2017-01-07 at 00:02 -0800, Kenneth Graunke wrote: > > In Vulkan, we'll compile the TCS and TES at the same time, so I can > > just > > pass the TCS output VUE map to brw_compile_tes as the TES input VUE > > map. > > > > So

Re: [Mesa-dev] [PATCH] glsl: fix opt_minmax redundancy checks against baserange

On Fri, 2017-01-06 at 13:29 +0100, Iago Toral wrote: > Hi Tim, > > it's been a while, so off the top of my head I don't have any > particular suggestions or the capacity to tell whether your fix is > correct or not :-/. > > I'll try to spend some time re-acquainting myself with that code on > Mon

Re: [Mesa-dev] [PATCH 2/2] anv/pipeline: Call NIR passes using NIR_PASS_V

Both patches are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/6] i965: Pass NULL for gl_program when compiling TES.

Patches 3-5 are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 6/6] i965: Move TES input VUE map calculation out a layer.

On Sat, 2017-01-07 at 00:02 -0800, Kenneth Graunke wrote: > In Vulkan, we'll compile the TCS and TES at the same time, so I can > just > pass the TCS output VUE map to brw_compile_tes as the TES input VUE > map. > > So, we only need to do this in GL.  Move it to the GL-specific layer. > > Signed-

Re: [Mesa-dev] [PATCH 2/6] mesa: Introduce a compiler enum for tessellation spacing.

Patches 1-2 are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 5/6] i965: Pass NULL for gl_program when compiling TES.

This isn't needed, and Vulkan doesn't have one. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 821d093d4da..

[Mesa-dev] [PATCH 6/6] i965: Move TES input VUE map calculation out a layer.

In Vulkan, we'll compile the TCS and TES at the same time, so I can just pass the TCS output VUE map to brw_compile_tes as the TES input VUE map. So, we only need to do this in GL. Move it to the GL-specific layer. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_compiler.h |

[Mesa-dev] [PATCH 2/6] mesa: Introduce a compiler enum for tessellation spacing.

It feels weird using GL_* enums in a Vulkan driver. Signed-off-by: Kenneth Graunke --- src/compiler/glsl/ast.h | 2 +- src/compiler/glsl/glsl_parser.yy | 8 src/compiler/glsl/glsl_parser_extras.cpp | 2 +- src/compiler/glsl/linker.cpp | 6 +++---

[Mesa-dev] [PATCH 3/6] i965: Access TES shader info via NIR.

NIR exists in both GL and Vulkan, but gl_program is GL specific. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_tes.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tes.c b/src/mesa/drivers/dri/i965/brw_tes.c inde

[Mesa-dev] [PATCH 1/6] compiler: Change shader_info->tes.vertex_order into a ccw boolean.

The vertex order is either clockwise or counterclockwise. We can just store a "ccw" boolean rather than GLenum values. I don't want to use GLenums in a Vulkan driver, and even in GL a simple boolean works fine. Signed-off-by: Kenneth Graunke --- src/compiler/shader_info.h | 3 ++- sr

[Mesa-dev] [PATCH 4/6] i965: Move TES spacing/domain/topology setup to brw_compile_tes().

Moving this down a layer lets us share code between Vulkan and GL. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_shader.cpp | 34 src/mesa/drivers/dri/i965/brw_tes.c | 33 --- 2 files changed, 34 insertions(+),