[Mesa-dev] [PATCH] nir: Use a single bit for the dual-source blend index

2015-08-01 Thread Timothy Arceri
The only values allowed are 0 and 1, and the value is checked before assigning. This is a copy of 8eeca7a56c that seems to have been made to the glsl ir type after it was copied for use in nir but before nir landed. --- src/glsl/nir/nir.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[Mesa-dev] [PATCH] mesa: fix type for array indexing validation

2015-08-01 Thread Timothy Arceri
parse_program_resource_name returns -1 when the index is invalid this needs to be tested before assigning the value to the unsigned array_index. In link_varyings.cpp (the other place parse_program_resource_name is used) after the -1 check is done the value is just assigned to an unsigned variable

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-08-01 Thread Timothy Arceri
On Sat, 2015-08-01 at 15:58 -0700, Matt Turner wrote: > On Wed, Jul 29, 2015 at 6:56 AM, Timothy Arceri > wrote: > > This removes the need for multiple functions designed to validate an array > > subscript and replaces them with a call to a single function. > > > > The change also means that val

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-08-01 Thread Matt Turner
On Wed, Jul 29, 2015 at 6:56 AM, Timothy Arceri wrote: > This removes the need for multiple functions designed to validate an array > subscript and replaces them with a call to a single function. > > The change also means that validation is now only done once and the index > is retrived at the sam

Re: [Mesa-dev] [Mesa-stable] [PATCH] xa: add xa_surface_from_handle2

2015-08-01 Thread Thomas Hellstrom
Hi! On 08/01/2015 07:16 PM, Emil Velikov wrote: > On 22 July 2015 at 00:00, Rob Clark wrote: >> From: Rob Clark >> >> Like xa_surface_from_handle(), but takes a handle type, rather than >> hard-coding 'shared' handle. This is needed to fix bugs seen with >> xf86-video-freedreno with xrandr rota

Re: [Mesa-dev] [Mesa-stable] [PATCH] xa: add xa_surface_from_handle2

2015-08-01 Thread Rob Clark
On Sat, Aug 1, 2015 at 1:16 PM, Emil Velikov wrote: > On 22 July 2015 at 00:00, Rob Clark wrote: >> From: Rob Clark >> >> Like xa_surface_from_handle(), but takes a handle type, rather than >> hard-coding 'shared' handle. This is needed to fix bugs seen with >> xf86-video-freedreno with xrandr

[Mesa-dev] [Bug 73512] [clover] mesa.icd. should contain full path

2015-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73512 Igor Gnatenko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] vl/mpeg12: Silence GCC unused-variable warning.

2015-08-01 Thread Vinson Lee
vl/vl_mpeg12_bitstream.c: In function 'decode_slice': vl/vl_mpeg12_bitstream.c:928:19: warning: unused variable 'extra' [-Wunused-variable] unsigned extra = vl_vlc_get_uimsbf(&bs->vlc, 1); ^ Signed-off-by: Vinson Lee --- src/gallium/auxiliary/vl/vl_mpeg12_bitstream.

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Fix bug with computing hard_event status

2015-08-01 Thread Marek Olšák
On Sat, Aug 1, 2015 at 7:29 PM, Emil Velikov wrote: > On 1 August 2015 at 17:57, Marek Olšák wrote: >> No, we don't need this. radeonsi doesn't return a NULL fence anymore. >> > Glad to hear. On the other hand is that fix in stable ? I believe the > following commit resolves the issue, yet it's a

[Mesa-dev] [Bug 91468] LLVM 3.8(svn): llvm changes llvm-config output again?

2015-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91468 Krzysztof A. Sobiecki changed: What|Removed |Added CC||sob...@gmail.com,

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Fix bug with computing hard_event status

2015-08-01 Thread Emil Velikov
On 1 August 2015 at 17:57, Marek Olšák wrote: > No, we don't need this. radeonsi doesn't return a NULL fence anymore. > Glad to hear. On the other hand is that fix in stable ? I believe the following commit resolves the issue, yet it's a bit short of nomination. Can anyone confirm if we need it fo

Re: [Mesa-dev] [PATCH 00/12] bmake inspired fixes

2015-08-01 Thread Emil Velikov
On 17 July 2015 at 19:53, Emil Velikov wrote: > On 17 July 2015 at 19:09, Matt Turner wrote: >> On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov >> wrote: >>> Hello all, >>> >>> A few days ago I realised that BSD make (bmake) is available in the >>> Archlinux repos, so I decided to give it a try

Re: [Mesa-dev] [PATCH 5/5] vc4: add missing nir include, to fix the build

2015-08-01 Thread Emil Velikov
On 21 July 2015 at 13:14, Emil Velikov wrote: > On 17/07/15 18:17, Emil Velikov wrote: >> Cc: 10.6 >> Cc: Eric Anholt >> Signed-off-by: Emil Velikov >> --- >> src/gallium/drivers/vc4/Makefile.am | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/gallium/drivers/vc4/Makefile.am >>

Re: [Mesa-dev] [Mesa-stable] [PATCH] xa: add xa_surface_from_handle2

2015-08-01 Thread Emil Velikov
On 22 July 2015 at 00:00, Rob Clark wrote: > From: Rob Clark > > Like xa_surface_from_handle(), but takes a handle type, rather than > hard-coding 'shared' handle. This is needed to fix bugs seen with > xf86-video-freedreno with xrandr rotation, for example. The root issue > is that doing a GEM

Re: [Mesa-dev] [Mesa-stable] [PATCH 16/18] i965: Prevent coordinate overflow in intel_emit_linear_blit

2015-08-01 Thread Emil Velikov
Hello all, On 20 July 2015 at 18:08, Anuj Phogat wrote: > On Sat, Jul 18, 2015 at 1:24 AM, Chris Wilson > wrote: >> On Fri, Jul 17, 2015 at 05:12:54PM -0700, Anuj Phogat wrote: >>> On Mon, Jul 6, 2015 at 3:33 AM, Chris Wilson >>> wrote: >>> > + do { >>> > + /* The pitch given to the GP

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Fix bug with computing hard_event status

2015-08-01 Thread Marek Olšák
No, we don't need this. radeonsi doesn't return a NULL fence anymore. Marek On Sat, Aug 1, 2015 at 6:54 PM, Emil Velikov wrote: > On 16 July 2015 at 19:16, Tom Stellard wrote: >> On Sat, Jul 11, 2015 at 02:35:53PM +0300, Francisco Jerez wrote: >>> Tom Stellard writes: >>> >>> > pipe_context::f

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Fix bug with computing hard_event status

2015-08-01 Thread Emil Velikov
On 16 July 2015 at 19:16, Tom Stellard wrote: > On Sat, Jul 11, 2015 at 02:35:53PM +0300, Francisco Jerez wrote: >> Tom Stellard writes: >> >> > pipe_context::flush() can return a NULL fence if the queue is already >> > empty, so we should not assume that an event with a NULL fence >> > has the s

Re: [Mesa-dev] [PATCH 1/2] gallium/drivers: Add threadsafe wrappers for pipe_context v2

2015-08-01 Thread Emil Velikov
On 11 July 2015 at 02:55, Tom Stellard wrote: > These wrappers can be used by state trackers to ensure threadsafe access > to pipe_context objects. > > v2: > - Don't add wrappers for pipe_screen. > - Build system cleanups > > CC: 10.6 Humble ping. Seems that this series never landed in maste

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/bdw: Fix 3DSTATE_VF_INSTANCING when the edge flag is used

2015-08-01 Thread Emil Velikov
Hello Neil, On 10 July 2015 at 18:04, Neil Roberts wrote: > When the edge flag element is enabled then the elements are slightly > reordered so that the edge flag is always the last one. This was > confusing the code to upload the 3DSTATE_VF_INSTANCING state because > that is uploaded with a sepa

Re: [Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.

2015-08-01 Thread Emil Velikov
On 6 July 2015 at 21:40, Kenneth Graunke wrote: > On Monday, July 06, 2015 12:18:18 PM Matt Turner wrote: >> On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke >> wrote: >> > It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a >> > (i965: Make a brw_stage_prog_data for storing the

Re: [Mesa-dev] [PATCH 7/7] mesa: Replace uses of IROUND{, 64} with libm functions.

2015-08-01 Thread Brian Paul
I don't remember the specifics, but I recall some of the old conformance tests being sensitive to float->int conversion in a few areas. Matt, if you have access to the conform tests and can run the old swrast driver with your change, that'd be interesting. -Brian On Fri, Jul 31, 2015 at 7:52 PM

Re: [Mesa-dev] [PATCH v3 74/78] i965/vec4: Enable NIR-vec4 pass on ARB_vertex_programs

2015-08-01 Thread Jason Ekstrand
LGTM RB On Aug 1, 2015 5:16 AM, "Eduardo Lima Mitev" wrote: > From: Antia Puentes > > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 47 > +- > 1 file changed, 24 insertions(+), 23 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/src/mesa/

Re: [Mesa-dev] [PATCH v3 09/78] i965/nir: Pass a is_scalar boolean to brw_create_nir()

2015-08-01 Thread Jason Ekstrand
This looks better. Sorry I didn't catch the scalar vs problems before. R-B On Aug 1, 2015 5:16 AM, "Eduardo Lima Mitev" wrote: > The upcoming introduction of NIR->vec4 pass will require that some NIR > lowering > passes are enabled/disabled depending on the type of shader (scalar vs. > vector). >

Re: [Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-08-01 Thread Emil Velikov
On 29 July 2015 at 18:17, Matt Turner wrote: > On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov > wrote: >> Strictly speaking the xcb_connection_has_error() might be sufficient, >> yet the documentation does not mention what will happen if NULL is fed >> to the function. >> >> Keep things explicit,

Re: [Mesa-dev] [PATCH] includes/GL: remove duplicated extension declarations from glx.h

2015-08-01 Thread Emil Velikov
On 30 July 2015 at 16:44, Ian Romanick wrote: > On 07/30/2015 07:50 AM, Emil Velikov wrote: >> On 30 July 2015 at 15:22, Emil Velikov wrote: >>> All three of GLX_NV_float_buffer, GLX_EXT_texture_from_pixmap and >>> GLX_MESA_query_renderer have been in glxext.h for a while now. >>> >>> As such we

[Mesa-dev] [RFC] [PATCH] nir: Add a loop analysis pass

2015-08-01 Thread Thomas Helland
I was meant to send out this yesterday, but my git send-email got corrupted again. Don't know what's up with that. But enough with the chit-chat, here it is. The pass is now working! It detects the induction variables and calculates the unroll count correctly on the one shader I've tried it on as

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-01 Thread Eduardo Lima Mitev
On 07/31/2015 10:48 AM, Eduardo Lima Mitev wrote: > On 07/30/2015 09:48 PM, Jason Ekstrand wrote: >> >> On Jul 27, 2015 3:39 PM, "Jason Ekstrand" > > wrote: >>> >>> On Mon, Jul 27, 2015 at 2:07 PM, Eduardo Lima Mitev > > wrote: On 07/25/201

[Mesa-dev] [PATCH v3 09/78] i965/nir: Pass a is_scalar boolean to brw_create_nir()

2015-08-01 Thread Eduardo Lima Mitev
The upcoming introduction of NIR->vec4 pass will require that some NIR lowering passes are enabled/disabled depending on the type of shader (scalar vs. vector). With this patch we pass a 'is_scalar' variable to the process of constructing the NIR, to let an external context decide how the shader

[Mesa-dev] [PATCH v3 74/78] i965/vec4: Enable NIR-vec4 pass on ARB_vertex_programs

2015-08-01 Thread Eduardo Lima Mitev
From: Antia Puentes --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 47 +- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 8d83887..88b601a 100644 --- a/src/mesa/dr