Re: [Mesa-dev] [PATCH 28/29] i965: Define implementation constants for ARB_shader_image_load_store.

On Saturday, May 02, 2015 06:29:55 PM Francisco Jerez wrote: > Reviewed-by: Paul Berry > > v2: Drop VS support pre-Gen8, drop GS support. > --- > src/mesa/drivers/dri/i965/brw_context.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_context.

Re: [Mesa-dev] [PATCH 8/8] st/mesa: add double input support including lowering (v3)

On Mon, May 4, 2015 at 7:33 PM, Dave Airlie wrote: > On 30 April 2015 at 13:23, Ilia Mirkin wrote: >> On Wed, Apr 29, 2015 at 9:14 PM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> This takes a different approach to previously, we cannot index into the >>> inputMapping with anything but the

Re: [Mesa-dev] [PATCH 6/8] glsl: check total count of multi-slot double vertex attribs

On 5 May 2015 at 09:47, Ian Romanick wrote: > On 04/29/2015 06:14 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> The spec is vague all over the place about this, but this seems >> to be the intent, we can probably make this optional later if >> someone makes hw that cares and writes a driver.

Re: [Mesa-dev] [PATCH 5/8] glsl: track which program inputs are doubles

On 5 May 2015 at 09:53, Ian Romanick wrote: > On 04/29/2015 06:14 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> instead of doing the attempts at dual slot handling here, >> let the backend do it. > > Just curious... why? It seems like everyone wants the same mapping, so > doing it one place

Re: [Mesa-dev] [PATCH 4/8] glsl: add ARB_vertex_attrib_64bit support.

On 5 May 2015 at 09:40, Ian Romanick wrote: > On 04/29/2015 06:13 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> Just more boilerplate stuff. >> >> Signed-off-by: Dave Airlie >> --- >> src/glsl/ast_to_hir.cpp | 3 +++ >> src/glsl/glcpp/glcpp-parse.y| 3 +++ >> src/glsl/glsl_parse

Re: [Mesa-dev] [PATCH 5/8] glsl: track which program inputs are doubles

On 04/29/2015 06:14 PM, Dave Airlie wrote: > From: Dave Airlie > > instead of doing the attempts at dual slot handling here, > let the backend do it. Just curious... why? It seems like everyone wants the same mapping, so doing it one place ought to be better. There is a lot of stuff in the GL

Re: [Mesa-dev] ARB_vertex_attrib_64bit support (2nd posting I think)

Patches 2, 3, and 7 are Reviewed-by: Ian Romanick Comments sent on patch 4, 5, and 6. I don't know anything about patches 1 or 8. On 04/29/2015 06:13 PM, Dave Airlie wrote: > The biggest change in this series is the attribute slot counting > code in patch 6, and some cleanups in patch 8. > >

Re: [Mesa-dev] [PATCH 6/8] glsl: check total count of multi-slot double vertex attribs

On 04/29/2015 06:14 PM, Dave Airlie wrote: > From: Dave Airlie > > The spec is vague all over the place about this, but this seems > to be the intent, we can probably make this optional later if > someone makes hw that cares and writes a driver. > > Basically we need to double count some of the

Re: [Mesa-dev] [PATCH 4/8] glsl: add ARB_vertex_attrib_64bit support.

On 04/29/2015 06:13 PM, Dave Airlie wrote: > From: Dave Airlie > > Just more boilerplate stuff. > > Signed-off-by: Dave Airlie > --- > src/glsl/ast_to_hir.cpp | 3 +++ > src/glsl/glcpp/glcpp-parse.y| 3 +++ > src/glsl/glsl_parser_extras.cpp | 1 + > src/glsl/glsl_parser_extras.h

Re: [Mesa-dev] [PATCH 8/8] st/mesa: add double input support including lowering (v3)

On 30 April 2015 at 13:23, Ilia Mirkin wrote: > On Wed, Apr 29, 2015 at 9:14 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> This takes a different approach to previously, we cannot index into the >> inputMapping with anything but the mesa attribute index, so we can't use >> the just add one t

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v2)

On Saturday, May 02, 2015 06:29:27 PM Francisco Jerez wrote: > This v2 is motivated by the less than enthusiastic reception of my > last two series implementing the image load, store and atomic > intrinsics in the i965 back-end. It substitutes both. > > The built-ins are now implemented in the sc

Re: [Mesa-dev] [PATCH 6/9] glsl: mark named uniform block arrays as active if defined with shared or std140 layout qualifier

On Tue, Feb 24, 2015 at 10:02 AM, Eduardo Lima Mitev wrote: > From: Samuel Iglesias Gonsalvez > > If the named uniform block is an array declared with a shared or > std140 layout qualifier and no shader instruction has referenced it, > then it is never marked as active, then num_array_elements is

Re: [Mesa-dev] [PATCH 5/9] mesa: fix deletion of inactive bound transform feedback object

On Tue, Feb 24, 2015 at 10:02 AM, Eduardo Lima Mitev wrote: > From: Samuel Iglesias Gonsalvez > > When a transform feedback object is bound and not active, the OpenGL ES > 3.0 and GL_ARB_transform_feedback2 specs don't explicitly disallow its > deletion. Only the deletion of the default framebuff

Re: [Mesa-dev] [PATCH 09/29] i965: Define the setup_vector_uniform_values() backend_visitor interface.

On Saturday, May 02, 2015 06:29:36 PM Francisco Jerez wrote: > This cleans up the VEC4 implementation of setup_uniform_values() > somewhat and will avoid duplication of the image uniform upload code > by having a common interface to upload a vector of uniforms on either > back-end. > --- > src/mes

Re: [Mesa-dev] [PATCH 14/29] i965: Lift the constness restriction on surface indices passed to untyped ops.

On Saturday, May 02, 2015 06:29:41 PM Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 8 ++-- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 > src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 8 ++-- > src/mesa/drivers/dri/i965/brw_vec4_vis

Re: [Mesa-dev] [PATCH 2/9] i965: Fix textureGrad with cube samplers

Am 05.05.2015 um 00:16 schrieb Matt Turner: > On Tue, Feb 24, 2015 at 10:39 AM, Roland Scheidegger > wrote: >> As a side note (not really directly related to the patch) I think this >> could benefit from some optimization, unless there's some passes >> somewhere which can already do this. >> >> T

Re: [Mesa-dev] [PATCH 03/29] i965: Define consistent interface to disable control flow execution masking.

On Saturday, May 02, 2015 06:29:30 PM Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ > src/mesa/drivers/dri/i965/brw_ir_vec4.h | 9 + > 2 files changed, 19 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_ir_fs.h > b/src/mesa/drivers/

Re: [Mesa-dev] [PATCH 2/9] i965: Fix textureGrad with cube samplers

On Tue, Feb 24, 2015 at 10:39 AM, Roland Scheidegger wrote: > As a side note (not really directly related to the patch) I think this > could benefit from some optimization, unless there's some passes > somewhere which can already do this. > > The non-scalar (non-cube) calculation does this: > lod_

Re: [Mesa-dev] [PATCH 01/29] i965/fs: Have component() set the register stride to zero.

On Saturday, May 02, 2015 06:29:28 PM Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_ir_fs.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_ir_fs.h > b/src/mesa/drivers/dri/i965/brw_ir_fs.h > index e2d2617..32fab65 100644 > --- a/src/mesa/dri

Re: [Mesa-dev] [PATCH 1/9] glsl: don't lower fragdata array if the output data types don't match

On Tue, Feb 24, 2015 at 10:02 AM, Eduardo Lima Mitev wrote: > From: Samuel Iglesias Gonsalvez > > Commit 7e414b58640aee6e243d337e72cea290c354f632 broke the gl_FragData array > into separate gl_FragData[i] variables, so drivers can eliminate useless > writes to gl_FragData improving their performa

Re: [Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog v2

On Mon, May 4, 2015 at 5:54 PM, Tim Rowley wrote: > Switch to using VERT_BIT_GENERIC macro. Downloading piglet and > thought about how to test for this, but it doesn't look like I can > make a test pass/fail based on the tgsi generated (which is the most > straightforward way of testing this). N

[Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog v2

Switch to using VERT_BIT_GENERIC macro. Downloading piglet and thought about how to test for this, but it doesn't look like I can make a test pass/fail based on the tgsi generated (which is the most straightforward way of testing this). diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/f

Re: [Mesa-dev] [PATCH 00/20] Begin enabling OpenGL ES 3.1

On 04/30/2015 07:47 AM, Mike Lothian wrote: > Isn't that override to change the GL version rather than the GLES version? Patch 20 causes MESA_GL_VERSION_OVERRIDE to affect the GLES version as well. > On Thu, 30 Apr 2015 00:26 Ian Romanick > wrote: > > There's st

Re: [Mesa-dev] [PATCH] i965: Sort extension enable lists

On Mon, May 4, 2015 at 1:51 PM, Ian Romanick wrote: > From: Ian Romanick > > Sort by GEN, then sort by extension name. > > Signed-off-by: Ian Romanick > --- Alphabetize! \o/ Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedeskt

[Mesa-dev] [PATCH] i965: Sort extension enable lists

From: Ian Romanick Sort by GEN, then sort by extension name. Signed-off-by: Ian Romanick --- I had intended to send this out with the GLES3.1 stuff, but, for some reason, I forgot. src/mesa/drivers/dri/i965/intel_extensions.c | 69 ++-- 1 file changed, 35 insertions(+)

Re: [Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog

On Mon, May 4, 2015 at 3:57 PM, Tim Rowley wrote: > This was working before because it failed into generating the more > general case lighting equation. > > diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/ffvertex_prog.c > index 7fdd9ba..cce0636 100644 > --- a/src/mesa/main/ffvertex_pro

[Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog

This was working before because it failed into generating the more general case lighting equation. diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/ffvertex_prog.c index 7fdd9ba..cce0636 100644 --- a/src/mesa/main/ffvertex_prog.c +++ b/src/mesa/main/ffvertex_prog.c @@ -135,7 +135,7 @@ st

Re: [Mesa-dev] [PATCH 06/20] glsl: Add glsl_parser_state::has_atomic_counters helper

On 04/29/2015 11:42 PM, Tapani Pälli wrote: > > > On 04/30/2015 02:25 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/glsl/builtin_functions.cpp | 2 +- >> src/glsl/builtin_types.cpp | 2 +- >> src/glsl/builtin_variables.cpp | 2 +- >> src/

Re: [Mesa-dev] [PATCH] mesa: Restore functionality to dispatch sanity test

On 04/29/2015 02:44 PM, Brian Paul wrote: > On 04/29/2015 02:53 PM, Ian Romanick wrote: >> On 04/29/2015 12:07 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Along with a couple secondary goals, the dispatch sanity test had two >>> major, primary goals. >>> >>> 1. Ensure that all functions

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

On Mon, May 4, 2015 at 12:11 PM, Ilia Mirkin wrote: > On Mon, May 4, 2015 at 12:47 PM, Tom Stellard wrote: > > On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote: > >> On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote: > >> > On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrot

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

On Mon, May 4, 2015 at 12:47 PM, Tom Stellard wrote: > On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote: >> On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote: >> > On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote: >> >> On Sat, May 2, 2015 at 1:19 PM, EdB wrote: >> >> > T

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote: > On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote: > > On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote: > >> On Sat, May 2, 2015 at 1:19 PM, EdB wrote: > >> > The standard ICD file path is /etc/OpenCL/vendor/. > >> > How

Re: [Mesa-dev] [PATCH 08/19] gallium: add set_tess_state to configure default tessellation parameters

AFAIK this isn't possible with d3d11, but if hw can do it it makes sense indeed. For the series: Reviewed-by: Roland Scheidegger Am 04.05.2015 um 15:33 schrieb Marek Olšák: > Hi Roland, > > It depends on the hardware. On Radeon, the tessellation evaluation > shader can read vertex shader outpu

Re: [Mesa-dev] [PATCH 07/29] i965/fs: Introduce FS IR builder.

On Sat, May 2, 2015 at 8:29 AM, Francisco Jerez wrote: > The purpose of this change is threefold: First, it improves the > modularity of the compiler back-end by separating the functionality > required to construct an i965 IR program from the rest of the visitor > god-object, what in turn will red

Re: [Mesa-dev] [PATCH] main/queryobj: add GL_QUERY_TARGET support to GetQueryObjectiv()

Reviewed-by: Ilia Mirkin On Mon, May 4, 2015 at 10:06 AM, Martin Peres wrote: > This was missing from my patchset to support the query-related entry > points of Direct State Access. > > Reported-by: Ilia Mirkin > Signed-off-by: Martin Peres > --- > src/mesa/main/queryobj.c | 12 >

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote: > On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote: >> On Sat, May 2, 2015 at 1:19 PM, EdB wrote: >> > The standard ICD file path is /etc/OpenCL/vendor/. >> > However it doesn't fit well with custom build. >> > This option allow ICD

Re: [Mesa-dev] [PATCH 0/9] Some egl/wayland patches

Hi, On 2 May 2015 at 11:15, Axel Davy wrote: > Since gallium egl state tracker was dropped, > there was no way to use swrast with wayland, > since it was not implemented for egl_dri2. > https://bugs.freedesktop.org/show_bug.cgi?id=86701 > > This patch serie aimed at implementing swrast support >

[Mesa-dev] [PATCH] main/queryobj: add GL_QUERY_TARGET support to GetQueryObjectiv()

This was missing from my patchset to support the query-related entry points of Direct State Access. Reported-by: Ilia Mirkin Signed-off-by: Martin Peres --- src/mesa/main/queryobj.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryo

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote: > On Sat, May 2, 2015 at 1:19 PM, EdB wrote: > > The standard ICD file path is /etc/OpenCL/vendor/. > > However it doesn't fit well with custom build. > > This option allow ICD vendor file installation path override > > --- > > configur

Re: [Mesa-dev] [PATCH 2/2] mesa: Always return a value in _mesa_format_from_format_and_type

On Mon, 2015-05-04 at 05:52 -0700, Jason Ekstrand wrote: > > On May 4, 2015 4:25 AM, "Iago Toral Quiroga" > wrote: > > > > Return MESA_FORMAT_NONE if no matching type was found. We have an > > assertion here, but we should return something anyway to avoid > > confusion with non-debug builds. > >

Re: [Mesa-dev] [PATCH 4/7] i965: Perform basic optimizations on the FIND_LIVE_CHANNEL opcode.

Kenneth Graunke writes: > On Thursday, April 30, 2015 04:59:49 PM Francisco Jerez wrote: >> Matt Turner writes: >> >> > On Fri, Feb 20, 2015 at 11:49 AM, Francisco Jerez >> > wrote: >> >> --- >> >> src/mesa/drivers/dri/i965/brw_fs.cpp | 49 >> >> ++ >> >> s

Re: [Mesa-dev] [PATCH 7/7] i965/sync: Implement DRI2_Fence extension

Hi, On 1 May 2015 at 21:02, Chad Versace wrote: > +static bool > +brw_fence_has_completed(struct brw_fence *fence) > +{ > + if (fence->signalled) > + return true; > + > + if (fence->batch_bo && !drm_intel_bo_busy(fence->batch_bo)) { > + drm_intel_bo_unreference(fence->batch_bo); > +

Re: [Mesa-dev] [PATCH 08/19] gallium: add set_tess_state to configure default tessellation parameters

FWIW nvidia also does not require a special TCS in this case and can program the tessellation levels directly from the cmd stream. [Actually it might need a TCS with only an "exit" instruction, I should double-check.] However AFAIK Intel hardware requires a more involved passthrough TCS which handl

Re: [Mesa-dev] [PATCH 08/19] gallium: add set_tess_state to configure default tessellation parameters

Hi Roland, It depends on the hardware. On Radeon, the tessellation evaluation shader can read vertex shader outputs directly. That means the tessellation control shader is not necessary if the tessellation levels are fixed. set_tess_state sets the fixed tessellation levels for exactly this case.

Re: [Mesa-dev] [PATCH 1/2] swrast: Fix rgba_draw_pixels with GL_COLOR_INDEX

On May 4, 2015 6:41 AM, "Juha-Pekka Heikkila" wrote: > > These two patches > > Reviewed-and-tested-by: Juha-Pekka Heikkila Those should probably be sperate tags. Also, Reviewed-by: Jason Ekstrand > On 04.05.2015 12:24, Iago Toral Quiroga wrote: > > When we implemented the format conversion r

Re: [Mesa-dev] [PATCH 2/2] mesa: Always return a value in _mesa_format_from_format_and_type

On May 4, 2015 4:25 AM, "Iago Toral Quiroga" wrote: > > Return MESA_FORMAT_NONE if no matching type was found. We have an > assertion here, but we should return something anyway to avoid > confusion with non-debug builds. > --- > src/mesa/main/glformats.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [Mesa-dev] [PATCH 3/7] glsl: Forbid opaque variables as operands of the ternary operator.

Matt Turner writes: > On Sat, Jan 31, 2015 at 12:54 PM, Francisco Jerez > wrote: >> --- >> src/glsl/ast_to_hir.cpp | 12 >> 1 file changed, 12 insertions(+) > > Patches 1-2 were already reviewed and committed. > > Patches 3-7 are > > Reviewed-by: Matt Turner Thanks! signature.

Re: [Mesa-dev] [PATCH 6/8] mesa: Implement image uniform queries.

Matt Turner writes: > On Sat, Jan 31, 2015 at 10:27 AM, Francisco Jerez > wrote: >> --- >> src/mesa/main/uniform_query.cpp | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/src/mesa/main/uniform_query.cpp >> b/src/mesa/main/uniform_query.cpp >> index 32870d0..82e5

Re: [Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

On Mon, May 04, 2015 at 02:56:33PM +0300, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Mon, May 04, 2015 at 02:18:37PM +0300, Francisco Jerez wrote: > >> "Pohjolainen, Topi" writes: > >> > >> > On Sat, Apr 25, 2015 at 01:45:36AM +0300, Francisco Jerez wrote: > >> >> "Pohjolaine

Re: [Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

"Pohjolainen, Topi" writes: > On Mon, May 04, 2015 at 02:18:37PM +0300, Francisco Jerez wrote: >> "Pohjolainen, Topi" writes: >> >> > On Sat, Apr 25, 2015 at 01:45:36AM +0300, Francisco Jerez wrote: >> >> "Pohjolainen, Topi" writes: >> >> >> >> > On Fri, Feb 27, 2015 at 05:34:55PM +0200, Fran

Re: [Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

On Mon, May 04, 2015 at 02:47:33PM +0300, Pohjolainen, Topi wrote: > On Mon, May 04, 2015 at 02:18:37PM +0300, Francisco Jerez wrote: > > "Pohjolainen, Topi" writes: > > > > > On Sat, Apr 25, 2015 at 01:45:36AM +0300, Francisco Jerez wrote: > > >> "Pohjolainen, Topi" writes: > > >> > > >> > On

Re: [Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

On Mon, May 04, 2015 at 02:18:37PM +0300, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Sat, Apr 25, 2015 at 01:45:36AM +0300, Francisco Jerez wrote: > >> "Pohjolainen, Topi" writes: > >> > >> > On Fri, Feb 27, 2015 at 05:34:55PM +0200, Francisco Jerez wrote: > >> >> --- > >> >>

Re: [Mesa-dev] [PATCH 1/2] swrast: Fix rgba_draw_pixels with GL_COLOR_INDEX

These two patches Reviewed-and-tested-by: Juha-Pekka Heikkila On 04.05.2015 12:24, Iago Toral Quiroga wrote: > When we implemented the format conversion rewrite we forgot to handle > GL_COLOR_INDEX here, which needs special handling. > > Fixes the following piglit test: > bin/gl-1.0-drawpixels-

Re: [Mesa-dev] [PATCH 08/19] gallium: add set_tess_state to configure default tessellation parameters

Seems a bit awkward that you have to set such state separately. I don't know much about how this is supposed to work though, some quick grep says these parameters are used when there's no tessellation control shader, so I guess that's why it is separate state. How does that actually work in hw, can

Re: [Mesa-dev] [PATCH 00/19] gallium: basic tessellation support

Hmm someting like TESSEVAL is fine by me but I'd prefer something a bit more descriptive than TESSC/TESSE... Roland Am 03.05.2015 um 17:59 schrieb Marek Olšák: > Renaming everything would be slightly annoying. I personally prefer > shorter names anyway (TESSC/TESSE, PIPE_SHADER_TESSEVAL, etc.). I

Re: [Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

"Pohjolainen, Topi" writes: > Unfortunately mail server has purged the original patch number 13. I took > a look instead in your recent image-load-store-nir branch. You probably meant the image-load-store-scalar branch? > I studied the fence mechanism a little in bspec, and based on that I > ca

Re: [Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

"Pohjolainen, Topi" writes: > On Sat, Apr 25, 2015 at 01:45:36AM +0300, Francisco Jerez wrote: >> "Pohjolainen, Topi" writes: >> >> > On Fri, Feb 27, 2015 at 05:34:55PM +0200, Francisco Jerez wrote: >> >> --- >> >> src/mesa/drivers/dri/i965/brw_defines.h| 4 + >> >> src/mesa/driv

Re: [Mesa-dev] [PATCH] glsl: mark special built-in inputs referenced by vertex stage

On 30/04/15 09:27, Tapani Pälli wrote: Refactoring done on active attribute queries did not take in to account special built-in inputs for the vertex stage. This commit sets them referenced by vertex stage so that they get enumerated properly. Fixes Piglit test 'get-active-attrib-returns-all-inp

[Mesa-dev] [Bug 90213] glDrawPixels with GL_COLOR_INDEX never returns.

https://bugs.freedesktop.org/show_bug.cgi?id=90213 --- Comment #5 from Iago Toral --- Sent a couple of patches to the mailing list for review: http://lists.freedesktop.org/archives/mesa-dev/2015-May/083334.html http://lists.freedesktop.org/archives/mesa-dev/2015-May/083335.html The first one fi

[Mesa-dev] [PATCH 2/2] mesa: Always return a value in _mesa_format_from_format_and_type

Return MESA_FORMAT_NONE if no matching type was found. We have an assertion here, but we should return something anyway to avoid confusion with non-debug builds. --- src/mesa/main/glformats.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c

[Mesa-dev] [PATCH 1/2] swrast: Fix rgba_draw_pixels with GL_COLOR_INDEX

When we implemented the format conversion rewrite we forgot to handle GL_COLOR_INDEX here, which needs special handling. Fixes the following piglit test: bin/gl-1.0-drawpixels-color-index -auto -fbo Buzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90213 --- src/mesa/swrast/s_drawpix.c | 29

Re: [Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

Unfortunately mail server has purged the original patch number 13. I took a look instead in your recent image-load-store-nir branch. I studied the fence mechanism a little in bspec, and based on that I can't see anything obvious amiss. Small nit below but: Reviewed-by: Topi Pohjolainen Sorry fo

Re: [Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

On Sat, Apr 25, 2015 at 01:45:36AM +0300, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Fri, Feb 27, 2015 at 05:34:55PM +0200, Francisco Jerez wrote: > >> --- > >> src/mesa/drivers/dri/i965/brw_defines.h| 4 + > >> src/mesa/drivers/dri/i965/brw_eu.h