Re: [Mesa-dev] [PATCH 2/2] i965: Let dump_instructions() work before calculate_cfg().

2015-02-14 Thread Ben Widawsky
On Fri, Feb 13, 2015 at 10:54:06AM -0800, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 24 > src/mesa/drivers/dri/i965/brw_shader.cpp | 17 - > 2 files changed, 28 insertions(+), 13 deletions(-) > > diff --git a/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] mesa: don't enable NV_fragment_program_option with swrast

2015-02-14 Thread Roland Scheidegger
Am 14.02.2015 um 21:12 schrieb Kenneth Graunke: > On Saturday, February 14, 2015 04:37:25 PM srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Since dropping some NV_fragment_program opcodes (commits >> 868f95f1da74cf6dd7468cba1b56664aad585ccb, >> a3688d686f147f4252d19b298ae26d4ac72c2e0

Re: [Mesa-dev] [PATCH v3 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Matt Turner
Thanks Jason. The series looks good to me: Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index da81b61..3ade796 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/drive

Re: [Mesa-dev] [PATCH v2 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Jason Ekstrand
On Sat, Feb 14, 2015 at 1:26 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > index da81b61..9d5079c 100644

Re: [Mesa-dev] [PATCH v2 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Connor Abbott
Reviewed-by: Connor Abbott On Sat, Feb 14, 2015 at 4:26 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp >

[Mesa-dev] [PATCH v2 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index da81b61..9d5079c 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/driver

Re: [Mesa-dev] [PATCH 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Jason Ekstrand
On Sat, Feb 14, 2015 at 1:02 PM, Matt Turner wrote: > On Sat, Feb 14, 2015 at 1:00 PM, Connor Abbott > wrote: > > I think we should be adding this to nir_emit_system_values_block() > > like we do for the other system values. This should get us parity with > > what we had before where we only cal

Re: [Mesa-dev] [PATCH 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Jason Ekstrand
On Sat, Feb 14, 2015 at 1:06 PM, Matt Turner wrote: > On Sat, Feb 14, 2015 at 12:51 PM, Jason Ekstrand > wrote: > > --- > > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b

Re: [Mesa-dev] [PATCH 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Matt Turner
On Sat, Feb 14, 2015 at 12:51 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > index da81b61..28a5f64

Re: [Mesa-dev] [PATCH 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Matt Turner
On Sat, Feb 14, 2015 at 1:00 PM, Connor Abbott wrote: > I think we should be adding this to nir_emit_system_values_block() > like we do for the other system values. This should get us parity with > what we had before where we only called > emit_frontfacing_interpolation() once per shader. Calling

Re: [Mesa-dev] [PATCH 2/3] mesa: Add support for the ARB_pipeline_statistics_query extension

2015-02-14 Thread Ilia Mirkin
BTW, I mentioned this on IRC, but after reading the spec more carefully (for the fragment count stuff), I happened upon these 2 little tidbits: (22) What is the behavior of pipeline statistics queries returning information about primitive counts in case of legacy primitive types

Re: [Mesa-dev] [PATCH 2/3] nir: Make gl_FrontFacing a system_value

2015-02-14 Thread Connor Abbott
Patches 2 and 3 are Reviewed-by: Connor Abbott On Sat, Feb 14, 2015 at 3:51 PM, Jason Ekstrand wrote: > GLSL IR labels gl_FrontFacing as an input variable and not a system value. > This commit makes NIR silently translate gl_FrontFacing to a system value > so that it properly gets translated in

Re: [Mesa-dev] [PATCH 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Connor Abbott
I think we should be adding this to nir_emit_system_values_block() like we do for the other system values. This should get us parity with what we had before where we only called emit_frontfacing_interpolation() once per shader. On Sat, Feb 14, 2015 at 3:51 PM, Jason Ekstrand wrote: > --- > src/m

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_has_compute_shaders

2015-02-14 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sat, Feb 14, 2015 at 3:53 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/main/context.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h > index d902ea7..34799ba 100644

[Mesa-dev] [PATCH 1/3] mesa: Add _mesa_has_compute_shaders

2015-02-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/context.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index d902ea7..34799ba 100644 --- a/src/mesa/main/context.h +++ b/src/mesa/main/context.h @@ -326,6 +326,17 @@ _mesa_has_geom

[Mesa-dev] [PATCH 2/3] nir: Make gl_FrontFacing a system_value

2015-02-14 Thread Jason Ekstrand
GLSL IR labels gl_FrontFacing as an input variable and not a system value. This commit makes NIR silently translate gl_FrontFacing to a system value so that it properly gets translated into a load_system_value intrinsic. --- src/glsl/nir/glsl_to_nir.cpp | 10 -- 1 file changed, 8 insertion

[Mesa-dev] [PATCH 3/3] i965/nir: Don't support gl_FrontFacing as an input variable

2015-02-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 28a5f64..119cc84 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH 1/3] i965/nir: Add support for nir_intrinsic_load_front_face

2015-02-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index da81b61..28a5f64 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/d

Re: [Mesa-dev] [PATCH] mesa: don't enable NV_fragment_program_option with swrast

2015-02-14 Thread Kenneth Graunke
On Saturday, February 14, 2015 04:37:25 PM srol...@vmware.com wrote: > From: Roland Scheidegger > > Since dropping some NV_fragment_program opcodes (commits > 868f95f1da74cf6dd7468cba1b56664aad585ccb, > a3688d686f147f4252d19b298ae26d4ac72c2e08) > we can no longer parse all opcodes necessary for

Re: [Mesa-dev] [PATCH 1/2] st/mesa: treat resource-less xfb buffers as if they weren't there

2015-02-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Feb 14, 2015 at 7:46 AM, Ilia Mirkin wrote: > If a transform feedback buffer's size is 0, st_bufferobj_data doesn't > end up creating a buffer for it. There's no point in trying to write to > such a buffer, so just pretend as if it's not really there. > >

Re: [Mesa-dev] [PATCH] st/mesa: add ARB_pipeline_statistics_query support

2015-02-14 Thread Marek Olšák
I only know that it works on r600g and radeonsi. Not sure about the other drivers. Marek On Sat, Feb 14, 2015 at 7:18 PM, Ilia Mirkin wrote: > On Sat, Feb 14, 2015 at 1:11 PM, Marek Olšák wrote: >> Reviewed-by: Marek Olšák >> >> Could you please update the release notes as well (mentioning all

Re: [Mesa-dev] [PATCH] st/mesa: add ARB_pipeline_statistics_query support

2015-02-14 Thread Ilia Mirkin
On Sat, Feb 14, 2015 at 1:11 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Could you please update the release notes as well (mentioning all > drivers supporting it)? Will do. By my count, that's ilo (but usually not mentioned in release notes) nvc0 r600 radeonsi softpipe -ilia _

Re: [Mesa-dev] [PATCH] st/mesa: add ARB_pipeline_statistics_query support

2015-02-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Could you please update the release notes as well (mentioning all drivers supporting it)? Thanks, Marek On Sat, Feb 14, 2015 at 8:16 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > This applies on top of Ben Widawsky's patch series. Mildly tested on > n

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_has_compute_shaders

2015-02-14 Thread Ilia Mirkin
On Sat, Feb 14, 2015 at 3:33 AM, Jordan Justen wrote: > On 2015-02-13 23:13:01, Ilia Mirkin wrote: >> On Sat, Feb 14, 2015 at 2:02 AM, Ben Widawsky >> wrote: >> > From: Jordan Justen >> > >> > Signed-off-by: Jordan Justen >> > Reviewed-by: Ben Widawsky >> > --- >> > src/mesa/main/context.h |

Re: [Mesa-dev] [PATCH v2] auxiliary/vl: bring back the VL code for the dri targets

2015-02-14 Thread Jon TURNEY
On 10/02/2015 22:29, Emil Velikov wrote: With commit c642e87d9f4(auxiliary/vl: rework the build of the VL code) we split out the VL code into a separate static library that was meant to be used by the VL targets alone - va, vdpau, xvmc. The commit failed to consider the way we handle vdpau-gl in

Re: [Mesa-dev] [PATCH] mesa: don't enable NV_fragment_program_option with swrast

2015-02-14 Thread Roland Scheidegger
Actually I think you can forget the second part of the comment. It seems we still use some hacks internally to parse such shaders, even if they aren't officially supported (though I don't know if they also relied on the dropped opcodes). I guess though the NV_fragment_program_option in the context

[Mesa-dev] [PATCH] mesa: don't enable NV_fragment_program_option with swrast

2015-02-14 Thread sroland
From: Roland Scheidegger Since dropping some NV_fragment_program opcodes (commits 868f95f1da74cf6dd7468cba1b56664aad585ccb, a3688d686f147f4252d19b298ae26d4ac72c2e08) we can no longer parse all opcodes necessary for this extension, leading to bugs (https://bugs.freedesktop.org/show_bug.cgi?id=869

[Mesa-dev] [PATCH 1/8 v3] mesa: Add missing error checks to GetProgramInfoLog, GetShaderInfoLog and GetProgramiv

2015-02-14 Thread Eduardo Lima Mitev
Fixes 3 dEQP tests: * dEQP-GLES3.functional.negative_api.state.get_program_info_log * dEQP-GLES3.functional.negative_api.state.get_shader_info_log * dEQP-GLES3.functional.negative_api.state.get_programiv --- src/mesa/main/shaderapi.c | 38 -- 1 file changed, 32

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_has_compute_shaders

2015-02-14 Thread Jordan Justen
On 2015-02-13 23:13:01, Ilia Mirkin wrote: > On Sat, Feb 14, 2015 at 2:02 AM, Ben Widawsky > wrote: > > From: Jordan Justen > > > > Signed-off-by: Jordan Justen > > Reviewed-by: Ben Widawsky > > --- > > src/mesa/main/context.h | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff