Jason Ekstrand writes:
> I've got a patch I cooked up today that generalizes this a bit. I haven't
> sent it yet because it lacks shader-db statistics. That said, I'm fine
> with merging this in the mean time.
Not sure what generalization you're working on, but something that let
me have "any
Connor Abbott writes:
> Hi Eric,
>
> A general suggestion:
>
> I think that we should rename these functions to "nir_op_create()" so
> that we can make a more specific "nir_op()" function that takes and
> returns a nir_ssa_def *, so that we can do stuff like:
>
> nir_builder *b = ...
>
> nir_ssa_
On Tue, Jan 27, 2015 at 11:24 PM, Jonathan Gray wrote:
> Including under __GNUC__ is going to break the build of
> Mesa on everything compiled with clang/gcc that isn't Linux.
Good point, I'll add a configure check for futex.
thanks,
Kristian
___
mesa
Hi Eric,
A general suggestion:
I think that we should rename these functions to "nir_op_create()" so
that we can make a more specific "nir_op()" function that takes and
returns a nir_ssa_def *, so that we can do stuff like:
nir_builder *b = ...
nir_ssa_def *new_index = nir_iadd(b, nir_imul(b, o
Reviewed-by: Jason Ekstrand
On Wed, Jan 28, 2015 at 5:50 PM, Matt Turner wrote:
> On Wed, Jan 28, 2015 at 5:08 PM, Eric Anholt wrote:
> > This will be used by tgsi_to_nir, which needs to get vec4 types for
> > declaring shader input/output variables.
> > ---
> > src/glsl/nir/nir_types.cpp | 1
Reviewed-by: Jason Ekstrand
On Wed, Jan 28, 2015 at 5:08 PM, Eric Anholt wrote:
> ---
> src/glsl/nir/nir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c
> index 25cdac0..10e6ed3 100644
> --- a/src/glsl/nir/nir.c
> +++ b/src/gls
I'm not super-familiar with Connor's to-SSA pass, but I think that does
what you want.
Reviewed-by: Jason Ekstrand
On Wed, Jan 28, 2015 at 5:09 PM, Eric Anholt wrote:
> ---
> The i965 driver apparently only has things all in ssa or all in non-ssa,
> while
> for TGSI I ended up doing some thing
On 29.01.2015 00:37, Emil Velikov wrote:
>
> February 20th 2015 - Release candidate 3
> February 20th 2015 - Release candidate 4
I assume you meant February 27th for rc4. :)
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast |
I've got a patch I cooked up today that generalizes this a bit. I haven't
sent it yet because it lacks shader-db statistics. That said, I'm fine
with merging this in the mean time.
--Jason
On Wed, Jan 28, 2015 at 5:48 PM, Matt Turner wrote:
> Reviewed-by: Matt Turner
> ___
>>
>> On 29 August 2014 08:46, Gwenole Beauchesne wrote:
>>>
>>> Could you please describe in there the ownership model? I think the
>>> implementation should own the fd, so the clients should dup() it if
>>> ever necessary.
>>
>>
>> So the fd can be destroyed at any time, particularly with thread
(oops pushed send too quick)
> So there is resistance to a query API upstream in the KHR area, at
> least according
> to https://www.khronos.org/registry/egl/extensions/MESA/EGL_MESA_drm_image.txt
> which I based this on.
>
> So I'm wondering how would this API look if we are going to pass back
> m
On 29/01/15 01:08, Eric Anholt wrote:
> v2: Rebase on the nir_opcodes.h python code generation support.
> v3: Use SSA values, and set an appropriate writemask on dot products.
> ---
> src/glsl/Makefile.am | 5 ++
> src/glsl/nir/.gitignore | 1 +
> src/glsl/nir/nir_
On Wed, Jan 28, 2015 at 5:08 PM, Eric Anholt wrote:
> This will be used by tgsi_to_nir, which needs to get vec4 types for
> declaring shader input/output variables.
> ---
> src/glsl/nir/nir_types.cpp | 12
> src/glsl/nir/nir_types.h | 3 +++
> 2 files changed, 15 insertions(+)
>
>
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
We end up with these from TGSI-to-NIR because the pass generating the
comparisons doesn't know if the arg is actually a bool input or not.
total instructions in shared programs: 41801 -> 41508 (-0.70%)
instructions in affected programs: 4253 -> 3960 (-6.89%)
---
src/glsl/nir/nir_opt_algebraic
---
The i965 driver apparently only has things all in ssa or all in non-ssa, while
for TGSI I ended up doing some things directly in SSA before the to-SSA pass.
src/glsl/nir/nir_to_ssa.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glsl/nir/nir_to_ssa.c b/src/glsl/nir/nir_to_ssa.c
in
v2: Rebase on the nir_opcodes.h python code generation support.
v3: Use SSA values, and set an appropriate writemask on dot products.
---
src/glsl/Makefile.am | 5 ++
src/glsl/nir/.gitignore | 1 +
src/glsl/nir/nir_builder.h| 95
---
src/glsl/nir/nir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c
index 25cdac0..10e6ed3 100644
--- a/src/glsl/nir/nir.c
+++ b/src/glsl/nir/nir.c
@@ -1295,7 +1295,7 @@ nir_instr_insert_before_cf(nir_cf_node *node, nir_instr
*before)
This will be used by tgsi_to_nir, which needs to get vec4 types for
declaring shader input/output variables.
---
src/glsl/nir/nir_types.cpp | 12
src/glsl/nir/nir_types.h | 3 +++
2 files changed, 15 insertions(+)
diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cp
Matt Turner writes:
> On Tue, Jan 27, 2015 at 5:31 PM, Jason Ekstrand wrote:
>> + emit(MUL(acc, op[0], op[1]));
>> + emit(MACH(reg_null_d, op[0], op[1]));
>> + emit(MOV(result, fs_reg(acc)));
>>break;
>> }
>>
>> @@ -773,72 +767,38 @@ fs_visitor::nir_emit_alu(nir_alu_in
On Wed, Jan 28, 2015 at 4:28 PM, Ian Romanick wrote:
> On 01/27/2015 05:31 PM, Jason Ekstrand wrote:
> > v2 Jason Ekstrand :
> > - Add better comments
> > - Use nir_ssa_dest_init and nir_src_for_ssa more places
> > - Fix some void * casts
> >
> > v3 Jason Ekstrand :
> > - Rework the way we de
On 01/27/2015 05:31 PM, Jason Ekstrand wrote:
> v2 Jason Ekstrand :
> - Add better comments
> - Use nir_ssa_dest_init and nir_src_for_ssa more places
> - Fix some void * casts
>
> v3 Jason Ekstrand :
> - Rework the way we determine whether or not to sccalarize a phi node to
>make the recur
On Wed, Jan 28, 2015 at 4:02 PM, Matt Turner wrote:
> On Tue, Jan 27, 2015 at 5:31 PM, Jason Ekstrand
> wrote:
> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> > index de0d780..217fe09 100644
> > @@ -689,9 +689,9 @@ fs_visitor::nir_emit_alu
On Tue, Jan 27, 2015 at 5:31 PM, Jason Ekstrand wrote:
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index de0d780..217fe09 100644
> @@ -689,9 +689,9 @@ fs_visitor::nir_emit_alu(nir_alu_instr *instr)
>
>struct brw_reg acc = retype(b
On 01/28/2015 02:04 PM, Matt Turner wrote:
> On Wed, Jan 28, 2015 at 1:53 PM, Ian Romanick wrote:
>> On 01/28/2015 11:51 AM, Matt Turner wrote:
>>> What I'm asking is whether we suspect that they specifically want
>>> half-up behavior (speculation, so not likely insightful), or if
>>> there's a wa
On Wed, Jan 28, 2015 at 1:53 PM, Ian Romanick wrote:
> On 01/28/2015 11:51 AM, Matt Turner wrote:
>> What I'm asking is whether we suspect that they specifically want
>> half-up behavior (speculation, so not likely insightful), or if
>> there's a way we can emulate round-half-up behavior using rou
On 01/28/2015 11:51 AM, Matt Turner wrote:
> On Wed, Jan 28, 2015 at 11:20 AM, Ian Romanick wrote:
>> On 01/28/2015 10:31 AM, Matt Turner wrote:
>>> Note: this will round differently for x.5 where x is even.
>>>
>>> total instructions in shared programs: 5953897 -> 5948654 (-0.09%)
>>> instruction
On Wed, Jan 28, 2015 at 1:30 PM, Adam Jackson wrote:
> a001 and a011 are pineview chips. Say so.
>
> Signed-off-by: Adam Jackson
Sorry you have to work with those.
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
htt
a001 and a011 are pineview chips. Say so.
Signed-off-by: Adam Jackson
---
include/pci_ids/i915_pci_ids.h| 4 ++--
src/mesa/drivers/dri/i915/intel_chipset.h | 14 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/pci_ids/i915_pci_ids.h b/include/p
On Wed, Jan 28, 2015 at 12:46 PM, Jason Ekstrand wrote:
> This reverts commit d7d340fb2f68c46bd5a0008ecf53c6693e29c916.
>
> We have an isnormal() implementation available, the only problem was that
> we had the wrong return type (fixed in a later patch).
I'd put patch 3 first, so that you don't r
The rest of the series seems reasonable although I'm not an expert,
but this one is definitely
Reviewed-by: Connor Abbott
On Wed, Jan 28, 2015 at 3:46 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_opcodes.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl
https://bugs.freedesktop.org/show_bug.cgi?id=88852
--- Comment #1 from Jason Ekstrand ---
I just sent 3 patches to the list to fix this. Could you please try them.
They're also on my wip/fix-ldexp branch.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the
This reverts commits d6eb572905e39c36168b8f5da240af961f9dde0a and
58e8468d113c7d3d4a59ea4a8d70fd45b78e85e6.
This is no longer necessary as we aren't using it in NIR anymore. Also, it
broke the build on some strange systems so let's put it back in querymatrix
where it came from.
---
src/mesa/main
This reverts commit d7d340fb2f68c46bd5a0008ecf53c6693e29c916.
We have an isnormal() implementation available, the only problem was that
we had the wrong return type (fixed in a later patch).
---
src/glsl/nir/nir_opcodes.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gl
---
src/glsl/nir/nir_opcodes.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py
index f54a017..77f3bb8 100644
--- a/src/glsl/nir/nir_opcodes.py
+++ b/src/glsl/nir/nir_opcodes.py
@@ -477,7 +477,7 @@ else
dst = ((1 <<
https://bugs.freedesktop.org/show_bug.cgi?id=88852
Bug ID: 88852
Summary: macros.h(181) : error C2143: syntax error : missing
'{' before 'enum [tag]'
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: W
https://bugs.freedesktop.org/show_bug.cgi?id=88806
Vinson Lee changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bugs.freedesktop.org/show_bug.cgi?id=79706
Bug 79706 depends on bug 88806, which changed state.
Bug 88806 Summary: nir/nir_constant_expressions.c:2754:15: error: controlling
expression type 'unsigned int' not compatible with any generic association type
https://bugs.freedesktop.org/show_b
On Wed, Jan 28, 2015 at 11:20 AM, Ian Romanick wrote:
> On 01/28/2015 10:31 AM, Matt Turner wrote:
>> Note: this will round differently for x.5 where x is even.
>>
>> total instructions in shared programs: 5953897 -> 5948654 (-0.09%)
>> instructions in affected programs: 88619 -> 83376 (-5.92%
https://bugs.freedesktop.org/show_bug.cgi?id=88851
Jason Ekstrand changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
On Wednesday 28 January 2015 11:20:10 Tom Stellard wrote:
> On Wed, Jan 28, 2015 at 10:44:57AM -0800, Jason Ekstrand wrote:
> > The problem is that the fallbacks we have at the moment don't work in C++.
> > While we could theoretically fix the fallbacks it would also raise the
> > issue of correctl
On 01/28/2015 10:31 AM, Matt Turner wrote:
> Note: this will round differently for x.5 where x is even.
>
> total instructions in shared programs: 5953897 -> 5948654 (-0.09%)
> instructions in affected programs: 88619 -> 83376 (-5.92%)
> helped:696
> ---
> If we
On Wed, Jan 28, 2015 at 10:44:57AM -0800, Jason Ekstrand wrote:
> The problem is that the fallbacks we have at the moment don't work in C++.
> While we could theoretically fix the fallbacks it would also raise the
> issue of correctly detecting the fpclassify function. So, for now, we'll
> just di
https://bugs.freedesktop.org/show_bug.cgi?id=88851
--- Comment #2 from Fabio Pedretti ---
I cannot test (posting from a phone) until some days. But if you commit it I
can check if it passes the next automatically scheduled build.
--
You are receiving this mail because:
You are the QA Contact fo
https://bugs.freedesktop.org/show_bug.cgi?id=88851
Jason Ekstrand changed:
What|Removed |Added
Status|NEW |NEEDINFO
Assignee|mesa-dev@li
https://bugs.freedesktop.org/show_bug.cgi?id=88851
Bug ID: 88851
Summary: clover build failure - error: expected identifier
before numeric constant
Product: Mesa
Version: git
Hardware: All
OS: Linux (All)
The problem is that the fallbacks we have at the moment don't work in C++.
While we could theoretically fix the fallbacks it would also raise the
issue of correctly detecting the fpclassify function. So, for now, we'll
just disable it until we actually have a C++ user.
Reported-by: Tom Stellard
https://bugs.freedesktop.org/show_bug.cgi?id=88850
Bug ID: 88850
Summary: Wrong samplerbuffer fails silently
Product: Mesa
Version: 10.4
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: norma
Note: this will round differently for x.5 where x is even.
total instructions in shared programs: 5953897 -> 5948654 (-0.09%)
instructions in affected programs: 88619 -> 83376 (-5.92%)
helped:696
---
If we implemented round() differently from roundEven(), we sho
https://bugs.freedesktop.org/show_bug.cgi?id=87076
Sven Arvidsson changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=77449
Bug 77449 depends on bug 87076, which changed state.
Bug 87076 Summary: Dead Island needs allow_glsl_extension_directive_midshader
https://bugs.freedesktop.org/show_bug.cgi?id=87076
What|Removed |Added
-
On Wednesday, January 28, 2015 01:14:08 PM Syrja, Harri wrote:
> Hi Kenneth,
>
> Constant cache could and should allocate to separate region in $L3. The main
> point of having separate constant region is to avoid texture data trashing
> due to pulled constants load. In optimal solution constant
Hi all,
Here is my preliminary plan for the mesa 10.5.0 release
February 6th 2015 - Feature freeze/Release candidate 1
February 13st 2015 - Release candidate 2
February 20th 2015 - Release candidate 3
February 20th 2015 - Release candidate 4
March 6th 2015 - Release candidate 5/Mesa 10.5.0
This
Hi Kenneth,
Constant cache could and should allocate to separate region in $L3. The main
point of having separate constant region is to avoid texture data trashing due
to pulled constants load. In optimal solution constant region is allocated only
when shader uses pull constants, but that is no
Pushed, thanks.
Marek
On Mon, Dec 8, 2014 at 7:43 PM, Sven Arvidsson wrote:
> Signed-off-by: Sven Arvidsson
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87076
> ---
> src/mesa/drivers/dri/common/drirc | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri
https://bugs.freedesktop.org/show_bug.cgi?id=88275
--- Comment #28 from Eugene ---
(In reply to Jason Ekstrand from comment #26)
> I tried this on a pineview machine which is i915 not 865 but it works fine,
> so this doesn't look a generic driver change.
As I understood configuration you tried n
On Wed, 2015-01-28 at 13:39 +0100, Iago Toral wrote:
> On Wed, 2015-01-28 at 10:48 +0100, Iago Toral wrote:
> > Hi,
> >
> > I think I have found a bug that can even produce a GPU hang in the i965
> > code that handles 1DArray textures and that is related to the miptree
> > structure that supports
On Wed, 2015-01-28 at 10:48 +0100, Iago Toral wrote:
> Hi,
>
> I think I have found a bug that can even produce a GPU hang in the i965
> code that handles 1DArray textures and that is related to the miptree
> structure that supports them. At least IvyBridge and Haswell are
> affected.
>
> The pro
https://bugs.freedesktop.org/show_bug.cgi?id=79706
Bug 79706 depends on bug 88806, which changed state.
Bug 88806 Summary: nir/nir_constant_expressions.c:2754:15: error: controlling
expression type 'unsigned int' not compatible with any generic association type
https://bugs.freedesktop.org/show_b
https://bugs.freedesktop.org/show_bug.cgi?id=88806
Jason Ekstrand changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=88841
---
src/mesa/drivers/dri/i965/intel_pixel_read.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c
b/src/mesa/drivers/dri/i965/intel_pixel_read.c
index babf8ca..198d616 100644
--- a/src/
Cc: Chad Versace
---
src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 30 +-
src/mesa/drivers/dri/i965/intel_tiled_memcpy.h | 4 ++--
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c
b/src/mesa/drivers/dri/i9
Thanks Eric,
Reviewed-by: Marek Olšák
Marek
On Mon, Jan 26, 2015 at 8:45 PM, Eric Anholt wrote:
> The idea is that after a remove_from_list(), you might want to be able to
> do a remove_from_list() on it again or an is_empty_list(). This is
> apparently relied on by r300g.
> ---
> src/util/s
Kenneth Graunke writes:
> On Sunday, January 18, 2015 01:04:02 AM Francisco Jerez wrote:
>> This is the first part of a series meant to improve our usage of the L3
>> cache.
>> Currently it's far from ideal since the following objects aren't taking any
>> advantage of it:
>> - Pull constants (i
Hi,
I think I have found a bug that can even produce a GPU hang in the i965
code that handles 1DArray textures and that is related to the miptree
structure that supports them. At least IvyBridge and Haswell are
affected.
The problem happens when we need to drop the initial miptree to create a
new
65 matches
Mail list logo
