[Mesa-dev] [PATCH 1/2] nvc0/ir: use manual TXD when offsets are involved

2014-07-04 Thread Ilia Mirkin
Something about how we're implementing offsets for TXD is wrong, just flip to the generic quadop-based implementation in that case. This is the minimal fix appropriate for backporting. Signed-off-by: Ilia Mirkin Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 3 ++- 1 f

[Mesa-dev] [PATCH 2/2] nvc0/ir: fill offset in properly for TXD

2014-07-04 Thread Ilia Mirkin
Apparently TXD wants its offset differently than TEX, accepting it in the upper bits of the layer index. Unclear what happens when this is combined with indirect sampler indexing. Signed-off-by: Ilia Mirkin --- .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 47 -- 1 fil

Re: [Mesa-dev] [PATCH 11/13] i965: Make backend_instruction usable from C.

2014-07-04 Thread Matt Turner
On Wed, Jul 2, 2014 at 6:59 AM, Pohjolainen, Topi wrote: > On Mon, Jun 30, 2014 at 02:40:42PM -0700, Matt Turner wrote: >> With a hack to place an exec_node in the struct in C to be at the same >> location as the inherited exec_node in C++. > > Are you planning to eventually have one but not the o

[Mesa-dev] [PATCH] nvc0: do quadops on the right texture coordinates for TXD

2014-07-04 Thread Ilia Mirkin
handleTEX moves the layer as the first argument. This makes sure that the quadops deal with the texture coordinates. Signed-off-by: Ilia Mirkin Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gall

[Mesa-dev] [PATCH 1/3] gallium: switch dedicated centroid field to interpolation location

2014-07-04 Thread Ilia Mirkin
The new location field can be either center, centroid, or sample, which indicates the location that the shader should interpolate at. Signed-off-by: Ilia Mirkin --- I tried to make sure I hit all the uses, but I guess a bunch of drivers don't look at the Centroid field at all? src/gallium/auxi

[Mesa-dev] [PATCH 3/3] tgsi: add interpolation location modifier support to text parser

2014-07-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- nouveau_compiler standalone binary uses the text representation for shader input, so this is necessary to be able to test the centroid/sample stuff src/gallium/auxiliary/tgsi/tgsi_text.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/ga

[Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-04 Thread Ilia Mirkin
This enables a gallium driver not to care about the semantics of ARB_sample_shading vs ARB_gpu_shader5 sample attributes. When ARB_sample_shading-style sample shading is enabled, all of the fp inputs are marked for interpolation at the sample location. Signed-off-by: Ilia Mirkin --- I _think_ I

[Mesa-dev] [Bug 80933] New: Fullscreen OpenGL programs (e.g. games) crash if focus lost then regained, something to do with automatic compositing suspension

2014-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80933 Priority: medium Bug ID: 80933 Assignee: mesa-dev@lists.freedesktop.org Summary: Fullscreen OpenGL programs (e.g. games) crash if focus lost then regained, something to do with automat

[Mesa-dev] [PATCH 2/2] nv50/ir: ignore bias for samplerCubeShadow on nv50

2014-07-04 Thread Ilia Mirkin
Unfortunately there's no good way to do this on the nv50 shader isa. Dropping the bias seems preferable to doing the compare post-filtering. Signed-off-by: Ilia Mirkin Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nv50.cpp | 10 ++ 1 file changed, 10 insertions(+) diff -

[Mesa-dev] [PATCH 1/2] nv50/ir: retrieve shadow compare from first arg

2014-07-04 Thread Ilia Mirkin
This can only happen with texture(samplerCubeShadow, bias), where the compare will be in the first argument. Signed-off-by: Ilia Mirkin Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouve

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix samplerCubeShadow with bias

2014-07-04 Thread Ilia Mirkin
Ah yes, my bad. I did try to look at all the stuff, but it doesn't help that e.g. the texture man page is wrong for samplerCubeShadow (http://www.opengl.org/sdk/docs/man/html/texture.xhtml -- it lists the argument as vec3... I did double-check in the GL 4.4 spec, and it's correct there with a vec4)

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix samplerCubeShadow with bias

2014-07-04 Thread Marek Olšák
samplerCubeArrayShadow cannot be used with lod and bias in GLSL 4.40, so it's impossible to get TXL or TXB with it. Some sampler types are more limited than others. For example, samplerCubeArrayShadow can only be used with this: float texture(gsamplerCubeArrayShadow sampler, vec4 P, float compare

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix samplerCubeShadow with bias

2014-07-04 Thread Ilia Mirkin
On Fri, Jul 4, 2014 at 3:30 PM, Ilia Mirkin wrote: > On Fri, Jul 4, 2014 at 2:49 PM, Ilia Mirkin wrote: >> On Fri, Jul 4, 2014 at 8:10 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> It has 5 coordinates: (x,y,z,depth,lodbias) >>> >>> Cc: mesa-sta...@lists.freedesktop.org >> >> Reviewed-by

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix samplerCubeShadow with bias

2014-07-04 Thread Ilia Mirkin
On Fri, Jul 4, 2014 at 2:49 PM, Ilia Mirkin wrote: > On Fri, Jul 4, 2014 at 8:10 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> It has 5 coordinates: (x,y,z,depth,lodbias) >> >> Cc: mesa-sta...@lists.freedesktop.org > > Reviewed-by: Ilia Mirkin > > Although I still haven't worked out what el

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix samplerCubeShadow with bias

2014-07-04 Thread Ilia Mirkin
On Fri, Jul 4, 2014 at 8:10 AM, Marek Olšák wrote: > From: Marek Olšák > > It has 5 coordinates: (x,y,z,depth,lodbias) > > Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Ilia Mirkin Although I still haven't worked out what else is wrong with nouveau... nv50 hits an assert, while nvc0 just

[Mesa-dev] [PATCH 1/1] gallivm, llvmpipe: Handle MSAA textures in emit_fetch_texels in a preliminary fashion to prevent a crash in a Piglit test.

2014-07-04 Thread Darius Goad
--- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c index 3d7df3e..4bf9242 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c +++ b/src

Re: [Mesa-dev] [PATCH 1/2] R600/SI: fix shadow mapping for 1D and 2D array textures

2014-07-04 Thread Tom Stellard
On Thu, Jul 03, 2014 at 06:26:04PM +0200, Marek Olšák wrote: > From: Marek Olšák Reviewed-by: Tom Stellard > > It was conflicting with def TEX_SHADOW_ARRAY, which also handles them. > --- > lib/Target/R600/R600Instructions.td | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

[Mesa-dev] [PATCH v3 2/2] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-04 Thread Neil Roberts
Here is version 3 of the glClearTexImage implementation. I figured out I could avoid the whole issue of preserving the glClearColor state by using glClearBuffer instead of glClear. I think the patch is a lot neater this way. I also fixed using sRGB textures and explicitly disabled dithering. - Ne

[Mesa-dev] [PATCH 1/2] meta: Add a state flag for the GL_DITHER

2014-07-04 Thread Neil Roberts
The Meta implementation of glClearTexSubImage is going to want to ensure that dithering is disabled so that it can get a consistent color across the whole texture when clearing. This adds a state flag to easily save it and set it to the default value when performing meta operations. --- src/mesa/d

Re: [Mesa-dev] [PATCH] gallium: fix u_default_transfer_inline_write for textures

2014-07-04 Thread Roland Scheidegger
Am 03.07.2014 18:29, schrieb Marek Olšák: > From: Marek Olšák > > This doesn't fix any known issue. In fact, radeon drivers ignore all > the discard flags for textures and implicitly do "discard range" > for any write transfer. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/gallium/auxil

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-04 Thread Tom Stellard
On Fri, Jul 04, 2014 at 05:25:42PM +0200, Francisco Jerez wrote: > Tom Stellard writes: > > > On Fri, Jul 04, 2014 at 12:28:05PM +0200, Francisco Jerez wrote: > >> Tom Stellard writes: > >> > >> > On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: > >> >> Tom Stellard writes: > >

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-04 Thread Francisco Jerez
Tom Stellard writes: > On Fri, Jul 04, 2014 at 12:28:05PM +0200, Francisco Jerez wrote: >> Tom Stellard writes: >> >> > On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: >> >> Tom Stellard writes: >> >> >> >> > On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: >>

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-04 Thread Tom Stellard
On Fri, Jul 04, 2014 at 12:28:05PM +0200, Francisco Jerez wrote: > Tom Stellard writes: > > > On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: > >> Tom Stellard writes: > >> > >> > On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: > >> >> Tom Stellard writes: > >

Re: [Mesa-dev] What are some good beginner's tasks for Mesa?

2014-07-04 Thread Tom Stellard
On Thu, Jul 03, 2014 at 10:33:41PM -0500, Darius Goad wrote: > Hello. I'm trying to get my feet wet with Mesa, and I was wondering > what some good tasks for me would be. Thanks again. > What hardware do you have? What are you interested in working on? -Tom > - Darius Goad > __

Re: [Mesa-dev] [PATCH v2 5/5] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-04 Thread Neil Roberts
"Pohjolainen, Topi" writes: > Oh, I didn't realize that. Should we fix and put this into > _mesa_meta_begin/_mesa_meta_end instead? Yes, perhaps that would be a good idea. I will try writing a separate patch for that. Thinking about it a bit more I also realised I'm not handling sRGB textures c

[Mesa-dev] [PATCH 1/2] st/mesa: fix samplerCubeShadow with bias

2014-07-04 Thread Marek Olšák
From: Marek Olšák It has 5 coordinates: (x,y,z,depth,lodbias) Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_g

[Mesa-dev] [PATCH 2/2] radeonsi: fix samplerCubeShadow with bias

2014-07-04 Thread Marek Olšák
From: Marek Olšák Pack the depth value before overwriting it with cube coordinates. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_shader.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-04 Thread Emil Velikov
On 3 July 2014 10:48, Boris BREZILLON wrote: [snip] > Perfect! > Emil, could you add me in Cc of this future submission ? > Of course :) -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-de

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-04 Thread Francisco Jerez
Tom Stellard writes: > On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: >> Tom Stellard writes: >> >> > On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: >> >> Tom Stellard writes: >> >> >> >> > On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: >>

Re: [Mesa-dev] [PATCH 8/9] i965: Check after malloc success in intel_miptree_alloc_hiz()

2014-07-04 Thread Juha-Pekka Heikkila
On 04.07.2014 00:21, Kenneth Graunke wrote: > On Thursday, July 03, 2014 11:13:18 AM Juha-Pekka Heikkila wrote: >> Signed-off-by: Juha-Pekka Heikkila >> --- >> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/i

Re: [Mesa-dev] [PATCH 2/9] i965: check malloc return value in intel_resolve_map_set()

2014-07-04 Thread Juha-Pekka Heikkila
On 04.07.2014 00:29, Kenneth Graunke wrote: > On Thursday, July 03, 2014 11:13:12 AM Juha-Pekka Heikkila wrote: >> Signed-off-by: Juha-Pekka Heikkila >> --- >> src/mesa/drivers/dri/i965/intel_resolve_map.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH demos 1/2] demos: Fix make distcheck

2014-07-04 Thread Andreas Boll
Signed-off-by: Andreas Boll --- src/xdemos/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/xdemos/Makefile.am b/src/xdemos/Makefile.am index 0bdf13d..cfd23b1 100644 --- a/src/xdemos/Makefile.am +++ b/src/xdemos/Makefile.am @@ -79,7 +79,8 @@ xrotfontdemo_SOURC

[Mesa-dev] [PATCH demos 2/2] configure.ac: Fix help text

2014-07-04 Thread Andreas Boll
Matches behavior with action-if-not-given Signed-off-by: Andreas Boll --- configure.ac | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index cd523c1..09c2cd5 100644 --- a/configure.ac +++ b/configure.ac @@ -111,7 +111,7 @@ DEMO_L

Re: [Mesa-dev] [PATCH 7/9] i965: Avoid null access in fs_generator::generate_code()

2014-07-04 Thread Pohjolainen, Topi
On Thu, Jul 03, 2014 at 05:31:19PM +0300, Juha-Pekka Heikkila wrote: > On 03.07.2014 16:26, Pohjolainen, Topi wrote: > > On Thu, Jul 03, 2014 at 11:13:17AM +0300, Juha-Pekka Heikkila wrote: > >> Avoid null access while printing debug infos. On the same go > >> change local variable name to avoid co

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-04 Thread Steven Newbury
On Fri, 2014-07-04 at 03:40 -0400, Ilia Mirkin wrote: > On Fri, Jul 4, 2014 at 3:37 AM, Steven Newbury > wrote: > > On Thu, 2014-07-03 at 10:47 +0200, Andreas Boll wrote: > > > 2014-07-03 7:39 GMT+02:00 Steven Newbury > > > : > > > > On Wed, 2014-07-02 at 21:04 +0200, Andreas Boll wrote: > >

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-04 Thread Ilia Mirkin
On Fri, Jul 4, 2014 at 3:37 AM, Steven Newbury wrote: > On Thu, 2014-07-03 at 10:47 +0200, Andreas Boll wrote: >> 2014-07-03 7:39 GMT+02:00 Steven Newbury : >> > On Wed, 2014-07-02 at 21:04 +0200, Andreas Boll wrote: >> > > >> > > I'd like to make a new demos release on Friday, July 4th. >> > >

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-04 Thread Steven Newbury
On Thu, 2014-07-03 at 10:47 +0200, Andreas Boll wrote: > 2014-07-03 7:39 GMT+02:00 Steven Newbury : > > On Wed, 2014-07-02 at 21:04 +0200, Andreas Boll wrote: > > > > > > I'd like to make a new demos release on Friday, July 4th. > > > The last release was on February 24th, 2013. Additionally thi

Re: [Mesa-dev] [PATCH 4/6] i965/gen7: Don't allocate hiz miptree structure

2014-07-04 Thread Kenneth Graunke
On Wednesday, July 02, 2014 12:33:16 PM Jordan Justen wrote: > On Wed, Jul 2, 2014 at 5:39 AM, Pohjolainen, Topi > wrote: > > On Tue, Jul 01, 2014 at 04:53:06PM -0700, Jordan Justen wrote: > >> We now skip allocating a hiz miptree for gen7. Instead, we calculate > >> the required hiz buffer parame

Re: [Mesa-dev] [PATCH 1/2] glxinfo: remove query of GL_MAX_VERTEX_ATTRIB_STRIDE

2014-07-04 Thread Andreas Boll
Both patches are Reviewed-by: Andreas Boll Thanks for fixing this issue! I'll make the release after this series has been merged. Andreas. 2014-07-03 16:19 GMT+02:00 Brian Paul : > This is not part of the GL_ARB_vertex_attrib_binding extension. > It's part of OpenGL 4.4. > Fixes compilation fai