Re: [Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

2014-06-21 Thread Chris Forbes
In the indirect case we can possibly just adjust the indirect setup code to write the uniform with MI_SRM, if we know where it will be -- so not too awful -- but it is different. On Sun, Jun 22, 2014 at 1:59 PM, Marek Olšák wrote: > That's right. A uniform won't work with ARB_draw_indirect unless

Re: [Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

2014-06-21 Thread Marek Olšák
That's right. A uniform won't work with ARB_draw_indirect unless you lower it to direct draws, which would be very bad if it was applied to all drivers. Radeonsi indeed supports BaseVertex and BaseInstance as system values in the vertex shader. Well, vertex fetching has to be done in the vertex sh

Re: [Mesa-dev] [PATCH 04/13] mesa: Group gl_system_value values by the stage where they exist

2014-06-21 Thread Marek Olšák
For 1-4: Reviewed-by: Marek Olšák Marek On Sat, Jun 21, 2014 at 5:19 PM, Roland Scheidegger wrote: > Am 21.06.2014 03:00, schrieb Ian Romanick: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> Cc: Ilia Mirkin >> Cc: Marek Olšák >> Cc: Roland Scheidegger >> Cc: "10.2" >> --- >>

Re: [Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

2014-06-21 Thread Chris Forbes
This will be broken for indirect draws too, and possibly performance-crippling to fix there, since we don't have the baseVertex value available to shove into a uniform. On Sun, Jun 22, 2014 at 3:36 AM, Roland Scheidegger wrote: > Am 21.06.2014 03:00, schrieb Ian Romanick: >> This patch series fix

Re: [Mesa-dev] [Mesa-stable] [PATCH 12/13] i965: If STATE_BASE_VERTEX is used, set its value

2014-06-21 Thread Chris Forbes
This looks like it's adding a pile of uniform scanning overhead even to draws which don't need the feature. Can we stash the index we need earlier? On Sat, Jun 21, 2014 at 1:01 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: "10.2" > --- > src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 00/11] [RFC v2] Solve the mapping bug

2014-06-21 Thread Bruno Jimenez
On Sat, 2014-06-21 at 17:39 +0200, Francisco Jerez wrote: > Bruno Jiménez writes: > > > Hi, > > > > This is my second attempt to fix the mapping bug adding all the > > suggestions that Tom Stellard sent, and, so far, it seems that > > it is resolved. > > > > This series changes completely how Ope

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-21 Thread Matt Arsenault
On Jun 21, 2014, at 12:32 PM, Francisco Jerez wrote: > Matt Arsenault writes: > >> On Jun 21, 2014, at 9:37 AM, Francisco Jerez wrote: >> >>> Tom Stellard writes: [...] case CL_DEVICE_EXTENSIONS: - buf.as_string() = ""; + // The trailing space is intentional.

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-21 Thread Francisco Jerez
Matt Arsenault writes: > On Jun 21, 2014, at 9:37 AM, Francisco Jerez wrote: > >> Tom Stellard writes: >>>[...] >>>case CL_DEVICE_EXTENSIONS: >>> - buf.as_string() = ""; >>> + // The trailing space is intentional. It is a spec-ism that there is >>> a >>> + // trailing space

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-21 Thread Matt Arsenault
On Jun 21, 2014, at 9:37 AM, Francisco Jerez wrote: > Tom Stellard writes: > >> --- >> src/gallium/state_trackers/clover/api/device.cpp | 4 +++- >> src/gallium/state_trackers/clover/core/device.cpp | 6 ++ >> src/gallium/state_trackers/clover/core/device.hpp | 1 + >> 3 files changed, 10 in

Re: [Mesa-dev] Testing OpenCL with gegl

2014-06-21 Thread Jan Vesely
On Sat, 2014-06-21 at 20:09 +0300, Kertesz Laszlo wrote: > On 06/21/2014 12:57 PM, Bruno Jimenez wrote: > > Hi, > > > > Have you built gegl with the patches that Jan sent to the mailing list? > > > > You can find them here: > > http://lists.freedesktop.org/archives/mesa-dev/2014-June/061880.html

Re: [Mesa-dev] Testing OpenCL with gegl

2014-06-21 Thread Jan Vesely
I readded the mesa list again, as the info might be interesting to others. On Sat, 2014-06-21 at 11:50 +0200, Bruno Jimenez wrote: > On Fri, 2014-06-20 at 17:01 -0400, Jan Vesely wrote: > > On Fri, 2014-06-20 at 21:58 +0200, Bruno Jimenez wrote: > > > [snip] > > I also found a reference to BABL_PA

Re: [Mesa-dev] Testing OpenCL with gegl

2014-06-21 Thread Kertesz Laszlo
On 06/21/2014 12:57 PM, Bruno Jimenez wrote: > Hi, > > Have you built gegl with the patches that Jan sent to the mailing list? > > You can find them here: > http://lists.freedesktop.org/archives/mesa-dev/2014-June/061880.html > > Hope it helps! > Bruno > Yes it did help. Although some of the te

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-21 Thread Francisco Jerez
Tom Stellard writes: > --- > src/gallium/state_trackers/clover/api/device.cpp | 4 +++- > src/gallium/state_trackers/clover/core/device.cpp | 6 ++ > src/gallium/state_trackers/clover/core/device.hpp | 1 + > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/stat

Re: [Mesa-dev] [PATCH 3/5] clover: Report default values for half and double fp configs

2014-06-21 Thread Francisco Jerez
Tom Stellard writes: > From: Matt Arsenault > > --- > src/gallium/state_trackers/clover/api/device.cpp | 11 +-- > src/gallium/state_trackers/clover/core/device.cpp | 24 > +++ > src/gallium/state_trackers/clover/core/device.hpp | 3 +++ > 3 files changed, 36 inse

Re: [Mesa-dev] [PATCH 2/5] clover: Fix not setting build log if the build succeeds.

2014-06-21 Thread Francisco Jerez
Tom Stellard writes: > From: Matt Arsenault > > If there were only warnings, they would not be added to the log. > Also fixes valgrind use after free errors. > --- > src/gallium/state_trackers/clover/core/compiler.hpp | 3 ++- > src/gallium/state_trackers/clover/core/error.hpp | 2 +- >

Re: [Mesa-dev] [PATCH 00/11] [RFC v2] Solve the mapping bug

2014-06-21 Thread Francisco Jerez
Bruno Jiménez writes: > Hi, > > This is my second attempt to fix the mapping bug adding all the > suggestions that Tom Stellard sent, and, so far, it seems that > it is resolved. > > This series changes completely how OpenCL buffers are handled > by the r600g driver. Before this, we would add the

Re: [Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

2014-06-21 Thread Roland Scheidegger
Am 21.06.2014 03:00, schrieb Ian Romanick: > This patch series fixes bugs in the i965 w.r.t. several uses of > gl_VertexID. OpenGL (desktop and ES) have the following expectations of > gl_VertexID: > > 1. When used with BaseVertex drawing commands, gl_VertexID will include > the value of basevert

Re: [Mesa-dev] [PATCH 04/13] mesa: Group gl_system_value values by the stage where they exist

2014-06-21 Thread Roland Scheidegger
Am 21.06.2014 03:00, schrieb Ian Romanick: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: Ilia Mirkin > Cc: Marek Olšák > Cc: Roland Scheidegger > Cc: "10.2" > --- > src/mesa/main/mtypes.h | 32 > +++--- > src/mesa/state_tracker/st_gl

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-21 Thread Emil Velikov
On 21/06/14 01:30, Thomas Helland wrote: > Hi again, > > Autogen seems to work flawlessly with the updated branch. > Everything builds and compiles as normal on my Ivy Bridge setup. > When trying to do a make install though, something fails. > I'm not sure if it's related to your changes, but at l

Re: [Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

2014-06-21 Thread Ilia Mirkin
On Fri, Jun 20, 2014 at 11:17 PM, Timothy Arceri wrote: > On Fri, 2014-06-20 at 10:46 -0700, Ian Romanick wrote: > >> I care a lot less about "what is often done" than I do about "what >> should be done". If there is an argument to be made that stand-alone >> comments (not on a line with other co

Re: [Mesa-dev] Testing OpenCL with gegl

2014-06-21 Thread Bruno Jimenez
Hi, Have you built gegl with the patches that Jan sent to the mailing list? You can find them here: http://lists.freedesktop.org/archives/mesa-dev/2014-June/061880.html Hope it helps! Bruno On Sat, 2014-06-21 at 09:17 +0300, Kertesz Laszlo wrote: > Hmm. I get > > GEGL_DEBUG=opencl ./run-compos

[Mesa-dev] [Bug 80266] Many instances of 1<<31, which is undefined in C99

2014-06-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80266 --- Comment #12 from Vittorio --- In texstore.c lines 1281 and 1340 255 << 24 is computed in PACK_COLOR_. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mai

Re: [Mesa-dev] [PATCH] scons: avoid building any piece of i915

2014-06-21 Thread Jakob Bornecrantz
On Thu, Jun 19, 2014 at 9:02 PM, Emil Velikov wrote: > Leftover from commit c21fca8bf24. > > Signed-off-by: Emil Velikov > --- > src/gallium/SConscript| 11 --- > src/gallium/drivers/i915/SConscript | 12 > src/gallium/winsys/i915/sw/SConscript | 12 ---

Re: [Mesa-dev] [PATCH 02/11] Makes DRI3 use invalidate.

2014-06-21 Thread Ben Skeggs
On Thu, Jun 19, 2014 at 1:27 PM, Axel Davy wrote: > This doesn't change anything to the intel DRI3 implementation, > but enables the gallium implementation to use dri2.stamp instead > of relying on the stamp shared with the st backend. > > Signed-off-by: Axel Davy Seems to fix the same issue as t