Re: [Mesa-dev] [PATCH] egl/dri2: do not leak dri2_dpy->driver_name

2014-06-01 Thread Chia-I Wu
On Sun, Jun 1, 2014 at 11:53 PM, Emil Velikov wrote: > Originally all hardware drivers duplicate the driver_name string > from an external source, while for the software rasterizer we set > it to "swrast". Follow the example set by hw drivers this way > we can free the string at dri2_terminate().

[Mesa-dev] [PATCH 10/11] mesa: Add pixel storage support for GetCompressedTexImage

2014-06-01 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/texgetimage.c | 73 + 1 file changed, 40 insertions(+), 33 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index c22fb9b..8c0d3a1 100644 --- a/src/mesa/main/texgetimage.c

[Mesa-dev] [PATCH 06/11] mesa: Add new pixel pack/unpack state for ARB_compressed_texture_pixel_storage

2014-06-01 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/get_hash_params.py | 10 +++ src/mesa/main/mtypes.h | 4 +++ src/mesa/main/pixelstore.c | 64 3 files changed, 78 insertions(+) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/mai

[Mesa-dev] [PATCH 08/11] mesa: Extract computation of compressed pixel store params

2014-06-01 Thread Chris Forbes
This logic is reusable across CompressedTex*Image* and GetCompressedTexImage; the strides calculated will also be needed in the PBO validation functions to ensure that the referenced range of bytes is valid. Signed-off-by: Chris Forbes --- src/mesa/main/texstore.c | 47 ++

[Mesa-dev] [PATCH 04/11] glapi: Add XML infrastructure for ARB_compressed_texture_pixel_storage

2014-06-01 Thread Chris Forbes
Signed-off-by: Chris Forbes --- .../gen/ARB_compressed_texture_pixel_storage.xml| 21 + src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 4 +++- 3 files changed, 25 insertions(+), 1 deletion(-) create mode

[Mesa-dev] [PATCH 05/11] tests: Add new enum strings for ARB_compressed_texture_pixel_storage

2014-06-01 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/tests/enum_strings.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/main/tests/enum_strings.cpp b/src/mesa/main/tests/enum_strings.cpp index d16eb36..66ff4ec 100644 --- a/src/mesa/main/tests/enum_strings.cpp +++ b/src/mesa/mai

[Mesa-dev] [PATCH 09/11] mesa: Compute proper strides for compressed texture pixel storage.

2014-06-01 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/texstore.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index b5b7254..cb81f3f 100644 --- a/src/mesa/main/texstore.c +++ b/src/mesa/main/texstore.c @@ -421

[Mesa-dev] [PATCH 07/11] mesa: Emit errors for inconsistent compressed pixel store state

2014-06-01 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/texgetimage.c | 10 +- src/mesa/main/teximage.c| 45 + src/mesa/main/teximage.h| 6 ++ 3 files changed, 60 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c b/src/me

[Mesa-dev] [PATCH 11/11] docs: Mark off ARB_compressed_texture_pixel_storage

2014-06-01 Thread Chris Forbes
.. and add to release notes for 10.3 Signed-off-by: Chris Forbes --- docs/GL3.txt| 2 +- docs/relnotes/10.3.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index c360f2c..9f86a39 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -13

[Mesa-dev] [RFC PATCH 00/11] Add support for ARB_compressed_texture_pixel_storage

2014-06-01 Thread Chris Forbes
This series adds support for ARB_compressed_texture_pixel_storage from GL4.2. This provides a convenient way to update a subrectangle of a compressed texture from client memory or a pixel buffer object, without having to rearrange the client copy. (Well, as convenient as GL pixel store state ev

[Mesa-dev] [PATCH 03/11] mesa: Add extension enable for ARB_compressed_texture_pixel_storage

2014-06-01 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index c2ff7e3..6b51425 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -86,6 +86,7 @@ static const str

[Mesa-dev] [PATCH 02/11] mesa: Make CompressedTexSubImage errors more consistent

2014-06-01 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/teximage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 845ba80..5058b39 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3844,7 +3844,7 @@

[Mesa-dev] [PATCH 01/11] mesa: Trim down PixelStorei implementation

2014-06-01 Thread Chris Forbes
Move _mesa_error call for INVALID_VALUE to one place. Remove checks for previous value matching -- this was important when we were flushing vertices before the update, but that hasn't happened for a long time now. Signed-off-by: Chris Forbes --- src/mesa/main/pixelstore.c | 175 +++--

Re: [Mesa-dev] [RFC PATCH 04/16] i965: Split gen6 depth state out from brw

2014-06-01 Thread Pohjolainen, Topi
On Thu, May 29, 2014 at 01:53:43PM -0700, Jordan Justen wrote: > We will program the gen6 depth state differently to enable layered > rendering on gen6. > > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/brw_context.c |

Re: [Mesa-dev] [RFC PATCH 01/16] i965: Split gen6 renderbuffer surface state from gen5 and older

2014-06-01 Thread Pohjolainen, Topi
On Thu, May 29, 2014 at 01:53:40PM -0700, Jordan Justen wrote: > We will program the gen6 renderbuffer surface state differently to > enable layered rendering on gen6. > > Signed-off-by: Jordan Justen Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 +

Re: [Mesa-dev] [RFC PATCH 03/16] i965/gen6: Align height to 2 with MSAA for certain surface heights

2014-06-01 Thread Pohjolainen, Topi
On Thu, May 29, 2014 at 01:53:42PM -0700, Jordan Justen wrote: > TODO: Find a good documented reason for this change. > > This could be related to PRM Volume 1 Part 1: Graphics Core, Section > 7.18.3.7.1 (Surface Arrays For all surfaces other than separate > stencil buffer): > > "[DevSNB] Errata

Re: [Mesa-dev] [RFC PATCH 02/16] i965/gen6: add support for layered renderbuffers

2014-06-01 Thread Pohjolainen, Topi
On Thu, May 29, 2014 at 01:53:41PM -0700, Jordan Justen wrote: > Rather than pointing the surface_state directly at a single > sub-image of the texture for rendering, we now point the > surface_state at the top level of the texture, and configure > the surface_state as needed based on this. > > Si

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 Nikolay changed: What|Removed |Added CC||mar.ko...@gmail.com -- You are receiving this

Re: [Mesa-dev] how "client glx extensions" and "GLX extensions" are determined (and how best to limit them)

2014-06-01 Thread Axel Davy
On 01/06/2014 20:49, Jeremy Huddleston Sequoia wrote : I'm trying to take a stab at adding core profile support to XQuartz. As a first step, I'm trying to add GLX_ARB_create_context and GLX_ARB_create_context_profile. For now, I want to make sure that GLX_ARB_create_context and GLX_ARB_creat

[Mesa-dev] how "client glx extensions" and "GLX extensions" are determined (and how best to limit them)

2014-06-01 Thread Jeremy Huddleston Sequoia
I'm trying to take a stab at adding core profile support to XQuartz. As a first step, I'm trying to add GLX_ARB_create_context and GLX_ARB_create_context_profile. For now, I want to make sure that GLX_ARB_create_context and GLX_ARB_create_context_profile are only advertised as being available

Re: [Mesa-dev] [PATCH 04/19] i965/fs: Store the number of sources an fs_inst has.

2014-06-01 Thread Matt Turner
On Sat, May 31, 2014 at 10:05 PM, Kenneth Graunke wrote: > On Tuesday, May 27, 2014 06:47:35 PM Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 21 +++-- >> src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- >> 2 files changed, 13 insertions(+), 11 deletions(-) >>

Re: [Mesa-dev] [PATCH 1/2] mesa/main: Make get_hash.c values constant.

2014-06-01 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] mesa: Make glGetIntegerv(GL_*_ARRAY_SIZE) return GL_BGRA.

2014-06-01 Thread Matt Turner
On Sun, Jun 1, 2014 at 12:56 PM, wrote: > From: José Fonseca > > Same as b026b6bbfe3f15c8a7296ac107dc3d31f74e401e, but > COLOR_ARRAY_SIZE/SECONDARY_COLOR_ARRAY_SIZE. > > Ideally we wouldn't munge the incoming state, so that we wouldn't need to > unmunge it back on glGet*. But the array size sta

[Mesa-dev] [PATCH 2/2] mesa: Make glGetIntegerv(GL_*_ARRAY_SIZE) return GL_BGRA.

2014-06-01 Thread jfonseca
From: José Fonseca Same as b026b6bbfe3f15c8a7296ac107dc3d31f74e401e, but COLOR_ARRAY_SIZE/SECONDARY_COLOR_ARRAY_SIZE. Ideally we wouldn't munge the incoming state, so that we wouldn't need to unmunge it back on glGet*. But the array size state is copied and referred in many places, many of whic

[Mesa-dev] [PATCH 1/2] mesa/main: Make get_hash.c values constant.

2014-06-01 Thread jfonseca
From: José Fonseca --- src/mesa/main/get_hash_generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get_hash_generator.py b/src/mesa/main/get_hash_generator.py index 96bc495..b200d19 100644 --- a/src/mesa/main/get_hash_generator.py +++ b/src/mesa/main/ge

[Mesa-dev] [PATCH 2/5] glsl: Remove useless call to as_rvalue().

2014-06-01 Thread Matt Turner
The type returned by hir() is already an ir_rvalue pointer. --- src/glsl/ast_function.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index 4b84470..a8bf27d 100644 --- a/src/glsl/ast_function.cpp +++ b/src/glsl/ast_funct

[Mesa-dev] [PATCH 4/5] glsl: Move ir_type_unset to end of enumeration.

2014-06-01 Thread Matt Turner
Now that the constructors set a type, ir_type_unset is not very useful. Move it to the end of the enum (specifically out of position 0) so that enums checks for dereferences and rvalues can save an instruction. --- Could also get rid of ir_type_unset completely by replacing its uses with ir_type_ma

[Mesa-dev] [PATCH 3/5] glsl: Reorder ir_type_* enum for easier comparisons.

2014-06-01 Thread Matt Turner
Makes checking whether an object is an ir_dereference, an ir_rvalue, or an ir_jump simpler. Since ir_dereference is a subclass or ir_rvalue, list its subtypes first so that they can both generate nice code. --- src/glsl/ir.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) dif

[Mesa-dev] [PATCH 5/5] glsl: Make most ir_instruction::as_subclass() functions non-virtual.

2014-06-01 Thread Matt Turner
There are several common ways to check whether an object is a particular subclass: dynamic_cast<>, the as_subclass() pattern, or explicit enum tags. We originally used the virtual as_subclass methods, but later added enum tags as they are much nicer for debugging. Since we have the enum tags, we

[Mesa-dev] [PATCH 1/5] glsl: Set ir_instruction::ir_type in the base class constructor

2014-06-01 Thread Matt Turner
From: Ian Romanick This has the added perk that if you forget to set ir_type in the constructor of a new subclass (or a new constructor of an existing subclass) the compiler will tell you... instead of relying on ir_validate or similar run-time detection. Reviewed-by: Matt Turner Reviewed-by: K

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 Ernst Sjöstrand changed: What|Removed |Added CC||ern...@gmail.com -- You are receiving

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 --- Comment #9 from Fabio Pedretti --- Same problem for other users: http://www.phoronix.com/forums/showthread.php?50038-Updated-and-Optimized-Ubuntu-Free-Graphics-Drivers&p=420455#post420455 -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 --- Comment #8 from Marek Olšák --- (In reply to comment #4) > Ugh... this should also affect the 10.2 release branch. I'm not super > excited about reverting patches, but I don't want to ship a release with > Unigine broken either. > > Ideas /

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 Fabio Pedretti changed: What|Removed |Added CC||fabio@libero.it --- Comment #7 from

[Mesa-dev] [PATCH] egl/dri2: do not leak dri2_dpy->driver_name

2014-06-01 Thread Emil Velikov
Originally all hardware drivers duplicate the driver_name string from an external source, while for the software rasterizer we set it to "swrast". Follow the example set by hw drivers this way we can free the string at dri2_terminate(). v2: Use strdup over strndup. Suggested by Ilia Mirkin. Cc: C

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 Alexander Monakov changed: What|Removed |Added CC||amona...@gmail.com -- You are recei

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: do not leak dri2_dpy->driver_name

2014-06-01 Thread Ilia Mirkin
On Sun, Jun 1, 2014 at 10:19 AM, Emil Velikov wrote: > Originally all hardware drivers duplicate the driver_name string > from an external source, while for the software rasterizer we've > set it to a literal. Follow the example set by hw drivers this way > we can free the string at dri2_terminate

[Mesa-dev] [PATCH 2/2] egl/dri2: do not leak dri2_dpy->driver_name

2014-06-01 Thread Emil Velikov
Originally all hardware drivers duplicate the driver_name string from an external source, while for the software rasterizer we've set it to a literal. Follow the example set by hw drivers this way we can free the string at dri2_terminate(). Cc: Chia-I Wu Signed-off-by: Emil Velikov --- src/egl/

[Mesa-dev] [PATCH 1/2] egl/dri2/x11: use standard strndup function

2014-06-01 Thread Emil Velikov
Using a custom version of the function brings no benefit. Cc: Chad Versace Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 --- Comment #6 from Benjamin Bellec --- (In reply to comment #3) > Confirmed on r600g. +1 (Evergreen) -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing lis

[Mesa-dev] [PATCH] i965: Put '_default_' in the name of functions that set default state.

2014-06-01 Thread Kenneth Graunke
Eventually we're going to use functions to set bits on an instruction. Putting 'default' in the name of functions that alter default state will help distinguins them. This patch was generated entirely mechanically, by the following: for file in brw*.{cpp,c,h}; do sed -i \ -e 's/brw_set_mask

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 --- Comment #5 from Alexander Monakov --- The patch that changed RTLD_GLOBAL to RTLD_LOCAL was incorrect; see http://lists.freedesktop.org/archives/mesa-dev/2014-May/060441.html dlopening libGL to bring symbols from libglapi is a gross hack, but

Re: [Mesa-dev] [PATCH 16/19] i965/fs: Perform CSE on load_payload instructions if it's not a copy.

2014-06-01 Thread Kenneth Graunke
On Friday, April 18, 2014 11:56:52 AM Matt Turner wrote: > Since CSE creates instructions, if we let CSE generate things register > coalescing can't remove, bad things will happen. Only let CSE combine > non-copy load_payloads. > > E.g., allow CSE to handle this > >load_payload vgrf4+0, vgrf5

Re: [Mesa-dev] [PATCH 15/19] i965/fs: Support register coalescing on LOAD_PAYLOAD operands.

2014-06-01 Thread Kenneth Graunke
On Friday, April 18, 2014 11:56:51 AM Matt Turner wrote: > --- > .../drivers/dri/i965/brw_fs_register_coalesce.cpp | 59 ++ > 1 file changed, 49 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp b/src/mesa/drivers/dri/i96