On 05/14/2014 11:39 PM, Jordan Justen wrote:
> mt->format is of type mesa_format, and therefore can't be
> used with _mesa_base_fbo_format which requires a GLenum input.
>
> On gen8, this fixes various piglit fbo-depthstencil tests with
> samples > 1.
>
> Signed-off-by: Jordan Justen
> Cc: Topi
mt->format is of type mesa_format, and therefore can't be
used with _mesa_base_fbo_format which requires a GLenum input.
On gen8, this fixes various piglit fbo-depthstencil tests with
samples > 1.
Signed-off-by: Jordan Justen
Cc: Topi Pohjolainen
Cc: Kenneth Graunke
---
This was tested on Ken'
On 05/14/2014 03:19 PM, Matt Turner wrote:
> They've served their purpose (in transitioning blorp to using
> fs_generator) and now they just necessitate large amounts of manual
> labor to regenerate if the disassembler changes.
>
> Cc: Topi Pohjolainen
> ---
> Deleted file diff removed.
>
> src
https://bugs.freedesktop.org/show_bug.cgi?id=78716
Michel Dänzer changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Hi,
On Wednesday, May 14, 2014 02:45:26 Jose Fonseca wrote:
> If you rebase it on top of my series it can be reduced to merely this:
Ok, thanks that is actually great news, as this gives me something to work with.
> In other words, we'd be introducing leaks for sake of thread-safety. I care
>
>
> While the GLSL ES 3.00 (.4) spec says (The GLSL ES 3.1 spec contains
> this wording too)
> > All uniform variables are read-only. They are initialized to 0 at link
> time and may be updated through the API.
> So I think we're correct in disallowing it.
>
Ok, fair enough. /me shakes fist at the
On Wed, May 14, 2014 at 03:19:36PM -0700, Matt Turner wrote:
> They've served their purpose (in transitioning blorp to using
> fs_generator) and now they just necessitate large amounts of manual
> labor to regenerate if the disassembler changes.
>
> Cc: Topi Pohjolainen
> ---
> Deleted file diff
https://bugs.freedesktop.org/show_bug.cgi?id=78716
--- Comment #3 from Tapani Pälli ---
OK finally got it going. Demo may need compute and tesselation support (?) as
it queries following enums:
GL_MAX_TESS_CONTROL_TEXTURE_IMAGE_UNITS
GL_MAX_TESS_EVALUATION_UNIFORM_COMPONENTS
GL_MAX_TESS_CONTROL_
loader_get_pci_id_for_fd() and loader_get_device_name_for_fd() now attempt
all available strategies to identify the hardware, instead of conditionally
compiling in a single test. The existing libudev and DRM approaches have
been retained, and another simple alternative of looking up the answer in
https://bugs.freedesktop.org/show_bug.cgi?id=78716
--- Comment #2 from Tapani Pälli ---
For me the demo fails with following error:
setrlimit() failed with error 22 (Invalid argument)
- Max per-process value allowed is 4096 (we wanted 1).
--
You are receiving this mail because:
You are the
Carl, this patch fixes a bug in commit
3e817e7e56806d8adb8f16c35136045c29908944; please hold off on backporting
that to the 10.1 branch without this fix.
On 15.05.2014 12:56, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Fixes the valgrind report below and random crashes with piglit on radeon
From: Michel Dänzer
Fixes the valgrind report below and random crashes with piglit on radeonsi.
==30005== Conditional jump or move depends on uninitialised value(s)
==30005==at 0xB13584E: st_translate_program (st_glsl_to_tgsi.cpp:5100)
==30005==by 0xB14698B: st_translate_fragment_program
On 15.05.2014 10:58, Marek Olšák wrote:
> Hi everybody,
>
> Some distros seem to care about the size of Mesa, so I came up with
> this little patch.
>
> It puts r600g and radeonsi into r300_dri.so. The result is one shared
> library which contains all three drivers. Also, all driver loaders in
>
On Mon, May 5, 2014 at 9:07 AM, Giovanni Campagna
wrote:
> @@ -2080,6 +2080,7 @@ AC_CONFIG_FILES([Makefile
> src/gallium/targets/dri-ilo/Makefile
> src/gallium/targets/dri-nouveau/Makefile
> src/gallium/targets/dri-swrast/Makefile
> + s
On 15/05/14 02:58, Marek Olšák wrote:
> Hi everybody,
>
> Some distros seem to care about the size of Mesa, so I came up with
> this little patch.
>
> It puts r600g and radeonsi into r300_dri.so. The result is one shared
> library which contains all three drivers. Also, all driver loaders in
> Me
Hi everybody,
Some distros seem to care about the size of Mesa, so I came up with
this little patch.
It puts r600g and radeonsi into r300_dri.so. The result is one shared
library which contains all three drivers. Also, all driver loaders in
Mesa should now always load the r300 driver instead of r
https://bugs.freedesktop.org/show_bug.cgi?id=78716
--- Comment #1 from Michel Dänzer ---
The first issue I'm hitting with r600g is that the demo tries to get the value
of GL_MAX_COMPUTE_TEXTURE_IMAGE_UNITS and then fails an assertion because
that's not available. Looks like an issue in the demo r
On 05/05/14 17:07, Giovanni Campagna wrote:
> This is my second attempt to bring swrast to the DRM EGL platform.
> It includes both the legacy loader, which will work with any
> swrast driver, and the new gallium winsys which works with the
> DRI2 loader and softpipe/llvmpipe.
>
Hi Giovanni,
Just
On 05/05/14 17:07, Giovanni Campagna wrote:
> From: Giovanni Campagna
>
> Add a new winsys and target that can be used with a dri2 state tracker and
> loader instead of drisw. This allows to use gbm as a dri2/image loader
> and avoid the extra copy from the backbuffer to the shadow frontbuffer.
>
On 05/05/14 17:07, Giovanni Campagna wrote:
> From: Giovanni Campagna
>
> Turn GBM into a swrast loader (providing putimage/getimage backed
> by a dumb KMS buffer). This allows to run KMS+DRM GL applications
> (such as weston or mutter-wayland) unmodified on cards that don't
> have any client sid
Tracking this will allow us to issue warnings when using a program that
hasn't yet been relinked, or when re-linking unnecessarily.
The following functions cause changes that don't take effect until the
program has been re-linked:
- glAttachShader
- glBindAttribLocation
- glBindFragDataLocation
-
Now that we track whether a program needs re-linking, we can issue a
warning if it's called when a re-link isn't required.
Signed-off-by: Kenneth Graunke
---
src/mesa/main/shaderapi.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
OpenGL allows you to call ShaderSource and CompileShader on existing
shaders which are already attached to programs that have been linked.
I want to be able to accurately track when programs need relinking,
and unfortunately this is one of those cases.
Signed-off-by: Kenneth Graunke
---
src/gls
Beyond issuing a warning, we can actually skip the LinkProgram call if
it isn't necessary. Notably, some game engines may set "new" attribute
bindings and re-link, when it actually picked the same values, so there
was no actual change.
Skips a bunch of unnecessary linking in an upcoming game.
Si
A certain game engine links its shaders, calls BindAttribLocation to set
the same values a second time, then re-links them all.
If the binding doesn't actually change, there's no need to re-link,
so we can avoid flagging that.
Signed-off-by: Kenneth Graunke
---
src/mesa/main/shader_query.cpp |
Hi all,
Here's a series of patches which implements warnings related to re-linking
shader programs:
1. If you draw with a shader that needs re-linking, it gives you a warning.
Most likely you simply forgot, and will be surprised by the results.
Occasionally you might have meant to do that.
Drawing with a program that hasn't been re-linked is legal, but likely
isn't what the application author intended. Give a helpful warning.
(_mesa_shader_debug might be more appropriate than _mesa_warning...)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78700
Signed-off-by: Kenneth Grau
https://bugs.freedesktop.org/show_bug.cgi?id=78716
Priority: medium
Bug ID: 78716
Assignee: mesa-dev@lists.freedesktop.org
Summary: Fix Mesa bugs for running Unreal Engine 4.1 Cave
effects demo compiled for Linux
Severity: no
On Tue, May 13, 2014 at 12:15:01AM +0100, Emil Velikov wrote:
> Just fold libllvmradeon in libradeon.
For the series:
Reviewed-by: Tom Stellard
>
> Signed-off-by: Emil Velikov
> ---
> src/gallium/drivers/r600/Makefile.am | 2 --
> src/gallium/drivers/radeon/Makefile.am | 12 ---
On Wed, May 14, 2014 at 3:14 PM, Ian Romanick wrote:
> On 05/09/2014 08:28 PM, Ian Romanick wrote:
>> (This is a re-send with a GPG signature.)
>>
>> Mesa 10.2 release candidate 2 is now available for testing. The current
>> plan of record is to have an additional release candidate each Friday
>>
https://bugs.freedesktop.org/show_bug.cgi?id=75010
--- Comment #1 from Vinson Lee ---
Created attachment 99048
--> https://bugs.freedesktop.org/attachment.cgi?id=99048&action=edit
configure.ac: Remove -fstack-protector-strong from LLVM flags.
--
You are receiving this mail because:
You are th
They've served their purpose (in transitioning blorp to using
fs_generator) and now they just necessitate large amounts of manual
labor to regenerate if the disassembler changes.
Cc: Topi Pohjolainen
---
Deleted file diff removed.
src/mesa/drivers/dri/i965/.gitignore |1 -
src
On 05/09/2014 08:28 PM, Ian Romanick wrote:
> (This is a re-send with a GPG signature.)
>
> Mesa 10.2 release candidate 2 is now available for testing. The current
> plan of record is to have an additional release candidate each Friday
> until the 10.2 release on Friday, May 30th (correcte from t
https://bugs.freedesktop.org/show_bug.cgi?id=78700
Kenneth Graunke changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|mesa-dev@l
https://bugs.freedesktop.org/show_bug.cgi?id=77288
--- Comment #3 from Eric Anholt ---
The alternative I think would be to make "if (ir->write_mask == 0) {" (which is
presumably the case that was being hit before) also explicitly accept
matrices/structures.
--
You are receiving this mail becaus
Reviewed-by: Ian Romanick
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> If texObj == NULL here it mean there is already GL_INVALID_VALUE
> or GL_OUT_OF_MEMORY error set to context.
>
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/drivers/common/meta_blit.c | 3 +++
> 1 file chang
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> For GLX_BACK_BUFFER_AGE_EXT query added extra null check.
>
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/glx/glx_pbuffer.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c
> index
Am 14.05.2014 21:45, schrieb Brian Paul:
> On 05/14/2014 01:07 PM, srol...@vmware.com wrote:
>> From: Roland Scheidegger
>>
>> Previously the code used the total number of ubos being declared in the
>> linked program (so the ubos of all shaders combined), use the number
>> from the particular shad
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/glsl/link_uniform_blocks.cpp | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/glsl/link_uniform_blocks.cpp
> b/src/glsl/link_uniform_blocks.cpp
> index 1a0e643..3643734 100644
>
Reviewed-by: Ian Romanick
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> Check return value from hash_table_find before using it as a pointer
>
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/glsl/loop_analysis.cpp | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/program/symbol_table.c | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c
> index 94629
I'm nervous this has the same problem as patch 3. Can you try some tests?
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/drivers/dri/i965/intel_resolve_map.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/mesa/drive
Chia-I Wu writes:
> I'd like to nominate this commit on master for 10.1.4
>
> commit 9245206cbfaaa4e18c1f3715eebb5f281070d772
> Author: Eric Anholt
> Date: Fri Feb 14 16:06:31 2014 -0800
>
> i965/vs: Use samplers for UBOs in the VS like we do for non-UBO
> pulls.
Great. I've cherry-pic
Reviewed-by: Ian Romanick
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/main/hash.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c
> index 23018e9..674c29d 100644
> ---
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/glsl/link_varyings.cpp | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
> index 71998df..7fdf337 100644
> --- a/src/glsl/link_v
On 05/14/2014 01:07 PM, srol...@vmware.com wrote:
From: Roland Scheidegger
Previously the code used the total number of ubos being declared in the
linked program (so the ubos of all shaders combined), use the number
from the particular shader instead.
This fixes an assertion failure with piglit
Reviewed-by: Ian Romanick
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> Check calloc return values in hash_table_insert() and
> hash_table_replace()
>
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/program/prog_hash_table.c | 8
> 1 file changed, 8 insertions(+)
>
> dif
On 05/14/2014 10:55 AM, Juha-Pekka Heikkila wrote:
> Type mismatch caused random memory to be copied when casted
> memory area was smaller than expected type.
>
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/main/ff_fragment_shader.cpp | 17 +
> 1 file changed, 9 insertion
Hi, I'm on vacation, so I have no way of testing this until next week.
/Thomas
On 05/14/2014 02:04 PM, Emil Velikov wrote:
> ping for the series
>
> If there is no objections I would like to push these over the weekend.
>
> Cheers,
> Emil
> On 09/05/14 18:10, Emil Velikov wrote:
>> ping
>>
>> T
On 05/14/2014 11:52 AM, Matt Turner wrote:
> On Wed, May 14, 2014 at 10:00 AM, Aras Pranckevicius wrote:
>> Hi,
>>
>> Mesa's ast_to_hir.cpp does a check like:
>>
>> state->check_version(120, 0, &initializer_loc,
>>"cannot initialize uniforms");
>>
>> i.e. it does not
From: Roland Scheidegger
Previously the code used the total number of ubos being declared in the
linked program (so the ubos of all shaders combined), use the number
from the particular shader instead.
This fixes an assertion failure with piglit arb_uniform_buffer_object-maxblocks
seen in llvmpip
Le 14 mai 2014 21:02, "Mohamed MEDIOUNI" a
écrit :
>
> Le 29 avr. 2014 02:52, "Rob Clark" a écrit :
> >
> > On Sun, Apr 27, 2014 at 5:51 AM, Mohamed MEDIOUNI
> > wrote:
> > >
> > > Le 21 avr. 2014 13:16, "Rob Clark" a écrit :
> > >>
> > >> On Sat, Apr 19, 2014 at 9:32 AM, Mohamed MEDIOUNI
> >
On Wed, May 14, 2014 at 10:00 AM, Aras Pranckevicius wrote:
> Hi,
>
> Mesa's ast_to_hir.cpp does a check like:
>
> state->check_version(120, 0, &initializer_loc,
>"cannot initialize uniforms");
>
> i.e. it does not allow uniform initializers on GLSL ES 3.00.
>
> Upon
There probably either was wrong name for comparison or ! missing.
In vec4_generator::generate_code() there was similar code thus
I decided it was wrong name.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/performance_monitor.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/performance_monitor.c
b/src/mesa/main/performance_monitor.c
index 21b9423..9d1a6b4 100644
--- a/src/mesa/main/performance_monitor.c
+++ b/src/mesa/mai
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/vdpau.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/vdpau.c b/src/mesa/main/vdpau.c
index d974593..f1b3ece 100644
--- a/src/mesa/main/vdpau.c
+++ b/src/mesa/main/vdpau.c
@@ -132,6 +132,11 @@ register_surface(struct gl
Check calloc return value and report on error, also later skip
results handling if there was no memory to store results to.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_performance_monitor.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mes
Check calloc return value while adding build-in functions.
Signed-off-by: Juha-Pekka Heikkila
---
src/glsl/linker.cpp | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index a43d230..97bd0ef 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.
Verify _mesa_lookup_texture() returned valid pointer before using it.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/vdpau.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/main/vdpau.c b/src/mesa/main/vdpau.c
index f1b3ece..975b812 100644
--- a/src/mesa/main/vdpau.c
+++
Check intel_miptree_create() return value before using it as
a pointer.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/intel_tex.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_tex.c
b/src/mesa/drivers/dri/i965/intel_tex.c
index f18ca45
For GLX_BACK_BUFFER_AGE_EXT query added extra null check.
Signed-off-by: Juha-Pekka Heikkila
---
src/glx/glx_pbuffer.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c
index 0cd0554..bbfdd65 100644
--- a/src/glx/glx_pbuffer.c
+++ b/src/glx/glx
Type mismatch caused random memory to be copied when casted
memory area was smaller than expected type.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/ff_fragment_shader.cpp | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/mesa/main/ff_fragment_shad
Report memory error on realloc failure and don't leak any memory.
Signed-off-by: Juha-Pekka Heikkila
---
src/glsl/link_atomics.cpp | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/glsl/link_atomics.cpp b/src/glsl/link_atomics.cpp
index d92cdb1..fbe4e73 10064
If texObj == NULL here it mean there is already GL_INVALID_VALUE
or GL_OUT_OF_MEMORY error set to context.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/common/meta_blit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/common/meta_blit.c
b/src/mesa/drivers/com
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/intel_resolve_map.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c
b/src/mesa/drivers/dri/i965/intel_resolve_map.c
index 04b5c94..c5a4cd7 100644
--- a/src/mesa/drivers/dri/i
Check return value from hash_table_find before using it as a pointer
Signed-off-by: Juha-Pekka Heikkila
---
src/glsl/loop_analysis.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/glsl/loop_analysis.cpp b/src/glsl/loop_analysis.cpp
index d6a9ac7..78ac300 100644
-
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/program/symbol_table.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c
index 9462978..5b22745 100644
--- a/src/mesa/program/symbol_table.c
+++ b/sr
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/hash.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c
index 23018e9..674c29d 100644
--- a/src/mesa/main/hash.c
+++ b/src/mesa/main/hash.c
@@ -115,10 +115,20 @@ _mesa_NewHashTable(void
Check calloc return values in hash_table_insert() and
hash_table_replace()
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/program/prog_hash_table.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/program/prog_hash_table.c
b/src/mesa/program/prog_hash_table.c
index f45ed46.
check variable_storage() found the requested fs_reg.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index d2
Signed-off-by: Juha-Pekka Heikkila
---
src/glsl/link_uniform_blocks.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/glsl/link_uniform_blocks.cpp b/src/glsl/link_uniform_blocks.cpp
index 1a0e643..3643734 100644
--- a/src/glsl/link_uniform_blocks.cpp
+++ b/src/glsl/link_uniform_blo
separate two null checks connected with && to their own if branches.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_context.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/
Signed-off-by: Juha-Pekka Heikkila
---
src/glsl/link_varyings.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index 71998df..7fdf337 100644
--- a/src/glsl/link_varyings.cpp
+++ b/src/glsl/link_varyings.cpp
@@ -318,6 +318,11 @@ t
My Klocwork set again rebased and added with few new patches. This set pass
piglit quick set on my ivybridge without regressions.
i965: Avoid null access in intelMakeCurrent() I was a bit iffy if its
the same behavior which I replaced.
mesa/drivers: Add extra null check in blitframebuffer_textur
Hi,
Mesa's ast_to_hir.cpp does a check like:
state->check_version(120, 0, &initializer_loc,
"cannot initialize uniforms");
i.e. it does not allow uniform initializers on GLSL ES 3.00.
Upon my reading of the spec, I can't find any place where that would be
disallowed
- Original Message -
> On 05/14/2014 03:45 AM, Jose Fonseca wrote:
> > - Original Message -
> >>
> >> Hi Jose,
> >>
> >> On Tuesday, May 13, 2014 08:16:34 Jose Fonseca wrote:
> >>> I tweaked the comment (was below) but indeed did a poor job. I think
> >>> I'll
> >>> just put the
On 05/14/2014 03:45 AM, Jose Fonseca wrote:
- Original Message -
Hi Jose,
On Tuesday, May 13, 2014 08:16:34 Jose Fonseca wrote:
I tweaked the comment (was below) but indeed did a poor job. I think I'll
just put the original back:
"We must never free LLVM contexts, because LLVM h
Am 14.05.2014 13:43, schrieb Jose Fonseca:
>
>
> - Original Message -
>> From: Roland Scheidegger
>>
>> In 1d35f77228ad540a551a8e09e062b764a6e31f5e support for multiple constant
>> buffers was introduced. This meant we had another indirection, and we did
>> resolve the indirection for ea
https://bugs.freedesktop.org/show_bug.cgi?id=78700
Priority: medium
Bug ID: 78700
Assignee: mesa-dev@lists.freedesktop.org
Summary: Debug warnings should be generated when
BindAttribLocation isn't followed by a re-link
Severi
On 14.05.2014 22:49, Alex Deucher wrote:
> On Wed, May 14, 2014 at 3:32 AM, Michel Dänzer wrote:
>> From: Michel Dänzer
>>
>> Bring it back in line with r600g. I broke this in the original radeonsi
>> bringup. :(
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78537
>> Signed-off-by:
From: José Fonseca
Fixed upstream.
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
index 4d63f9a..ec54776 100644
--- a/src/gall
From: José Fonseca
It works fine, though it requires using ELF objects.
With this change there is nothing preventing us to switch exclusively
to MCJIT, everywhere. It's still off though.
---
scons/llvm.py | 8 +++-
src/gallium/auxiliary/gallivm/lp_bld_misc.c
On 14.05.2014 06:45, Marek Olšák wrote:
> From: Marek Olšák
>
> It works just fine.
>
> This fixes a crash in:
> piglit/spec/glsl-1.20/execution/fs-const-array-of-struct-of-array
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78666
>
> Cc: 10.2 10.1 mesa-sta...@lists.freedesktop.
On Wed, May 14, 2014 at 3:32 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Bring it back in line with r600g. I broke this in the original radeonsi
> bringup. :(
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78537
> Signed-off-by: Michel Dänzer
CC stable?
Reviewed-by: Alex Deu
On 13/05/14 13:15, Jon TURNEY wrote:
> On 16/02/2014 02:00, Jeremy Huddleston Sequoia wrote:
>> Mesa master hasn't built for OSX for over a year now, unfortunately,
>> but I agree excluding in Makefile.am is preferable to cpp-guards.
>> Hopefully "someone" will have the time and patience to get it
https://bugs.freedesktop.org/show_bug.cgi?id=78666
--- Comment #3 from David Heidelberger (okias) ---
(In reply to comment #2)
> The assertion fails while translating from GLSL IR to TGSI.
and when it's compiled without debug information, it just segfault elsewhere
--
You are receiving this ma
Am 14.05.2014 00:25, schrieb Rob Clark:
> From: Rob Clark
>
> It wasn't completely clear from the docs, so I had to figure out by
> looking at piglit results. Hopefully this saves the next driver writer
> implementing queries some time.
>
> Signed-off-by: Rob Clark
> ---
> src/gallium/docs/so
ping for the series
If there is no objections I would like to push these over the weekend.
Cheers,
Emil
On 09/05/14 18:10, Emil Velikov wrote:
> ping
>
> Thomas, Rob,
> Can you please take a look if the patch makes sense ? I have double checked
> that only the required functions are exported alt
- Original Message -
> From: Roland Scheidegger
>
> In 1d35f77228ad540a551a8e09e062b764a6e31f5e support for multiple constant
> buffers was introduced. This meant we had another indirection, and we did
> resolve the indirection for each constant buffer access. This looks very
> reasonab
Reviewed-by: Marek Olšák
Marek
On Wed, May 14, 2014 at 12:25 AM, Rob Clark wrote:
> From: Rob Clark
>
> It wasn't completely clear from the docs, so I had to figure out by
> looking at piglit results. Hopefully this saves the next driver writer
> implementing queries some time.
>
> Signed-off
Reviewed-by: Marek Olšák
Marek
On Wed, May 14, 2014 at 9:32 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Bring it back in line with r600g. I broke this in the original radeonsi
> bringup. :(
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78537
> Signed-off-by: Michel Dänzer
- Original Message -
> Am 14.05.2014 09:55, schrieb Michel Dänzer:
> > On 14.05.2014 06:45, Marek Olšák wrote:
> >> From: Marek Olšák
> >>
> >> It works just fine.
> >>
> >> This fixes a crash in:
> >>piglit/spec/glsl-1.20/execution/fs-const-array-of-struct-of-array
> >>
> >> Bugzill
- Original Message -
>
> Hi Jose,
>
> On Tuesday, May 13, 2014 08:16:34 Jose Fonseca wrote:
> > I tweaked the comment (was below) but indeed did a poor job. I think I'll
> > just put the original back:
> >
> >"We must never free LLVM contexts, because LLVM has several global
> >
Am 14.05.2014 09:55, schrieb Michel Dänzer:
On 14.05.2014 06:45, Marek Olšák wrote:
From: Marek Olšák
It works just fine.
This fixes a crash in:
piglit/spec/glsl-1.20/execution/fs-const-array-of-struct-of-array
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78666
Cc: 10.2 10.1 me
On 14.05.2014 06:45, Marek Olšák wrote:
> From: Marek Olšák
>
> It works just fine.
>
> This fixes a crash in:
> piglit/spec/glsl-1.20/execution/fs-const-array-of-struct-of-array
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78666
>
> Cc: 10.2 10.1 mesa-sta...@lists.freedesktop.
From: Michel Dänzer
Bring it back in line with r600g. I broke this in the original radeonsi
bringup. :(
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78537
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/r600/r600_pipe.h | 9 -
src/gallium/drivers/radeon/r600_pip
96 matches
Mail list logo
