On Fri, Mar 21, 2014 at 11:17 PM, Matt Turner wrote:
> On Fri, Mar 21, 2014 at 7:33 AM, Juha-Pekka Heikkila
> wrote:
>> Our hardware has an "accumulator" register, which can be used to store
>> intermediate results across multiple instructions. Many instructions
>> can implicitly write a value t
On Fri, Mar 21, 2014 at 7:33 AM, Juha-Pekka Heikkila
wrote:
> Our hardware has an "accumulator" register, which can be used to store
> intermediate results across multiple instructions. Many instructions
> can implicitly write a value to the accumulator in addition to their
> normal destination r
On Sat, Mar 22, 2014 at 03:05:41PM +1100, Jonathan Gray wrote:
> On Sat, Mar 22, 2014 at 12:10:26AM +, Emil Velikov wrote:
> > On 19/03/14 01:06, Jonathan Gray wrote:
> > > On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote:
> > >> On 18/03/14 14:59, Jonathan Gray wrote:
> > >>> Signe
On Sat, Mar 22, 2014 at 12:10:26AM +, Emil Velikov wrote:
> On 19/03/14 01:06, Jonathan Gray wrote:
> > On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote:
> >> On 18/03/14 14:59, Jonathan Gray wrote:
> >>> Signed-off-by: Jonathan Gray
> >>> ---
> >> Hi Jonathan
> >>
> >> While the s
https://bugs.freedesktop.org/show_bug.cgi?id=76188
--- Comment #3 from veb...@hotmail.fr ---
As an additional comment,
I would like to add that glamor uses EGL_EXT_image_dma_buf_import with the new
behaviour (actually I didn't know the spec was updated in December, but I knew
the decision was take
Now that BindRenderbufferTexImage() is a thing that drivers can do, winsys
FBOs *can* have NeedsFinishRenderTexture set.
v2: Keep the short-circuit for non-BindRenderbufferTexImage() drivers
(review by Ken).
---
src/mesa/main/fbobject.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(
This gets us equivalent code paths on BDW and pre-BDW, except for stencil
(where we don't have MSAA stencil resolve code yet)
v2: Move the new meta code to brw_meta_updownsample.c, name it
brw_meta_updownsample(), add a comment about
intel_rb_storage_first_mt_slice(), and rename that funct
Sometimes it would be nice to benchmark some app with MSAA versus not, but
it doesn't offer the controls you want. Just provide a handy knob to
force the issue.
---
src/mesa/drivers/dri/i965/intel_screen.c | 15 +++
src/mesa/drivers/dri/i965/intel_screen.h | 2 ++
2 files changed, 17
Even if the singlesample_mt got reopened from DRI due to
pageflipping/buffer swapping, our private miptree shouldn't need any
changes.
Improves performance of a little swapbuffers-loving microbenchmark with
MSAA forced on, by 1.2371% +/- 0.624802% (n=102)
---
src/mesa/drivers/dri/i965/intel_mipma
The formatting was weird, and the tests were duplicated, and it is
guaranteed that mt->region exists.
---
src/mesa/drivers/dri/i965/brw_context.c | 38 ++---
1 file changed, 16 insertions(+), 22 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/m
Fixes a memory leak with MSAA winsys buffers since my move of
singlesample_mt to the rb in 4e0924c5de5f3964e4ca81f923d877dbb59fad0a
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/driver
On 19/03/14 01:06, Jonathan Gray wrote:
> On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote:
>> On 18/03/14 14:59, Jonathan Gray wrote:
>>> Signed-off-by: Jonathan Gray
>>> ---
>> Hi Jonathan
>>
>> While the summary covers what the patch does, the *ahem* commit message
>> fails to expla
WebGL Aquarium in Chrome 24 actually hits this.
v2: Move to core Mesa (wisely suggested by Ian); only consider
components which actually exist.
Signed-off-by: Kenneth Graunke
Cc: Ian Romanick
Cc: Paul Berry
Cc: Anuj Phogat
---
src/mesa/main/clear.c | 19 ++-
1 file change
>From OpenGL 4.0 spec, page 306:
"Calling GetTexImage with a format of STENCIL_INDEX
causes the error INVALID_ENUM."
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgeti
_mesa_texstore_z24_s8() and _mesa_texstore_z32f_x24s8() are capable of
handling GL_DEPTH_STENCIL format. So, allow it in both the functions.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstore.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/texsto
Depth-stencil teture targets are allowed to use source data of type
GL_UNSIGNED_INT_24_8_EXT and GL_FLOAT_32_UNSIGNED_INT_24_8_REV.
Fixes few crashes in Khronos OpenGL CTS packed_pixels tests.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstore.c | 8 ++--
1 file changed, 6 insertion
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/format_unpack.c | 79 ++-
src/mesa/main/format_unpack.h | 5 +++
2 files changed, 83 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
index 7abbe46..1
OpenGL 4.0 spec, page 306 suggests an INVALID_OPERATION in glGetTexImage
if :
"format is one of the integer formats in table 3.3 and the internal
format of the texture image is not integer, or format is not one of
the integer formats in table 3.3 and the internal format is integer."
Cc:
This patch makes non-functional changes in the code. New helper
function added here will make it easier to support more data
types in the following patches.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/format_unpack.c | 24
src/mesa/main/format_unpack.h | 5 -
This patch contains non-functional changes. Assertion checks made
earlier in the functions make the if checks redundant. So, remove
the if checks and unindent the code in if block.
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstore.c | 170 ++-
1 fi
Fixes a crash in Khronos CTS packed_pixels tests.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_pixel_read.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c
b/src/mesa/drivers/dri/i965/intel_pixel_read.c
index 600d288
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/mtypes.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index a0d893c..0b754b1 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -3535,6 +3535,7 @@ struct gl_extensions
GLb
Fixes a crash in Khronos OpenGL CTS packed_pixels tests.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index 7129d4c..733985b 100644
--- a/src/mesa/
On Friday, March 21, 2014 04:47:29 Kenneth Graunke wrote:
> This lets us distinguish MSAA resolves from other ordinary blits.
>
> Signed-off-by: Kenneth Graunke
> Cc: Dylan Baker
> Cc: Keith Packard
> Cc: Eric Anholt
> ---
> src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8
> 1 file c
On Thu, Mar 20, 2014 at 4:02 PM, Kenneth Graunke wrote:
> Currently, we don't use this path on Sandybridge because we suspect
> other paths will be faster. But we potentially could. If we do, we
> should allow it to support Y-tiled BLTs.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/driv
On Wed, Mar 19, 2014 at 3:16 PM, Matt Turner wrote:
> - Does the broken behavior depend on the hardware generation? I.e.,
> broken on Ivy Bridge and Haswell but not Ironlake?
> - There are ~12 math ops. Are the dependency control hints broken for
> all of them, or just exp2?
The problem with NoD
Kenneth Graunke writes:
> Currently, we don't use this path on Sandybridge because we suspect
> other paths will be faster. But we potentially could. If we do, we
> should allow it to support Y-tiled BLTs.
>
> Signed-off-by: Kenneth Graunke
Reviewed-by: Eric Anholt
pgpT1CowWMQxC.pgp
Descri
Kenneth Graunke writes:
> Traditionally, we've implemented fragment color clamping by emitting
> "mov.sat" in the fragment shader's final color write code, clamping
> the output to [0, 1] prior to blending. (When clamping is off, we
> use a regular "mov".) This means we have to recompile based
https://bugs.freedesktop.org/show_bug.cgi?id=70410
--- Comment #23 from Dave Witbrodt ---
(In reply to comment #22)
> > But I still cannot build without attachment 91725 [details] above. The LLVM
> > fix referenced in this bug seems to have made it upstream (rev 202719), but
> > that hasn't prev
On Thu, Mar 20, 2014 at 2:18 AM, Kenneth Graunke wrote:
> If the number of layers is invalid, we're supposed to return
> INVALID_VALUE. _mesa_legal_texture_dimensions detects some of these
> cases (i.e. number of layers not being divisible by 6 for cubes), but
> results in an INVALID_OPERATION er
Tom,
Thanks for your answer.
On 21.03.2014 17:51, Tom Stellard wrote:
On Fri, Mar 21, 2014 at 05:47:56PM +0100, Christian Zigotzky wrote:
Hi All,
I have compiled LLVM 3.4 and Mesa 10.0.4 without any changes.
Here is the result of this test.
-> glxinfo | grep OpenGL
terminate called after t
On Fri, Mar 21, 2014 at 4:47 AM, Kenneth Graunke wrote:
> This lets us distinguish MSAA resolves from other ordinary blits.
>
> Signed-off-by: Kenneth Graunke
> Cc: Dylan Baker
> Cc: Keith Packard
> Cc: Eric Anholt
> ---
> src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8
> 1 file ch
https://bugs.freedesktop.org/show_bug.cgi?id=76377
--- Comment #6 from Jonathan Gray ---
Well the changes to not get the drm driver from the x server leaves non udev
system with 'unknown chipset' and gpu hangs. So this patch alone isn't going
to help matters on stable much. Even master needs so
https://bugs.freedesktop.org/show_bug.cgi?id=76377
--- Comment #5 from Fabio Pedretti ---
The patch should also be applied on 10.1 brach.
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@list
https://bugs.freedesktop.org/show_bug.cgi?id=76377
--- Comment #4 from Jonathan Gray ---
Yes, the updated patch seems to have the --disable-dri3 behaviour by default
here on OpenBSD. Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
_
Currently only linux can make use of dri3, so it would make sense to
enable it explicitly for the platform.
Drop a duplicated libudev check while we're at it.
v3: Properly handle dri3 and reword commit message.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76377
Signed-off-by: Emil Velik
https://bugs.freedesktop.org/show_bug.cgi?id=76377
Emil Velikov changed:
What|Removed |Added
Attachment #96176|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=76377
--- Comment #2 from Jonathan Gray ---
Thanks, though perhaps the logic of the test would be better inverted? You
seem to have missed disabling dri3 on gnu* (hurd) for example.
Passing --disable-dri3 to configure also disables the test for dri3p
https://bugs.freedesktop.org/show_bug.cgi?id=76377
--- Comment #1 from Emil Velikov ---
Created attachment 96176
--> https://bugs.freedesktop.org/attachment.cgi?id=96176&action=edit
configure: drop duplicated libudev check
Thanks for the report Jonathan.
FWIW there is a bit of confusion wrt u
For the purposes of configure.ac --enable-dri3 can be considered a subset
of --enable-dri where the latter already checks for libudev. Additionally
it's done in a platform aware manner, meaning that libudev will be required
only on linux.
v2: Disable dri3 on non-linux platforms.
Bugzilla: https:/
On 03/21/2014 04:47 AM, Kenneth Graunke wrote:
> WebGL Aquarium in Chrome 24 actually hits this.
>
> Signed-off-by: Kenneth Graunke
> Cc: Dylan Baker
> Cc: Keith Packard
> Cc: Eric Anholt
> ---
> src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 5 +
> 1 file changed, 5 insertions(+)
>
> d
For the purposes of configure.ac --enable-dri3 can be considered a subset
of --enable-dri where the latter already checks for libudev. Additionally
it's done in a platform aware manner, meaning that libudev will be required
only on linux.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=7637
On Fri, Mar 21, 2014 at 05:47:56PM +0100, Christian Zigotzky wrote:
> Hi All,
>
> I have compiled LLVM 3.4 and Mesa 10.0.4 without any changes.
>
> Here is the result of this test.
>
> -> glxinfo | grep OpenGL
>
> terminate called after throwing an instance of 'std::bad_alloc'
> what(): std:
Hi All,
I have compiled LLVM 3.4 and Mesa 10.0.4 without any changes.
Here is the result of this test.
-> glxinfo | grep OpenGL
terminate called after throwing an instance of 'std::bad_alloc'
what(): std::bad_alloc
-> LIBGL_DEBUG=verbose glxinfo | grep OpenGL
libGL: OpenDriver: trying /us
ping?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 21 March 2014 04:47, Kenneth Graunke wrote:
> The SIMD16 replicated FB write message only works if we don't need the
> color calculator to mask our framebuffer writes. Previously, we bailed
> on it if color_mask wasn't . However, this was
> needlessly strict for formats with fewer than four
Our hardware has an "accumulator" register, which can be used to store
intermediate results across multiple instructions. Many instructions
can implicitly write a value to the accumulator in addition to their
normal destination register. This is enabled by the "AccWrEn" flag.
This patch introduc
This allows us to generate the MAC (multiply-accumulate) instruction,
which can be used to implement some expressions in fewer instructions
than doing a series of MUL and ADDs.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_eu.h | 1 +
src/mesa/drivers/dri/i96
This allows us to emit ADD/MUL/MAC instead of MUL/ADD/MUL/ADD,
saving one instruction and two temporary registers.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/src
This allows us to generate the MAC (multiply-accumulate) instruction,
which can be used to implement some expressions in fewer instructions
than doing a series of MUL and ADDs.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +
src/mesa/drivers/dri/i965/
This allows us to emit ADD/MUL/MAC instead of MUL/ADD/MUL/ADD,
saving one instruction and two temporary registers.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/
Thanks Matt, Eric and Kenneth for the comments, I did rework my set to look
a bit different. I noticed Matt has partially overlapping set of patches about
dead code elimination and as for my set I did not have access this week
to Ironlake machine thus calling this 'RFC'y set. Kenneth, I think pedan
On 03/21/2014 03:00 AM, Chris Forbes wrote:
> Tested on ILK and CTG (with the GL3isms taken out of the piglits).
>
> Signed-off-by: Chris Forbes
> ---
> src/mesa/drivers/dri/i965/intel_extensions.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i96
This lets us distinguish MSAA resolves from other ordinary blits.
Signed-off-by: Kenneth Graunke
Cc: Dylan Baker
Cc: Keith Packard
Cc: Eric Anholt
---
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/
The SIMD16 replicated FB write message only works if we don't need the
color calculator to mask our framebuffer writes. Previously, we bailed
on it if color_mask wasn't . However, this was
needlessly strict for formats with fewer than four components - only the
components that actually exist matt
It's useful to know whether a clear is fast (MCS-based), using the
SIMD16 repdata message, or slow.
Signed-off-by: Kenneth Graunke
Cc: Dylan Baker
Cc: Keith Packard
Cc: Eric Anholt
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 11 +--
1 file changed, 9 insertions(+), 2 deletions
WebGL Aquarium in Chrome 24 actually hits this.
Signed-off-by: Kenneth Graunke
Cc: Dylan Baker
Cc: Keith Packard
Cc: Eric Anholt
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
b/src/mesa
Tested on ILK and CTG (with the GL3isms taken out of the piglits).
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/intel_extensions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_exte
58 matches
Mail list logo
